chenwj added a comment.
@erichkeane Just share what I investigated.
In https://reviews.llvm.org/D32759#744769, @erichkeane wrote:
> In https://reviews.llvm.org/D32759#744613, @chenwj wrote:
>
> > > Ah, sorry. "Our Tests" means the lit test SemaObjC/method-bad-param.m
> > > (line 11). I ran th
chenwj added a subscriber: eli.friedman.
chenwj added a comment.
@eli.friedman I find you added `isObjCObjectType` check in svn revision 184006
(git commit ddb5a392). Could you confirm returning zero rather than true here
is okay? A little explanation would be even better. Thanks.
https://revi
ddcc added a comment.
@dcoughlin : ping
https://reviews.llvm.org/D28955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Fri May 5 21:58:43 2017
New Revision: 302330
URL: http://llvm.org/viewvc/llvm-project?rev=302330&view=rev
Log:
Fix lgamma_r linking errors on Windows. It appears the normal lgamma function
is thread safe anyway
Modified:
libcxx/trunk/include/random
Modified: libcxx/tru
EricWF added a comment.
I think the medium to long term goal should be to replace the
`__ExceptionPtrFoo` functions we use with our own implementation, so we no
longer rely on these MSVC implementation details.
However it appears that we don't have access to the internal headers that we
might
On 1 May 2017 at 16:43, Vedant Kumar via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsk created this revision.
>
> When building with implicit modules it's possible to hit a scenario
> where modules are built without -fsanitize=address, and are subsequently
> imported into CUs with -fsanitiz
EricWF added inline comments.
Comment at: include/exception:192
+#endif
+void* __ptr1_;
+void* __ptr2_;
STL_MSFT wrote:
> BillyONeal wrote:
> > I hope you realize you are doing "evil" unsupported things :). (We won't go
> > out of our way to break this,
STL_MSFT resigned from this revision.
STL_MSFT added inline comments.
Comment at: include/exception:192
+#endif
+void* __ptr1_;
+void* __ptr2_;
BillyONeal wrote:
> I hope you realize you are doing "evil" unsupported things :). (We won't go
> out of our w
BillyONeal added inline comments.
Comment at: include/exception:192
+#endif
+void* __ptr1_;
+void* __ptr2_;
I hope you realize you are doing "evil" unsupported things :). (We won't go out
of our way to break this, but if it does break we won't feel bad :
Author: stl_msft
Date: Fri May 5 18:51:39 2017
New Revision: 302325
URL: http://llvm.org/viewvc/llvm-project?rev=302325&view=rev
Log:
[libcxx] [test] Suppress MSVC's /analyze warning C6294 in a more fine-grained
manner.
Fixes D32926.
Modified:
libcxx/trunk/test/std/utilities/template.bits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Gotta love warnings caused by weird bitset instantiations.
https://reviews.llvm.org/D32926
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
EricWF created this revision.
Herald added a subscriber: mgorny.
This patch implements exception_ptr on Windows using the `__ExceptionPtrFoo`
functions provided by MSVC. The `__ExceptionPtrFoo` functions are defined
inside the C++ standard library, `msvcprt`, which is unfortunate because it
req
Author: stl_msft
Date: Fri May 5 18:38:24 2017
New Revision: 302322
URL: http://llvm.org/viewvc/llvm-project?rev=302322&view=rev
Log:
[libcxx] [test] Fix MSVC "warning C6326: Potential comparison of a constant
with another constant".
The expressions `1 == 1` and `true` have the same type, value
STL_MSFT created this revision.
[libcxx] [test] Suppress MSVC's /analyze warning C6294 in a more fine-grained
manner.
https://reviews.llvm.org/D32926
Files:
test/std/utilities/template.bitset/bitset.cons/char_ptr_ctor.pass.cpp
test/std/utilities/template.bitset/bitset.cons/default.pass.cpp
Author: kcc
Date: Fri May 5 18:28:18 2017
New Revision: 302320
URL: http://llvm.org/viewvc/llvm-project?rev=302320&view=rev
Log:
[sanitizer-coverage] implement -fsanitize-coverage=no-prune,... instead of a
hidden -mllvm flag. clang part.
Modified:
cfe/trunk/docs/SanitizerCoverage.rst
cf
vsk added a comment.
Offline, @aprantl mentioned a concern about module hashes being required for
correctness. I'm not sure whether this is OK or not (@bruno, any thoughts?).
AFAICT there are items included in the module hash that, were they removed,
would break implicit module builds (e.g '-DF
STL_MSFT closed this revision.
STL_MSFT added a comment.
Committed with requested changes.
https://reviews.llvm.org/D32727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: stl_msft
Date: Fri May 5 18:01:38 2017
New Revision: 302318
URL: http://llvm.org/viewvc/llvm-project?rev=302318&view=rev
Log:
[libcxx] [test] Be compatible with LWG 2438 "std::iterator inheritance
shouldn't be mandated".
In C++17, these iterators are allowed but not required
to inherit
Author: kuhar
Date: Fri May 5 18:00:37 2017
New Revision: 302317
URL: http://llvm.org/viewvc/llvm-project?rev=302317&view=rev
Log:
[clang-tidy] Use cxxStdInitializerListExpr in modernize-use-emplace
Summary: Use the cxxStdInitializerListExp matcher from ASTMatchers.h instead of
a local one.
Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302317: [clang-tidy] Use cxxStdInitializerListExpr in
modernize-use-emplace (authored by kuhar).
Changed prior to commit:
https://reviews.llvm.org/D32923?vs=98024&id=98034#toc
Repository:
rL LLVM
ht
Author: tnorthover
Date: Fri May 5 17:36:06 2017
New Revision: 302313
URL: http://llvm.org/viewvc/llvm-project?rev=302313&view=rev
Log:
AArch64: fix weird edge case in ABI.
It turns out there are some sort-of-but-not-quite empty structs that break all
the rules. For example:
struct SuperEmpty {
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D32923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: rsmith
Date: Fri May 5 17:34:07 2017
New Revision: 302312
URL: http://llvm.org/viewvc/llvm-project?rev=302312&view=rev
Log:
Permit keywords in module names in #pragma clang module *.
This is necessary to be able to build a libc++ module from preprocessed source
(due to the submodule std.
aprantl added a comment.
Is it the right solution to use the module hash for correctness, or should the
mismatch of the serialized langopts trigger a module rebuild and the module
hash is only there to tune the performance/disk size tradeoff?
https://reviews.llvm.org/D32724
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
A few minor nits, but the operation of ignoring certain sanitizer flags seems
to be happening in the wrong place.
Comment at: lib/Basic/LangOptions.cpp:32
- //
Author: rsmith
Date: Fri May 5 17:18:51 2017
New Revision: 302309
URL: http://llvm.org/viewvc/llvm-project?rev=302309&view=rev
Log:
Add support for building modules from preprocessed source.
To support this, an optional marker "#pragma clang module contents" is
recognized in module map files, an
vsk updated this revision to Diff 98030.
vsk edited the summary of this revision.
vsk added a comment.
- Exclude sanitizers which cannot affect AST generation from the module hash.
- Improve the test to check modules are actually rebuilt when we expect them to
be rebuilt, and not rebuilt otherwis
STL_MSFT created this revision.
[libcxx] [test] Fix MSVC "warning C6326: Potential comparison of a constant
with another constant".
The expressions `1 == 1` and `true` have the same type, value category, and
value.
https://reviews.llvm.org/D32924
Files:
test/std/containers/sequences/vector
kuhar created this revision.
kuhar added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
Use the cxxStdInitializerListExp matcher from ASTMatchers.h instead of a local
one.
Repository:
rL LLVM
https://reviews.llvm.org/D32923
Files:
clang-tidy/modernize/UseEmplaceCheck.
Author: ericwf
Date: Fri May 5 16:32:37 2017
New Revision: 302298
URL: http://llvm.org/viewvc/llvm-project?rev=302298&view=rev
Log:
Mark test using as UNSUPPORTED on Windows
Modified:
libcxx/trunk/test/std/thread/thread.threads/thread.thread.this/sleep_for.pass.cpp
Modified:
libcxx/trunk
Author: ericwf
Date: Fri May 5 16:31:22 2017
New Revision: 302297
URL: http://llvm.org/viewvc/llvm-project?rev=302297&view=rev
Log:
Fix condition_variable::wait_until and wait_for on Windows.
The ERROR_TIMEDOUT returned by the Windows API does not
have the same value as ETIMEDOUT. This caused co
Author: jroelofs
Date: Fri May 5 16:30:13 2017
New Revision: 302296
URL: http://llvm.org/viewvc/llvm-project?rev=302296&view=rev
Log:
Multilib: add dump methods
Modified:
cfe/trunk/include/clang/Driver/Multilib.h
cfe/trunk/lib/Driver/Multilib.cpp
Modified: cfe/trunk/include/clang/Driver
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added reviewers: kcc, kubamracek.
vsk added a subscriber: zaks.anna.
vsk added a comment.
@zaks.anna suggested some more reviewers who may be interested.
https://reviews.llvm.org/D32842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302287: Add cxxStdInitializerListExpr AST matcher (authored
by kuhar).
Changed prior to commit:
https://reviews.llvm.org/D32810?vs=97700&id=98018#toc
Repository:
rL LLVM
https://reviews.llvm.org/D32
Author: kuhar
Date: Fri May 5 16:01:12 2017
New Revision: 302287
URL: http://llvm.org/viewvc/llvm-project?rev=302287&view=rev
Log:
Add cxxStdInitializerListExpr AST matcher
Summary:
This adds a new ASTMatcher for CXXStdInitializerListExprs that matches C++
initializer list expressions.
The pri
Author: ericwf
Date: Fri May 5 15:50:24 2017
New Revision: 302285
URL: http://llvm.org/viewvc/llvm-project?rev=302285&view=rev
Log:
Fix detection for [[fallthrough]] with GCC
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/llvm-pr
Author: rtrieu
Date: Fri May 5 15:47:50 2017
New Revision: 302284
URL: http://llvm.org/viewvc/llvm-project?rev=302284&view=rev
Log:
[ODRHash] Fix typo, NFC
NestedNameSpecifer to NestedNameSpecifier. This was not a problem before since
one of the included headers transitively brought in the defi
Author: ericwf
Date: Fri May 5 15:39:03 2017
New Revision: 302283
URL: http://llvm.org/viewvc/llvm-project?rev=302283&view=rev
Log:
Fix remaining GCC 7 build warnings
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experimental/filesystem/operati
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302281: [clang-tidy] Fix PR32896: detect initializer lists
in modernize-use-empalce (authored by kuhar).
Changed prior to commit:
https://reviews.llvm.org/D32767?vs=97704&id=98013#toc
Repository:
rL
Author: kuhar
Date: Fri May 5 15:35:30 2017
New Revision: 302281
URL: http://llvm.org/viewvc/llvm-project?rev=302281&view=rev
Log:
[clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce
Summary:
This patch fixes [[ https://bugs.llvm.org/show_bug.cgi?id=32896 | PR32896 ]].
T
Author: ericwf
Date: Fri May 5 15:32:26 2017
New Revision: 302280
URL: http://llvm.org/viewvc/llvm-project?rev=302280&view=rev
Log:
Fix new warnings emitted by GCC 7
Modified:
libcxx/trunk/include/__config
libcxx/trunk/include/locale
libcxx/trunk/src/locale.cpp
Modified: libcxx/trun
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/CMakeLists.txt:8
FloatLoopCounter.cpp
+ PostfixOperatorCheck.cpp
LimitedRandomnessCheck.cpp
aaron.ballman wrote:
> Please keep the list of source files alphabetized.
This is still in the wron
Author: aaronballman
Date: Fri May 5 14:56:09 2017
New Revision: 302275
URL: http://llvm.org/viewvc/llvm-project?rev=302275&view=rev
Log:
Do not redefine the THREAD_ANNOTATION_ATTRIBUTE__ macro in the documentation.
Patch by Roman Lebedev.
Modified:
cfe/trunk/docs/ThreadSafetyAnalysis.rst
Author: weimingz
Date: Fri May 5 14:25:29 2017
New Revision: 302274
URL: http://llvm.org/viewvc/llvm-project?rev=302274&view=rev
Log:
[ARM] Limit the diagnose when an ISR calls a regular function
Summary:
When the function is compiled with soft-float or on CPU with no FPU, we
don't need to diagn
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302274: [ARM] Limit the diagnose when an ISR calls a regular
function (authored by weimingz).
Changed prior to commit:
https://reviews.llvm.org/D32918?vs=97996&id=98001#toc
Repository:
rL LLVM
https
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for doing that... I totally forgot!
Repository:
rL LLVM
https://reviews.llvm.org/D32918
___
cfe-commits mailing list
cfe-comm
weimingz created this revision.
Herald added subscribers: javed.absar, rengolin, aemerson.
When the function is compiled with soft-float or on CPU with no FPU, we
don't need to diagnose for a call from an ISR to a regular function.
Repository:
rL LLVM
https://reviews.llvm.org/D32918
Files:
Author: compnerd
Date: Fri May 5 13:39:06 2017
New Revision: 302270
URL: http://llvm.org/viewvc/llvm-project?rev=302270&view=rev
Log:
CodeGen: avoid use of @clang.arc.use intrinsic at O0
The clang.arc.use intrinsic is removed via the ARC Contract Pass. This
pass is only executed in optimized bu
On 5/5/2017 10:20 AM, Nico Weber via cfe-commits wrote:
Timestamps on cfe-commits are a bit messed up. I landed that just now,
but the timestamp is from 13 minutes in the past. Maybe the clock on
the mail server is off by 13 min?
The timestamp on the message matches the timestamp in the svn lo
pammon added a comment.
ping?
https://reviews.llvm.org/D32635
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302261: [clang-tidy] Fix misc-move-const-arg for move-only
types. (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D31160?vs=97971&id=97985#toc
Repository:
rL LLVM
https://rev
Author: alexfh
Date: Fri May 5 12:33:49 2017
New Revision: 302261
URL: http://llvm.org/viewvc/llvm-project?rev=302261&view=rev
Log:
[clang-tidy] Fix misc-move-const-arg for move-only types.
Summary: Fix misc-move-const-arg false positives on move-only types.
Reviewers: sbenza
Reviewed By: sben
On Fri, May 5, 2017 at 1:15 PM, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Fri May 5 12:15:08 2017
> New Revision: 302258
>
> URL: http://llvm.org/viewvc/llvm-project?rev=302258&view=rev
> Log:
> ANSIfy. No behavior change.
Thank you for handling these!
~Aaron
>
> Modified:
>
I had run `ack "[\x80-\xFF]" lib` to find these, and didn't expect that it
can fire more than once on a given line. (We had 4 instance in all of
clang, 2 in this line.)
On Fri, May 5, 2017 at 1:16 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Fri May
Author: nico
Date: Fri May 5 12:16:58 2017
New Revision: 302259
URL: http://llvm.org/viewvc/llvm-project?rev=302259&view=rev
Log:
ANSIfy more. Still no behavior change.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/viewvc/l
Author: nico
Date: Fri May 5 12:15:08 2017
New Revision: 302258
URL: http://llvm.org/viewvc/llvm-project?rev=302258&view=rev
Log:
ANSIfy. No behavior change.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
cfe/trunk/lib/Sema/SemaStmt.cpp
Modified: c
On Fri, May 5, 2017 at 1:21 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, May 5, 2017 at 1:05 PM, Nico Weber via cfe-commits
> wrote:
> > Author: nico
> > Date: Fri May 5 12:05:56 2017
> > New Revision: 302255
> >
> > URL: http://llvm.org/viewvc/llvm-project?re
On Fri, May 5, 2017 at 1:05 PM, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Fri May 5 12:05:56 2017
> New Revision: 302255
>
> URL: http://llvm.org/viewvc/llvm-project?rev=302255&view=rev
> Log:
> Warn that the [] spelling of uuid(...) is deprecated.
>
> https://reviews.llvm.org/D328
Timestamps on cfe-commits are a bit messed up. I landed that just now, but
the timestamp is from 13 minutes in the past. Maybe the clock on the mail
server is off by 13 min?
On Fri, May 5, 2017 at 1:05 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Fri
thakis closed this revision.
thakis added a comment.
r302255, thanks!
https://reviews.llvm.org/D32879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Fri May 5 12:05:56 2017
New Revision: 302255
URL: http://llvm.org/viewvc/llvm-project?rev=302255&view=rev
Log:
Warn that the [] spelling of uuid(...) is deprecated.
https://reviews.llvm.org/D32879
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trun
alexfh added inline comments.
Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:76
if (IsConstArg || IsTriviallyCopyable) {
+if (const CXXRecordDecl *R = Arg->getType()->getAsCXXRecordDecl()) {
+ for (const auto *Ctor : R->ctors()) {
alexfh wr
krasimir added a comment.
@klimek: We don't have any clients of this field inside clang.
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek accepted this revision.
Prazek added a comment.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D32767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:76
if (IsConstArg || IsTriviallyCopyable) {
+if (const CXXRecordDecl *R = Arg->getType()->getAsCXXRecordDecl()) {
+ for (const auto *Ctor : R->ctors()) {
sbenza wr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302253: Add a fix-it for -Wunguarded-availability (authored
by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D32424?vs=97922&id=97977#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: arphaman
Date: Fri May 5 11:42:44 2017
New Revision: 302253
URL: http://llvm.org/viewvc/llvm-project?rev=302253&view=rev
Log:
Add a fix-it for -Wunguarded-availability
This patch adds a fix-it for the -Wunguarded-availability warning. This fix-it
is similar to the Swift one: it suggests
sbenza added inline comments.
Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:76
if (IsConstArg || IsTriviallyCopyable) {
+if (const CXXRecordDecl *R = Arg->getType()->getAsCXXRecordDecl()) {
+ for (const auto *Ctor : R->ctors()) {
Can we ge
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D32856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
alexfh added a comment.
Friendly ping.
https://reviews.llvm.org/D31160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh updated this revision to Diff 97971.
alexfh added a comment.
Herald added a subscriber: xazax.hun.
Rebased on HEAD.
https://reviews.llvm.org/D31160
Files:
clang-tidy/misc/MoveConstantArgumentCheck.cpp
test/clang-tidy/misc-move-const-arg.cpp
Index: test/clang-tidy/misc-move-const-ar
Author: arphaman
Date: Fri May 5 11:15:17 2017
New Revision: 302250
URL: http://llvm.org/viewvc/llvm-project?rev=302250&view=rev
Log:
[ObjC] Don't disallow vector parameters/return values in methods
whose introduced version is lower than the allowed version.
We should just rely on the target ver
thakis marked an inline comment as done.
thakis added a comment.
s/Add one/All done/
https://reviews.llvm.org/D32914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis closed this revision.
thakis marked 3 inline comments as done.
thakis added a comment.
Thanks! Add one and landed in r302247.
Comment at: include/clang/Sema/Sema.h:3760
+ /// \brief Warn when implicitly casting 0 to nullptr.
+ void diagnoseZeroToNullptrConversion(Cas
Author: nico
Date: Fri May 5 11:11:08 2017
New Revision: 302247
URL: http://llvm.org/viewvc/llvm-project?rev=302247&view=rev
Log:
Introduce Wzero-as-null-pointer-constant.
Add an opt-in warning that fires when 0 is used as a null pointer.
gcc has this warning, and there's some demand for it.
h
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Nice. Some comments, but lgtm.
Comment at: include/clang/Sema/Sema.h:3760
+ /// \brief Warn when implicitly casting 0 to nullptr.
+ void diagnoseZeroToNullptrConversion(CastK
thakis created this revision.
Add an opt-in warning that fires when 0 is used as a null pointer.
gcc has this warning, and there's some demand for it:
http://stackoverflow.com/questions/34953361/which-clang-warning-is-equivalent-to-wzero-as-null-pointer-constant-from-gcc
https://twitter.com/Steph
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D32424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
svenvh updated this revision to Diff 97959.
svenvh added a comment.
Added more tests as suggested.
https://reviews.llvm.org/D32856
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/sampler_t.cl
Index: test/SemaOpenCL/sampler_t.cl
===
takuto.ikuta added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:271
+ InvalidatedBugType.reset(
+ new BugType(this, "Iterator invalidated", "Misuse of STL APIs"));
+ InvalidatedBugType->setSuppressOnSink(true);
OK to use mak
NoQ added a comment.
Noticed a few more things.
It sounds as if once this first patch lands, the rest should be easy :)
Regarding the comments in the code. I materialized my wishes to something like:
- At the top of the file:
// In the code, iterator can be represented as a:
// * type-I: t
takuto.ikuta added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:357
+return;
+ } else if (isEndCall(Func)) {
handleEnd(C, OrigExpr, Call.getReturnValue(),
We cannot use else after return?
http://llvm.org/docs/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302240: [Driver] Add a "-mmacos_version_min" option that's
an alias for (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D32796?vs=97599&id=97956#toc
Repository:
rL LLVM
htt
Author: arphaman
Date: Fri May 5 09:52:48 2017
New Revision: 302240
URL: http://llvm.org/viewvc/llvm-project?rev=302240&view=rev
Log:
[Driver] Add a "-mmacos_version_min" option that's an alias for
"-mmacosx_version_min"
The option -mmacosx_version_min will still be the canonical option for now,
takuto.ikuta added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:711
+void IteratorChecker::checkBeginFunction(CheckerContext &C) const {
+ // Copy state of iterator arguments to iterator parameters
takuto.ikuta wrote:
> Can we u
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:711
+void IteratorChecker::checkBeginFunction(CheckerContext &C) const {
+ // Copy state of iterator arguments to iterator parameters
takuto.ikuta wrote:
> Can we use `const
takuto.ikuta added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:711
+void IteratorChecker::checkBeginFunction(CheckerContext &C) const {
+ // Copy state of iterator arguments to iterator parameters
Can we use `const CheckerConte
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302236: [Tooling] Remove redundant check, NFCi (authored by
krasimir).
Changed prior to commit:
https://reviews.llvm.org/D32909?vs=97952&id=97953#toc
Repository:
rL LLVM
https://reviews.llvm.org/D32
Author: krasimir
Date: Fri May 5 09:07:23 2017
New Revision: 302236
URL: http://llvm.org/viewvc/llvm-project?rev=302236&view=rev
Log:
[Tooling] Remove redundant check, NFCi
Summary: The Database check looks redundant.
Reviewers: bkramer
Subscribers: klimek, cfe-commits
Differential Revision:
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D32909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
krasimir created this revision.
Herald added a subscriber: klimek.
The Database check looks redundant.
https://reviews.llvm.org/D32909
Files:
lib/Tooling/JSONCompilationDatabase.cpp
Index: lib/Tooling/JSONCompilationDatabase.cpp
==
yaxunl added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:6085
+ // space qualifier or with the const qualifier.
+ if (DC->isTranslationUnit() &&
+ !(R.getAddressSpace() == LangAS::opencl_constant ||
svenvh wrote:
> yaxunl wrote:
> > shou
takuto.ikuta updated this revision to Diff 97949.
takuto.ikuta added a comment.
Remove IncludeLoc
https://reviews.llvm.org/D32903
Files:
clang/include/clang/Lex/DirectoryLookup.h
clang/include/clang/Lex/HeaderSearch.h
clang/lib/Lex/HeaderSearch.cpp
Index: clang/lib/Lex/HeaderSearch.cpp
=
baloghadamsoftware added a comment.
Split to 10 parts.
https://reviews.llvm.org/D31975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
baloghadamsoftware created this revision.
check::Bind() is not invoked for parameter passing. We use a trick instead: in
checkBeginFunction we copy the positions of iterator parameters from the
arguments to the parameters.
https://reviews.llvm.org/D32906
Files:
lib/StaticAnalyzer/Checkers/I
baloghadamsoftware created this revision.
This patch adds explicit evaluation of the following functions: std::find,
std::find_end, std::find_first_of, std::find_if, std::find_if_not,
std::lower_bound, std::upper_bound, std::search and std::search_n. On the one
hand this is an optimization sinc
klimek added a comment.
Is there a specific reason to take this out? It seems generally useful to allow
compilation-db implementors to provide sources.
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
baloghadamsoftware created this revision.
This patch adds support for the following operations in the iterator checkers:
assign, clear, insert, insert_after, emplace, emplace_after, erase and
erase_after. This affects mismatched iterator checks ("this" and parameter must
match) and invalidation
baloghadamsoftware updated this revision to Diff 97942.
baloghadamsoftware added a comment.
Wrong diff.
https://reviews.llvm.org/D32902
Files:
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analysis/Inputs/system-header-simulator-cxx.h
test/Analysis/diagnostics/explicit-suppression.
1 - 100 of 116 matches
Mail list logo
