mharoush added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D33277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mharoush added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D33278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
srhines added a comment.
Richard's points are really valid here. I missed the aspect that packed always
implies alignment 1, which does have an effect on the code in most of the cases
listed here. I agree that the value of this warning is low, since the
possibility of false-positive is quite hi
echuraev updated this revision to Diff 105375.
echuraev marked an inline comment as done.
https://reviews.llvm.org/D35000
Files:
test/CodeGenOpenCL/kernel-arg-info.cl
Index: test/CodeGenOpenCL/kernel-arg-info.cl
===
--- test/Code
Hahnfeld added inline comments.
Comment at: lib/Driver/Driver.cpp:564
+ auto &CudaTC =
+ ToolChains[TT.str() + "/" + HostTC->getTriple().normalize()];
+ if (!CudaTC)
gtbercea wrote:
> Hahnfeld wrote:
> > The code above u
Hahnfeld added a comment.
In https://reviews.llvm.org/D34888#799576, @gtbercea wrote:
> Does this also include the fixes in the following revision?
>
> https://reviews.llvm.org/D29905
Sorry, I wasn't aware of this revision and thought that it had long been
committed. I just verified that the b
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Sounds plausible to me
https://reviews.llvm.org/D34860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
mgrang added a comment.
Ping for reviews please.
https://reviews.llvm.org/D34860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyknight added inline comments.
Comment at: lib/Driver/ToolChains/Linux.cpp:755
+!Version.isOlderThan(4, 8, 0)) {
+ // For gcc >= 4.8.x, clang will preinclude
+ // -ffreestanding suppresses this behavior.
I don't see why it makes any sense to c
alexshap created this revision.
Herald added a subscriber: xazax.hun.
This is a follow up for one of the previous diffs
https://reviews.llvm.org/D32328.
getTypeSize and with getIntWidth are not equivalent for bool
(see https://clang.llvm.org/doxygen/ASTContext_8cpp_source.html#l08444),
this caus
dlj added a comment.
In https://reviews.llvm.org/D34853#798699, @andrewng wrote:
> Hi,
>
> I believe that this "build mode" is intended for the Visual Studio MSVC
> build. This build is special in that it can produce builds for multiple
> configurations, e.g. Debug, Release & RelWithDebInfo, wi
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D34489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ahatanak added a subscriber: EricWF.
ahatanak added a comment.
Does r307218 unbreak the tests?
Repository:
rL LLVM
https://reviews.llvm.org/D34574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
> Creating a function pointer with proper parameters pointing to std::next() or
> std::prev() should work.
Actually, according to the standard taking the address of a STL function is UB,
and
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This LGTM. I'm assuming it works but we can iron out the kinks once it lands.
We should probably add builders that run the tests as well.
Comment at: test/lit.cfg:46
+li
Author: rsmith
Date: Wed Jul 5 17:30:00 2017
New Revision: 307232
URL: http://llvm.org/viewvc/llvm-project?rev=307232&view=rev
Log:
[modules ts] Do not emit strong function definitions from the module interface
unit in every user.
Added:
cfe/trunk/test/CXX/modules-ts/basic/basic.def.odr/
Author: rsmith
Date: Wed Jul 5 17:29:13 2017
New Revision: 307231
URL: http://llvm.org/viewvc/llvm-project?rev=307231&view=rev
Log:
[cxx_status] Update link to Modules TS to latest working draft. Fix Coroutines
TS flag to work if copy-pasted.
Modified:
cfe/trunk/www/cxx_status.html
Modifie
Author: ericwf
Date: Wed Jul 5 17:29:09 2017
New Revision: 307230
URL: http://llvm.org/viewvc/llvm-project?rev=307230&view=rev
Log:
Fix incomplete type test on OS X; workaround weird DYLD_LIBRARY_PATH behavior
Modified:
libcxxabi/trunk/test/incomplete_type.sh.cpp
Modified: libcxxabi/trunk/t
rsmith added a comment.
We need to be completely clear on the differences and interactions between
`_Float16` and `__fp16`; you should include a documentation update that
describes this as part of this change or as a companion change. In particular,
an explanation of why we need two different t
jroelofs created this revision.
Herald added a subscriber: mgorny.
Mostly cargo-culted from libcxxabi, since the unwinder was forked from there in
the first place.
Might still be some cruft that's only applicable to libcxxabi in here, so let
me know if you spot anything like that. I killed some
rsmith added inline comments.
Comment at: clang/test/CodeGenCXX/cxx11-extern-constexpr.cpp:15
+// CHECK: @_ZL4BAR3 = available_externally constant i32 44,
+static constexpr int BAR3 = 44;
+
mehdi_amini wrote:
> rsmith wrote:
> > mehdi_amini wrote:
> > > Looks lik
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:478
+auto MArchList = DAL->getAllArgValues(options::OPT_march_EQ);
+assert(MArchList.size() < 2 && "At most one GPU arch allowed.");
+if (MArchList.empty())
hfinkel wrote:
> Ca
rsmith added a comment.
Some concrete suggestions throughout the patch, but I think we should take a
step back and reconsider this warning approach: it seems bizarre for us to warn
on any packed struct that happens to contain a `char`. It would make sense to
warn if an `__attribute__((packed))`
mehdi_amini added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2374
+ llvm::Constant *Init = nullptr;
+ if (D && D->isConstexpr() && !D->isInline() && !D->hasAttr())
{
+const VarDecl *InitDecl;
rsmith wrote:
> Applying this for only `co
gtbercea updated this revision to Diff 105355.
gtbercea added a comment.
Address Comments.
https://reviews.llvm.org/D34784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload.c
Index: test/Driver/
gtbercea updated this revision to Diff 105354.
gtbercea added a comment.
Address comments.
https://reviews.llvm.org/D34784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChains/Co
rsmith added a comment.
We've had problems in the past with speculative emission of values like this
resulting in us producing invalid symbol references. (Two cases I remember: an
`available_externally` symbol references a symbol that should be emitted as
`linkonce_odr` but which is not emitted
mehdi_amini added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2376
+const VarDecl *InitDecl;
+const Expr *InitExpr = D->getAnyInitializer(InitDecl);
+if (InitExpr) {
ahatanak wrote:
> Does getAnyInitializer ever return a null poin
ahatanak added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2376
+const VarDecl *InitDecl;
+const Expr *InitExpr = D->getAnyInitializer(InitDecl);
+if (InitExpr) {
Does getAnyInitializer ever return a null pointer here when D is a
yawanng added a comment.
PING
Repository:
rL LLVM
https://reviews.llvm.org/D34114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jul 5 15:40:58 2017
New Revision: 307218
URL: http://llvm.org/viewvc/llvm-project?rev=307218&view=rev
Log:
Suppress -Waligned-allocation-unavailable warning in libc++ test suite
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/t
ddcc added a comment.
ping
https://reviews.llvm.org/D28953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 5 July 2017 at 14:09, Melanie Blower via Phabricator <
revi...@reviews.llvm.org> wrote:
> mibintc added a comment.
>
> Jonas asked about adding a new test to ensure that "-include
> stdc-predef.h" does not get added if the file doesn't exist.
>
> I added a reply to that but I can't see where it
On 5 July 2017 at 14:29, James Y Knight wrote:
> I actually didn't know that attribute existed. It does look like the right
> thing to use here. However, unfortunately, it appears it doesn't work for
> enum class in clang [[1]]. It *does* seem to work in GCC.
>
> Unfortunately, it seems that GCC
I missed the second part.
Am 05.07.2017 um 23:38 schrieb svk:
Hello,
the attached patch introduces a -mtls-gs command line option for clang
for the x86_64 target.
This option will force the usage of the GS instead of the FS register
for TLS references and
stack canary references.
This is pa
efriedma added a comment.
Needs a testcase (to check the emitted IR).
Comment at: lib/CodeGen/TargetInfo.cpp:4769
DarwinPCS
};
Can we extend ABIKind rather than adding a separate boolean?
https://reviews.llvm.org/D35008
__
Hello,
the attached patch introduces a -mtls-gs command line option for clang
for the x86_64 target.
This option will force the usage of the GS instead of the FS register
for TLS references and
stack canary references.
This is particularly useful for low-level kernel-side development.
Best re
I actually didn't know that attribute existed. It does look like the right
thing to use here. However, unfortunately, it appears it doesn't work for
enum class in clang [[1]]. It *does* seem to work in GCC.
Unfortunately, it seems that GCC has actually hardcoded the type name
"std::byte" (in gcc/c
On Wed, Jul 5, 2017 at 5:05 PM, Douglas Gregor wrote:
>
> On Jul 5, 2017, at 1:33 PM, Aaron Ballman wrote:
>
> On Wed, Jul 5, 2017 at 4:20 PM, Douglas Gregor via cfe-commits
> wrote:
>
> Author: dgregor
> Date: Wed Jul 5 13:20:15 2017
> New Revision: 307197
>
> URL: http://llvm.org/viewvc/llvm-
On 5 July 2017 at 14:05, Douglas Gregor via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> On Jul 5, 2017, at 1:33 PM, Aaron Ballman wrote:
>
> On Wed, Jul 5, 2017 at 4:20 PM, Douglas Gregor via cfe-commits
> wrote:
>
> Author: dgregor
> Date: Wed Jul 5 13:20:15 2017
> New Revision: 30719
Author: dgregor
Date: Wed Jul 5 14:12:37 2017
New Revision: 307202
URL: http://llvm.org/viewvc/llvm-project?rev=307202&view=rev
Log:
Fix test case in pre-C++11 mode; address Aaron Ballman's code review.
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
cfe/trunk/test/SemaTemplate/overload-ca
mibintc added a comment.
Jonas asked about adding a new test to ensure that "-include stdc-predef.h"
does not get added if the file doesn't exist.
I added a reply to that but I can't see where it went. So I'm writing the reply
again.
The current version of the patch doesn't check for the exist
Author: mzolotukhin
Date: Wed Jul 5 14:06:11 2017
New Revision: 307201
URL: http://llvm.org/viewvc/llvm-project?rev=307201&view=rev
Log:
Fix one more reference to lit.util.capture()
The capture method was removed in r306643.
Modified:
cfe/trunk/utils/perf-training/lit.cfg
cfe/trunk/util
> On Jul 5, 2017, at 1:33 PM, Aaron Ballman wrote:
>
> On Wed, Jul 5, 2017 at 4:20 PM, Douglas Gregor via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
>> Author: dgregor
>> Date: Wed Jul 5 13:20:15 2017
>> New Revision: 307197
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=3071
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D34927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
mibintc updated this revision to Diff 105329.
mibintc added a comment.
I responded to the review from Jonas Hahnfeld: I moved the entire change into
ToolChains/Linux and removed the modifications to Gnu.h and Gnu.cpp; I modified
the new tests to use -### with FileCheck, and added a tree in Input
jordan_rose added a comment.
I'm not sure why we would care if a commit is made on a branch. The important
information here is what commit is checked out, and that's what HEAD refers to.
https://reviews.llvm.org/D34955
___
cfe-commits mailing list
On Wed, Jul 5, 2017 at 4:20 PM, Douglas Gregor via cfe-commits
wrote:
> Author: dgregor
> Date: Wed Jul 5 13:20:15 2017
> New Revision: 307197
>
> URL: http://llvm.org/viewvc/llvm-project?rev=307197&view=rev
> Log:
> Cope with Range-v3's CONCEPT_REQUIRES idiom
>
> Modified:
> cfe/trunk/lib/Se
pcc added a comment.
FYI, I don't think `HEAD` on its own will work because it is not necessarily
updated on every commit, see discussion on https://reviews.llvm.org/D31985.
https://reviews.llvm.org/D34955
___
cfe-commits mailing list
cfe-commits@l
modocache planned changes to this revision.
modocache added a comment.
Oh, nice catch @jordan_rose, you're absolutely right. I just tried updating my
Git submodule reference for Clang and rebuilding my project, but the commit
hash shown for Clang didn't change accordingly.
I'll need to find a f
Author: dgregor
Date: Wed Jul 5 13:20:15 2017
New Revision: 307197
URL: http://llvm.org/viewvc/llvm-project?rev=307197&view=rev
Log:
Cope with Range-v3's CONCEPT_REQUIRES idiom
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
cfe/trunk/test/SemaTemplate/overload-candidates.cpp
Modified: cf
Author: dgregor
Date: Wed Jul 5 13:20:14 2017
New Revision: 307196
URL: http://llvm.org/viewvc/llvm-project?rev=307196&view=rev
Log:
Customize the SFINAE diagnostics for enable_if to provide the failed condition.
When enable_if disables a particular overload resolution candidate,
rummage through
mibintc added a comment.
In https://reviews.llvm.org/D34158#797968, @Hahnfeld wrote:
> In https://reviews.llvm.org/D34158#797170, @mibintc wrote:
>
> > The other test that fails is my own new test! It fails because I don't know
> > how to set it up so the test thinks it has a gcc toolchain with
gtbercea added a comment.
In https://reviews.llvm.org/D29658#732520, @ABataev wrote:
> Tests?
Can't write any meaningful tests. This will be tested by all future patches
that perform offloading using OpenMP.
https://reviews.llvm.org/D29658
___
c
modocache added a comment.
Thanks for the review, Hal! :)
https://reviews.llvm.org/D34928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gtbercea added inline comments.
Comment at: lib/Driver/Driver.cpp:564
+ auto &CudaTC =
+ ToolChains[TT.str() + "/" + HostTC->getTriple().normalize()];
+ if (!CudaTC)
Hahnfeld wrote:
> The code above uses `HostTriple.str(
Author: modocache
Date: Wed Jul 5 12:55:51 2017
New Revision: 307193
URL: http://llvm.org/viewvc/llvm-project?rev=307193&view=rev
Log:
Add docs for -foptimization-record-file=
Summary: The Clang option was previously not included in the User's Manual.
Reviewers: anemet, davidxl, hfinkel
Review
gtbercea updated this revision to Diff 105320.
gtbercea edited the summary of this revision.
gtbercea added a comment.
Rebase on latest master.
https://reviews.llvm.org/D29658
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
=
FWIW, doesn't this just need a may_alias attribute on the definition?
On Wed, Jul 5, 2017 at 2:39 PM James Y Knight via Phabricator via
cfe-commits wrote:
> jyknight added a comment.
>
> Ping. I don't think this got resolved, and I really wouldn't like to see
> released in this state...can you ei
mehdi_amini accepted this revision.
mehdi_amini added a comment.
Make sure your commit message correctly reference the LLVM change.
Comment at: test/CodeGen/ms-barriers-intrinsics.c:39
#endif
-
Don't remove: file should end with a new line I believe.
https:/
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks!
https://reviews.llvm.org/D33109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
Sorry for the delay.
The spec says:
The data type names described in the table below are reserved and cannot be
used by applications as user-defined type names.
However, it does not forbid using the reserved types as builtin types if the
compiler supports it.
I would
STL_MSFT added a comment.
Ping for this one - there's no functional change here, but since I don't have
any glibc coverage, I wanted to get a review.
https://reviews.llvm.org/D34535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
STL_MSFT added a comment.
Yeah, I just wanted to check that you didn't mean to actually use these
typedefs for something. Thanks!
https://reviews.llvm.org/D34536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
a.sidorin added a comment.
Oh, I see now. I was wrongly thinking that these patches do the same thing and
we're duplicating the work. Thank you very much for your explanation, Devin.
Repository:
rL LLVM
https://reviews.llvm.org/D16403
___
cfe-co
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. @STL_MSFT This seems like you could commit it without review. You're a
professional STL developer after all, if you can't get this right may God have
mercy on your users.
https://revie
mehdi_amini added inline comments.
Comment at: clang/test/CodeGenCXX/cxx11-extern-constexpr.cpp:12
+// CHECK: @_ZN3Foo4BAR2E = external constant i32,
+ static const int BAR2 = 43;
+};
Note: I'm not sure if the standard allows us to assume that we can fold the
dcoughlin added a comment.
> @dcoughlin As a reviewer of both patches - could you tell us what's the
> difference between them? And how are we going to resolve this issue?
These two patches are emitting markers in the CFG for different things.
Here is how I would characterize the difference bet
STL_MSFT added a comment.
Ping?
https://reviews.llvm.org/D34536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyknight added a comment.
Ping. I don't think this got resolved, and I really wouldn't like to see
released in this state...can you either revert this from the library, or
implement the compiler support, before the 5.0 release branch?
In https://reviews.llvm.org/D31022#716702, @jyknight wrote:
gtbercea added inline comments.
Comment at: test/Driver/openmp-offload.c:607
+
+// CHK-FOPENMP-EQ-TARGET: clang{{.*}} argument unused during compilation:
'-Xopenmp-target=powerpc64le-ibm-linux-gnu -march=pwr8'
+
hfinkel wrote:
> I don't see why you'd check that
I had initially also thought that thunks wouldn't need to be exported, since
you should always have one of two scenarios:
1. The class doesn't have a key function, in which case both its vtable and
its thunks will just be emitted wherever they're needed.
2. The class has a key function, in whic
mclow.lists added a comment.
@smeenai wrote:
> This is kinda ugly, but I can't think of a better way to do it. I'm fine with
> this, but given that it's a pretty invasive change, I'm not comfortable
> accepting. You may wanna ping @EricWF and @mclow.lists directly.
I'll be meeting with the MS
yaxunl updated this revision to Diff 105310.
yaxunl marked 6 inline comments as done.
yaxunl retitled this revision from "[AMDGPU] Fix address space of global
variable" to "CodeGen: Fix address space of global variable".
yaxunl edited the summary of this revision.
yaxunl added a comment.
Revised
If the thinks are not imported, why would it make sense to export them?
Maybe devirtualization could trigger this?
On Wed, Jul 5, 2017 at 1:17 PM Shoaib Meenai wrote:
> The thunks are (as far as I know, at least) only referenced from vtables,
> so
> there's no opportunity to perform indirect ca
yaxunl marked 12 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:969
+ /// LangAS::Default.
+ virtual unsigned getGlobalAddressSpace() const { return LangAS::Default; }
+
rjmccall wrote:
> I'm not sure this re
No, it was not deliberate. I'll take a look at the failing tests today.
> On Jul 5, 2017, at 10:02 AM, Marshall Clow via Phabricator via cfe-commits
> wrote:
>
> mclow.lists added a comment.
>
> This commit breaks all the libc++ aligned new/delete tests on Mac OS. Was
> that deliberate?
>
>
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Sorry for the long delay! This looks good to me. Do you have commit access, or
do you need someone to commit it for you?
> Regarding " I think it would also be good to (eventually) add C
boris created this revision.
Extend the -fmodule-file option to support the [=] value format.
If the name is omitted, then the old semantics is preserved (the module file
is loaded whether needed or not). If the name is specified, then the mapping
is treated as just another prebuilt module search
The thunks are (as far as I know, at least) only referenced from vtables, so
there's no opportunity to perform indirect calls via the IAT for them. The
vtable would just end up referencing the linker-generated import thunk
instead.
I can play around with marking the thunks as dllimport if the func
ilya-biryukov added a comment.
In https://reviews.llvm.org/D34936#799589, @mibintc wrote:
> Thanks so much!
You're welcome.
Repository:
rL LLVM
https://reviews.llvm.org/D34936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Author: epilk
Date: Wed Jul 5 10:08:56 2017
New Revision: 307175
URL: http://llvm.org/viewvc/llvm-project?rev=307175&view=rev
Log:
[Sema] Don't allow -Wunguarded-availability to be silenced with redecls
Differential revision: https://reviews.llvm.org/D33816
Modified:
cfe/trunk/include/clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307175: [Sema] Don't allow -Wunguarded-availability to be
silenced with redecls (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D33816?vs=104437&id=105296#toc
Repository:
rL LL
yawanng updated this revision to Diff 105293.
yawanng marked 8 inline comments as done.
https://reviews.llvm.org/D34913
Files:
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/CloexecOpenCheck.cpp
clang-tidy/android/CloexecSocketCheck.cpp
cla
mclow.lists added a comment.
This commit breaks all the libc++ aligned new/delete tests on Mac OS. Was that
deliberate?
Failing Tests (8):
libc++ ::
std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp
libc++ ::
std/language.support/support.
malhar1995 updated this revision to Diff 105292.
malhar1995 added a comment.
Corrected one of the two test-cases added in the last-diff.
Repository:
rL LLVM
https://reviews.llvm.org/D34937
Files:
lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
test/Analysis/retain-release-inline.m
In
mclow.lists added a comment.
> I'm not exactly sure why the test failed, but the patch was reverted in
> r306859.
My bad, since the tests are failing due to clang whining about the system dylib
not supporting aligned new/delete on 10.12, I meant to post this on
https://reviews.llvm.org/D34574
Anastasia added a comment.
LGTM! Thanks!
https://reviews.llvm.org/D34980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
Btw, is there any reason to add testing specifically for half? Is there
anything specific to half in the implementation of this?
Comment at: test/CodeGenOpenCL/kernel-arg-info.cl:79
+kernel void foo6_2(global const volatile half * restrict
globalcon
ahatanak added a comment.
I'm not exactly sure why the test failed, but the patch was reverted in r306859.
Repository:
rL LLVM
https://reviews.llvm.org/D34556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307172: Address comments that escaped D3 (authored by
erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D34671?vs=104966&id=105284#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: erichkeane
Date: Wed Jul 5 09:43:45 2017
New Revision: 307172
URL: http://llvm.org/viewvc/llvm-project?rev=307172&view=rev
Log:
Address comments that escaped D3
Patch By: Jen Yu
Differential Revision:https://reviews.llvm.org/D34671
Modified:
cfe/trunk/include/clang/Basic/Diagno
On Wed, Jul 5, 2017 at 12:22 PM Mehdi AMINI wrote:
> The LLVM verifier is complaining that dllimport have to be external
> linkage and isn't happy with available_externally, is the verifier wrong?
>
IMO, yes. I imagine that it is fine with dllimport available_externally
functions already.
> 20
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D34947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: marshall
Date: Wed Jul 5 09:37:19 2017
New Revision: 307171
URL: http://llvm.org/viewvc/llvm-project?rev=307171&view=rev
Log:
Fix a bug in regex_Iterator where it would report zero-length matches forever.
Reported as http://llvm.org/PR33681. Thanks to Karen Arutyunov for the report.
Mod
vladimir.plyashkun updated this revision to Diff 105283.
vladimir.plyashkun edited the summary of this revision.
vladimir.plyashkun added a comment.
- made code less verbose
- used assignment initialization form
- removed extra `.c_str()` call
Repository:
rL LLVM
https://reviews.llvm.org/D344
The LLVM verifier is complaining that dllimport have to be external linkage
and isn't happy with available_externally, is the verifier wrong?
2017-07-05 9:12 GMT-07:00 David Majnemer :
> I don't think you need the dllimport restriction.
>
> On Wed, Jul 5, 2017 at 12:05 PM Alex Lorenz via Phabrica
I don't think you need the dllimport restriction.
On Wed, Jul 5, 2017 at 12:05 PM Alex Lorenz via Phabricator via cfe-commits
wrote:
> arphaman added a comment.
>
> Does this apply to all constexpr global variables? It could potentially
> fix https://bugs.llvm.org/show_bug.cgi?id=31860 .
>
>
> h
mclow.lists added a comment.
This doesn't work when running the libc++ tests against a non-system libc++.
(which is what all the libc++ developers and AND all the test bots do)
Repository:
rL LLVM
https://reviews.llvm.org/D34556
___
cfe-commits
gtbercea updated this revision to Diff 105280.
gtbercea marked 3 inline comments as done.
gtbercea added a comment.
Address comments.
https://reviews.llvm.org/D34784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Cuda.cpp
test/D
1 - 100 of 203 matches
Mail list logo
