[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

MyDeveloperDay added a comment. Herald added a reviewer: rymiel. Cloud you include a test that contains multiple levels of nested scope, I'm assuming we won't add an additonal line at every {} level (or will we?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2429 + This determines the number of empty lines to use when + SeparateDefinitionBlocks == SeparateDefinitionStyle::SDS_Always. + Can you write this not in terms of the cod

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

HazardyKnusperkeks added a comment. In D132256#3740714 , @alecto wrote: > If possible I would like to error out if MaxEmptyLinesToKeep < > DefinitionBlockSpacing, because that case is probably a mistake on the part > of the user, and a failure would be

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

alecto added a comment. If possible I would like to error out if MaxEmptyLinesToKeep < DefinitionBlockSpacing, because that case is probably a mistake on the part of the user, and a failure would be better than clang-format silently doing something unexpected, but I'm not sure where to put the

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

HazardyKnusperkeks added a comment. In D132256#3738407 , @alecto wrote: > In D132256#3736076 , > @HazardyKnusperkeks wrote: > >> Do we want to define the behavior of `MaxEmptyLinesToKeep < >> DefinitionBlockSpac

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

alecto added a comment. In D132256#3736076 , @HazardyKnusperkeks wrote: > Do we want to define the behavior of `MaxEmptyLinesToKeep < > DefinitionBlockSpacing`? Then we need tests for that! > Tests with `MaxEmptyLinesToKeep < DefinitionBlockSpacing` and

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

alecto updated this revision to Diff 454343. alecto added a comment. Revise based on feedback from Björn Schäpers We updated the version tag to 16 and positioned the DefinitionBLockSpacing field alphabetically. We also updated the documentation with `clang/docs/tools/dump_format_style.py` Repo

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

MyDeveloperDay added a comment. nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132256/new/ https://reviews.llvm.org/D132256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

HazardyKnusperkeks added a comment. Please run `clang/docs/tools/dump_format_style.py`. Comment at: clang/include/clang/Format/Format.h:3189 + /// to DefinitionBlockSpacing. + /// \version 15 + unsigned DefinitionBlockSpacing; This isn't going to land in 15.

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

alecto created this revision. alecto added reviewers: Richard, smith. Herald added a project: All. alecto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/57180 Given configuration: Separ