[PATCH] D145509: [HIP] Fix temporary files

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f8a3ce325be: [HIP] Fix temporary files (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https:

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503892. yaxunl added a comment. fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp clang/test/Driver/hip-link-bc-to-bc.hip

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503826. yaxunl marked an inline comment as done. yaxunl added a comment. fix comments and tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h clang/lib/Drive

[PATCH] D145509: [HIP] Fix temporary files

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Driver.h:630 // Creates a temp file with $Prefix-%%.$Suffix const char *CreateTempFile(Compilation &C, StringRef Prefix, StringRef Suffix, t

[PATCH] D145509: [HIP] Fix temporary files

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Driver.h:630 // Creates a temp file with $Prefix-%%.$Suffix const char *CreateTempFile(Compilation &C, StringRef Prefix, Stri

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503504. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h clang/lib/

[PATCH] D145509: [HIP] Fix temporary files

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Driver.h:634 + StringRef BoundArch = {}, + Action::OffloadKind OFK = Action::OFK_None) const; t

[PATCH] D145509: [HIP] Fix temporary files

tra added a comment. In D145509#4176732 , @yaxunl wrote: > However, it seems the previous code using GetTemporaryDirectory was > intentional (https://reviews.llvm.org/D111269). My guess is that lipo using > some hash of input file name in the generated

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503218. yaxunl edited the summary of this revision. yaxunl added a reviewer: keith. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp

[PATCH] D145509: [HIP] Fix temporary files

yaxunl added a comment. In D145509#4175773 , @tra wrote: > LGTM, but we should probably get someone familiar with macos to chime in, > just in case there may be some reason behind macos using temp directories > here. > >> This change is OK for MacOS as

[PATCH] D145509: [HIP] Fix temporary files

tra added a comment. LGTM, but we should probably get someone familiar with macos to chime in, just in case there may be some reason behind macos using temp directories here. > This change is OK for MacOS as lipo does not requires specific I'm curious why lipo has been singled out. Is that the

[PATCH] D145509: [HIP] Fix temporary files

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay. Herald added a reviewer: JDevlieghere. Herald added a project: All. yaxunl requested review of this revision. Currently HIP toolchain uses Driver::GetTemporaryDirectory to create a temporary directory for some temporary files duri