ahatanak abandoned this revision.
ahatanak added a comment.
Abandoning this patch as I've removed -Wpadded in r258900.
http://reviews.llvm.org/D15897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
On Tue, Jan 26, 2016 at 07:43:03PM +, Akira Hatanaka via cfe-commits wrote:
> ahatanak added a comment.
>
> Do you mean "-Wpadded -Wno-error=padded" instead of padding?
>
> I'm looking for a way to silence the warning, so that isn't enough. If
> we need more time to decide whether we want to
ahatanak added a comment.
There is also a PR about splitting -Wpadded into two options: one warns about
padding in the middle of a struct and the other warns about padding at the end.
If the former option is used instead of -Wpadded, I believe it's possible to
remove the pragmas that are curren
ahatanak added a comment.
Do you mean "-Wpadded -Wno-error=padded" instead of padding?
I'm looking for a way to silence the warning, so that isn't enough. If we need
more time to decide whether we want to use -Wpadded (for both buildit and
cmake), I think I'll just remove -Wpadded from buildit'
joerg added a comment.
As I said on IRC, it might be useful to set -Wpadding -Wno-error=padding, but I
don't think the current state adds value. So removing the option is certainly
an acceptable step forward to me.
http://reviews.llvm.org/D15897
_
ahatanak added a comment.
Maybe we can just remove -Wpadded from buildit's command line for now? If we
decide in the future it's worthwhile to use -Wpadded, we can put it back and
commit this patch. Also in that case we should make sure cmake uses the option
too.
http://reviews.llvm.org/D1589
ahatanak added reviewers: mclow.lists, EricWF, joerg, howard.hinnant.
ahatanak added a comment.
Adding reviewers
http://reviews.llvm.org/D15897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
ahatanak added a comment.
Ping.
The same pragma is being used in other places (regex.cpp and locale.cpp) to
silence the warning.
http://reviews.llvm.org/D15897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
ahatanak created this revision.
ahatanak added a subscriber: cfe-commits.
This patch fixes a warning that is issued when -Wpadded is on clang's command
line. The following warning is from the build log of
http://lab.llvm.org:8080/green/view/Libcxx/job/libcxx_abi/554/consoleText (note
that I see
