https://github.com/ilovepi approved this pull request.
LGTM, but let’s update the pr title and description to match the current patch.
Also, a title like modify tests isn’t very informative. Something like “Support
markdown and simplify checks” seems more appropriate. Additionally, those two
@@ -54,306 +54,249 @@
// JSON-INDEX-NEXT: };
// JSON-INDEX-NEXT: }
-// HTML-SHAPE:
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT: class Shape
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT:
-//
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/97684
>From 778f43dd6505c41d4175c1fe717b8cf79d7a43fc Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Thu, 4 Jul 2024 02:52:11 -0400
Subject: [PATCH 1/2] [clang-doc] modify basic-project test
---
.../test/clang-doc
@@ -54,306 +54,249 @@
// JSON-INDEX-NEXT: };
// JSON-INDEX-NEXT: }
-// HTML-SHAPE:
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT: class Shape
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT:
-// HTML-SHAPE-NEXT:
-//
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/97684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi commented:
This is headed in the right direction, but I'm not sure we want to match so
many of the single line tags ... they don't seem particularly valuable from a
testing standpoint. If you think we're missing tests for the HTML structure,
then we should have some
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: None (PeterChou1)
Changes
This patch modifies the basic-project in clang-doc. Currently we're matching
the entire html output. This patch modifies it so that we only match the parts
relevant to the documentation logic instead
https://github.com/PeterChou1 created
https://github.com/llvm/llvm-project/pull/97684
This patch modifies the basic-project in clang-doc. Currently we're matching
the entire html output. This patch modifies it so that we only match the parts
relevant to the documentation logic instead just mat
