Re: [libcxx] r271060 - Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

2016-05-28 Thread Richard Smith via cfe-commits
On 28 May 2016 12:58 a.m., "Eric Fiselier via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > I think that would be a possibility. However IMO such a change has little value. Unlike other uses of `_LIBCPP_PREFERRED_OVERLOAD`, which fix const correctness issue, I don't think the int vs bool re

Re: [libcxx] r271060 - Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

2016-05-28 Thread Eric Fiselier via cfe-commits
I think that would be a possibility. However IMO such a change has little value. Unlike other uses of `_LIBCPP_PREFERRED_OVERLOAD`, which fix const correctness issue, I don't think the int vs bool return type distinction as that important. Perhaps I"m just being ignorant? /Eric ___

Re: [libcxx] r271060 - Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

2016-05-28 Thread Richard Smith via cfe-commits
Could we use __LIBCPP_PREFERRED_OVERLOAD to get this working even with older glibc (and recent clang)? On 27 May 2016 3:26 p.m., "Eric Fiselier via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Fri May 27 17:19:53 2016 > New Revision: 271060 > > URL: http://llvm.org/v