[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/171000 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
github-actions[bot] wrote: # :penguin: Linux x64 Test Results * 3054 tests passed * 7 tests skipped All tests passed but another part of the build **failed**. Click on a failure below to see the details. tools/mlir/lib/Pass/CMakeFiles/obj.MLIRPass.dir/PassRegistry.cpp.o ``` FAILED: tools/mlir/lib/Pass/CMakeFiles/obj.MLIRPass.dir/PassRegistry.cpp.o sccache /opt/llvm/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/mlir/lib/Pass -I/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Pass -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/mlir/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -Werror=global-constructors -O3 -DNDEBUG -std=c++17 -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/mlir/lib/Pass/CMakeFiles/obj.MLIRPass.dir/PassRegistry.cpp.o -MF tools/mlir/lib/Pass/CMakeFiles/obj.MLIRPass.dir/PassRegistry.cpp.o.d -o tools/mlir/lib/Pass/CMakeFiles/obj.MLIRPass.dir/PassRegistry.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Pass/PassRegistry.cpp /home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Pass/PassRegistry.cpp:439:37: error: ISO C++ requires the name after '::~' to be found in the same scope as the name before '::~' [-Werror,-Wdtor-name] 439 | llvm::cl::OptionValue::~OptionValue() = default; | ^~ | ::OptionValue 1 error generated. ``` If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label. https://github.com/llvm/llvm-project/pull/171000 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From ed27a1b7703ca1b70bb486fb8ea2fd87edbbf2ab Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From cb17ddaaeb61e05c01560037e79a3bb7b8ef7cde Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From c83fbed50b39a7264714bdb62bf5d1d5ce878b80 Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From 1ae6217d345c4307532a59f3206901e524f8f114 Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From 561d7848f596b69535e01911f5d986f3ceb35872 Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From 5e47501248ed5ca5d8494fdce21c8380af1dab36 Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From 0a9455ab6f92d054be06e15991d7a8b90c05e1f9 Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From dd0f8747aa93e36bd2934aebc3175906aff1371c Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From 1d701b0e30978489e6d362e4e939bb7369b6727b Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From 8c772e01b7fb816d927b5f8167f6c9baa82e4a1d Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From 11da329f48ce44b2ceb6898f0fe56ad980c3dadd Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From efc034d7051910bb930a1325abed77475ad5ae17 Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
xlauko wrote: ### Merge activity * **Dec 8, 3:14 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.com/github/pr/llvm/llvm-project/171000). https://github.com/llvm/llvm-project/pull/171000 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/AmrDeveloper approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/171000 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/171000 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko updated https://github.com/llvm/llvm-project/pull/171000 >From 59d0f7fca06b386ad8148adc4d7814c4101b19ac Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..6b4d3b4fc585b 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp --diff_from_common_commit `` :warning: The reproduction instructions above might return results for more than one PR in a stack if you are using a stacked PR workflow. You can limit the results by changing `origin/main` to the base branch/commit you want to compare against. :warning: View the diff from clang-format here. ``diff diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index cf1a7dcd7..6b4d3b4fc 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,8 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_(lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibility())); + fn.setVisibility_( + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2160,8 +2160,8 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - mlir::LLVM::Visibility visibility = lowerCIRVisibilityToLLVMVisibility( - op.getGlobalVisibility()); + mlir::LLVM::Visibility visibility = + lowerCIRVisibilityToLLVMVisibility(op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), `` https://github.com/llvm/llvm-project/pull/171000 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Henrich Lauko (xlauko) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/171000.diff 1 Files Affected: - (modified) clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp (+5-7) ``diff diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..cf1a7dcd77ecd 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_(lowerCIRVisibilityToLLVMVisibility( +op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = lowerCIRVisibilityToLLVMVisibility( + op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } `` https://github.com/llvm/llvm-project/pull/171000 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
llvmbot wrote: @llvm/pr-subscribers-clang Author: Henrich Lauko (xlauko) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/171000.diff 1 Files Affected: - (modified) clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp (+5-7) ``diff diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..cf1a7dcd77ecd 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_(lowerCIRVisibilityToLLVMVisibility( +op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = lowerCIRVisibilityToLLVMVisibility( + op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } `` https://github.com/llvm/llvm-project/pull/171000 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko created https://github.com/llvm/llvm-project/pull/171000 None >From 0d0280b71a709206b0fe7ec7d3e833088a2966e2 Mon Sep 17 00:00:00 2001 From: xlauko Date: Sat, 6 Dec 2025 22:36:08 +0100 Subject: [PATCH] [CIR] Clean up visibility conversion (NFC) --- clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp index 97bd3cf850daa..cf1a7dcd77ecd 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp +++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp @@ -2015,9 +2015,8 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::matchAndRewrite( fn.setAlwaysInline(*inlineKind == cir::InlineKind::AlwaysInline); } - fn.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + fn.setVisibility_(lowerCIRVisibilityToLLVMVisibility( +op.getGlobalVisibility())); rewriter.inlineRegionBefore(op.getBody(), fn.getBody(), fn.end()); if (failed(rewriter.convertRegionTypes(&fn.getBody(), *typeConverter, @@ -2161,14 +2160,13 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( } } - // Rewrite op. + mlir::LLVM::Visibility visibility = lowerCIRVisibilityToLLVMVisibility( + op.getGlobalVisibility()); mlir::SymbolRefAttr comdatAttr = getComdatAttr(op, rewriter); auto newOp = rewriter.replaceOpWithNewOp( op, llvmType, isConst, linkage, symbol, init.value_or(mlir::Attribute()), alignment, addrSpace, isDsoLocal, isThreadLocal, comdatAttr, attributes); - newOp.setVisibility_Attr(mlir::LLVM::VisibilityAttr::get( - getContext(), lowerCIRVisibilityToLLVMVisibility( -op.getGlobalVisibilityAttr().getValue(; + newOp.setVisibility_(visibility); return mlir::success(); } ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
https://github.com/xlauko ready_for_review https://github.com/llvm/llvm-project/pull/171000 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [CIR] Clean up visibility conversion (NFC) (PR #171000)
xlauko wrote: * **#171001** https://app.graphite.com/github/pr/llvm/llvm-project/171001?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> * **#171000** https://app.graphite.com/github/pr/llvm/llvm-project/171000?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.com/github/pr/llvm/llvm-project/171000?utm_source=stack-comment-view-in-graphite"; target="_blank">(View in Graphite) * `main` This stack of pull requests is managed by https://graphite.dev?utm-source=stack-comment";>Graphite. Learn more about https://stacking.dev/?utm_source=stack-comment";>stacking. https://github.com/llvm/llvm-project/pull/171000 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
