[clang] [Sema] Remove an unnecessary cast (NFC) (PR #147203)
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/9984 Here is the relevant piece of the build log for the reference ``` Step 6 (test) failure: build (failure) ``` https://github.com/llvm/llvm-project/pull/147203 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Sema] Remove an unnecessary cast (NFC) (PR #147203)
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-win` running on `as-builder-10` while building `clang` at step 8 "test-check-lldb-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/211/builds/284 Here is the relevant piece of the build log for the reference ``` Step 8 (test-check-lldb-unit) failure: Test just built components: check-lldb-unit completed (failure) TEST 'lldb-unit :: Host/./HostTests.exe/31/87' FAILED Script(shard): -- GTEST_OUTPUT=json:C:\buildbot\as-builder-10\lldb-x86-64\build\tools\lldb\unittests\Host\.\HostTests.exe-lldb-unit-14604-31-87.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=87 GTEST_SHARD_INDEX=31 C:\buildbot\as-builder-10\lldb-x86-64\build\tools\lldb\unittests\Host\.\HostTests.exe -- Script: -- C:\buildbot\as-builder-10\lldb-x86-64\build\tools\lldb\unittests\Host\.\HostTests.exe --gtest_filter=MainLoopTest.NoSpuriousPipeReads -- C:\buildbot\as-builder-10\lldb-x86-64\llvm-project\lldb\unittests\Host\MainLoopTest.cpp(141): error: Expected equality of these values: 1u Which is: 1 callback_count Which is: 2 C:\buildbot\as-builder-10\lldb-x86-64\llvm-project\lldb\unittests\Host\MainLoopTest.cpp:141 Expected equality of these values: 1u Which is: 1 callback_count Which is: 2 ``` https://github.com/llvm/llvm-project/pull/147203 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Sema] Remove an unnecessary cast (NFC) (PR #147203)
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/147203 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Sema] Remove an unnecessary cast (NFC) (PR #147203)
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/147203 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Sema] Remove an unnecessary cast (NFC) (PR #147203)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
StorageClass is already of spirv::StorageClass.
---
Full diff: https://github.com/llvm/llvm-project/pull/147203.diff
1 Files Affected:
- (modified) clang/lib/Sema/SemaSPIRV.cpp (+1-1)
``diff
diff --git a/clang/lib/Sema/SemaSPIRV.cpp b/clang/lib/Sema/SemaSPIRV.cpp
index c27d3fed2b990..76d3cff908b37 100644
--- a/clang/lib/Sema/SemaSPIRV.cpp
+++ b/clang/lib/Sema/SemaSPIRV.cpp
@@ -116,7 +116,7 @@ static bool checkGenericCastToPtr(Sema &SemaRef, CallExpr
*Call) {
RT = RT->getPointeeType();
auto Qual = RT.getQualifiers();
LangAS AddrSpace;
- switch (static_cast(StorageClass)) {
+ switch (StorageClass) {
case spirv::StorageClass::CrossWorkgroup:
AddrSpace =
SemaRef.LangOpts.isSYCL() ? LangAS::sycl_global :
LangAS::opencl_global;
``
https://github.com/llvm/llvm-project/pull/147203
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Sema] Remove an unnecessary cast (NFC) (PR #147203)
llvmbot wrote:
@llvm/pr-subscribers-backend-spir-v
Author: Kazu Hirata (kazutakahirata)
Changes
StorageClass is already of spirv::StorageClass.
---
Full diff: https://github.com/llvm/llvm-project/pull/147203.diff
1 Files Affected:
- (modified) clang/lib/Sema/SemaSPIRV.cpp (+1-1)
``diff
diff --git a/clang/lib/Sema/SemaSPIRV.cpp b/clang/lib/Sema/SemaSPIRV.cpp
index c27d3fed2b990..76d3cff908b37 100644
--- a/clang/lib/Sema/SemaSPIRV.cpp
+++ b/clang/lib/Sema/SemaSPIRV.cpp
@@ -116,7 +116,7 @@ static bool checkGenericCastToPtr(Sema &SemaRef, CallExpr
*Call) {
RT = RT->getPointeeType();
auto Qual = RT.getQualifiers();
LangAS AddrSpace;
- switch (static_cast(StorageClass)) {
+ switch (StorageClass) {
case spirv::StorageClass::CrossWorkgroup:
AddrSpace =
SemaRef.LangOpts.isSYCL() ? LangAS::sycl_global :
LangAS::opencl_global;
``
https://github.com/llvm/llvm-project/pull/147203
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Sema] Remove an unnecessary cast (NFC) (PR #147203)
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/147203
StorageClass is already of spirv::StorageClass.
>From 22b9a1ae6d4874a50586c369a47136f97a60b66c Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sat, 5 Jul 2025 10:47:10 -0700
Subject: [PATCH] [Sema] Remove an unnecessary cast (NFC)
StorageClass is already of spirv::StorageClass.
---
clang/lib/Sema/SemaSPIRV.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/lib/Sema/SemaSPIRV.cpp b/clang/lib/Sema/SemaSPIRV.cpp
index c27d3fed2b990..76d3cff908b37 100644
--- a/clang/lib/Sema/SemaSPIRV.cpp
+++ b/clang/lib/Sema/SemaSPIRV.cpp
@@ -116,7 +116,7 @@ static bool checkGenericCastToPtr(Sema &SemaRef, CallExpr
*Call) {
RT = RT->getPointeeType();
auto Qual = RT.getQualifiers();
LangAS AddrSpace;
- switch (static_cast(StorageClass)) {
+ switch (StorageClass) {
case spirv::StorageClass::CrossWorkgroup:
AddrSpace =
SemaRef.LangOpts.isSYCL() ? LangAS::sycl_global :
LangAS::opencl_global;
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
