[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-17 Thread Bruno Cardoso Lopes via cfe-commits 

https://github.com/bcardosolopes closed 
https://github.com/llvm/llvm-project/pull/131057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-17 Thread Bruno Cardoso Lopes via cfe-commits 

https://github.com/bcardosolopes approved this pull request.


https://github.com/llvm/llvm-project/pull/131057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-17 Thread via cfe-commits 

https://github.com/darkbuck updated 
https://github.com/llvm/llvm-project/pull/131057

>From 255050e6d1e3ebbf25b30c17a10be14d29e5dae7 Mon Sep 17 00:00:00 2001
From: Michael Liao 
Date: Tue, 4 Mar 2025 12:47:24 -0500
Subject: [PATCH] [clang][CIR] Add missing dependency on MLIR headers

- Add dependency on MLIRBuiltinOpsIncGen as
  "clang/CIR/FrontendAction/CIRGenAction.h" needs to include
  "mlir/IR/BuiltinOps.h"
---
 clang/lib/CIR/FrontendAction/CMakeLists.txt | 1 +
 clang/lib/FrontendTool/CMakeLists.txt   | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..1ebac07f44662 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,7 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  MLIRBuiltinOpsIncGen
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..7c83086a7da3b 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,9 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  list(APPEND deps
+MLIRBuiltinOpsIncGen
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-16 Thread via cfe-commits 

https://github.com/darkbuck updated 
https://github.com/llvm/llvm-project/pull/131057

>From 255050e6d1e3ebbf25b30c17a10be14d29e5dae7 Mon Sep 17 00:00:00 2001
From: Michael Liao 
Date: Tue, 4 Mar 2025 12:47:24 -0500
Subject: [PATCH] [clang][CIR] Add missing dependency on MLIR headers

- Add dependency on MLIRBuiltinOpsIncGen as
  "clang/CIR/FrontendAction/CIRGenAction.h" needs to include
  "mlir/IR/BuiltinOps.h"
---
 clang/lib/CIR/FrontendAction/CMakeLists.txt | 1 +
 clang/lib/FrontendTool/CMakeLists.txt   | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..1ebac07f44662 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,7 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  MLIRBuiltinOpsIncGen
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..7c83086a7da3b 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,9 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  list(APPEND deps
+MLIRBuiltinOpsIncGen
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-15 Thread via cfe-commits 

https://github.com/darkbuck updated 
https://github.com/llvm/llvm-project/pull/131057

>From 255050e6d1e3ebbf25b30c17a10be14d29e5dae7 Mon Sep 17 00:00:00 2001
From: Michael Liao 
Date: Tue, 4 Mar 2025 12:47:24 -0500
Subject: [PATCH] [clang][CIR] Add missing dependency on MLIR headers

- Add dependency on MLIRBuiltinOpsIncGen as
  "clang/CIR/FrontendAction/CIRGenAction.h" needs to include
  "mlir/IR/BuiltinOps.h"
---
 clang/lib/CIR/FrontendAction/CMakeLists.txt | 1 +
 clang/lib/FrontendTool/CMakeLists.txt   | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..1ebac07f44662 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,7 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  MLIRBuiltinOpsIncGen
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..7c83086a7da3b 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,9 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  list(APPEND deps
+MLIRBuiltinOpsIncGen
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-15 Thread via cfe-commits 

https://github.com/darkbuck updated 
https://github.com/llvm/llvm-project/pull/131057

>From 255050e6d1e3ebbf25b30c17a10be14d29e5dae7 Mon Sep 17 00:00:00 2001
From: Michael Liao 
Date: Tue, 4 Mar 2025 12:47:24 -0500
Subject: [PATCH] [clang][CIR] Add missing dependency on MLIR headers

- Add dependency on MLIRBuiltinOpsIncGen as
  "clang/CIR/FrontendAction/CIRGenAction.h" needs to include
  "mlir/IR/BuiltinOps.h"
---
 clang/lib/CIR/FrontendAction/CMakeLists.txt | 1 +
 clang/lib/FrontendTool/CMakeLists.txt   | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..1ebac07f44662 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,7 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  MLIRBuiltinOpsIncGen
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..7c83086a7da3b 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,9 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  list(APPEND deps
+MLIRBuiltinOpsIncGen
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-15 Thread via cfe-commits 

https://github.com/darkbuck updated 
https://github.com/llvm/llvm-project/pull/131057

>From 255050e6d1e3ebbf25b30c17a10be14d29e5dae7 Mon Sep 17 00:00:00 2001
From: Michael Liao 
Date: Tue, 4 Mar 2025 12:47:24 -0500
Subject: [PATCH] [clang][CIR] Add missing dependency on MLIR headers

- Add dependency on MLIRBuiltinOpsIncGen as
  "clang/CIR/FrontendAction/CIRGenAction.h" needs to include
  "mlir/IR/BuiltinOps.h"
---
 clang/lib/CIR/FrontendAction/CMakeLists.txt | 1 +
 clang/lib/FrontendTool/CMakeLists.txt   | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..1ebac07f44662 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,7 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  MLIRBuiltinOpsIncGen
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..7c83086a7da3b 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,9 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  list(APPEND deps
+MLIRBuiltinOpsIncGen
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-15 Thread via cfe-commits 


@@ -11,6 +11,9 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  mlir-generic-headers

darkbuck wrote:

> MLIRBuiltinLocationAttributesIncGen



> Why not `MLIRBuiltinLocationAttributesIncGen`?

narrow down to `MLIRBuiltinOpsIncGen`

https://github.com/llvm/llvm-project/pull/131057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-14 Thread via cfe-commits 

https://github.com/darkbuck updated 
https://github.com/llvm/llvm-project/pull/131057

>From 255050e6d1e3ebbf25b30c17a10be14d29e5dae7 Mon Sep 17 00:00:00 2001
From: Michael Liao 
Date: Tue, 4 Mar 2025 12:47:24 -0500
Subject: [PATCH] [clang][CIR] Add missing dependency on MLIR headers

- Add dependency on MLIRBuiltinOpsIncGen as
  "clang/CIR/FrontendAction/CIRGenAction.h" needs to include
  "mlir/IR/BuiltinOps.h"
---
 clang/lib/CIR/FrontendAction/CMakeLists.txt | 1 +
 clang/lib/FrontendTool/CMakeLists.txt   | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..1ebac07f44662 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,7 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  MLIRBuiltinOpsIncGen
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..7c83086a7da3b 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,9 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  list(APPEND deps
+MLIRBuiltinOpsIncGen
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-13 Thread Bruno Cardoso Lopes via cfe-commits 


@@ -11,6 +11,9 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  mlir-generic-headers

bcardosolopes wrote:

Why not `MLIRBuiltinLocationAttributesIncGen`?

https://github.com/llvm/llvm-project/pull/131057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-13 Thread via cfe-commits 

https://github.com/darkbuck updated 
https://github.com/llvm/llvm-project/pull/131057

>From 2a86c00614aed22f409c262dcb076f018e1fbbde Mon Sep 17 00:00:00 2001
From: Michael Liao 
Date: Tue, 4 Mar 2025 12:47:24 -0500
Subject: [PATCH] [clang][CIR] Add missing dependency on MLIR headers

---
 clang/lib/CIR/FrontendAction/CMakeLists.txt | 3 +++
 clang/lib/FrontendTool/CMakeLists.txt   | 5 +
 2 files changed, 8 insertions(+)

diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..df0e075fb7532 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,9 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  mlir-generic-headers
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..5a828ce239c64 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,11 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  list(APPEND deps
+mlir-generic-headers
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-12 Thread via cfe-commits 

darkbuck wrote:

This patch is to fix the build failure once CIR is enabled. The error reads like
```
llvm-project/llvm/../mlir/include/mlir/IR/Location.h:145:10: fatal error: 
mlir/IR/BuiltinLocationAttributes.h.inc: No such file or directory
```

https://github.com/llvm/llvm-project/pull/131057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-12 Thread via cfe-commits 

https://github.com/darkbuck updated 
https://github.com/llvm/llvm-project/pull/131057

>From 2a86c00614aed22f409c262dcb076f018e1fbbde Mon Sep 17 00:00:00 2001
From: Michael Liao 
Date: Tue, 4 Mar 2025 12:47:24 -0500
Subject: [PATCH] [clang][CIR] Add missing dependency on MLIR headers

---
 clang/lib/CIR/FrontendAction/CMakeLists.txt | 3 +++
 clang/lib/FrontendTool/CMakeLists.txt   | 5 +
 2 files changed, 8 insertions(+)

diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..df0e075fb7532 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,9 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  mlir-generic-headers
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..5a828ce239c64 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,11 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  list(APPEND deps
+mlir-generic-headers
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-12 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clangir

Author: None (darkbuck)


Changes



---
Full diff: https://github.com/llvm/llvm-project/pull/131057.diff


2 Files Affected:

- (modified) clang/lib/CIR/FrontendAction/CMakeLists.txt (+3) 
- (modified) clang/lib/FrontendTool/CMakeLists.txt (+5) 


``diff
diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..df0e075fb7532 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,9 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  mlir-generic-headers
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..5a828ce239c64 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,11 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  list(APPEND deps
+mlir-generic-headers
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

``




https://github.com/llvm/llvm-project/pull/131057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-12 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: None (darkbuck)


Changes



---
Full diff: https://github.com/llvm/llvm-project/pull/131057.diff


2 Files Affected:

- (modified) clang/lib/CIR/FrontendAction/CMakeLists.txt (+3) 
- (modified) clang/lib/FrontendTool/CMakeLists.txt (+5) 


``diff
diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..df0e075fb7532 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,9 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  mlir-generic-headers
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..5a828ce239c64 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,11 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  list(APPEND deps
+mlir-generic-headers
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

``




https://github.com/llvm/llvm-project/pull/131057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Add missing dependency on MLIR headers (PR #131057)

2025-03-12 Thread via cfe-commits 

https://github.com/darkbuck created 
https://github.com/llvm/llvm-project/pull/131057

None

>From 2a86c00614aed22f409c262dcb076f018e1fbbde Mon Sep 17 00:00:00 2001
From: Michael Liao 
Date: Tue, 4 Mar 2025 12:47:24 -0500
Subject: [PATCH] [clang][CIR] Add missing dependency on MLIR headers

---
 clang/lib/CIR/FrontendAction/CMakeLists.txt | 3 +++
 clang/lib/FrontendTool/CMakeLists.txt   | 5 +
 2 files changed, 8 insertions(+)

diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt 
b/clang/lib/CIR/FrontendAction/CMakeLists.txt
index 6d5a8758468f6..df0e075fb7532 100644
--- a/clang/lib/CIR/FrontendAction/CMakeLists.txt
+++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt
@@ -11,6 +11,9 @@ add_clang_library(clangCIRFrontendAction
   DEPENDS
   MLIRCIROpsIncGen
   MLIRCIROpInterfacesIncGen
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  mlir-generic-headers
 
   LINK_LIBS
   clangAST
diff --git a/clang/lib/FrontendTool/CMakeLists.txt 
b/clang/lib/FrontendTool/CMakeLists.txt
index d7a3699361f0a..5a828ce239c64 100644
--- a/clang/lib/FrontendTool/CMakeLists.txt
+++ b/clang/lib/FrontendTool/CMakeLists.txt
@@ -15,6 +15,11 @@ set(link_libs
 set(deps)
 
 if(CLANG_ENABLE_CIR)
+  # Add mlir-generic-headers dependency as the header CIRGenAction.h needs to
+  # include BuiltinOps.h
+  list(APPEND deps
+mlir-generic-headers
+  )
   list(APPEND link_libs
 clangCIRFrontendAction
 MLIRIR

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits