[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)
asb wrote: > It could be due to builtins, I believe we always serialize them, and that > would be different between targets. Does RISC-V have a lot of them compared > to other targets? That's almost certainly it then, thanks! We have a _lot_ of vector builtins in particular. https://github.com/llvm/llvm-project/pull/123959 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)
Bigcheese wrote: It could be due to builtins, I believe we always serialize them, and that would be different between targets. Does RISC-V have a lot of them compared to other targets? https://github.com/llvm/llvm-project/pull/123959 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)
asb wrote: Thanks, I've gone ahead an merged. Any insight into why the module files may be larger on RISC-V vs other targets greatly appreciated - as I said in https://github.com/llvm/llvm-project/pull/111360 I'm not sure how to best inspect the module files. https://github.com/llvm/llvm-project/pull/123959 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/123959 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)
https://github.com/ChuanqiXu9 approved this pull request. CC @Bigcheese But I think the patch itself is good to go. Let's avoid breaking the CI. https://github.com/llvm/llvm-project/pull/123959 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Alex Bradbury (asb)
Changes
I'm not sure why the test is larger for RISC-V than other targets, but we saw
this before with #111360.
The file is just over the current 60KB limit:
```
62772
/home/asb/llvm-project/build/stage2/tools/clang/test/Modules/Output/empty.modulemap.tmp/base.pcm
```
---
Full diff: https://github.com/llvm/llvm-project/pull/123959.diff
1 Files Affected:
- (modified) clang/test/Modules/empty.modulemap (+2-2)
``diff
diff --git a/clang/test/Modules/empty.modulemap
b/clang/test/Modules/empty.modulemap
index f2d37c19d77bcc..8cad8b67b91155 100644
--- a/clang/test/Modules/empty.modulemap
+++ b/clang/test/Modules/empty.modulemap
@@ -13,8 +13,8 @@
// The module file should be identical each time we produce it.
// RUN: diff %t/base.pcm %t/check.pcm
//
-// We expect an empty module to be less than 60KB (and at least 10K, for now).
+// We expect an empty module to be less than 70KB (and at least 10K, for now).
// RUN: wc -c %t/base.pcm | FileCheck --check-prefix=CHECK-SIZE %s
-// CHECK-SIZE: {{(^|[^0-9])[1-5][0-9][0-9][0-9][0-9]($|[^0-9])}}
+// CHECK-SIZE: {{(^|[^0-9])[1-6][0-9][0-9][0-9][0-9]($|[^0-9])}}
module empty { header "Inputs/empty.h" export * }
``
https://github.com/llvm/llvm-project/pull/123959
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Alex Bradbury (asb)
Changes
I'm not sure why the test is larger for RISC-V than other targets, but we saw
this before with #111360.
The file is just over the current 60KB limit:
```
62772
/home/asb/llvm-project/build/stage2/tools/clang/test/Modules/Output/empty.modulemap.tmp/base.pcm
```
---
Full diff: https://github.com/llvm/llvm-project/pull/123959.diff
1 Files Affected:
- (modified) clang/test/Modules/empty.modulemap (+2-2)
``diff
diff --git a/clang/test/Modules/empty.modulemap
b/clang/test/Modules/empty.modulemap
index f2d37c19d77bcc..8cad8b67b91155 100644
--- a/clang/test/Modules/empty.modulemap
+++ b/clang/test/Modules/empty.modulemap
@@ -13,8 +13,8 @@
// The module file should be identical each time we produce it.
// RUN: diff %t/base.pcm %t/check.pcm
//
-// We expect an empty module to be less than 60KB (and at least 10K, for now).
+// We expect an empty module to be less than 70KB (and at least 10K, for now).
// RUN: wc -c %t/base.pcm | FileCheck --check-prefix=CHECK-SIZE %s
-// CHECK-SIZE: {{(^|[^0-9])[1-5][0-9][0-9][0-9][0-9]($|[^0-9])}}
+// CHECK-SIZE: {{(^|[^0-9])[1-6][0-9][0-9][0-9][0-9]($|[^0-9])}}
module empty { header "Inputs/empty.h" export * }
``
https://github.com/llvm/llvm-project/pull/123959
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)
https://github.com/asb created https://github.com/llvm/llvm-project/pull/123959
I'm not sure why the test is larger for RISC-V than other targets, but we saw
this before with #111360.
The file is just over the current 60KB limit:
```
62772
/home/asb/llvm-project/build/stage2/tools/clang/test/Modules/Output/empty.modulemap.tmp/base.pcm
```
>From 00fb282a7bb78dd8e511226408f2e5578232b62a Mon Sep 17 00:00:00 2001
From: Alex Bradbury
Date: Wed, 22 Jan 2025 15:45:49 +
Subject: [PATCH] [clang][Modules] Raise empty.modulemap expected size to <70KB
to fix RISC-V failure
I'm not sure why the test is larger for RISC-V than other targets, but
we saw this before with #111360.
The file is just over the current 60KB limit:
```
62772
/home/asb/llvm-project/build/stage2/tools/clang/test/Modules/Output/empty.modulemap.tmp/base.pcm
```
---
clang/test/Modules/empty.modulemap | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/clang/test/Modules/empty.modulemap
b/clang/test/Modules/empty.modulemap
index f2d37c19d77bcc..8cad8b67b91155 100644
--- a/clang/test/Modules/empty.modulemap
+++ b/clang/test/Modules/empty.modulemap
@@ -13,8 +13,8 @@
// The module file should be identical each time we produce it.
// RUN: diff %t/base.pcm %t/check.pcm
//
-// We expect an empty module to be less than 60KB (and at least 10K, for now).
+// We expect an empty module to be less than 70KB (and at least 10K, for now).
// RUN: wc -c %t/base.pcm | FileCheck --check-prefix=CHECK-SIZE %s
-// CHECK-SIZE: {{(^|[^0-9])[1-5][0-9][0-9][0-9][0-9]($|[^0-9])}}
+// CHECK-SIZE: {{(^|[^0-9])[1-6][0-9][0-9][0-9][0-9]($|[^0-9])}}
module empty { header "Inputs/empty.h" export * }
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
