[clang] [clang][bytecode][NFC] Remove Frame.cpp (PR #140750)

2025-05-20 Thread LLVM Continuous Integration via cfe-commits 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running 
on `aix-ppc64` while building `clang` at step 6 
"test-build-unified-tree-check-all".

Full details are available at: 
https://lab.llvm.org/buildbot/#/builders/64/builds/3702


Here is the relevant piece of the build log for the reference

```
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
 TEST 'lit :: timeout-hang.py' FAILED 
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 13
not env -u FILECHECK_OPTS 
"/home/llvm/llvm-external-buildbots/workers/env/bin/python3.11" 
/home/llvm/llvm-external-buildbots/workers/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/utils/lit/lit.py
 -j1 --order=lexical Inputs/timeout-hang/run-nonexistent.txt  --timeout=1 
--param external=0 | 
"/home/llvm/llvm-external-buildbots/workers/env/bin/python3.11" 
/home/llvm/llvm-external-buildbots/workers/aix-ppc64/clang-ppc64-aix/build/utils/lit/tests/timeout-hang.py
 1
# executed command: not env -u FILECHECK_OPTS 
/home/llvm/llvm-external-buildbots/workers/env/bin/python3.11 
/home/llvm/llvm-external-buildbots/workers/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/utils/lit/lit.py
 -j1 --order=lexical Inputs/timeout-hang/run-nonexistent.txt --timeout=1 
--param external=0
# .---command stderr
# | lit.py: 
/home/llvm/llvm-external-buildbots/workers/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/utils/lit/lit/main.py:72:
 note: The test suite configuration requested an individual test timeout of 0 
seconds but a timeout of 1 seconds was requested on the command line. Forcing 
timeout to be 1 seconds.
# `-
# executed command: 
/home/llvm/llvm-external-buildbots/workers/env/bin/python3.11 
/home/llvm/llvm-external-buildbots/workers/aix-ppc64/clang-ppc64-aix/build/utils/lit/tests/timeout-hang.py
 1
# .---command stdout
# | Testing took as long or longer than timeout
# `-
# error: command failed with exit status: 1

--




```



https://github.com/llvm/llvm-project/pull/140750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode][NFC] Remove Frame.cpp (PR #140750)

2025-05-20 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: Timm Baeder (tbaederr)


Changes

The file was basically empty. The actual implementation for function frames of 
the two interpreter life in their own respective files.

---
Full diff: https://github.com/llvm/llvm-project/pull/140750.diff


3 Files Affected:

- (removed) clang/lib/AST/ByteCode/Frame.cpp (-14) 
- (modified) clang/lib/AST/ByteCode/Frame.h (+1-1) 
- (modified) clang/lib/AST/CMakeLists.txt (-1) 


``diff
diff --git a/clang/lib/AST/ByteCode/Frame.cpp b/clang/lib/AST/ByteCode/Frame.cpp
deleted file mode 100644
index 16134aa1db36c..0
--- a/clang/lib/AST/ByteCode/Frame.cpp
+++ /dev/null
@@ -1,14 +0,0 @@
-//===--- Frame.cpp - Call frame for the VM and AST Walker ---*- C++ 
-*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM 
Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===--===//
-
-#include "Frame.h"
-
-using namespace clang;
-using namespace clang::interp;
-
-Frame::~Frame() {}
diff --git a/clang/lib/AST/ByteCode/Frame.h b/clang/lib/AST/ByteCode/Frame.h
index 079e4259b0ae8..b67a77a368997 100644
--- a/clang/lib/AST/ByteCode/Frame.h
+++ b/clang/lib/AST/ByteCode/Frame.h
@@ -24,7 +24,7 @@ namespace interp {
 /// Base class for stack frames, shared between VM and walker.
 class Frame {
 public:
-  virtual ~Frame();
+  virtual ~Frame() = default;
 
   /// Generates a human-readable description of the call site.
   virtual void describe(llvm::raw_ostream &OS) const = 0;
diff --git a/clang/lib/AST/CMakeLists.txt b/clang/lib/AST/CMakeLists.txt
index b5cd14b915673..d4fd7a7f16d53 100644
--- a/clang/lib/AST/CMakeLists.txt
+++ b/clang/lib/AST/CMakeLists.txt
@@ -74,7 +74,6 @@ add_clang_library(clangAST
   ByteCode/Descriptor.cpp
   ByteCode/Disasm.cpp
   ByteCode/EvalEmitter.cpp
-  ByteCode/Frame.cpp
   ByteCode/Function.cpp
   ByteCode/FunctionPointer.cpp
   ByteCode/InterpBuiltin.cpp

``




https://github.com/llvm/llvm-project/pull/140750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode][NFC] Remove Frame.cpp (PR #140750)

2025-05-20 Thread Timm Baeder via cfe-commits 

https://github.com/tbaederr created 
https://github.com/llvm/llvm-project/pull/140750

The file was basically empty. The actual implementation for function frames of 
the two interpreter life in their own respective files.

>From c6ca3e84103a6c80ea0ecd741a38ba3ce22005ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?= 
Date: Tue, 20 May 2025 17:34:53 +0200
Subject: [PATCH] [clang][bytecode][NFC] Remove Frame.cpp

The file was basically empty. The actual implementation for function
frames of the two interpreter life in their own respective files.
---
 clang/lib/AST/ByteCode/Frame.cpp | 14 --
 clang/lib/AST/ByteCode/Frame.h   |  2 +-
 clang/lib/AST/CMakeLists.txt |  1 -
 3 files changed, 1 insertion(+), 16 deletions(-)
 delete mode 100644 clang/lib/AST/ByteCode/Frame.cpp

diff --git a/clang/lib/AST/ByteCode/Frame.cpp b/clang/lib/AST/ByteCode/Frame.cpp
deleted file mode 100644
index 16134aa1db36c..0
--- a/clang/lib/AST/ByteCode/Frame.cpp
+++ /dev/null
@@ -1,14 +0,0 @@
-//===--- Frame.cpp - Call frame for the VM and AST Walker ---*- C++ 
-*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM 
Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===--===//
-
-#include "Frame.h"
-
-using namespace clang;
-using namespace clang::interp;
-
-Frame::~Frame() {}
diff --git a/clang/lib/AST/ByteCode/Frame.h b/clang/lib/AST/ByteCode/Frame.h
index 079e4259b0ae8..b67a77a368997 100644
--- a/clang/lib/AST/ByteCode/Frame.h
+++ b/clang/lib/AST/ByteCode/Frame.h
@@ -24,7 +24,7 @@ namespace interp {
 /// Base class for stack frames, shared between VM and walker.
 class Frame {
 public:
-  virtual ~Frame();
+  virtual ~Frame() = default;
 
   /// Generates a human-readable description of the call site.
   virtual void describe(llvm::raw_ostream &OS) const = 0;
diff --git a/clang/lib/AST/CMakeLists.txt b/clang/lib/AST/CMakeLists.txt
index b5cd14b915673..d4fd7a7f16d53 100644
--- a/clang/lib/AST/CMakeLists.txt
+++ b/clang/lib/AST/CMakeLists.txt
@@ -74,7 +74,6 @@ add_clang_library(clangAST
   ByteCode/Descriptor.cpp
   ByteCode/Disasm.cpp
   ByteCode/EvalEmitter.cpp
-  ByteCode/Frame.cpp
   ByteCode/Function.cpp
   ByteCode/FunctionPointer.cpp
   ByteCode/InterpBuiltin.cpp

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits