[clang] [clang] Fix manual memory management with SmallVector in ConceptRef (PR #147231)
bv2k4 wrote: Thanks for merging! https://github.com/llvm/llvm-project/pull/147231 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix manual memory management with SmallVector in ConceptRef (PR #147231)
https://github.com/shafik commented: Thanks, this is a nice refactor. https://github.com/llvm/llvm-project/pull/147231 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix manual memory management with SmallVector in ConceptRef (PR #147231)
github-actions[bot] wrote: @bv2k4 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail [here](https://llvm.org/docs/MyFirstTypoFix.html#myfirsttypofix-issues-after-landing-your-pr). If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of [LLVM development](https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy). You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! https://github.com/llvm/llvm-project/pull/147231 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix manual memory management with SmallVector in ConceptRef (PR #147231)
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/147231 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix manual memory management with SmallVector in ConceptRef (PR #147231)
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/147231 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix manual memory management with SmallVector in ConceptRef (PR #147231)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Bogdan Vetrenko (bv2k4)
Changes
This change replaces manual `new[]`/`delete[]` with `llvm::SmallVector` for
`TemplateArgumentLocInfo` in `createTrivialConceptReference`.
---
Full diff: https://github.com/llvm/llvm-project/pull/147231.diff
1 Files Affected:
- (modified) clang/lib/AST/TypeLoc.cpp (+3-3)
``diff
diff --git a/clang/lib/AST/TypeLoc.cpp b/clang/lib/AST/TypeLoc.cpp
index 1bdb86ad445a4..5c45c596538f8 100644
--- a/clang/lib/AST/TypeLoc.cpp
+++ b/clang/lib/AST/TypeLoc.cpp
@@ -22,6 +22,7 @@
#include "clang/AST/TypeLocVisitor.h"
#include "clang/Basic/SourceLocation.h"
#include "clang/Basic/Specifiers.h"
+#include "llvm/ADT/SmallVector.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/MathExtras.h"
#include
@@ -652,9 +653,9 @@ static ConceptReference
*createTrivialConceptReference(ASTContext &Context,
DeclarationNameInfo(AT->getTypeConstraintConcept()->getDeclName(), Loc,
AT->getTypeConstraintConcept()->getDeclName());
unsigned size = AT->getTypeConstraintArguments().size();
- TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size];
+ llvm::SmallVector TALI(size);
TemplateSpecializationTypeLoc::initializeArgLocs(
- Context, AT->getTypeConstraintArguments(), TALI, Loc);
+ Context, AT->getTypeConstraintArguments(), TALI.data(), Loc);
TemplateArgumentListInfo TAListI;
for (unsigned i = 0; i < size; ++i) {
TAListI.addArgument(
@@ -666,7 +667,6 @@ static ConceptReference
*createTrivialConceptReference(ASTContext &Context,
Context, NestedNameSpecifierLoc{}, Loc, DNI, nullptr,
AT->getTypeConstraintConcept(),
ASTTemplateArgumentListInfo::Create(Context, TAListI));
- delete[] TALI;
return ConceptRef;
}
``
https://github.com/llvm/llvm-project/pull/147231
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix manual memory management with SmallVector in ConceptRef (PR #147231)
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using `@` followed by their GitHub username. If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the [LLVM GitHub User Guide](https://llvm.org/docs/GitHub.html). You can also ask questions in a comment on this PR, on the [LLVM Discord](https://discord.com/invite/xS7Z362) or on the [forums](https://discourse.llvm.org/). https://github.com/llvm/llvm-project/pull/147231 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix manual memory management with SmallVector in ConceptRef (PR #147231)
https://github.com/bv2k4 created
https://github.com/llvm/llvm-project/pull/147231
This change replaces manual `new[]`/`delete[]` with `llvm::SmallVector` for
`TemplateArgumentLocInfo` in `createTrivialConceptReference`.
>From fd77cdcc7e0a1e55ddcbf74fa86517623287d974 Mon Sep 17 00:00:00 2001
From: Bogdan Vetrenko
Date: Mon, 7 Jul 2025 05:59:06 +0300
Subject: [PATCH] [clang] Fix manual memory management with SmallVector in
ConceptReference
---
clang/lib/AST/TypeLoc.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/clang/lib/AST/TypeLoc.cpp b/clang/lib/AST/TypeLoc.cpp
index 1bdb86ad445a4..5c45c596538f8 100644
--- a/clang/lib/AST/TypeLoc.cpp
+++ b/clang/lib/AST/TypeLoc.cpp
@@ -22,6 +22,7 @@
#include "clang/AST/TypeLocVisitor.h"
#include "clang/Basic/SourceLocation.h"
#include "clang/Basic/Specifiers.h"
+#include "llvm/ADT/SmallVector.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/MathExtras.h"
#include
@@ -652,9 +653,9 @@ static ConceptReference
*createTrivialConceptReference(ASTContext &Context,
DeclarationNameInfo(AT->getTypeConstraintConcept()->getDeclName(), Loc,
AT->getTypeConstraintConcept()->getDeclName());
unsigned size = AT->getTypeConstraintArguments().size();
- TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size];
+ llvm::SmallVector TALI(size);
TemplateSpecializationTypeLoc::initializeArgLocs(
- Context, AT->getTypeConstraintArguments(), TALI, Loc);
+ Context, AT->getTypeConstraintArguments(), TALI.data(), Loc);
TemplateArgumentListInfo TAListI;
for (unsigned i = 0; i < size; ++i) {
TAListI.addArgument(
@@ -666,7 +667,6 @@ static ConceptReference
*createTrivialConceptReference(ASTContext &Context,
Context, NestedNameSpecifierLoc{}, Loc, DNI, nullptr,
AT->getTypeConstraintConcept(),
ASTTemplateArgumentListInfo::Create(Context, TAListI));
- delete[] TALI;
return ConceptRef;
}
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
