[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-09-27 Thread Aiden Grossman via cfe-commits 

boomanaiden154 wrote:

> It's fine to drop them now. This deprecation is already part of the LLVM 21 
> release, so no need to wait another one. (Generally, deprecations are mostly 
> a courtesy for LLVM users that follow main, so they can don't need to be 
> long-lived. We mostly just forget to actually remove them...)

Ack. I can put up a patch to remove them. Give me like a week to migrate the 
~100 or so callsites that are still left internally so we don't get swamped 
with all the build failures at once.

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-09-27 Thread Nikita Popov via cfe-commits 

nikic wrote:

> @nikic Is there a timeline for how long we want to leave the deprecated 
> wrappers in before removing them? Maybe remove after llvm 22 branches?

It's fine to drop them now. This deprecation is already part of the LLVM 21 
release, so no need to wait another one. (Generally, deprecations are mostly a 
courtesy for LLVM users that follow main, so they can don't need to be 
long-lived. We mostly just forget to actually remove them...)

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-09-26 Thread Aiden Grossman via cfe-commits 

boomanaiden154 wrote:

@nikic Is there a timeline for how long we want to leave the deprecated 
wrappers in before removing them? Maybe remove after llvm 22 branches?

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-15 Thread Matt Arsenault via cfe-commits 


@@ -84,10 +84,9 @@ TargetMachine *EngineBuilder::selectTarget(const Triple 
&TargetTriple,
   }
 
   // Allocate a target...
-  TargetMachine *Target =
-  TheTarget->createTargetMachine(TheTriple.getTriple(), MCPU, FeaturesStr,
- Options, RelocModel, CMModel, OptLevel,
-/*JIT*/ true);
+  TargetMachine *Target = TheTarget->createTargetMachine(
+  TheTriple, MCPU, FeaturesStr, Options, RelocModel, CMModel, OptLevel,
+  /*JIT*/ true);

arsenm wrote:

```suggestion
  /*JIT=*/ true);
```

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread LLVM Continuous Integration via cfe-commits 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ppc64le-flang-rhel-clang` 
running on `ppc64le-flang-rhel-test` while building 
`bolt,clang,flang,llvm,mlir,offload` at step 5 "build-unified-tree".

Full details are available at: 
https://lab.llvm.org/buildbot/#/builders/157/builds/22293


Here is the relevant piece of the build log for the reference

```
Step 5 (build-unified-tree) failure: build (failure)
...
87.281 [105/8/6645] Linking CXX executable bin/mlir-opt
87.357 [105/7/6646] Building CXX object 
tools/llvm-objdump/CMakeFiles/llvm-objdump.dir/MachODump.cpp.o
87.471 [104/7/6647] Linking CXX executable bin/llvm-objdump
87.477 [103/7/6648] Generating ../../bin/llvm-otool
88.047 [103/6/6649] Linking CXX shared library lib/libclang-cpp.so.21.0git
88.054 [102/6/6650] Creating library symlink lib/libclang-cpp.so
94.354 [102/5/6651] Building CXX object 
tools/clang/tools/clang-linker-wrapper/CMakeFiles/clang-linker-wrapper.dir/ClangLinkerWrapper.cpp.o
94.626 [101/5/6652] Linking CXX executable bin/clang-linker-wrapper
95.214 [101/4/6653] Building CXX object 
tools/flang/tools/flang-driver/CMakeFiles/flang.dir/fc1_main.cpp.o
95.388 [101/3/6654] Building CXX object 
tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o
FAILED: 
tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o 
ccache /home/buildbots/llvm-external-buildbots/clang.19.1.7/bin/clang++ 
-DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG 
-D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS 
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/flang/lib/Frontend
 
-I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Frontend
 
-I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/include
 
-I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/flang/include
 
-I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/include
 
-I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/llvm/include
 -isystem 
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/../mlir/include
 -isystem 
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/mlir/include
 -isystem 
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/clang/include
 -isystem 
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/llvm/../clang/include
 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden 
-Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra 
-Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers 
-pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough 
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor 
-Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion 
-Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color 
-ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy 
-Wno-string-conversion -Wno-ctad-maybe-unsupported 
-Wno-unused-command-line-argument -Wstring-conversion   
-Wcovered-switch-default -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17  
-fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT 
tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o 
-MF 
tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o.d 
-o tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o 
-c 
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Frontend/CompilerInstance.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Frontend/CompilerInstance.cpp:375:34:
 error: 'createTargetMachine' is deprecated: Use overload accepting Triple 
instead [-Werror,-Wdeprecated-declarations]
  375 |   targetMachine.reset(theTarget->createTargetMachine(
  |  ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/llvm/include/llvm/MC/TargetRegistry.h:466:5:
 note: 'createTargetMachine' has been explicitly marked deprecated here
  466 |   [[deprecated("Use overload accepting Triple instead")]]
  | ^
1 error generated.
117.751 [101/2/6655] Building CXX object 
tools/llvm-jitlink/CMakeFi

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread LLVM Continuous Integration via cfe-commits 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-libcxx` 
running on `linaro-flang-aarch64-libcxx` while building 
`bolt,clang,flang,llvm,mlir,offload` at step 5 "build-unified-tree".

Full details are available at: 
https://lab.llvm.org/buildbot/#/builders/89/builds/18479


Here is the relevant piece of the build log for the reference

```
Step 5 (build-unified-tree) failure: build (failure)
...
149.293 [146/8/7229] Linking CXX executable bin/llvm-jitlink
151.487 [146/7/7230] Building CXX object 
tools/sancov/CMakeFiles/sancov.dir/sancov.cpp.o
151.588 [145/7/7231] Linking CXX executable bin/sancov
157.261 [145/6/7232] Building CXX object 
tools/llvm-opt-fuzzer/CMakeFiles/llvm-opt-fuzzer.dir/llvm-opt-fuzzer.cpp.o
157.422 [144/6/7233] Linking CXX executable bin/llvm-opt-fuzzer
157.505 [144/5/7234] Building CXX object 
tools/llvm-objdump/CMakeFiles/llvm-objdump.dir/MachODump.cpp.o
166.380 [144/4/7235] Building CXX object 
tools/llvm-objdump/CMakeFiles/llvm-objdump.dir/llvm-objdump.cpp.o
166.509 [143/4/7236] Linking CXX executable bin/llvm-objdump
166.516 [142/4/7237] Generating ../../bin/llvm-otool
167.594 [142/3/7238] Building CXX object 
tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o
FAILED: 
tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o 
/usr/local/bin/c++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 
-DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE 
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/flang/lib/Frontend
 
-I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/flang/lib/Frontend
 -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/flang/include 
-I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/flang/include 
-I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/include 
-I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/include 
-isystem 
/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/flang/../mlir/include
 -isystem 
/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/mlir/include 
-isystem 
/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/clang/include 
-isystem 
/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/../clang/include
 -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden 
-Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra 
-Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers 
-pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough 
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor 
-Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion 
-Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color 
-ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy 
-Wno-string-conversion -Wno-ctad-maybe-unsupported 
-Wno-unused-command-line-argument -Wstring-conversion   
-Wcovered-switch-default -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -fPIC  
-fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT 
tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o 
-MF 
tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o.d 
-o tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o 
-c 
/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/flang/lib/Frontend/CompilerInstance.cpp
../llvm-project/flang/lib/Frontend/CompilerInstance.cpp:375:34: error: 
'createTargetMachine' is deprecated: Use overload accepting Triple instead 
[-Werror,-Wdeprecated-declarations]
  375 |   targetMachine.reset(theTarget->createTargetMachine(
  |  ^
../llvm-project/llvm/include/llvm/MC/TargetRegistry.h:466:5: note: 
'createTargetMachine' has been explicitly marked deprecated here
  466 |   [[deprecated("Use overload accepting Triple instead")]]
  | ^
1 error generated.
171.864 [142/2/7239] Building CXX object 
tools/flang/tools/flang-driver/CMakeFiles/flang.dir/fc1_main.cpp.o
244.098 [142/1/7240] Building CXX object 
tools/flang/tools/bbc/CMakeFiles/bbc.dir/bbc.cpp.o
ninja: build stopped: subcommand failed.

```



https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Yingwei Zheng via cfe-commits 

https://github.com/dtcxzyw approved this pull request.


https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Nikita Popov via cfe-commits 

https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Matt Arsenault via cfe-commits 


@@ -116,7 +116,7 @@ body: |
 successors: %bb.2, %bb.4
 liveins: $rdi, $rsi
 
-%1:gr32 = COPY $rsi
+%1:gr64 = COPY $rsi

arsenm wrote:

Verifier should have rejected using $rsi in the first place too

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Matt Arsenault via cfe-commits 


@@ -47,9 +47,8 @@ JITTargetMachineBuilder::createTargetMachine() {
 return make_error("Target has no JIT support",
inconvertibleErrorCode());
 
-  auto *TM =
-  TheTarget->createTargetMachine(TT.getTriple(), CPU, Features.getString(),
- Options, RM, CM, OptLevel, /*JIT*/ true);
+  auto *TM = TheTarget->createTargetMachine(
+  TT, CPU, Features.getString(), Options, RM, CM, OptLevel, /*JIT*/ true);

arsenm wrote:

```suggestion
  TT, CPU, Features.getString(), Options, RM, CM, OptLevel, /*JIT=*/ true);
```

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Nikita Popov via cfe-commits 

https://github.com/nikic updated 
https://github.com/llvm/llvm-project/pull/130940

>From 7aa005a4e9aa14c79a527719936824bcfe9a409c Mon Sep 17 00:00:00 2001
From: Nikita Popov 
Date: Wed, 12 Mar 2025 10:57:58 +0100
Subject: [PATCH 1/3] [TargetRegistry] Accept Triple in createTargetMachine()
 (NFC)

This avoids doing a Triple -> std::string -> Triple round trip
in lots of places, now that the Module stores a Triple.
---
 bolt/lib/Passes/AsmDump.cpp |  2 +-
 clang/lib/CodeGen/BackendUtil.cpp   |  2 +-
 clang/lib/Interpreter/DeviceOffload.cpp |  2 +-
 clang/lib/Interpreter/Wasm.cpp  |  5 ++---
 .../clang-fuzzer/handle-llvm/handle_llvm.cpp|  4 ++--
 .../clang-linker-wrapper/ClangLinkerWrapper.cpp |  2 +-
 clang/tools/driver/cc1_main.cpp | 16 ++--
 flang/tools/bbc/bbc.cpp |  2 +-
 flang/tools/flang-driver/fc1_main.cpp   |  4 ++--
 llvm/examples/Kaleidoscope/Chapter8/toy.cpp |  2 +-
 llvm/include/llvm/MC/TargetRegistry.h   |  6 +++---
 llvm/lib/CodeGen/CommandFlags.cpp   |  2 +-
 llvm/lib/DWARFLinker/Classic/DWARFStreamer.cpp  |  2 +-
 .../DWARFLinker/Parallel/DWARFEmitterImpl.cpp   |  2 +-
 .../Orc/JITTargetMachineBuilder.cpp |  5 ++---
 llvm/lib/ExecutionEngine/TargetSelect.cpp   |  7 +++
 llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp   |  2 +-
 llvm/lib/LTO/LTOBackend.cpp |  2 +-
 llvm/lib/LTO/LTOCodeGenerator.cpp   |  4 ++--
 llvm/lib/LTO/LTOModule.cpp  |  4 ++--
 llvm/lib/LTO/ThinLTOCodeGenerator.cpp   |  2 +-
 llvm/lib/Target/SPIRV/SPIRVAPI.cpp  |  2 +-
 llvm/lib/Target/TargetMachineC.cpp  |  8 
 llvm/tools/llc/llc.cpp  |  4 ++--
 llvm/tools/llvm-exegesis/lib/LlvmState.cpp  |  4 ++--
 llvm/tools/llvm-split/llvm-split.cpp|  2 +-
 .../CodeGen/AArch64SelectionDAGTest.cpp |  2 +-
 llvm/unittests/CodeGen/AMDGPUMetadataTest.cpp   |  5 +++--
 .../CodeGen/DroppedVariableStatsMIRTest.cpp |  3 ++-
 .../CodeGen/GlobalISel/GISelMITest.cpp  |  8 
 llvm/unittests/CodeGen/InstrRefLDVTest.cpp  |  6 +++---
 .../CodeGen/MachineDomTreeUpdaterTest.cpp   |  6 +++---
 llvm/unittests/CodeGen/PassManagerTest.cpp  |  8 +++-
 .../CodeGen/SelectionDAGAddressAnalysisTest.cpp |  2 +-
 .../CodeGen/SelectionDAGPatternMatchTest.cpp|  2 +-
 llvm/unittests/CodeGen/TargetOptionsTest.cpp|  4 ++--
 llvm/unittests/CodeGen/TestAsmPrinter.cpp   |  4 ++--
 .../DebugInfo/DWARF/DwarfGenerator.cpp  |  2 +-
 llvm/unittests/MC/AMDGPU/DwarfRegMappings.cpp   |  7 ---
 llvm/unittests/MI/LiveIntervalTest.cpp  |  2 +-
 llvm/unittests/MIR/MachineMetadata.cpp  |  3 ++-
 llvm/unittests/MIR/MachineStableHashTest.cpp|  3 ++-
 .../Target/AArch64/AArch64RegisterInfoTest.cpp  |  2 +-
 .../AArch64/AArch64SVESchedPseudoTest.cpp   |  2 +-
 .../Target/AArch64/AddressingModes.cpp  |  2 +-
 llvm/unittests/Target/AArch64/Immediates.cpp|  2 +-
 llvm/unittests/Target/AArch64/InstSizes.cpp |  2 +-
 .../Target/AArch64/MatrixRegisterAliasing.cpp   |  2 +-
 .../unittests/Target/AMDGPU/AMDGPUUnitTests.cpp |  5 +++--
 llvm/unittests/Target/AMDGPU/PALMetadata.cpp|  6 +++---
 llvm/unittests/Target/ARM/InstSizes.cpp |  2 +-
 llvm/unittests/Target/ARM/MachineInstrTest.cpp  | 12 ++--
 llvm/unittests/Target/LoongArch/InstSizes.cpp   |  2 +-
 .../Target/PowerPC/AIXRelocModelTest.cpp|  2 +-
 .../Target/RISCV/RISCVInstrInfoTest.cpp |  2 +-
 llvm/unittests/Target/VE/MachineInstrTest.cpp   |  2 +-
 .../WebAssemblyExceptionInfoTest.cpp|  2 +-
 .../Target/X86/MachineSizeOptsTest.cpp  |  2 +-
 llvm/unittests/Target/X86/TernlogTest.cpp   |  2 +-
 .../tools/llvm-exegesis/Common/AssemblerUtils.h | 17 -
 mlir/lib/Target/LLVM/ModuleToObject.cpp |  4 ++--
 offload/plugins-nextgen/common/src/JIT.cpp  |  2 +-
 62 files changed, 122 insertions(+), 118 deletions(-)

diff --git a/bolt/lib/Passes/AsmDump.cpp b/bolt/lib/Passes/AsmDump.cpp
index 97f985d56ce64..08191669e72f3 100644
--- a/bolt/lib/Passes/AsmDump.cpp
+++ b/bolt/lib/Passes/AsmDump.cpp
@@ -143,7 +143,7 @@ void dumpFunction(const BinaryFunction &BF) {
 std::move(MCEInstance.MCE), std::move(MAB)));
   AsmStreamer->initSections(true, *BC.STI);
   std::unique_ptr TM(BC.TheTarget->createTargetMachine(
-  BC.TripleName, "", "", TargetOptions(), std::nullopt));
+  *BC.TheTriple, "", "", TargetOptions(), std::nullopt));
   std::unique_ptr MAP(
   BC.TheTarget->createAsmPrinter(*TM, std::move(AsmStreamer)));
 
diff --git a/clang/lib/CodeGen/BackendUtil.cpp 
b/clang/lib/CodeGen/BackendUtil.cpp
index 62a0e3c69bad1..7557cb8408921 100644
--- a/clang/lib/CodeGen/BackendUtil.cpp
+++ b/clang/lib/CodeGen/BackendUtil.cpp
@@ -595,7 +595,7 @@ sta

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Matt Arsenault via cfe-commits 

https://github.com/arsenm approved this pull request.


https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Nikita Popov via cfe-commits 


@@ -453,14 +453,14 @@ class Target {
   /// either the target triple from the module, or the target triple of the
   /// host if that does not exist.
   TargetMachine *createTargetMachine(
-  StringRef TT, StringRef CPU, StringRef Features,

nikic wrote:

Restored StringRef overload with deprecation.

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Nikita Popov via cfe-commits 


@@ -93,7 +93,7 @@ LLVMState::LLVMState(std::unique_ptr TM,
 std::unique_ptr LLVMState::createTargetMachine() const {
   return std::unique_ptr(
   TheTargetMachine->getTarget().createTargetMachine(
-  TheTargetMachine->getTargetTriple().normalize(),
+  Triple(TheTargetMachine->getTargetTriple().normalize()),

nikic wrote:

I tried that initially, but this one seems to be actually important (there are 
test failures otherwise).

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Nikita Popov via cfe-commits 


@@ -116,7 +116,7 @@ body: |
 successors: %bb.2, %bb.4
 liveins: $rdi, $rsi
 
-%1:gr32 = COPY $rsi
+%1:gr64 = COPY $rsi

nikic wrote:

I believe this test was previously creating a 32-bit TM by accident.

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Yingwei Zheng via cfe-commits 


@@ -93,7 +93,7 @@ LLVMState::LLVMState(std::unique_ptr TM,
 std::unique_ptr LLVMState::createTargetMachine() const {
   return std::unique_ptr(
   TheTargetMachine->getTarget().createTargetMachine(
-  TheTargetMachine->getTargetTriple().normalize(),
+  Triple(TheTargetMachine->getTargetTriple().normalize()),

dtcxzyw wrote:

```suggestion
  TheTargetMachine->getTargetTriple(),
```

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Matt Arsenault via cfe-commits 


@@ -453,14 +453,14 @@ class Target {
   /// either the target triple from the module, or the target triple of the
   /// host if that does not exist.
   TargetMachine *createTargetMachine(
-  StringRef TT, StringRef CPU, StringRef Features,

arsenm wrote:

Can we keep a StringRef overload, at least for a while? As-is this is going to 
break a lot of downstream builds 

https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread via cfe-commits 

github-actions[bot] wrote:




:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:



You can test this locally with the following command:


``bash
git-clang-format --diff 553da9634dc4bae215e6c850d2de3186d09f9da5 
7aa005a4e9aa14c79a527719936824bcfe9a409c --extensions h,cpp -- 
bolt/lib/Passes/AsmDump.cpp clang/lib/CodeGen/BackendUtil.cpp 
clang/lib/Interpreter/DeviceOffload.cpp clang/lib/Interpreter/Wasm.cpp 
clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp 
clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp 
clang/tools/driver/cc1_main.cpp flang/tools/bbc/bbc.cpp 
flang/tools/flang-driver/fc1_main.cpp 
llvm/examples/Kaleidoscope/Chapter8/toy.cpp 
llvm/include/llvm/MC/TargetRegistry.h llvm/lib/CodeGen/CommandFlags.cpp 
llvm/lib/DWARFLinker/Classic/DWARFStreamer.cpp 
llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.cpp 
llvm/lib/ExecutionEngine/Orc/JITTargetMachineBuilder.cpp 
llvm/lib/ExecutionEngine/TargetSelect.cpp 
llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp llvm/lib/LTO/LTOBackend.cpp 
llvm/lib/LTO/LTOCodeGenerator.cpp llvm/lib/LTO/LTOModule.cpp 
llvm/lib/LTO/ThinLTOCodeGenerator.cpp llvm/lib/Target/SPIRV/SPIRVAPI.cpp 
llvm/lib/Target/TargetMachineC.cpp llvm/tools/llc/llc.cpp 
llvm/tools/llvm-exegesis/lib/LlvmState.cpp llvm/tools/llvm-split/llvm-split.cpp 
llvm/unittests/CodeGen/AArch64SelectionDAGTest.cpp 
llvm/unittests/CodeGen/AMDGPUMetadataTest.cpp 
llvm/unittests/CodeGen/DroppedVariableStatsMIRTest.cpp 
llvm/unittests/CodeGen/GlobalISel/GISelMITest.cpp 
llvm/unittests/CodeGen/InstrRefLDVTest.cpp 
llvm/unittests/CodeGen/MachineDomTreeUpdaterTest.cpp 
llvm/unittests/CodeGen/PassManagerTest.cpp 
llvm/unittests/CodeGen/SelectionDAGAddressAnalysisTest.cpp 
llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp 
llvm/unittests/CodeGen/TargetOptionsTest.cpp 
llvm/unittests/CodeGen/TestAsmPrinter.cpp 
llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp 
llvm/unittests/MC/AMDGPU/DwarfRegMappings.cpp 
llvm/unittests/MI/LiveIntervalTest.cpp llvm/unittests/MIR/MachineMetadata.cpp 
llvm/unittests/MIR/MachineStableHashTest.cpp 
llvm/unittests/Target/AArch64/AArch64RegisterInfoTest.cpp 
llvm/unittests/Target/AArch64/AArch64SVESchedPseudoTest.cpp 
llvm/unittests/Target/AArch64/AddressingModes.cpp 
llvm/unittests/Target/AArch64/Immediates.cpp 
llvm/unittests/Target/AArch64/InstSizes.cpp 
llvm/unittests/Target/AArch64/MatrixRegisterAliasing.cpp 
llvm/unittests/Target/AMDGPU/AMDGPUUnitTests.cpp 
llvm/unittests/Target/AMDGPU/PALMetadata.cpp 
llvm/unittests/Target/ARM/InstSizes.cpp 
llvm/unittests/Target/ARM/MachineInstrTest.cpp 
llvm/unittests/Target/LoongArch/InstSizes.cpp 
llvm/unittests/Target/PowerPC/AIXRelocModelTest.cpp 
llvm/unittests/Target/RISCV/RISCVInstrInfoTest.cpp 
llvm/unittests/Target/VE/MachineInstrTest.cpp 
llvm/unittests/Target/WebAssembly/WebAssemblyExceptionInfoTest.cpp 
llvm/unittests/Target/X86/MachineSizeOptsTest.cpp 
llvm/unittests/Target/X86/TernlogTest.cpp 
llvm/unittests/tools/llvm-exegesis/Common/AssemblerUtils.h 
mlir/lib/Target/LLVM/ModuleToObject.cpp 
offload/plugins-nextgen/common/src/JIT.cpp
``





View the diff from clang-format here.


``diff
diff --git a/offload/plugins-nextgen/common/src/JIT.cpp 
b/offload/plugins-nextgen/common/src/JIT.cpp
index b77ce6dc6e..affedb1a33 100644
--- a/offload/plugins-nextgen/common/src/JIT.cpp
+++ b/offload/plugins-nextgen/common/src/JIT.cpp
@@ -114,9 +114,9 @@ createTargetMachine(Module &M, std::string CPU, unsigned 
OptLevel) {
 
   TargetOptions Options = codegen::InitTargetOptionsFromCodeGenFlags(TT);
 
-  std::unique_ptr TM(T->createTargetMachine(
-  M.getTargetTriple(), CPU, Features.getString(), Options, RelocModel,
-  CodeModel, CGOptLevel));
+  std::unique_ptr TM(
+  T->createTargetMachine(M.getTargetTriple(), CPU, Features.getString(),
+ Options, RelocModel, CodeModel, CGOptLevel));
   if (!TM)
 return make_error("Failed to create target machine",
inconvertibleErrorCode());

``




https://github.com/llvm/llvm-project/pull/130940
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread via cfe-commits 

llvmbot wrote:



@llvm/pr-subscribers-backend-webassembly

@llvm/pr-subscribers-backend-amdgpu

Author: Nikita Popov (nikic)


Changes

This avoids doing a Triple -> std::string -> Triple round trip in lots of 
places, now that the Module stores a Triple.

---

Patch is 51.13 KiB, truncated to 20.00 KiB below, full version: 
https://github.com/llvm/llvm-project/pull/130940.diff


62 Files Affected:

- (modified) bolt/lib/Passes/AsmDump.cpp (+1-1) 
- (modified) clang/lib/CodeGen/BackendUtil.cpp (+1-1) 
- (modified) clang/lib/Interpreter/DeviceOffload.cpp (+1-1) 
- (modified) clang/lib/Interpreter/Wasm.cpp (+2-3) 
- (modified) clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp (+2-2) 
- (modified) clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp (+1-1) 
- (modified) clang/tools/driver/cc1_main.cpp (+10-6) 
- (modified) flang/tools/bbc/bbc.cpp (+1-1) 
- (modified) flang/tools/flang-driver/fc1_main.cpp (+2-2) 
- (modified) llvm/examples/Kaleidoscope/Chapter8/toy.cpp (+1-1) 
- (modified) llvm/include/llvm/MC/TargetRegistry.h (+3-3) 
- (modified) llvm/lib/CodeGen/CommandFlags.cpp (+1-1) 
- (modified) llvm/lib/DWARFLinker/Classic/DWARFStreamer.cpp (+1-1) 
- (modified) llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.cpp (+1-1) 
- (modified) llvm/lib/ExecutionEngine/Orc/JITTargetMachineBuilder.cpp (+2-3) 
- (modified) llvm/lib/ExecutionEngine/TargetSelect.cpp (+3-4) 
- (modified) llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp (+1-1) 
- (modified) llvm/lib/LTO/LTOBackend.cpp (+1-1) 
- (modified) llvm/lib/LTO/LTOCodeGenerator.cpp (+2-2) 
- (modified) llvm/lib/LTO/LTOModule.cpp (+2-2) 
- (modified) llvm/lib/LTO/ThinLTOCodeGenerator.cpp (+1-1) 
- (modified) llvm/lib/Target/SPIRV/SPIRVAPI.cpp (+1-1) 
- (modified) llvm/lib/Target/TargetMachineC.cpp (+4-4) 
- (modified) llvm/tools/llc/llc.cpp (+2-2) 
- (modified) llvm/tools/llvm-exegesis/lib/LlvmState.cpp (+2-2) 
- (modified) llvm/tools/llvm-split/llvm-split.cpp (+1-1) 
- (modified) llvm/unittests/CodeGen/AArch64SelectionDAGTest.cpp (+1-1) 
- (modified) llvm/unittests/CodeGen/AMDGPUMetadataTest.cpp (+3-2) 
- (modified) llvm/unittests/CodeGen/DroppedVariableStatsMIRTest.cpp (+2-1) 
- (modified) llvm/unittests/CodeGen/GlobalISel/GISelMITest.cpp (+4-4) 
- (modified) llvm/unittests/CodeGen/InstrRefLDVTest.cpp (+3-3) 
- (modified) llvm/unittests/CodeGen/MachineDomTreeUpdaterTest.cpp (+3-3) 
- (modified) llvm/unittests/CodeGen/PassManagerTest.cpp (+3-5) 
- (modified) llvm/unittests/CodeGen/SelectionDAGAddressAnalysisTest.cpp (+1-1) 
- (modified) llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp (+1-1) 
- (modified) llvm/unittests/CodeGen/TargetOptionsTest.cpp (+2-2) 
- (modified) llvm/unittests/CodeGen/TestAsmPrinter.cpp (+2-2) 
- (modified) llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp (+1-1) 
- (modified) llvm/unittests/MC/AMDGPU/DwarfRegMappings.cpp (+4-3) 
- (modified) llvm/unittests/MI/LiveIntervalTest.cpp (+1-1) 
- (modified) llvm/unittests/MIR/MachineMetadata.cpp (+2-1) 
- (modified) llvm/unittests/MIR/MachineStableHashTest.cpp (+2-1) 
- (modified) llvm/unittests/Target/AArch64/AArch64RegisterInfoTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/AArch64/AArch64SVESchedPseudoTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/AArch64/AddressingModes.cpp (+1-1) 
- (modified) llvm/unittests/Target/AArch64/Immediates.cpp (+1-1) 
- (modified) llvm/unittests/Target/AArch64/InstSizes.cpp (+1-1) 
- (modified) llvm/unittests/Target/AArch64/MatrixRegisterAliasing.cpp (+1-1) 
- (modified) llvm/unittests/Target/AMDGPU/AMDGPUUnitTests.cpp (+3-2) 
- (modified) llvm/unittests/Target/AMDGPU/PALMetadata.cpp (+3-3) 
- (modified) llvm/unittests/Target/ARM/InstSizes.cpp (+1-1) 
- (modified) llvm/unittests/Target/ARM/MachineInstrTest.cpp (+6-6) 
- (modified) llvm/unittests/Target/LoongArch/InstSizes.cpp (+1-1) 
- (modified) llvm/unittests/Target/PowerPC/AIXRelocModelTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/RISCV/RISCVInstrInfoTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/VE/MachineInstrTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/WebAssembly/WebAssemblyExceptionInfoTest.cpp 
(+1-1) 
- (modified) llvm/unittests/Target/X86/MachineSizeOptsTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/X86/TernlogTest.cpp (+1-1) 
- (modified) llvm/unittests/tools/llvm-exegesis/Common/AssemblerUtils.h (+8-9) 
- (modified) mlir/lib/Target/LLVM/ModuleToObject.cpp (+2-2) 
- (modified) offload/plugins-nextgen/common/src/JIT.cpp (+1-1) 


``diff
diff --git a/bolt/lib/Passes/AsmDump.cpp b/bolt/lib/Passes/AsmDump.cpp
index 97f985d56ce64..08191669e72f3 100644
--- a/bolt/lib/Passes/AsmDump.cpp
+++ b/bolt/lib/Passes/AsmDump.cpp
@@ -143,7 +143,7 @@ void dumpFunction(const BinaryFunction &BF) {
 std::move(MCEInstance.MCE), std::move(MAB)));
   AsmStreamer->initSections(true, *BC.STI);
   std::unique_ptr TM(BC.TheTarget->createTargetMachine(
-  BC.TripleName, "", "", TargetOptions(), std::nullopt));
+  *BC.TheTriple, "", "", TargetOptions(),

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-backend-risc-v

Author: Nikita Popov (nikic)


Changes

This avoids doing a Triple -> std::string -> Triple round trip in lots of 
places, now that the Module stores a Triple.

---

Patch is 51.13 KiB, truncated to 20.00 KiB below, full version: 
https://github.com/llvm/llvm-project/pull/130940.diff


62 Files Affected:

- (modified) bolt/lib/Passes/AsmDump.cpp (+1-1) 
- (modified) clang/lib/CodeGen/BackendUtil.cpp (+1-1) 
- (modified) clang/lib/Interpreter/DeviceOffload.cpp (+1-1) 
- (modified) clang/lib/Interpreter/Wasm.cpp (+2-3) 
- (modified) clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp (+2-2) 
- (modified) clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp (+1-1) 
- (modified) clang/tools/driver/cc1_main.cpp (+10-6) 
- (modified) flang/tools/bbc/bbc.cpp (+1-1) 
- (modified) flang/tools/flang-driver/fc1_main.cpp (+2-2) 
- (modified) llvm/examples/Kaleidoscope/Chapter8/toy.cpp (+1-1) 
- (modified) llvm/include/llvm/MC/TargetRegistry.h (+3-3) 
- (modified) llvm/lib/CodeGen/CommandFlags.cpp (+1-1) 
- (modified) llvm/lib/DWARFLinker/Classic/DWARFStreamer.cpp (+1-1) 
- (modified) llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.cpp (+1-1) 
- (modified) llvm/lib/ExecutionEngine/Orc/JITTargetMachineBuilder.cpp (+2-3) 
- (modified) llvm/lib/ExecutionEngine/TargetSelect.cpp (+3-4) 
- (modified) llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp (+1-1) 
- (modified) llvm/lib/LTO/LTOBackend.cpp (+1-1) 
- (modified) llvm/lib/LTO/LTOCodeGenerator.cpp (+2-2) 
- (modified) llvm/lib/LTO/LTOModule.cpp (+2-2) 
- (modified) llvm/lib/LTO/ThinLTOCodeGenerator.cpp (+1-1) 
- (modified) llvm/lib/Target/SPIRV/SPIRVAPI.cpp (+1-1) 
- (modified) llvm/lib/Target/TargetMachineC.cpp (+4-4) 
- (modified) llvm/tools/llc/llc.cpp (+2-2) 
- (modified) llvm/tools/llvm-exegesis/lib/LlvmState.cpp (+2-2) 
- (modified) llvm/tools/llvm-split/llvm-split.cpp (+1-1) 
- (modified) llvm/unittests/CodeGen/AArch64SelectionDAGTest.cpp (+1-1) 
- (modified) llvm/unittests/CodeGen/AMDGPUMetadataTest.cpp (+3-2) 
- (modified) llvm/unittests/CodeGen/DroppedVariableStatsMIRTest.cpp (+2-1) 
- (modified) llvm/unittests/CodeGen/GlobalISel/GISelMITest.cpp (+4-4) 
- (modified) llvm/unittests/CodeGen/InstrRefLDVTest.cpp (+3-3) 
- (modified) llvm/unittests/CodeGen/MachineDomTreeUpdaterTest.cpp (+3-3) 
- (modified) llvm/unittests/CodeGen/PassManagerTest.cpp (+3-5) 
- (modified) llvm/unittests/CodeGen/SelectionDAGAddressAnalysisTest.cpp (+1-1) 
- (modified) llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp (+1-1) 
- (modified) llvm/unittests/CodeGen/TargetOptionsTest.cpp (+2-2) 
- (modified) llvm/unittests/CodeGen/TestAsmPrinter.cpp (+2-2) 
- (modified) llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp (+1-1) 
- (modified) llvm/unittests/MC/AMDGPU/DwarfRegMappings.cpp (+4-3) 
- (modified) llvm/unittests/MI/LiveIntervalTest.cpp (+1-1) 
- (modified) llvm/unittests/MIR/MachineMetadata.cpp (+2-1) 
- (modified) llvm/unittests/MIR/MachineStableHashTest.cpp (+2-1) 
- (modified) llvm/unittests/Target/AArch64/AArch64RegisterInfoTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/AArch64/AArch64SVESchedPseudoTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/AArch64/AddressingModes.cpp (+1-1) 
- (modified) llvm/unittests/Target/AArch64/Immediates.cpp (+1-1) 
- (modified) llvm/unittests/Target/AArch64/InstSizes.cpp (+1-1) 
- (modified) llvm/unittests/Target/AArch64/MatrixRegisterAliasing.cpp (+1-1) 
- (modified) llvm/unittests/Target/AMDGPU/AMDGPUUnitTests.cpp (+3-2) 
- (modified) llvm/unittests/Target/AMDGPU/PALMetadata.cpp (+3-3) 
- (modified) llvm/unittests/Target/ARM/InstSizes.cpp (+1-1) 
- (modified) llvm/unittests/Target/ARM/MachineInstrTest.cpp (+6-6) 
- (modified) llvm/unittests/Target/LoongArch/InstSizes.cpp (+1-1) 
- (modified) llvm/unittests/Target/PowerPC/AIXRelocModelTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/RISCV/RISCVInstrInfoTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/VE/MachineInstrTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/WebAssembly/WebAssemblyExceptionInfoTest.cpp 
(+1-1) 
- (modified) llvm/unittests/Target/X86/MachineSizeOptsTest.cpp (+1-1) 
- (modified) llvm/unittests/Target/X86/TernlogTest.cpp (+1-1) 
- (modified) llvm/unittests/tools/llvm-exegesis/Common/AssemblerUtils.h (+8-9) 
- (modified) mlir/lib/Target/LLVM/ModuleToObject.cpp (+2-2) 
- (modified) offload/plugins-nextgen/common/src/JIT.cpp (+1-1) 


``diff
diff --git a/bolt/lib/Passes/AsmDump.cpp b/bolt/lib/Passes/AsmDump.cpp
index 97f985d56ce64..08191669e72f3 100644
--- a/bolt/lib/Passes/AsmDump.cpp
+++ b/bolt/lib/Passes/AsmDump.cpp
@@ -143,7 +143,7 @@ void dumpFunction(const BinaryFunction &BF) {
 std::move(MCEInstance.MCE), std::move(MAB)));
   AsmStreamer->initSections(true, *BC.STI);
   std::unique_ptr TM(BC.TheTarget->createTargetMachine(
-  BC.TripleName, "", "", TargetOptions(), std::nullopt));
+  *BC.TheTriple, "", "", TargetOptions(), std::nullopt));
   std::unique_ptr MAP(

[clang] [flang] [llvm] [mlir] [TargetRegistry] Accept Triple in createTargetMachine() (NFC) (PR #130940)

2025-03-12 Thread Nikita Popov via cfe-commits 

https://github.com/nikic created 
https://github.com/llvm/llvm-project/pull/130940

This avoids doing a Triple -> std::string -> Triple round trip in lots of 
places, now that the Module stores a Triple.

>From 7aa005a4e9aa14c79a527719936824bcfe9a409c Mon Sep 17 00:00:00 2001
From: Nikita Popov 
Date: Wed, 12 Mar 2025 10:57:58 +0100
Subject: [PATCH] [TargetRegistry] Accept Triple in createTargetMachine() (NFC)

This avoids doing a Triple -> std::string -> Triple round trip
in lots of places, now that the Module stores a Triple.
---
 bolt/lib/Passes/AsmDump.cpp |  2 +-
 clang/lib/CodeGen/BackendUtil.cpp   |  2 +-
 clang/lib/Interpreter/DeviceOffload.cpp |  2 +-
 clang/lib/Interpreter/Wasm.cpp  |  5 ++---
 .../clang-fuzzer/handle-llvm/handle_llvm.cpp|  4 ++--
 .../clang-linker-wrapper/ClangLinkerWrapper.cpp |  2 +-
 clang/tools/driver/cc1_main.cpp | 16 ++--
 flang/tools/bbc/bbc.cpp |  2 +-
 flang/tools/flang-driver/fc1_main.cpp   |  4 ++--
 llvm/examples/Kaleidoscope/Chapter8/toy.cpp |  2 +-
 llvm/include/llvm/MC/TargetRegistry.h   |  6 +++---
 llvm/lib/CodeGen/CommandFlags.cpp   |  2 +-
 llvm/lib/DWARFLinker/Classic/DWARFStreamer.cpp  |  2 +-
 .../DWARFLinker/Parallel/DWARFEmitterImpl.cpp   |  2 +-
 .../Orc/JITTargetMachineBuilder.cpp |  5 ++---
 llvm/lib/ExecutionEngine/TargetSelect.cpp   |  7 +++
 llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp   |  2 +-
 llvm/lib/LTO/LTOBackend.cpp |  2 +-
 llvm/lib/LTO/LTOCodeGenerator.cpp   |  4 ++--
 llvm/lib/LTO/LTOModule.cpp  |  4 ++--
 llvm/lib/LTO/ThinLTOCodeGenerator.cpp   |  2 +-
 llvm/lib/Target/SPIRV/SPIRVAPI.cpp  |  2 +-
 llvm/lib/Target/TargetMachineC.cpp  |  8 
 llvm/tools/llc/llc.cpp  |  4 ++--
 llvm/tools/llvm-exegesis/lib/LlvmState.cpp  |  4 ++--
 llvm/tools/llvm-split/llvm-split.cpp|  2 +-
 .../CodeGen/AArch64SelectionDAGTest.cpp |  2 +-
 llvm/unittests/CodeGen/AMDGPUMetadataTest.cpp   |  5 +++--
 .../CodeGen/DroppedVariableStatsMIRTest.cpp |  3 ++-
 .../CodeGen/GlobalISel/GISelMITest.cpp  |  8 
 llvm/unittests/CodeGen/InstrRefLDVTest.cpp  |  6 +++---
 .../CodeGen/MachineDomTreeUpdaterTest.cpp   |  6 +++---
 llvm/unittests/CodeGen/PassManagerTest.cpp  |  8 +++-
 .../CodeGen/SelectionDAGAddressAnalysisTest.cpp |  2 +-
 .../CodeGen/SelectionDAGPatternMatchTest.cpp|  2 +-
 llvm/unittests/CodeGen/TargetOptionsTest.cpp|  4 ++--
 llvm/unittests/CodeGen/TestAsmPrinter.cpp   |  4 ++--
 .../DebugInfo/DWARF/DwarfGenerator.cpp  |  2 +-
 llvm/unittests/MC/AMDGPU/DwarfRegMappings.cpp   |  7 ---
 llvm/unittests/MI/LiveIntervalTest.cpp  |  2 +-
 llvm/unittests/MIR/MachineMetadata.cpp  |  3 ++-
 llvm/unittests/MIR/MachineStableHashTest.cpp|  3 ++-
 .../Target/AArch64/AArch64RegisterInfoTest.cpp  |  2 +-
 .../AArch64/AArch64SVESchedPseudoTest.cpp   |  2 +-
 .../Target/AArch64/AddressingModes.cpp  |  2 +-
 llvm/unittests/Target/AArch64/Immediates.cpp|  2 +-
 llvm/unittests/Target/AArch64/InstSizes.cpp |  2 +-
 .../Target/AArch64/MatrixRegisterAliasing.cpp   |  2 +-
 .../unittests/Target/AMDGPU/AMDGPUUnitTests.cpp |  5 +++--
 llvm/unittests/Target/AMDGPU/PALMetadata.cpp|  6 +++---
 llvm/unittests/Target/ARM/InstSizes.cpp |  2 +-
 llvm/unittests/Target/ARM/MachineInstrTest.cpp  | 12 ++--
 llvm/unittests/Target/LoongArch/InstSizes.cpp   |  2 +-
 .../Target/PowerPC/AIXRelocModelTest.cpp|  2 +-
 .../Target/RISCV/RISCVInstrInfoTest.cpp |  2 +-
 llvm/unittests/Target/VE/MachineInstrTest.cpp   |  2 +-
 .../WebAssemblyExceptionInfoTest.cpp|  2 +-
 .../Target/X86/MachineSizeOptsTest.cpp  |  2 +-
 llvm/unittests/Target/X86/TernlogTest.cpp   |  2 +-
 .../tools/llvm-exegesis/Common/AssemblerUtils.h | 17 -
 mlir/lib/Target/LLVM/ModuleToObject.cpp |  4 ++--
 offload/plugins-nextgen/common/src/JIT.cpp  |  2 +-
 62 files changed, 122 insertions(+), 118 deletions(-)

diff --git a/bolt/lib/Passes/AsmDump.cpp b/bolt/lib/Passes/AsmDump.cpp
index 97f985d56ce64..08191669e72f3 100644
--- a/bolt/lib/Passes/AsmDump.cpp
+++ b/bolt/lib/Passes/AsmDump.cpp
@@ -143,7 +143,7 @@ void dumpFunction(const BinaryFunction &BF) {
 std::move(MCEInstance.MCE), std::move(MAB)));
   AsmStreamer->initSections(true, *BC.STI);
   std::unique_ptr TM(BC.TheTarget->createTargetMachine(
-  BC.TripleName, "", "", TargetOptions(), std::nullopt));
+  *BC.TheTriple, "", "", TargetOptions(), std::nullopt));
   std::unique_ptr MAP(
   BC.TheTarget->createAsmPrinter(*TM, std::move(AsmStreamer)));
 
diff --git a/clang/lib/CodeGen/BackendUtil.cpp 
b/clang/lib/CodeGen/BackendUtil.cpp
index 62a0e3c69bad1..7557cb84