[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; MODULE: attributes #[[ATTR4]] = { "kernel" } -; MODULE: attributes #[[ATTR5]] = { nosync memory(none) } +; MODULE: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } +; MODULE: attributes #[[ATTR5]] = { "kernel" } +; MODULE: attributes #[[ATTR6]] = { nosync memory(none) } ;. ; CGSCC: attributes #[[ATTR0]] = { "llvm.assume"="ompx_aligned_barrier" } ; CGSCC: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; CGSCC: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; CGSCC: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; CGSCC: attributes #[[ATTR4]] = { "kernel" } -; CGSCC: attributes #[[ATTR5]] = { nosync memory(none) } +; CGSCC: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } AlexMaclean wrote: Okay, fair enough. I'll start switch us over to a calling convention in https://github.com/llvm/llvm-project/pull/120806 https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; MODULE: attributes #[[ATTR4]] = { "kernel" } -; MODULE: attributes #[[ATTR5]] = { nosync memory(none) } +; MODULE: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } +; MODULE: attributes #[[ATTR5]] = { "kernel" } +; MODULE: attributes #[[ATTR6]] = { nosync memory(none) } ;. ; CGSCC: attributes #[[ATTR0]] = { "llvm.assume"="ompx_aligned_barrier" } ; CGSCC: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; CGSCC: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; CGSCC: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; CGSCC: attributes #[[ATTR4]] = { "kernel" } -; CGSCC: attributes #[[ATTR5]] = { nosync memory(none) } +; CGSCC: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } arsenm wrote: Yeah that really should just be a separate calling convention https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; MODULE: attributes #[[ATTR4]] = { "kernel" } -; MODULE: attributes #[[ATTR5]] = { nosync memory(none) } +; MODULE: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } +; MODULE: attributes #[[ATTR5]] = { "kernel" } +; MODULE: attributes #[[ATTR6]] = { nosync memory(none) } ;. ; CGSCC: attributes #[[ATTR0]] = { "llvm.assume"="ompx_aligned_barrier" } ; CGSCC: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; CGSCC: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; CGSCC: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; CGSCC: attributes #[[ATTR4]] = { "kernel" } -; CGSCC: attributes #[[ATTR5]] = { nosync memory(none) } +; CGSCC: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } jhuber6 wrote: It's an error at the PTX level so the backend just lets it happen and waits until `ptxas` blows up AFAICT. https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; MODULE: attributes #[[ATTR4]] = { "kernel" } -; MODULE: attributes #[[ATTR5]] = { nosync memory(none) } +; MODULE: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } +; MODULE: attributes #[[ATTR5]] = { "kernel" } +; MODULE: attributes #[[ATTR6]] = { nosync memory(none) } ;. ; CGSCC: attributes #[[ATTR0]] = { "llvm.assume"="ompx_aligned_barrier" } ; CGSCC: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; CGSCC: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; CGSCC: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; CGSCC: attributes #[[ATTR4]] = { "kernel" } -; CGSCC: attributes #[[ATTR5]] = { nosync memory(none) } +; CGSCC: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } arsenm wrote: Does PTX support calling a kernel entry point as an ordinary function from another function? I've never understood how PTX doesn't set an IR calling convention for the entries https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; MODULE: attributes #[[ATTR4]] = { "kernel" } -; MODULE: attributes #[[ATTR5]] = { nosync memory(none) } +; MODULE: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } +; MODULE: attributes #[[ATTR5]] = { "kernel" } +; MODULE: attributes #[[ATTR6]] = { nosync memory(none) } ;. ; CGSCC: attributes #[[ATTR0]] = { "llvm.assume"="ompx_aligned_barrier" } ; CGSCC: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; CGSCC: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; CGSCC: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; CGSCC: attributes #[[ATTR4]] = { "kernel" } -; CGSCC: attributes #[[ATTR5]] = { nosync memory(none) } +; CGSCC: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } shiltian wrote: > Honestly, us putting `nvvm.kernel` on everything should be fixed. +1 It is likely because the OpenMPGPUCodeGen for the AMDGPU part shares the same code as NVPTX and even doesn't bother to emit the attribute based on actual target. ¯\_(ツ)_/¯ https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; MODULE: attributes #[[ATTR4]] = { "kernel" } -; MODULE: attributes #[[ATTR5]] = { nosync memory(none) } +; MODULE: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } +; MODULE: attributes #[[ATTR5]] = { "kernel" } +; MODULE: attributes #[[ATTR6]] = { nosync memory(none) } ;. ; CGSCC: attributes #[[ATTR0]] = { "llvm.assume"="ompx_aligned_barrier" } ; CGSCC: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; CGSCC: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; CGSCC: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; CGSCC: attributes #[[ATTR4]] = { "kernel" } -; CGSCC: attributes #[[ATTR5]] = { nosync memory(none) } +; CGSCC: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } jhuber6 wrote: Honestly, us putting `nvvm.kernel` on everything should be fixed. AFAIK it's used in some OpenMPOpt code to quickly determine kernel entry points, but could easily be replaced by a more generic name. I think that's what `"kernel"` also does? I'd need to look into it more. https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; MODULE: attributes #[[ATTR4]] = { "kernel" } -; MODULE: attributes #[[ATTR5]] = { nosync memory(none) } +; MODULE: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } +; MODULE: attributes #[[ATTR5]] = { "kernel" } +; MODULE: attributes #[[ATTR6]] = { nosync memory(none) } ;. ; CGSCC: attributes #[[ATTR0]] = { "llvm.assume"="ompx_aligned_barrier" } ; CGSCC: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; CGSCC: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; CGSCC: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; CGSCC: attributes #[[ATTR4]] = { "kernel" } -; CGSCC: attributes #[[ATTR5]] = { nosync memory(none) } +; CGSCC: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } AlexMaclean wrote: There is a `ptx_kernel` calling convention which is an alternative to `nvvm.annoations` `!"kernel"` already. However, I don't think we can safely auto-upgrade to this in all cases, in the openMP example @jhuber6 provided above the function has both `amdgpu_kernel` and `"nvvm.kernel"` which would not be possible with `ptx_kernel` CC. Is there any way around this? if not an attribute seems like the only option. > The metadata use useful if we have cases where we really want fast lookup of > all the kernels in the TU. I don't think there are any cases where we do this, there isn't even a function to traverse the metadata and find all the kernels (that I know of). It's far more important to be able to quickly check if a function is a kernel, which the metadata solution is fairly slow for (there is a cache hacked on to try to mitigate this but that has other issues). In addition metadata should not be used to carry semantic information like this. https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; MODULE: attributes #[[ATTR4]] = { "kernel" } -; MODULE: attributes #[[ATTR5]] = { nosync memory(none) } +; MODULE: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } +; MODULE: attributes #[[ATTR5]] = { "kernel" } +; MODULE: attributes #[[ATTR6]] = { nosync memory(none) } ;. ; CGSCC: attributes #[[ATTR0]] = { "llvm.assume"="ompx_aligned_barrier" } ; CGSCC: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; CGSCC: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; CGSCC: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; CGSCC: attributes #[[ATTR4]] = { "kernel" } -; CGSCC: attributes #[[ATTR5]] = { nosync memory(none) } +; CGSCC: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } shiltian wrote: >From my understanding, the reason we have `amdgpu_kernel` as a CC is, we also >have other kinds of "kernels" that have different calling conventions, such as >`amdgpu_cs`. @arsenm knows more about this. If `nvvm.kernel` is the only kind you have, I'm not sure how much you would gain by making it a CC. The current `kernel` should not be a CC because it is not. It has no calling convention related meaning. It is purely an identification used to identify kernel entry points for OpenMP target regions. https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; MODULE: attributes #[[ATTR4]] = { "kernel" } -; MODULE: attributes #[[ATTR5]] = { nosync memory(none) } +; MODULE: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } +; MODULE: attributes #[[ATTR5]] = { "kernel" } +; MODULE: attributes #[[ATTR6]] = { nosync memory(none) } ;. ; CGSCC: attributes #[[ATTR0]] = { "llvm.assume"="ompx_aligned_barrier" } ; CGSCC: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; CGSCC: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; CGSCC: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; CGSCC: attributes #[[ATTR4]] = { "kernel" } -; CGSCC: attributes #[[ATTR5]] = { nosync memory(none) } +; CGSCC: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } jhuber6 wrote: Even if you only have one CC it makes much more sense to model kernels as calling conventions. The metadata use useful if we have cases where we really want fast lookup of all the kernels in the TU. https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; MODULE: attributes #[[ATTR4]] = { "kernel" } -; MODULE: attributes #[[ATTR5]] = { nosync memory(none) } +; MODULE: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } +; MODULE: attributes #[[ATTR5]] = { "kernel" } +; MODULE: attributes #[[ATTR6]] = { nosync memory(none) } ;. ; CGSCC: attributes #[[ATTR0]] = { "llvm.assume"="ompx_aligned_barrier" } ; CGSCC: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; CGSCC: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; CGSCC: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write) } -; CGSCC: attributes #[[ATTR4]] = { "kernel" } -; CGSCC: attributes #[[ATTR5]] = { nosync memory(none) } +; CGSCC: attributes #[[ATTR4]] = { "kernel" "nvvm.kernel" } AlexMaclean wrote: I agree that `"omp_kernel"` seems like a much better name for the meaning we're currently signifying with the `"kernel"` attribute. > Realistically this should be a calling convention and not an attribute, but > there's a lot of historical cruft around it. @jhuber6 are you saying that the `"kernel"` attribute should be a calling convention? or that `"nvvm.kernel"` should be (similar to `amdgpu_kernel`)? https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
https://github.com/AlexMaclean edited https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)
https://github.com/AlexMaclean edited https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits