[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-10 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 ready_for_review 
https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-10 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 closed https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-10 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 updated 
https://github.com/llvm/llvm-project/pull/194516

>From 76744d64e54c2140c2467bd1b1183a27f9bdda35 Mon Sep 17 00:00:00 2001
From: mtx 
Date: Tue, 28 Apr 2026 10:54:46 +0800
Subject: [PATCH 1/3] [clang-tidy] Remove hicpp module [1/4]

---
 .../clang-tidy/hicpp/HICPPTidyModule.cpp  | 34 ---
 clang-tools-extra/clangd/TidyFastChecks.inc   |  8 -
 clang-tools-extra/docs/ReleaseNotes.rst   | 20 +++
 .../checks/bugprone/unused-return-value.rst   |  5 ---
 .../checks/hicpp/avoid-c-arrays.rst   | 11 --
 .../clang-tidy/checks/hicpp/avoid-goto.rst| 11 --
 .../checks/hicpp/braces-around-statements.rst | 13 ---
 .../checks/hicpp/deprecated-headers.rst   | 11 --
 .../checks/hicpp/exception-baseclass.rst  | 10 --
 .../checks/hicpp/explicit-conversions.rst | 25 --
 .../clang-tidy/checks/hicpp/function-size.rst | 14 
 .../checks/hicpp/ignored-remove-result.rst| 10 --
 .../docs/clang-tidy/checks/list.rst   |  8 -
 .../checks/modernize/avoid-c-arrays.rst   |  2 --
 .../unused-return-value-remove.cpp}   |  6 ++--
 15 files changed, 8 insertions(+), 180 deletions(-)
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-c-arrays.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-goto.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/braces-around-statements.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/deprecated-headers.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/exception-baseclass.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/function-size.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/ignored-remove-result.rst
 rename 
clang-tools-extra/test/clang-tidy/checkers/{hicpp/ignored-remove-result.cpp => 
bugprone/unused-return-value-remove.cpp} (80%)

diff --git a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp 
b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
index 501e7fc0e2d9b..e628c81db6955 100644
--- a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
@@ -9,21 +9,15 @@
 #include "../ClangTidy.h"
 #include "../ClangTidyModule.h"
 #include "../bugprone/SignedBitwiseCheck.h"
-#include "../bugprone/StdExceptionBaseclassCheck.h"
 #include "../bugprone/UndelegatedConstructorCheck.h"
-#include "../bugprone/UnusedReturnValueCheck.h"
 #include "../bugprone/UseAfterMoveCheck.h"
-#include "../cppcoreguidelines/AvoidGotoCheck.h"
 #include "../cppcoreguidelines/NoMallocCheck.h"
 #include "../cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h"
 #include "../cppcoreguidelines/ProTypeMemberInitCheck.h"
 #include "../cppcoreguidelines/ProTypeVarargCheck.h"
 #include "../cppcoreguidelines/SpecialMemberFunctionsCheck.h"
-#include "../google/ExplicitConstructorCheck.h"
 #include "../misc/NewDeleteOverloadsCheck.h"
 #include "../misc/StaticAssertCheck.h"
-#include "../modernize/AvoidCArraysCheck.h"
-#include "../modernize/DeprecatedHeadersCheck.h"
 #include "../modernize/UseAutoCheck.h"
 #include "../modernize/UseEmplaceCheck.h"
 #include "../modernize/UseEqualsDefaultCheck.h"
@@ -34,8 +28,6 @@
 #include "../performance/MoveConstArgCheck.h"
 #include "../performance/NoexceptMoveConstructorCheck.h"
 #include "../portability/NoAssemblerCheck.h"
-#include "../readability/BracesAroundStatementsCheck.h"
-#include "../readability/FunctionSizeCheck.h"
 #include "../readability/NamedParameterCheck.h"
 #include "../readability/UppercaseLiteralSuffixCheck.h"
 #include "MultiwayPathsCoveredCheck.h"
@@ -47,26 +39,10 @@ namespace {
 class HICPPModule : public ClangTidyModule {
 public:
   void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
-CheckFactories.registerCheck(
-"hicpp-avoid-c-arrays");
-CheckFactories.registerCheck(
-"hicpp-avoid-goto");
-CheckFactories.registerCheck(
-"hicpp-braces-around-statements");
-CheckFactories.registerCheck(
-"hicpp-deprecated-headers");
-CheckFactories.registerCheck(
-"hicpp-exception-baseclass");
-CheckFactories.registerCheck(
-"hicpp-ignored-remove-result");
 CheckFactories.registerCheck(
 "hicpp-multiway-paths-covered");
 CheckFactories.registerCheck(
 "hicpp-signed-bitwise");
-CheckFactories.registerCheck(
-"hicpp-explicit-conversions");
-CheckFactories.registerCheck(
-"hicpp-function-size");
 CheckFactories.registerCheck(
 "hicpp-named-parameter");
 CheckFactories.registerCheck(
@@ -111,16 +87,6 @@ class HICPPModule : public ClangTidyModule {
 CheckFactories.registerCheck(
 "hicpp-vararg");
   }
-
-  ClangTidyOptions getModuleOptions() override

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-10 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 updated 
https://github.com/llvm/llvm-project/pull/194516

>From 76744d64e54c2140c2467bd1b1183a27f9bdda35 Mon Sep 17 00:00:00 2001
From: mtx 
Date: Tue, 28 Apr 2026 10:54:46 +0800
Subject: [PATCH 1/2] [clang-tidy] Remove hicpp module [1/4]

---
 .../clang-tidy/hicpp/HICPPTidyModule.cpp  | 34 ---
 clang-tools-extra/clangd/TidyFastChecks.inc   |  8 -
 clang-tools-extra/docs/ReleaseNotes.rst   | 20 +++
 .../checks/bugprone/unused-return-value.rst   |  5 ---
 .../checks/hicpp/avoid-c-arrays.rst   | 11 --
 .../clang-tidy/checks/hicpp/avoid-goto.rst| 11 --
 .../checks/hicpp/braces-around-statements.rst | 13 ---
 .../checks/hicpp/deprecated-headers.rst   | 11 --
 .../checks/hicpp/exception-baseclass.rst  | 10 --
 .../checks/hicpp/explicit-conversions.rst | 25 --
 .../clang-tidy/checks/hicpp/function-size.rst | 14 
 .../checks/hicpp/ignored-remove-result.rst| 10 --
 .../docs/clang-tidy/checks/list.rst   |  8 -
 .../checks/modernize/avoid-c-arrays.rst   |  2 --
 .../unused-return-value-remove.cpp}   |  6 ++--
 15 files changed, 8 insertions(+), 180 deletions(-)
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-c-arrays.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-goto.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/braces-around-statements.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/deprecated-headers.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/exception-baseclass.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/function-size.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/ignored-remove-result.rst
 rename 
clang-tools-extra/test/clang-tidy/checkers/{hicpp/ignored-remove-result.cpp => 
bugprone/unused-return-value-remove.cpp} (80%)

diff --git a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp 
b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
index 501e7fc0e2d9b..e628c81db6955 100644
--- a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
@@ -9,21 +9,15 @@
 #include "../ClangTidy.h"
 #include "../ClangTidyModule.h"
 #include "../bugprone/SignedBitwiseCheck.h"
-#include "../bugprone/StdExceptionBaseclassCheck.h"
 #include "../bugprone/UndelegatedConstructorCheck.h"
-#include "../bugprone/UnusedReturnValueCheck.h"
 #include "../bugprone/UseAfterMoveCheck.h"
-#include "../cppcoreguidelines/AvoidGotoCheck.h"
 #include "../cppcoreguidelines/NoMallocCheck.h"
 #include "../cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h"
 #include "../cppcoreguidelines/ProTypeMemberInitCheck.h"
 #include "../cppcoreguidelines/ProTypeVarargCheck.h"
 #include "../cppcoreguidelines/SpecialMemberFunctionsCheck.h"
-#include "../google/ExplicitConstructorCheck.h"
 #include "../misc/NewDeleteOverloadsCheck.h"
 #include "../misc/StaticAssertCheck.h"
-#include "../modernize/AvoidCArraysCheck.h"
-#include "../modernize/DeprecatedHeadersCheck.h"
 #include "../modernize/UseAutoCheck.h"
 #include "../modernize/UseEmplaceCheck.h"
 #include "../modernize/UseEqualsDefaultCheck.h"
@@ -34,8 +28,6 @@
 #include "../performance/MoveConstArgCheck.h"
 #include "../performance/NoexceptMoveConstructorCheck.h"
 #include "../portability/NoAssemblerCheck.h"
-#include "../readability/BracesAroundStatementsCheck.h"
-#include "../readability/FunctionSizeCheck.h"
 #include "../readability/NamedParameterCheck.h"
 #include "../readability/UppercaseLiteralSuffixCheck.h"
 #include "MultiwayPathsCoveredCheck.h"
@@ -47,26 +39,10 @@ namespace {
 class HICPPModule : public ClangTidyModule {
 public:
   void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
-CheckFactories.registerCheck(
-"hicpp-avoid-c-arrays");
-CheckFactories.registerCheck(
-"hicpp-avoid-goto");
-CheckFactories.registerCheck(
-"hicpp-braces-around-statements");
-CheckFactories.registerCheck(
-"hicpp-deprecated-headers");
-CheckFactories.registerCheck(
-"hicpp-exception-baseclass");
-CheckFactories.registerCheck(
-"hicpp-ignored-remove-result");
 CheckFactories.registerCheck(
 "hicpp-multiway-paths-covered");
 CheckFactories.registerCheck(
 "hicpp-signed-bitwise");
-CheckFactories.registerCheck(
-"hicpp-explicit-conversions");
-CheckFactories.registerCheck(
-"hicpp-function-size");
 CheckFactories.registerCheck(
 "hicpp-named-parameter");
 CheckFactories.registerCheck(
@@ -111,16 +87,6 @@ class HICPPModule : public ClangTidyModule {
 CheckFactories.registerCheck(
 "hicpp-vararg");
   }
-
-  ClangTidyOptions getModuleOptions() override

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-10 Thread Zeyi Xu via cfe-commits 


@@ -203,22 +203,10 @@ New checks
 New check aliases
 ^
 
-- New alias :doc:`cert-exp45-c `
+- Renamed :doc:`cert-exp45-c `
   to :doc:`bugprone-assignment-in-selection-statement
   `.
 
-- Renamed :doc:`hicpp-exception-baseclass
-  `
-  to :doc:`bugprone-std-exception-baseclass
-  `.
-  The `hicpp-exception-baseclass` name is kept as an alias.
-
-- Renamed :doc:`hicpp-ignored-remove-result
-  `
-  to :doc:`bugprone-unused-return-value
-  `.
-  The `hicpp-ignored-remove-result` name is kept as an alias.
-

zeyi2 wrote:

I add a table in the ReleaseNote, thanks!

https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-10 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 converted_to_draft 
https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-10 Thread Baranov Victor via cfe-commits 

https://github.com/vbvictor approved this pull request.

LGTM

https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-09 Thread Baranov Victor via cfe-commits 


@@ -203,22 +203,10 @@ New checks
 New check aliases
 ^
 
-- New alias :doc:`cert-exp45-c `
+- Renamed :doc:`cert-exp45-c `
   to :doc:`bugprone-assignment-in-selection-statement
   `.
 
-- Renamed :doc:`hicpp-exception-baseclass
-  `
-  to :doc:`bugprone-std-exception-baseclass
-  `.
-  The `hicpp-exception-baseclass` name is kept as an alias.
-
-- Renamed :doc:`hicpp-ignored-remove-result
-  `
-  to :doc:`bugprone-unused-return-value
-  `.
-  The `hicpp-ignored-remove-result` name is kept as an alias.
-

vbvictor wrote:

Can we still write what checks should be used instead of removed hicpp?
(which are aliases of hicpp)

https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-09 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 updated 
https://github.com/llvm/llvm-project/pull/194516

>From 76744d64e54c2140c2467bd1b1183a27f9bdda35 Mon Sep 17 00:00:00 2001
From: mtx 
Date: Tue, 28 Apr 2026 10:54:46 +0800
Subject: [PATCH 1/2] [clang-tidy] Remove hicpp module [1/4]

---
 .../clang-tidy/hicpp/HICPPTidyModule.cpp  | 34 ---
 clang-tools-extra/clangd/TidyFastChecks.inc   |  8 -
 clang-tools-extra/docs/ReleaseNotes.rst   | 20 +++
 .../checks/bugprone/unused-return-value.rst   |  5 ---
 .../checks/hicpp/avoid-c-arrays.rst   | 11 --
 .../clang-tidy/checks/hicpp/avoid-goto.rst| 11 --
 .../checks/hicpp/braces-around-statements.rst | 13 ---
 .../checks/hicpp/deprecated-headers.rst   | 11 --
 .../checks/hicpp/exception-baseclass.rst  | 10 --
 .../checks/hicpp/explicit-conversions.rst | 25 --
 .../clang-tidy/checks/hicpp/function-size.rst | 14 
 .../checks/hicpp/ignored-remove-result.rst| 10 --
 .../docs/clang-tidy/checks/list.rst   |  8 -
 .../checks/modernize/avoid-c-arrays.rst   |  2 --
 .../unused-return-value-remove.cpp}   |  6 ++--
 15 files changed, 8 insertions(+), 180 deletions(-)
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-c-arrays.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-goto.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/braces-around-statements.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/deprecated-headers.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/exception-baseclass.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/function-size.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/ignored-remove-result.rst
 rename 
clang-tools-extra/test/clang-tidy/checkers/{hicpp/ignored-remove-result.cpp => 
bugprone/unused-return-value-remove.cpp} (80%)

diff --git a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp 
b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
index 501e7fc0e2d9b..e628c81db6955 100644
--- a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
@@ -9,21 +9,15 @@
 #include "../ClangTidy.h"
 #include "../ClangTidyModule.h"
 #include "../bugprone/SignedBitwiseCheck.h"
-#include "../bugprone/StdExceptionBaseclassCheck.h"
 #include "../bugprone/UndelegatedConstructorCheck.h"
-#include "../bugprone/UnusedReturnValueCheck.h"
 #include "../bugprone/UseAfterMoveCheck.h"
-#include "../cppcoreguidelines/AvoidGotoCheck.h"
 #include "../cppcoreguidelines/NoMallocCheck.h"
 #include "../cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h"
 #include "../cppcoreguidelines/ProTypeMemberInitCheck.h"
 #include "../cppcoreguidelines/ProTypeVarargCheck.h"
 #include "../cppcoreguidelines/SpecialMemberFunctionsCheck.h"
-#include "../google/ExplicitConstructorCheck.h"
 #include "../misc/NewDeleteOverloadsCheck.h"
 #include "../misc/StaticAssertCheck.h"
-#include "../modernize/AvoidCArraysCheck.h"
-#include "../modernize/DeprecatedHeadersCheck.h"
 #include "../modernize/UseAutoCheck.h"
 #include "../modernize/UseEmplaceCheck.h"
 #include "../modernize/UseEqualsDefaultCheck.h"
@@ -34,8 +28,6 @@
 #include "../performance/MoveConstArgCheck.h"
 #include "../performance/NoexceptMoveConstructorCheck.h"
 #include "../portability/NoAssemblerCheck.h"
-#include "../readability/BracesAroundStatementsCheck.h"
-#include "../readability/FunctionSizeCheck.h"
 #include "../readability/NamedParameterCheck.h"
 #include "../readability/UppercaseLiteralSuffixCheck.h"
 #include "MultiwayPathsCoveredCheck.h"
@@ -47,26 +39,10 @@ namespace {
 class HICPPModule : public ClangTidyModule {
 public:
   void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
-CheckFactories.registerCheck(
-"hicpp-avoid-c-arrays");
-CheckFactories.registerCheck(
-"hicpp-avoid-goto");
-CheckFactories.registerCheck(
-"hicpp-braces-around-statements");
-CheckFactories.registerCheck(
-"hicpp-deprecated-headers");
-CheckFactories.registerCheck(
-"hicpp-exception-baseclass");
-CheckFactories.registerCheck(
-"hicpp-ignored-remove-result");
 CheckFactories.registerCheck(
 "hicpp-multiway-paths-covered");
 CheckFactories.registerCheck(
 "hicpp-signed-bitwise");
-CheckFactories.registerCheck(
-"hicpp-explicit-conversions");
-CheckFactories.registerCheck(
-"hicpp-function-size");
 CheckFactories.registerCheck(
 "hicpp-named-parameter");
 CheckFactories.registerCheck(
@@ -111,16 +87,6 @@ class HICPPModule : public ClangTidyModule {
 CheckFactories.registerCheck(
 "hicpp-vararg");
   }
-
-  ClangTidyOptions getModuleOptions() override

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-09 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 updated 
https://github.com/llvm/llvm-project/pull/194516

>From 76744d64e54c2140c2467bd1b1183a27f9bdda35 Mon Sep 17 00:00:00 2001
From: mtx 
Date: Tue, 28 Apr 2026 10:54:46 +0800
Subject: [PATCH 1/2] [clang-tidy] Remove hicpp module [1/4]

---
 .../clang-tidy/hicpp/HICPPTidyModule.cpp  | 34 ---
 clang-tools-extra/clangd/TidyFastChecks.inc   |  8 -
 clang-tools-extra/docs/ReleaseNotes.rst   | 20 +++
 .../checks/bugprone/unused-return-value.rst   |  5 ---
 .../checks/hicpp/avoid-c-arrays.rst   | 11 --
 .../clang-tidy/checks/hicpp/avoid-goto.rst| 11 --
 .../checks/hicpp/braces-around-statements.rst | 13 ---
 .../checks/hicpp/deprecated-headers.rst   | 11 --
 .../checks/hicpp/exception-baseclass.rst  | 10 --
 .../checks/hicpp/explicit-conversions.rst | 25 --
 .../clang-tidy/checks/hicpp/function-size.rst | 14 
 .../checks/hicpp/ignored-remove-result.rst| 10 --
 .../docs/clang-tidy/checks/list.rst   |  8 -
 .../checks/modernize/avoid-c-arrays.rst   |  2 --
 .../unused-return-value-remove.cpp}   |  6 ++--
 15 files changed, 8 insertions(+), 180 deletions(-)
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-c-arrays.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-goto.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/braces-around-statements.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/deprecated-headers.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/exception-baseclass.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/function-size.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/ignored-remove-result.rst
 rename 
clang-tools-extra/test/clang-tidy/checkers/{hicpp/ignored-remove-result.cpp => 
bugprone/unused-return-value-remove.cpp} (80%)

diff --git a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp 
b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
index 501e7fc0e2d9b..e628c81db6955 100644
--- a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
@@ -9,21 +9,15 @@
 #include "../ClangTidy.h"
 #include "../ClangTidyModule.h"
 #include "../bugprone/SignedBitwiseCheck.h"
-#include "../bugprone/StdExceptionBaseclassCheck.h"
 #include "../bugprone/UndelegatedConstructorCheck.h"
-#include "../bugprone/UnusedReturnValueCheck.h"
 #include "../bugprone/UseAfterMoveCheck.h"
-#include "../cppcoreguidelines/AvoidGotoCheck.h"
 #include "../cppcoreguidelines/NoMallocCheck.h"
 #include "../cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h"
 #include "../cppcoreguidelines/ProTypeMemberInitCheck.h"
 #include "../cppcoreguidelines/ProTypeVarargCheck.h"
 #include "../cppcoreguidelines/SpecialMemberFunctionsCheck.h"
-#include "../google/ExplicitConstructorCheck.h"
 #include "../misc/NewDeleteOverloadsCheck.h"
 #include "../misc/StaticAssertCheck.h"
-#include "../modernize/AvoidCArraysCheck.h"
-#include "../modernize/DeprecatedHeadersCheck.h"
 #include "../modernize/UseAutoCheck.h"
 #include "../modernize/UseEmplaceCheck.h"
 #include "../modernize/UseEqualsDefaultCheck.h"
@@ -34,8 +28,6 @@
 #include "../performance/MoveConstArgCheck.h"
 #include "../performance/NoexceptMoveConstructorCheck.h"
 #include "../portability/NoAssemblerCheck.h"
-#include "../readability/BracesAroundStatementsCheck.h"
-#include "../readability/FunctionSizeCheck.h"
 #include "../readability/NamedParameterCheck.h"
 #include "../readability/UppercaseLiteralSuffixCheck.h"
 #include "MultiwayPathsCoveredCheck.h"
@@ -47,26 +39,10 @@ namespace {
 class HICPPModule : public ClangTidyModule {
 public:
   void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
-CheckFactories.registerCheck(
-"hicpp-avoid-c-arrays");
-CheckFactories.registerCheck(
-"hicpp-avoid-goto");
-CheckFactories.registerCheck(
-"hicpp-braces-around-statements");
-CheckFactories.registerCheck(
-"hicpp-deprecated-headers");
-CheckFactories.registerCheck(
-"hicpp-exception-baseclass");
-CheckFactories.registerCheck(
-"hicpp-ignored-remove-result");
 CheckFactories.registerCheck(
 "hicpp-multiway-paths-covered");
 CheckFactories.registerCheck(
 "hicpp-signed-bitwise");
-CheckFactories.registerCheck(
-"hicpp-explicit-conversions");
-CheckFactories.registerCheck(
-"hicpp-function-size");
 CheckFactories.registerCheck(
 "hicpp-named-parameter");
 CheckFactories.registerCheck(
@@ -111,16 +87,6 @@ class HICPPModule : public ClangTidyModule {
 CheckFactories.registerCheck(
 "hicpp-vararg");
   }
-
-  ClangTidyOptions getModuleOptions() override

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-08 Thread Yanzuo Liu via cfe-commits 

https://github.com/zwuis approved this pull request.

Please drop

https://github.com/llvm/llvm-project/blob/52fbf34e35194d05951dfd76a45cc886cf3e4ba5/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-goto.rst?plain=1#L12-L13

>  I think we can ignore the formatter diagnostics for now, so ready for review 
> :)

We can modify clang-format configuration file to make clang-format ignore this 
file (perhaps not in this PR).

https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-05-07 Thread Zeyi Xu via cfe-commits 

zeyi2 wrote:

friendly ping :)

https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-04-27 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 edited https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-04-27 Thread Zeyi Xu via cfe-commits 

zeyi2 wrote:

```
diff --git a/clang-tools-extra/clangd/TidyFastChecks.inc 
b/clang-tools-extra/clangd/TidyFastChecks.inc
index c1a72bae0..0cab3da8c 100644
--- a/clang-tools-extra/clangd/TidyFastChecks.inc
+++ b/clang-tools-extra/clangd/TidyFastChecks.inc
@@ -271,7 +271,7 @@ FAST(google-readability-todo, 0.0)
 FAST(google-runtime-float, 1.0)
 FAST(google-runtime-int, 2.0)
 FAST(google-runtime-operator, 1.0)
-FAST(google-upgrade-googletest-case, 1.0)
+FAST(google - upgrade - googletest - case, 1.0)
 FAST(hicpp-invalid-access-moved, 9.0)
 FAST(hicpp-member-init, 2.0)
 FAST(hicpp-move-const-arg, 2.0)
 ```
 
 I think we can ignore the formatter diagnostics, so ready for review :)

https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-04-27 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang-tidy

Author: Zeyi Xu (zeyi2)


Changes



---
Full diff: https://github.com/llvm/llvm-project/pull/194516.diff


15 Files Affected:

- (modified) clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp (-34) 
- (modified) clang-tools-extra/clangd/TidyFastChecks.inc (-8) 
- (modified) clang-tools-extra/docs/ReleaseNotes.rst (+1-13) 
- (modified) 
clang-tools-extra/docs/clang-tidy/checks/bugprone/unused-return-value.rst (-5) 
- (removed) clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-c-arrays.rst 
(-9) 
- (removed) clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-goto.rst (-9) 
- (removed) 
clang-tools-extra/docs/clang-tidy/checks/hicpp/braces-around-statements.rst 
(-11) 
- (removed) 
clang-tools-extra/docs/clang-tidy/checks/hicpp/deprecated-headers.rst (-9) 
- (removed) 
clang-tools-extra/docs/clang-tidy/checks/hicpp/exception-baseclass.rst (-8) 
- (removed) 
clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst (-23) 
- (removed) clang-tools-extra/docs/clang-tidy/checks/hicpp/function-size.rst 
(-12) 
- (removed) 
clang-tools-extra/docs/clang-tidy/checks/hicpp/ignored-remove-result.rst (-8) 
- (modified) clang-tools-extra/docs/clang-tidy/checks/list.rst (-8) 
- (modified) 
clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-arrays.rst (-2) 
- (renamed) 
clang-tools-extra/test/clang-tidy/checkers/bugprone/unused-return-value-remove.cpp
 (+4-2) 


``diff
diff --git a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp 
b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
index 501e7fc0e2d9b..e628c81db6955 100644
--- a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
@@ -9,21 +9,15 @@
 #include "../ClangTidy.h"
 #include "../ClangTidyModule.h"
 #include "../bugprone/SignedBitwiseCheck.h"
-#include "../bugprone/StdExceptionBaseclassCheck.h"
 #include "../bugprone/UndelegatedConstructorCheck.h"
-#include "../bugprone/UnusedReturnValueCheck.h"
 #include "../bugprone/UseAfterMoveCheck.h"
-#include "../cppcoreguidelines/AvoidGotoCheck.h"
 #include "../cppcoreguidelines/NoMallocCheck.h"
 #include "../cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h"
 #include "../cppcoreguidelines/ProTypeMemberInitCheck.h"
 #include "../cppcoreguidelines/ProTypeVarargCheck.h"
 #include "../cppcoreguidelines/SpecialMemberFunctionsCheck.h"
-#include "../google/ExplicitConstructorCheck.h"
 #include "../misc/NewDeleteOverloadsCheck.h"
 #include "../misc/StaticAssertCheck.h"
-#include "../modernize/AvoidCArraysCheck.h"
-#include "../modernize/DeprecatedHeadersCheck.h"
 #include "../modernize/UseAutoCheck.h"
 #include "../modernize/UseEmplaceCheck.h"
 #include "../modernize/UseEqualsDefaultCheck.h"
@@ -34,8 +28,6 @@
 #include "../performance/MoveConstArgCheck.h"
 #include "../performance/NoexceptMoveConstructorCheck.h"
 #include "../portability/NoAssemblerCheck.h"
-#include "../readability/BracesAroundStatementsCheck.h"
-#include "../readability/FunctionSizeCheck.h"
 #include "../readability/NamedParameterCheck.h"
 #include "../readability/UppercaseLiteralSuffixCheck.h"
 #include "MultiwayPathsCoveredCheck.h"
@@ -47,26 +39,10 @@ namespace {
 class HICPPModule : public ClangTidyModule {
 public:
   void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
-CheckFactories.registerCheck(
-"hicpp-avoid-c-arrays");
-CheckFactories.registerCheck(
-"hicpp-avoid-goto");
-CheckFactories.registerCheck(
-"hicpp-braces-around-statements");
-CheckFactories.registerCheck(
-"hicpp-deprecated-headers");
-CheckFactories.registerCheck(
-"hicpp-exception-baseclass");
-CheckFactories.registerCheck(
-"hicpp-ignored-remove-result");
 CheckFactories.registerCheck(
 "hicpp-multiway-paths-covered");
 CheckFactories.registerCheck(
 "hicpp-signed-bitwise");
-CheckFactories.registerCheck(
-"hicpp-explicit-conversions");
-CheckFactories.registerCheck(
-"hicpp-function-size");
 CheckFactories.registerCheck(
 "hicpp-named-parameter");
 CheckFactories.registerCheck(
@@ -111,16 +87,6 @@ class HICPPModule : public ClangTidyModule {
 CheckFactories.registerCheck(
 "hicpp-vararg");
   }
-
-  ClangTidyOptions getModuleOptions() override {
-ClangTidyOptions Options;
-ClangTidyOptions::OptionMap &Opts = Options.CheckOptions;
-Opts["hicpp-ignored-remove-result.CheckedFunctions"] =
-"^::std::remove$;^::std::remove_if$;^::std::unique$";
-Opts["hicpp-ignored-remove-result.CheckedReturnTypes"] = "";
-Opts["hicpp-ignored-remove-result.AllowCastToVoid"] = "true";
-return Options;
-  }
 };
 
 } // namespace
diff --git a/clang-tools-extra/clangd/TidyFastChecks.inc 
b/clang-tools-extra/clangd/TidyFastChecks.inc
index 15fc27cf81c01..c1a72bae035b7 100644
--- a/clang-tools-extra/clangd/TidyFastChecks.inc
+++ b/clang-tools-extra/

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-04-27 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clangd

Author: Zeyi Xu (zeyi2)


Changes



---
Full diff: https://github.com/llvm/llvm-project/pull/194516.diff


15 Files Affected:

- (modified) clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp (-34) 
- (modified) clang-tools-extra/clangd/TidyFastChecks.inc (-8) 
- (modified) clang-tools-extra/docs/ReleaseNotes.rst (+1-13) 
- (modified) 
clang-tools-extra/docs/clang-tidy/checks/bugprone/unused-return-value.rst (-5) 
- (removed) clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-c-arrays.rst 
(-9) 
- (removed) clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-goto.rst (-9) 
- (removed) 
clang-tools-extra/docs/clang-tidy/checks/hicpp/braces-around-statements.rst 
(-11) 
- (removed) 
clang-tools-extra/docs/clang-tidy/checks/hicpp/deprecated-headers.rst (-9) 
- (removed) 
clang-tools-extra/docs/clang-tidy/checks/hicpp/exception-baseclass.rst (-8) 
- (removed) 
clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst (-23) 
- (removed) clang-tools-extra/docs/clang-tidy/checks/hicpp/function-size.rst 
(-12) 
- (removed) 
clang-tools-extra/docs/clang-tidy/checks/hicpp/ignored-remove-result.rst (-8) 
- (modified) clang-tools-extra/docs/clang-tidy/checks/list.rst (-8) 
- (modified) 
clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-arrays.rst (-2) 
- (renamed) 
clang-tools-extra/test/clang-tidy/checkers/bugprone/unused-return-value-remove.cpp
 (+4-2) 


``diff
diff --git a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp 
b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
index 501e7fc0e2d9b..e628c81db6955 100644
--- a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
@@ -9,21 +9,15 @@
 #include "../ClangTidy.h"
 #include "../ClangTidyModule.h"
 #include "../bugprone/SignedBitwiseCheck.h"
-#include "../bugprone/StdExceptionBaseclassCheck.h"
 #include "../bugprone/UndelegatedConstructorCheck.h"
-#include "../bugprone/UnusedReturnValueCheck.h"
 #include "../bugprone/UseAfterMoveCheck.h"
-#include "../cppcoreguidelines/AvoidGotoCheck.h"
 #include "../cppcoreguidelines/NoMallocCheck.h"
 #include "../cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h"
 #include "../cppcoreguidelines/ProTypeMemberInitCheck.h"
 #include "../cppcoreguidelines/ProTypeVarargCheck.h"
 #include "../cppcoreguidelines/SpecialMemberFunctionsCheck.h"
-#include "../google/ExplicitConstructorCheck.h"
 #include "../misc/NewDeleteOverloadsCheck.h"
 #include "../misc/StaticAssertCheck.h"
-#include "../modernize/AvoidCArraysCheck.h"
-#include "../modernize/DeprecatedHeadersCheck.h"
 #include "../modernize/UseAutoCheck.h"
 #include "../modernize/UseEmplaceCheck.h"
 #include "../modernize/UseEqualsDefaultCheck.h"
@@ -34,8 +28,6 @@
 #include "../performance/MoveConstArgCheck.h"
 #include "../performance/NoexceptMoveConstructorCheck.h"
 #include "../portability/NoAssemblerCheck.h"
-#include "../readability/BracesAroundStatementsCheck.h"
-#include "../readability/FunctionSizeCheck.h"
 #include "../readability/NamedParameterCheck.h"
 #include "../readability/UppercaseLiteralSuffixCheck.h"
 #include "MultiwayPathsCoveredCheck.h"
@@ -47,26 +39,10 @@ namespace {
 class HICPPModule : public ClangTidyModule {
 public:
   void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
-CheckFactories.registerCheck(
-"hicpp-avoid-c-arrays");
-CheckFactories.registerCheck(
-"hicpp-avoid-goto");
-CheckFactories.registerCheck(
-"hicpp-braces-around-statements");
-CheckFactories.registerCheck(
-"hicpp-deprecated-headers");
-CheckFactories.registerCheck(
-"hicpp-exception-baseclass");
-CheckFactories.registerCheck(
-"hicpp-ignored-remove-result");
 CheckFactories.registerCheck(
 "hicpp-multiway-paths-covered");
 CheckFactories.registerCheck(
 "hicpp-signed-bitwise");
-CheckFactories.registerCheck(
-"hicpp-explicit-conversions");
-CheckFactories.registerCheck(
-"hicpp-function-size");
 CheckFactories.registerCheck(
 "hicpp-named-parameter");
 CheckFactories.registerCheck(
@@ -111,16 +87,6 @@ class HICPPModule : public ClangTidyModule {
 CheckFactories.registerCheck(
 "hicpp-vararg");
   }
-
-  ClangTidyOptions getModuleOptions() override {
-ClangTidyOptions Options;
-ClangTidyOptions::OptionMap &Opts = Options.CheckOptions;
-Opts["hicpp-ignored-remove-result.CheckedFunctions"] =
-"^::std::remove$;^::std::remove_if$;^::std::unique$";
-Opts["hicpp-ignored-remove-result.CheckedReturnTypes"] = "";
-Opts["hicpp-ignored-remove-result.AllowCastToVoid"] = "true";
-return Options;
-  }
 };
 
 } // namespace
diff --git a/clang-tools-extra/clangd/TidyFastChecks.inc 
b/clang-tools-extra/clangd/TidyFastChecks.inc
index 15fc27cf81c01..c1a72bae035b7 100644
--- a/clang-tools-extra/clangd/TidyFastChecks.inc
+++ b/clang-tools-extra/clan

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-04-27 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 ready_for_review 
https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-04-27 Thread via cfe-commits 

github-actions[bot] wrote:




:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:



You can test this locally with the following command:


``bash
git-clang-format --diff origin/main HEAD --extensions inc,cpp -- 
clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp 
clang-tools-extra/clangd/TidyFastChecks.inc 
clang-tools-extra/test/clang-tidy/checkers/bugprone/unused-return-value-remove.cpp
 --diff_from_common_commit
``

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:





View the diff from clang-format here.


``diff
diff --git a/clang-tools-extra/clangd/TidyFastChecks.inc 
b/clang-tools-extra/clangd/TidyFastChecks.inc
index c1a72bae0..0cab3da8c 100644
--- a/clang-tools-extra/clangd/TidyFastChecks.inc
+++ b/clang-tools-extra/clangd/TidyFastChecks.inc
@@ -271,7 +271,7 @@ FAST(google-readability-todo, 0.0)
 FAST(google-runtime-float, 1.0)
 FAST(google-runtime-int, 2.0)
 FAST(google-runtime-operator, 1.0)
-FAST(google-upgrade-googletest-case, 1.0)
+FAST(google - upgrade - googletest - case, 1.0)
 FAST(hicpp-invalid-access-moved, 9.0)
 FAST(hicpp-member-init, 2.0)
 FAST(hicpp-move-const-arg, 2.0)

``




https://github.com/llvm/llvm-project/pull/194516
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-04-27 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 updated 
https://github.com/llvm/llvm-project/pull/194516

>From 76744d64e54c2140c2467bd1b1183a27f9bdda35 Mon Sep 17 00:00:00 2001
From: mtx 
Date: Tue, 28 Apr 2026 10:54:46 +0800
Subject: [PATCH] [clang-tidy] Remove hicpp module [1/4]

---
 .../clang-tidy/hicpp/HICPPTidyModule.cpp  | 34 ---
 clang-tools-extra/clangd/TidyFastChecks.inc   |  8 -
 clang-tools-extra/docs/ReleaseNotes.rst   | 20 +++
 .../checks/bugprone/unused-return-value.rst   |  5 ---
 .../checks/hicpp/avoid-c-arrays.rst   | 11 --
 .../clang-tidy/checks/hicpp/avoid-goto.rst| 11 --
 .../checks/hicpp/braces-around-statements.rst | 13 ---
 .../checks/hicpp/deprecated-headers.rst   | 11 --
 .../checks/hicpp/exception-baseclass.rst  | 10 --
 .../checks/hicpp/explicit-conversions.rst | 25 --
 .../clang-tidy/checks/hicpp/function-size.rst | 14 
 .../checks/hicpp/ignored-remove-result.rst| 10 --
 .../docs/clang-tidy/checks/list.rst   |  8 -
 .../checks/modernize/avoid-c-arrays.rst   |  2 --
 .../unused-return-value-remove.cpp}   |  6 ++--
 15 files changed, 8 insertions(+), 180 deletions(-)
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-c-arrays.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-goto.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/braces-around-statements.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/deprecated-headers.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/exception-baseclass.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/function-size.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/ignored-remove-result.rst
 rename 
clang-tools-extra/test/clang-tidy/checkers/{hicpp/ignored-remove-result.cpp => 
bugprone/unused-return-value-remove.cpp} (80%)

diff --git a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp 
b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
index 501e7fc0e2d9b..e628c81db6955 100644
--- a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
@@ -9,21 +9,15 @@
 #include "../ClangTidy.h"
 #include "../ClangTidyModule.h"
 #include "../bugprone/SignedBitwiseCheck.h"
-#include "../bugprone/StdExceptionBaseclassCheck.h"
 #include "../bugprone/UndelegatedConstructorCheck.h"
-#include "../bugprone/UnusedReturnValueCheck.h"
 #include "../bugprone/UseAfterMoveCheck.h"
-#include "../cppcoreguidelines/AvoidGotoCheck.h"
 #include "../cppcoreguidelines/NoMallocCheck.h"
 #include "../cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h"
 #include "../cppcoreguidelines/ProTypeMemberInitCheck.h"
 #include "../cppcoreguidelines/ProTypeVarargCheck.h"
 #include "../cppcoreguidelines/SpecialMemberFunctionsCheck.h"
-#include "../google/ExplicitConstructorCheck.h"
 #include "../misc/NewDeleteOverloadsCheck.h"
 #include "../misc/StaticAssertCheck.h"
-#include "../modernize/AvoidCArraysCheck.h"
-#include "../modernize/DeprecatedHeadersCheck.h"
 #include "../modernize/UseAutoCheck.h"
 #include "../modernize/UseEmplaceCheck.h"
 #include "../modernize/UseEqualsDefaultCheck.h"
@@ -34,8 +28,6 @@
 #include "../performance/MoveConstArgCheck.h"
 #include "../performance/NoexceptMoveConstructorCheck.h"
 #include "../portability/NoAssemblerCheck.h"
-#include "../readability/BracesAroundStatementsCheck.h"
-#include "../readability/FunctionSizeCheck.h"
 #include "../readability/NamedParameterCheck.h"
 #include "../readability/UppercaseLiteralSuffixCheck.h"
 #include "MultiwayPathsCoveredCheck.h"
@@ -47,26 +39,10 @@ namespace {
 class HICPPModule : public ClangTidyModule {
 public:
   void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
-CheckFactories.registerCheck(
-"hicpp-avoid-c-arrays");
-CheckFactories.registerCheck(
-"hicpp-avoid-goto");
-CheckFactories.registerCheck(
-"hicpp-braces-around-statements");
-CheckFactories.registerCheck(
-"hicpp-deprecated-headers");
-CheckFactories.registerCheck(
-"hicpp-exception-baseclass");
-CheckFactories.registerCheck(
-"hicpp-ignored-remove-result");
 CheckFactories.registerCheck(
 "hicpp-multiway-paths-covered");
 CheckFactories.registerCheck(
 "hicpp-signed-bitwise");
-CheckFactories.registerCheck(
-"hicpp-explicit-conversions");
-CheckFactories.registerCheck(
-"hicpp-function-size");
 CheckFactories.registerCheck(
 "hicpp-named-parameter");
 CheckFactories.registerCheck(
@@ -111,16 +87,6 @@ class HICPPModule : public ClangTidyModule {
 CheckFactories.registerCheck(
 "hicpp-vararg");
   }
-
-  ClangTidyOptions getModuleOptions() override {
-

[clang-tools-extra] [clang-tidy] Remove hicpp module [1/4] (PR #194516)

2026-04-27 Thread Zeyi Xu via cfe-commits 

https://github.com/zeyi2 created 
https://github.com/llvm/llvm-project/pull/194516

None

>From 76744d64e54c2140c2467bd1b1183a27f9bdda35 Mon Sep 17 00:00:00 2001
From: mtx 
Date: Tue, 28 Apr 2026 10:54:46 +0800
Subject: [PATCH] [clang-tidy] Remove hicpp module [1/4]

---
 .../clang-tidy/hicpp/HICPPTidyModule.cpp  | 34 ---
 clang-tools-extra/clangd/TidyFastChecks.inc   |  8 -
 clang-tools-extra/docs/ReleaseNotes.rst   | 20 +++
 .../checks/bugprone/unused-return-value.rst   |  5 ---
 .../checks/hicpp/avoid-c-arrays.rst   | 11 --
 .../clang-tidy/checks/hicpp/avoid-goto.rst| 11 --
 .../checks/hicpp/braces-around-statements.rst | 13 ---
 .../checks/hicpp/deprecated-headers.rst   | 11 --
 .../checks/hicpp/exception-baseclass.rst  | 10 --
 .../checks/hicpp/explicit-conversions.rst | 25 --
 .../clang-tidy/checks/hicpp/function-size.rst | 14 
 .../checks/hicpp/ignored-remove-result.rst| 10 --
 .../docs/clang-tidy/checks/list.rst   |  8 -
 .../checks/modernize/avoid-c-arrays.rst   |  2 --
 .../unused-return-value-remove.cpp}   |  6 ++--
 15 files changed, 8 insertions(+), 180 deletions(-)
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-c-arrays.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/avoid-goto.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/braces-around-statements.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/deprecated-headers.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/exception-baseclass.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/function-size.rst
 delete mode 100644 
clang-tools-extra/docs/clang-tidy/checks/hicpp/ignored-remove-result.rst
 rename 
clang-tools-extra/test/clang-tidy/checkers/{hicpp/ignored-remove-result.cpp => 
bugprone/unused-return-value-remove.cpp} (80%)

diff --git a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp 
b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
index 501e7fc0e2d9b..e628c81db6955 100644
--- a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
@@ -9,21 +9,15 @@
 #include "../ClangTidy.h"
 #include "../ClangTidyModule.h"
 #include "../bugprone/SignedBitwiseCheck.h"
-#include "../bugprone/StdExceptionBaseclassCheck.h"
 #include "../bugprone/UndelegatedConstructorCheck.h"
-#include "../bugprone/UnusedReturnValueCheck.h"
 #include "../bugprone/UseAfterMoveCheck.h"
-#include "../cppcoreguidelines/AvoidGotoCheck.h"
 #include "../cppcoreguidelines/NoMallocCheck.h"
 #include "../cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h"
 #include "../cppcoreguidelines/ProTypeMemberInitCheck.h"
 #include "../cppcoreguidelines/ProTypeVarargCheck.h"
 #include "../cppcoreguidelines/SpecialMemberFunctionsCheck.h"
-#include "../google/ExplicitConstructorCheck.h"
 #include "../misc/NewDeleteOverloadsCheck.h"
 #include "../misc/StaticAssertCheck.h"
-#include "../modernize/AvoidCArraysCheck.h"
-#include "../modernize/DeprecatedHeadersCheck.h"
 #include "../modernize/UseAutoCheck.h"
 #include "../modernize/UseEmplaceCheck.h"
 #include "../modernize/UseEqualsDefaultCheck.h"
@@ -34,8 +28,6 @@
 #include "../performance/MoveConstArgCheck.h"
 #include "../performance/NoexceptMoveConstructorCheck.h"
 #include "../portability/NoAssemblerCheck.h"
-#include "../readability/BracesAroundStatementsCheck.h"
-#include "../readability/FunctionSizeCheck.h"
 #include "../readability/NamedParameterCheck.h"
 #include "../readability/UppercaseLiteralSuffixCheck.h"
 #include "MultiwayPathsCoveredCheck.h"
@@ -47,26 +39,10 @@ namespace {
 class HICPPModule : public ClangTidyModule {
 public:
   void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
-CheckFactories.registerCheck(
-"hicpp-avoid-c-arrays");
-CheckFactories.registerCheck(
-"hicpp-avoid-goto");
-CheckFactories.registerCheck(
-"hicpp-braces-around-statements");
-CheckFactories.registerCheck(
-"hicpp-deprecated-headers");
-CheckFactories.registerCheck(
-"hicpp-exception-baseclass");
-CheckFactories.registerCheck(
-"hicpp-ignored-remove-result");
 CheckFactories.registerCheck(
 "hicpp-multiway-paths-covered");
 CheckFactories.registerCheck(
 "hicpp-signed-bitwise");
-CheckFactories.registerCheck(
-"hicpp-explicit-conversions");
-CheckFactories.registerCheck(
-"hicpp-function-size");
 CheckFactories.registerCheck(
 "hicpp-named-parameter");
 CheckFactories.registerCheck(
@@ -111,16 +87,6 @@ class HICPPModule : public ClangTidyModule {
 CheckFactories.registerCheck(
 "hicpp-vararg");
   }
-
-  ClangTidyOptions getModuleOptions() overri