[clang-tools-extra] [clang-tools-extra] Remove redundant control flow statements (NFC) (PR #140846)
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick` running on `linaro-clang-aarch64-quick` while building `clang-tools-extra` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/16934 Here is the relevant piece of the build log for the reference ``` Step 5 (ninja check 1) failure: stage 1 checked (failure) TEST 'lit :: timeout-hang.py' FAILED Exit Code: 1 Command Output (stdout): -- # RUN: at line 13 not env -u FILECHECK_OPTS "/usr/bin/python3.10" /home/tcwg-buildbot/worker/clang-aarch64-quick/llvm/llvm/utils/lit/lit.py -j1 --order=lexical Inputs/timeout-hang/run-nonexistent.txt --timeout=1 --param external=0 | "/usr/bin/python3.10" /home/tcwg-buildbot/worker/clang-aarch64-quick/stage1/utils/lit/tests/timeout-hang.py 1 # executed command: not env -u FILECHECK_OPTS /usr/bin/python3.10 /home/tcwg-buildbot/worker/clang-aarch64-quick/llvm/llvm/utils/lit/lit.py -j1 --order=lexical Inputs/timeout-hang/run-nonexistent.txt --timeout=1 --param external=0 # .---command stderr # | lit.py: /home/tcwg-buildbot/worker/clang-aarch64-quick/llvm/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 1 seconds was requested on the command line. Forcing timeout to be 1 seconds. # `- # executed command: /usr/bin/python3.10 /home/tcwg-buildbot/worker/clang-aarch64-quick/stage1/utils/lit/tests/timeout-hang.py 1 # .---command stdout # | Testing took as long or longer than timeout # `- # error: command failed with exit status: 1 -- ``` https://github.com/llvm/llvm-project/pull/140846 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] [clang-tools-extra] Remove redundant control flow statements (NFC) (PR #140846)
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140846 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] [clang-tools-extra] Remove redundant control flow statements (NFC) (PR #140846)
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/140846 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] [clang-tools-extra] Remove redundant control flow statements (NFC) (PR #140846)
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/140846
None
>From 0adfa898b7196c7a4841b8bc73c2e0be2fc19bc5 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Tue, 20 May 2025 22:33:57 -0700
Subject: [PATCH] [clang-tools-extra] Remove redundant control flow statements
(NFC)
---
.../clang-tidy/readability/EnumInitialValueCheck.cpp| 1 -
clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp | 2 --
2 files changed, 3 deletions(-)
diff --git a/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
b/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
index e0b9939681794..b4a157c153bb9 100644
--- a/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
@@ -70,7 +70,6 @@ static void cleanInitialValue(DiagnosticBuilder &Diag,
return;
Diag << FixItHint::CreateRemoval(EqualLoc)
<< FixItHint::CreateRemoval(InitExprRange);
- return;
}
namespace {
diff --git a/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
b/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
index 724160dbfb7ca..eadf03b3abe24 100644
--- a/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
+++ b/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
@@ -49,7 +49,6 @@ TEST(ProjectAware, Test) {
C.Index.External.Location = "test";
WithContextValue With(Config::Key, std::move(C));
EXPECT_THAT(match(*Idx, Req), ElementsAre("1"));
- return;
}
TEST(ProjectAware, CreatedOnce) {
@@ -80,7 +79,6 @@ TEST(ProjectAware, CreatedOnce) {
match(*Idx, Req);
// It is cached afterwards.
EXPECT_EQ(InvocationCount, 1U);
- return;
}
} // namespace clangd
} // namespace clang
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] [clang-tools-extra] Remove redundant control flow statements (NFC) (PR #140846)
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140846.diff
2 Files Affected:
- (modified) clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
(-1)
- (modified) clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp (-2)
``diff
diff --git a/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
b/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
index e0b9939681794..b4a157c153bb9 100644
--- a/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
@@ -70,7 +70,6 @@ static void cleanInitialValue(DiagnosticBuilder &Diag,
return;
Diag << FixItHint::CreateRemoval(EqualLoc)
<< FixItHint::CreateRemoval(InitExprRange);
- return;
}
namespace {
diff --git a/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
b/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
index 724160dbfb7ca..eadf03b3abe24 100644
--- a/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
+++ b/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
@@ -49,7 +49,6 @@ TEST(ProjectAware, Test) {
C.Index.External.Location = "test";
WithContextValue With(Config::Key, std::move(C));
EXPECT_THAT(match(*Idx, Req), ElementsAre("1"));
- return;
}
TEST(ProjectAware, CreatedOnce) {
@@ -80,7 +79,6 @@ TEST(ProjectAware, CreatedOnce) {
match(*Idx, Req);
// It is cached afterwards.
EXPECT_EQ(InvocationCount, 1U);
- return;
}
} // namespace clangd
} // namespace clang
``
https://github.com/llvm/llvm-project/pull/140846
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] [clang-tools-extra] Remove redundant control flow statements (NFC) (PR #140846)
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140846.diff
2 Files Affected:
- (modified) clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
(-1)
- (modified) clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp (-2)
``diff
diff --git a/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
b/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
index e0b9939681794..b4a157c153bb9 100644
--- a/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/EnumInitialValueCheck.cpp
@@ -70,7 +70,6 @@ static void cleanInitialValue(DiagnosticBuilder &Diag,
return;
Diag << FixItHint::CreateRemoval(EqualLoc)
<< FixItHint::CreateRemoval(InitExprRange);
- return;
}
namespace {
diff --git a/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
b/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
index 724160dbfb7ca..eadf03b3abe24 100644
--- a/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
+++ b/clang-tools-extra/clangd/unittests/ProjectAwareIndexTests.cpp
@@ -49,7 +49,6 @@ TEST(ProjectAware, Test) {
C.Index.External.Location = "test";
WithContextValue With(Config::Key, std::move(C));
EXPECT_THAT(match(*Idx, Req), ElementsAre("1"));
- return;
}
TEST(ProjectAware, CreatedOnce) {
@@ -80,7 +79,6 @@ TEST(ProjectAware, CreatedOnce) {
match(*Idx, Req);
// It is cached afterwards.
EXPECT_EQ(InvocationCount, 1U);
- return;
}
} // namespace clangd
} // namespace clang
``
https://github.com/llvm/llvm-project/pull/140846
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
