[clang-tools-extra] Update debug output string (PR #152671)
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot3` while building `clang-tools-extra` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/13851 Here is the relevant piece of the build log for the reference ``` Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure) ... llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:522: note: using lld-link: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/lld-link llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:522: note: using ld64.lld: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/ld64.lld llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:522: note: using wasm-ld: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/wasm-ld llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:522: note: using ld.lld: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/ld.lld llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:522: note: using lld-link: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/lld-link llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:522: note: using ld64.lld: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/ld64.lld llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:522: note: using wasm-ld: /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/wasm-ld llvm-lit: /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/utils/lit/lit/main.py:73: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds. -- Testing: 91936 tests, 88 workers -- Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. FAIL: LLVM :: ExecutionEngine/JITLink/x86-64/MachO_weak_references.s (72800 of 91936) TEST 'LLVM :: ExecutionEngine/JITLink/x86-64/MachO_weak_references.s' FAILED Exit Code: 134 Command Output (stderr): -- rm -rf /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_weak_references.s.tmp && mkdir -p /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_weak_references.s.tmp # RUN: at line 1 + rm -rf /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_weak_references.s.tmp + mkdir -p /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_weak_references.s.tmp /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-mc -triple=x86_64-apple-macosx10.9 -filetype=obj -o /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_weak_references.s.tmp/macho_weak_refs.o /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/MachO_weak_references.s # RUN: at line 2 + /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-mc -triple=x86_64-apple-macosx10.9 -filetype=obj -o /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_weak_references.s.tmp/macho_weak_refs.o /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/MachO_weak_references.s /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-jitlink -noexec -check-name=jitlink-check-bar-present -abs bar=0x1 -check=/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/MachO_weak_references.s /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_weak_references.s.tmp/macho_weak_refs.o # RUN: at line 3 + /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-jitlink -noexec -check-name=jitlink-check-bar-present -abs bar=0x1 -check=/home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/MachO_weak_references.s /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/test/ExecutionEngine/JITLink/x86-64/Output/MachO_weak_references.s.tmp/macho_weak_refs.o /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/llvm-jitlink -noexec -check-name=jitlink-check-bar-absent -check=/home/b/sa
[clang-tools-extra] Update debug output string (PR #152671)
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/152671 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] Update debug output string (PR #152671)
https://github.com/HighCommander4 approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/152671 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] Update debug output string (PR #152671)
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Mythreya Kuricheti (MythreyaK) Changes Include `Signature` and `SnippetSuffix` in the output, when test fails Before:After:Value of: Result.Completions Expected: has 1 element that (named (Name: "bar")) and (signature (S: "(A self, int arg)")) and (snippet suffix (Text: "(${1:A self}, ${2:int arg})")) Actual: { bar - {"detail":"void","filterText":"bar","insertText":"bar","insertTextFormat":1,"kind":2,"label":" bar","labelDetails":{"detail":"(int arg)"},"score":0.65507817268371582,"sortText":"40d84cccbar","textEdit":{"newText":"bar","range":{"end":{"character":13,"line":10},"start":{"character":11,"line":10 }, whose element #0 doesn't match--- Full diff: https://github.com/llvm/llvm-project/pull/152671.diff 1 Files Affected: - (modified) clang-tools-extra/clangd/CodeComplete.cpp (+3) ``diff diff --git a/clang-tools-extra/clangd/CodeComplete.cpp b/clang-tools-extra/clangd/CodeComplete.cpp index 9c17b4ca9b706..cacff21e155a7 100644 --- a/clang-tools-extra/clangd/CodeComplete.cpp +++ b/clang-tools-extra/clangd/CodeComplete.cpp @@ -2434,6 +2434,9 @@ CompletionItem CodeCompletion::render(const CodeCompleteOptions &Opts) const { } llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, const CodeCompletion &C) { + OS << "Signature: " << "\"" << C.Signature << "\", " + << "SnippetSuffix: " << "\"" << C.SnippetSuffix << "\"" + << ", Rendered:"; // For now just lean on CompletionItem. return OS << C.render(CodeCompleteOptions()); } `` https://github.com/llvm/llvm-project/pull/152671 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commitsValue of: Result.Completions Expected: has 1 element that (named (Name: "bar")) and (signature (S: "(A self, int arg)")) and (snippet suffix (Text: "(${1:A self}, ${2:int arg})")) Actual: { Signature: "(A self, int arg)", SnippetSuffix: "", Rendered: bar - {"detail":"void","filterText":"bar","insertText":"bar","insertTextFormat":1,"kind":2,"label":" bar","labelDetails":{"detail":"(A self, int arg)"},"score":0.65507817268371582,"sortText":"40d84cccbar","textEdit":{"newText":"bar","range":{"end":{"character":13,"line":10},"start":{"character":11,"line":10 }, whose element #0 doesn't match
[clang-tools-extra] Update debug output string (PR #152671)
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Mythreya Kuricheti (MythreyaK) Changes Include `Signature` and `SnippetSuffix` in the output, when test fails Before:After:Value of: Result.Completions Expected: has 1 element that (named (Name: "bar")) and (signature (S: "(A self, int arg)")) and (snippet suffix (Text: "(${1:A self}, ${2:int arg})")) Actual: { bar - {"detail":"void","filterText":"bar","insertText":"bar","insertTextFormat":1,"kind":2,"label":" bar","labelDetails":{"detail":"(int arg)"},"score":0.65507817268371582,"sortText":"40d84cccbar","textEdit":{"newText":"bar","range":{"end":{"character":13,"line":10},"start":{"character":11,"line":10 }, whose element #0 doesn't match--- Full diff: https://github.com/llvm/llvm-project/pull/152671.diff 1 Files Affected: - (modified) clang-tools-extra/clangd/CodeComplete.cpp (+3) ``diff diff --git a/clang-tools-extra/clangd/CodeComplete.cpp b/clang-tools-extra/clangd/CodeComplete.cpp index 9c17b4ca9b706..cacff21e155a7 100644 --- a/clang-tools-extra/clangd/CodeComplete.cpp +++ b/clang-tools-extra/clangd/CodeComplete.cpp @@ -2434,6 +2434,9 @@ CompletionItem CodeCompletion::render(const CodeCompleteOptions &Opts) const { } llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, const CodeCompletion &C) { + OS << "Signature: " << "\"" << C.Signature << "\", " + << "SnippetSuffix: " << "\"" << C.SnippetSuffix << "\"" + << ", Rendered:"; // For now just lean on CompletionItem. return OS << C.render(CodeCompleteOptions()); } `` https://github.com/llvm/llvm-project/pull/152671 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commitsValue of: Result.Completions Expected: has 1 element that (named (Name: "bar")) and (signature (S: "(A self, int arg)")) and (snippet suffix (Text: "(${1:A self}, ${2:int arg})")) Actual: { Signature: "(A self, int arg)", SnippetSuffix: "", Rendered: bar - {"detail":"void","filterText":"bar","insertText":"bar","insertTextFormat":1,"kind":2,"label":" bar","labelDetails":{"detail":"(A self, int arg)"},"score":0.65507817268371582,"sortText":"40d84cccbar","textEdit":{"newText":"bar","range":{"end":{"character":13,"line":10},"start":{"character":11,"line":10 }, whose element #0 doesn't match
[clang-tools-extra] Update debug output string (PR #152671)
https://github.com/MythreyaK created
https://github.com/llvm/llvm-project/pull/152671
Include `Signature` and `SnippetSuffix` in the output, when test fails
Before: Value of: Result.Completions
Expected: has 1 element that (named (Name: "bar")) and (signature (S: "(A self,
int arg)")) and (snippet suffix (Text: "(${1:A self}, ${2:int arg})"))
Actual: { bar -
{"detail":"void","filterText":"bar","insertText":"bar","insertTextFormat":1,"kind":2,"label":"
bar","labelDetails":{"detail":"(int
arg)"},"score":0.65507817268371582,"sortText":"40d84cccbar","textEdit":{"newText":"bar","range":{"end":{"character":13,"line":10},"start":{"character":11,"line":10
}, whose element #0 doesn't match
After: Value of: Result.Completions
Expected: has 1 element that (named (Name: "bar")) and (signature (S: "(A self,
int arg)")) and (snippet suffix (Text: "(${1:A self}, ${2:int arg})"))
Actual: { Signature: "(A self, int arg)", SnippetSuffix: "",
Rendered: bar -
{"detail":"void","filterText":"bar","insertText":"bar","insertTextFormat":1,"kind":2,"label":"
bar","labelDetails":{"detail":"(A self, int
arg)"},"score":0.65507817268371582,"sortText":"40d84cccbar","textEdit":{"newText":"bar","range":{"end":{"character":13,"line":10},"start":{"character":11,"line":10
}, whose element #0 doesn't match
>From 27ddf058840ea66ffb401e3d4cfb3099d3051b0e Mon Sep 17 00:00:00 2001
From: Mythreya Kuricheti
Date: Fri, 8 Aug 2025 01:58:15 -0700
Subject: [PATCH] Update debug output string
Include signature and snippetSuffix in the output, when test fails
---
clang-tools-extra/clangd/CodeComplete.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/clang-tools-extra/clangd/CodeComplete.cpp
b/clang-tools-extra/clangd/CodeComplete.cpp
index 9c17b4ca9b706..cacff21e155a7 100644
--- a/clang-tools-extra/clangd/CodeComplete.cpp
+++ b/clang-tools-extra/clangd/CodeComplete.cpp
@@ -2434,6 +2434,9 @@ CompletionItem CodeCompletion::render(const
CodeCompleteOptions &Opts) const {
}
llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, const CodeCompletion &C) {
+ OS << "Signature: " << "\"" << C.Signature << "\", "
+ << "SnippetSuffix: " << "\"" << C.SnippetSuffix << "\""
+ << ", Rendered:";
// For now just lean on CompletionItem.
return OS << C.render(CodeCompleteOptions());
}
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
