> `BackingStore` uses its own Graphics to Paint the Image. This is fine when we
> want to paint it on a Window/Frame, but fails to print. Since `WPathGraphics`
> is used for Printing, backing store fails to print it and backing store uses
> newly created `SunGraphics2D` always. The proposed fix
On Wed, 8 Nov 2023 11:18:12 GMT, Tejesh R wrote:
>> Ok..But why it is needed for RTL and not for LTR?
>
> My guess is for RTL the first column might not start from extreme left, as we
> drag it moves towards the Left corner, this might be for that, still not
> sure, will verify and come back on
On Fri, 10 Nov 2023 06:47:57 GMT, Tejesh R wrote:
>>> And yes, you have to make the method public..
>>
>> Thats what I told already..
>
> Ok, guess I missed it..
Updated.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16552#discussion_r1389015259
On Fri, 10 Nov 2023 07:20:29 GMT, Tejesh R wrote:
>> `BackingStore` uses its own Graphics to Paint the Image. This is fine when
>> we want to paint it on a Window/Frame, but fails to print. Since
>> `WPathGraphics` is used for Printing, backing store fails to print it and
>> backing store uses
> Table contents does not follow right-left Orientation when Max width of
> columns are set. This is due to not considering the offset in `x position`
> while painting table grid and table cell. The fix handles the offset and
> adjust the x position for each paint, similar to how header is paint
> `BackingStore` uses its own Graphics to Paint the Image. This is fine when we
> want to paint it on a Window/Frame, but fails to print. Since `WPathGraphics`
> is used for Printing, backing store fails to print it and backing store uses
> newly created `SunGraphics2D` always. The proposed fix
On Thu, 9 Nov 2023 04:13:21 GMT, Alec Su wrote:
>> The bug on Windows doesn't generate any error messages. During the testcase
>> run, every "Open MIDI port" message should be followed by an "All
>> SysexMessage sent" message. Alternatively, you can check `%ERRORLEVEL%` to
>> determine if ther
On Fri, 10 Nov 2023 06:46:16 GMT, Prasanta Sadhukhan
wrote:
>> It's not public..
>
>> And yes, you have to make the method public..
>
> Thats what I told already..
Ok, guess I missed it..
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16552#discussion_r1388984285
On Fri, 10 Nov 2023 06:41:59 GMT, Tejesh R wrote:
>> Why cant you use isPrinting?
>
> It's not public..
> And yes, you have to make the method public..
Thats what I told already..
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16552#discussion_r1388981671
On Fri, 10 Nov 2023 06:39:29 GMT, Prasanta Sadhukhan
wrote:
>> Yes, it works, can't use `SwingUtilities2.isPrinting(g)` but can check for
>> `PrintGraphics` instance which is done in `SwingUtilities2.isPrinting(g)` ..
>> Thank you for the input...
>
> Why cant you use isPrinting?
It's not pub
On Fri, 10 Nov 2023 04:53:15 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/JViewport.java line 607:
>>
>>> 605:
>>> 606: private Graphics getBackingStoreGraphics(Graphics g) {
>>> 607: if (g instanceof SunGraphics2D) {
>>
>> One thing is the change is not obvio
On Sun, 5 Nov 2023 07:11:27 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less accepting
On Wed, 8 Nov 2023 13:33:26 GMT, Prasanta Sadhukhan
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/JViewport.java line 607:
>
>> 605:
>> 606: private Gr
> `BackingStore` uses its own Graphics to Paint the Image. This is fine when we
> want to paint it on a Window/Frame, but fails to print. Since `WPathGraphics`
> is used for Printing, backing store fails to print it and backing store uses
> newly created `SunGraphics2D` always. The proposed fix
> The issue exist only for non-editable combobox and the root cause is
> accessible object is not created due to incorrect index returned from
> component class which results in no a11y API invoked.
>
> Proposed solution is to return the correct accessible child from
> getAccessibleChild method
On Thu, 9 Nov 2023 19:16:05 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Extend Accessible class to return accessible name
>
> test/jdk/javax/accessibility/JComboBox/TestJComboBoxScreenMagni
On Thu, 9 Nov 2023 20:31:17 GMT, Alexey Ivanov wrote:
> Otherwise, the contract of `set{Min,Max}Size` will still be broken
That's what we are trying to clarify in the JSCrollBar spec that the contract
specified in JComponent is not valid for this widget because of so and so
reason, right?
---
On Thu, 9 Nov 2023 22:30:32 GMT, Harshitha Onkar wrote:
>> With Xcode upgraded to 14.3.1 for macOS builds secure coding warning message
>> was seen in the logs as below:
>>
>> "WARNING: Secure coding is not enabled for restorable state! Enable secure
>> coding by implementing
>> NSApplication
On Thu, 9 Nov 2023 20:25:09 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> local var reused
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/ApplicationDelegate.m line
> 534:
>
>> 532:
>> 5
On Wed, 8 Nov 2023 19:49:48 GMT, Harshitha Onkar wrote:
> With Xcode upgraded to 14.3.1 for macOS builds secure coding warning message
> was seen in the logs as below:
>
> "WARNING: Secure coding is not enabled for restorable state! Enable secure
> coding by implementing
> NSApplicationDelega
> With Xcode upgraded to 14.3.1 for macOS builds secure coding warning message
> was seen in the logs as below:
>
> "WARNING: Secure coding is not enabled for restorable state! Enable secure
> coding by implementing
> NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning
On Wed, 8 Nov 2023 05:06:14 GMT, Prasanta Sadhukhan
wrote:
> Although there seems to be no difference in rendering the scrollbars with and
> without these getXXX methods as can be seen here (top one without, bottom one
> with the methods),
I guess it's expected because `LayoutManager` usually
On Wed, 8 Nov 2023 19:49:48 GMT, Harshitha Onkar wrote:
> With Xcode upgraded to 14.3.1 for macOS builds secure coding warning message
> was seen in the logs as below:
>
> "WARNING: Secure coding is not enabled for restorable state! Enable secure
> coding by implementing
> NSApplicationDelega
On Wed, 8 Nov 2023 19:49:48 GMT, Harshitha Onkar wrote:
> With Xcode upgraded to 14.3.1 for macOS builds secure coding warning message
> was seen in the logs as below:
>
> "WARNING: Secure coding is not enabled for restorable state! Enable secure
> coding by implementing
> NSApplicationDelega
On Wed, 8 Nov 2023 19:49:48 GMT, Harshitha Onkar wrote:
> With Xcode upgraded to 14.3.1 for macOS builds secure coding warning message
> was seen in the logs as below:
>
> "WARNING: Secure coding is not enabled for restorable state! Enable secure
> coding by implementing
> NSApplicationDelega
With Xcode upgraded to 14.3.1 for macOS builds secure coding warning message
was seen in the logs as below:
"WARNING: Secure coding is not enabled for restorable state! Enable secure
coding by implementing
NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning
YES."
whi
On Thu, 9 Nov 2023 18:42:24 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
On Thu, 9 Nov 2023 15:33:57 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix for custom renderer
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line
> 201:
>
>>
> The issue exist only for non-editable combobox and the root cause is
> accessible object is not created due to incorrect index returned from
> component class which results in no a11y API invoked.
>
> Proposed solution is to return the correct accessible child from
> getAccessibleChild method
On Thu, 9 Nov 2023 18:21:02 GMT, Abhishek Kumar wrote:
> > I wonder if it makes sense to resolve warnings about raw classes.
>
> I didn't get this. Which warnings need to be resolved?
test/jdk/javax/swing/JComboBox/6567433/UpdateUIRecursionTest.java:61: warning:
[unchecked] unchecked call to
On Thu, 9 Nov 2023 15:50:20 GMT, Alexey Ivanov wrote:
> I wonder if it makes sense to resolve warnings about raw classes.
I didn't get this. Which warnings need to be resolved?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1388415539
On Thu, 9 Nov 2023 18:12:44 GMT, Abhishek Kumar wrote:
> So, I need to revert the changes that is done in the current commit and just
> add the bug id 8283214... right?
Yes, that's right.
-
PR Comment: https://git.openjdk.org/jdk/pull/14497#issuecomment-1804323444
On Thu, 9 Nov 2023 17:48:04 GMT, Alexey Ivanov wrote:
> > > Ideally, I'd like to make Aqua L&F classes work like Metal or Nimbus do. …
> >
> >
> > This way gets the accessible name _lazily_: it's requested only _when
> > needed_. Therefore you should submit another bug to address the limitatio
On Thu, 9 Nov 2023 04:39:32 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
On Thu, 9 Nov 2023 04:36:08 GMT, Abhishek Kumar wrote:
> Observed a test failure (regression) while running the CI jobs with the fix.
The failed test is `javax/swing/JComboBox/6567433/UpdateUIRecursionTest.java`.
It fails with `NullPointerException` because `PropertyChangeListener` in
`AquaCom
On Thu, 9 Nov 2023 04:39:32 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
36 matches
Mail list logo
