On Fri, 15 Mar 2024 15:42:42 GMT, Alexey Ivanov wrote:
>> 'Clear log' button calling logClear().
>
> @lawrence-andrew I can't see much value…
>
> Capturing logs by a screenshot is not something that you should ever do —
> copy the messages and paste them as text into a bug report.
>
> However,
On Fri, 15 Mar 2024 15:21:23 GMT, Alexander Zvegintsev
wrote:
>> It could be obvious from the usage… so we may skip the header altogether… if
>> it's mentioned in the instructions, which should still be mentioned to let
>> the test know they need to look for the messages.
>
>> Placeholder text
On Fri, 15 Mar 2024 15:05:28 GMT, Alexey Ivanov wrote:
>> I keep it for consistency across builder methods, e.g. `screenCapture` does
>> not need to specify it either.
>
> Okay. Most methods of the builder use `this.` prefix when assigning something
> to a field.
How about having a clear log b
On Fri, 15 Mar 2024 15:34:27 GMT, lawrence.andrews wrote:
>> How about having a clear log button. Just an idea
>> Example :
>> I have a mouse event test & I am using the logArea to add all the events
>> into it. But when I have to file a bug & I wanted to show only the required
>> log in the l
On Thu, 14 Mar 2024 16:04:50 GMT, Tejesh R wrote:
>> test/jdk/sun/java2d/loops/CopyAreaSpeed.java line 131:
>>
>>> 129: }
>>> 130: try {
>>> 131: Thread.sleep(1);
>>
>> I know it is an old code but i just wonder why do we add sleep to every
>> iteration
On Thu, 14 Mar 2024 10:39:15 GMT, Tejesh R wrote:
> Convert sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based
> using PassFailJFrame. This is a performance measurement test which provide
> benchmark to compare the outcome with different releases. I have converted
> the test
On Fri, 15 Mar 2024 15:33:30 GMT, lawrence.andrews wrote:
>> Okay. Most methods of the builder use `this.` prefix when assigning
>> something to a field.
>
> How about having a clear log button. Just an idea
> Example :
> I have a mouse event test & I am using the logArea to add all the events
On Fri, 15 Mar 2024 14:15:12 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 489:
>>
>>> 487:
>>> 488: buttonsLogPanel.add(buttonsPanel);
>>> 489: buttonsLogPanel.add(new JScrollPane(logArea));
>>
>> Suggestion:
>>
>>
On Fri, 15 Mar 2024 15:02:27 GMT, Alexey Ivanov wrote:
>> I expected the label to be aligned to the left. For this to happen, the
>> label may need to wrapped into another panel or horizontal box with added
>> glue.
>>
>>
>>
>> Box logLabelBox = Box.createHorizontalBox();
>>
On Fri, 15 Mar 2024 12:13:52 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyanga
On Fri, 15 Mar 2024 14:59:07 GMT, Alexey Ivanov wrote:
>> This doesn't look good to me
>> 
>>
>> So how about a placeholder text? It will not take up any of the height of
>> the window.
>>
>>  and
> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
> regression test for
> [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).
>
> I referenced this test in PR #17
On Fri, 15 Mar 2024 04:40:14 GMT, Alexander Zvegintsev
wrote:
> Often manual tests have a text area in the instruction window to print
> feedback from the test to be evaluated by a tester.
> I stumbled across another test that needed this, so I decided to make these
> changes a standard featur
On Fri, 15 Mar 2024 13:11:06 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 406:
>>
>>> 404:rows, columns,
>>> 405:enableScreenCapture,
>>> 406:
On Fri, 15 Mar 2024 04:40:35 GMT, Alexander Zvegintsev
wrote:
>> Often manual tests have a text area in the instruction window to print
>> feedback from the test to be evaluated by a tester.
>> I stumbled across another test that needed this, so I decided to make these
>> changes a standard fe
On Fri, 15 Mar 2024 07:29:53 GMT, Abhishek Kumar wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Marked as reviewed by azvegint (Reviewer).
test/jdk/javax/swing/JSlider/bug6587742.java line 30:
> 28: * @build PassFailJFrame
> 29: * @run main/m
On Fri, 15 Mar 2024 12:07:49 GMT, Jie Fu wrote:
> Please review this trivial change.
> Thanks.
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18326#pullrequestreview-1938858286
On Fri, 15 Mar 2024 12:38:23 GMT, Alexander Zvegintsev
wrote:
>> Please review this trivial change.
>> Thanks.
>
> Marked as reviewed by azvegint (Reviewer).
> Thanks @azvegint for the review.
Thank you for the fix
-
PR Comment: https://git.openjdk.org/jdk/pull/18326#issuecomment
On Fri, 15 Mar 2024 12:07:49 GMT, Jie Fu wrote:
> Please review this trivial change.
> Thanks.
This pull request has now been integrated.
Changeset: bf990c8b
Author:Jie Fu
URL:
https://git.openjdk.org/jdk/commit/bf990c8b32f1ce050450d94f4f8706e5a01aa3ec
Stats: 1 line in 1 file ch
On Fri, 15 Mar 2024 12:38:23 GMT, Alexander Zvegintsev
wrote:
>> Please review this trivial change.
>> Thanks.
>
> Marked as reviewed by azvegint (Reviewer).
Thanks @azvegint for the review.
-
PR Comment: https://git.openjdk.org/jdk/pull/18326#issuecomment-1999581499
On Thu, 14 Mar 2024 16:48:57 GMT, Alexander Zuev wrote:
>> Convert test to the automatic main and move it from its own folder since it
>> is no longer required.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor updat
> Hi Reviewers,
>
> I have updated the test with PassFailJFrame with information panel, earlier
> this was informed through terminal.
> Please review and let me know your suggestions if any.
Renjith Kannath Pariyangad has updated the pull request incrementally with two
additional commits since
Please review this trivial change.
Thanks.
-
Commit messages:
- 8328269: NonFocusablePopupMenuTest.java should be marked as headful
Changes: https://git.openjdk.org/jdk/pull/18326/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18326&range=00
Issue: https://bugs.openjdk.o
On Thu, 14 Mar 2024 19:57:06 GMT, Sergey Bylokhov wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Store the size of fileCache inside synchronized block
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/Bas
On Thu, 14 Mar 2024 19:37:30 GMT, Sergey Bylokhov wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add copyright header
>
> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java
> line 99
On Fri, 15 Mar 2024 10:53:06 GMT, Alexey Ivanov wrote:
> > I added it to our testing. Results early next week.
>
> @RealCLanger Thank you. I'm more interested in the failing case. How reliable
> does the test reproduce the problem?
Yes, it's running in 21 and 22 as well, so we'll see what happ
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
jtreg manual tag update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/183
On Thu, 14 Mar 2024 19:38:48 GMT, Sergey Bylokhov wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add copyright header
>
> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java
> line 21
Conversion of manual applet test to main based using PassFailJFrame manual
framework
-
Commit messages:
- whitespace fix
- Applet test converted to main manual
Changes: https://git.openjdk.org/jdk/pull/18325/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18325&range=00
> I'm adding a regression test for
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
> regression test for
> [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).
>
> I referenced this test in PR #17
On Fri, 15 Mar 2024 10:53:14 GMT, Tejesh R wrote:
>> @TejeshR13 What do you mean? What kind of line spacing would be nice here?
>
> Line spacing between JTREG tag and class.
It's not needed… but most people add it. And we cannot agree on *a common
style*, unfortunately.
These jtreg tags are ak
On Thu, 14 Mar 2024 19:37:48 GMT, Sergey Bylokhov wrote:
>> I'm adding a regression test for
>> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
>> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
>> regression test for
>> [JDK-8240690](https://bugs.openjd
On Fri, 15 Mar 2024 07:17:59 GMT, Christoph Langer wrote:
> I added it to our testing. Results early next week.
@RealCLanger Thank you. I'm more interested in the failing case. How reliable
does the test reproduce the problem?
-
PR Comment: https://git.openjdk.org/jdk/pull/18109#i
On Fri, 15 Mar 2024 10:50:18 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 45:
>>
>>> 43: * @build PassFailJFrame
>>> 44: * @run main/manual/othervm -Djava.security.manager=allow
>>> SecurityDialogTest
>>> 45: */
>>
>> Line spacing here would b
On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyanga
On Fri, 15 Mar 2024 03:33:50 GMT, Tejesh R wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Added summary
>
> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 45:
>
>> 43: * @build Pas
On Wed, 13 Mar 2024 13:26:46 GMT, Abhishek Kumar wrote:
> Conversion of manual applet test to automated test. CI testing is green. Link
> attached to JBS.
This pull request has now been integrated.
Changeset: 5249cc0a
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/52
On Fri, 15 Mar 2024 06:45:57 GMT, Tejesh R wrote:
>> Most of the test with PassFailJFrame instruction stored as string inside
>> class, what additional benefit will get keeping it inside Main ?
>
> When it can become local variable then why to keep it in class? Not like
> significant benefit ma
On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyanga
On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyanga
On Thu, 14 Mar 2024 18:05:11 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to automated test. CI testing is green.
>> Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor update
M
On Wed, 13 Mar 2024 06:49:16 GMT, Alexander Zuev wrote:
> Cleaned up five more tests.
>
> Continuation of https://github.com/openjdk/jdk/pull/18184
>
> Unfortunately one of the commits rendered the whole PR invalid so i closed it
> and restarting it here.
> All comments from the previous revie
On Thu, 14 Mar 2024 12:27:29 GMT, Alexander Zuev wrote:
> Convert test to the automatic main and move it from its own folder since it
> is no longer required.
This pull request has now been integrated.
Changeset: b8dfeafd
Author:Alexander Zuev
URL:
https://git.openjdk.org/jdk/commi
On Fri, 15 Mar 2024 03:33:24 GMT, Tejesh R wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Added summary
>
> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 43:
>
>> 41: * @key print
> Hi Reviewers,
>
> I have updated the test with PassFailJFrame with information panel, earlier
> this was informed through terminal.
> Please review and let me know your suggestions if any.
Renjith Kannath Pariyangad has updated the pull request incrementally with one
additional commit since
On Fri, 15 Mar 2024 07:16:31 GMT, Tejesh R wrote:
> Looks good to me. Does this work fine in other L&F (Like Aqua), because you
> have explicitly mentioned as Metal right?
The older version of applet test also checks for MetalLookAndFeel. Since the
test is just converted to main manual, didn't
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
jtreg manual tag update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/182
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
jtreg manual tag update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/183
Conversion of manual applet test to main based using PassFailJFrame manual
framework
-
Commit messages:
- Applet test converted to main manual
Changes: https://git.openjdk.org/jdk/pull/18323/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18323&range=00
Issue: https://bu
Few tests were converted from applet manual to main using PassFailJFrame manual
framework but the extra folder was not deleted
javax/swing/JFileChooser/6798062/bug6798062.java
javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.html
javax/swing/JInternalFrame/6726866/bug6726866.j
On Fri, 15 Mar 2024 07:20:30 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 67:
>>
>>> 65: }
>>> 66:
>>> 67: PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
>>
>> I am getting an error for using new `PassF
On Fri, 15 Mar 2024 03:43:13 GMT, Tejesh R wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> test/jdk/java/awt/print/PrinterJob/SecurityD
On Thu, 14 Mar 2024 18:05:11 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to automated test. CI testing is green.
>> Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor update
L
On Mon, 11 Mar 2024 19:16:21 GMT, Alexey Ivanov wrote:
> @mrserb, @RealCLanger, could you run this test in your environments, please?
> It is for Linux and macOS only.
>
> I'm looking for confirmation that the test fails without the fix for
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8
On Fri, 15 Mar 2024 03:17:07 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Ninor update
Ma
58 matches
Mail list logo
