On Wed, 17 Jul 2024 05:33:54 GMT, Jaikiran Pai wrote:
> This brings the CPU24_07 changes into jdk23 branch.
Marked as reviewed by djelinski (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20212#pullrequestreview-2181924794
On Wed, 17 Jul 2024 05:33:15 GMT, Jaikiran Pai wrote:
> This brings in CPU24_07 changes into master branch
Marked as reviewed by djelinski (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20211#pullrequestreview-2181924404
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Wed, 12 Jun 2024 04:58:47 GMT, Abhishek Kumar wrote:
> Looks like there was a typo for null character. It should be `'\0'` instead
> of `'/0'`.
> Build with clang toolchain with the help of [this
> PR](https://github.com/openjdk/jdk/pull/17019) and after the changes there is
> no warning.
On Fri, 29 Mar 2024 18:23:27 GMT, Daniel Jeliński wrote:
> Please review this PR that removes unused functions, variables, and WM_AWT
> window messages.
>
> The unused code was detected by automated analysis (MSVC compiler and linker,
> CodeQL analyzer). I manually verifi
g clean.
>
> Some WM_AWT messages have different IDs after this change. The IDs have
> changed a few times before, so I think this shouldn't be a problem.
Daniel Jeliński has updated the pull request incrementally with two additional
commits since the last revision:
- Up
On Tue, 2 Apr 2024 12:50:33 GMT, Alexey Ivanov wrote:
>> Please review this PR that removes unused functions, variables, and WM_AWT
>> window messages.
>>
>> The unused code was detected by automated analysis (MSVC compiler and
>> linker, CodeQL analyzer). I manually verified every symbol befo
On Fri, 29 Mar 2024 18:23:27 GMT, Daniel Jeliński wrote:
> Please review this PR that removes unused functions, variables, and WM_AWT
> window messages.
>
> The unused code was detected by automated analysis (MSVC compiler and linker,
> CodeQL analyzer). I manually verifi
On Fri, 29 Mar 2024 21:51:25 GMT, Phil Race wrote:
> About the WM_AWT messages, how did these tools you mention figure out no
> message of that name / ID is ever created ?
I presume that's what you must have done to decide it is OK to remove the
handling of these messages.
Well, that part was
Please review this PR that removes unused functions, variables, and WM_AWT
window messages.
The unused code was detected by automated analysis (MSVC compiler and linker,
CodeQL analyzer). I manually verified every symbol before removing. Mach5
client libs testing clean.
Some WM_AWT messages ha
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote:
>> The idea of setting up general "toolchains" in the native build was good,
>> but it turned out that we really only need a single toolchain, with a single
>> twist: if it should use CC or CPP to link. This is better described by a
>
On Mon, 26 Feb 2024 20:21:55 GMT, Magnus Ihse Bursie wrote:
>> The idea of setting up general "toolchains" in the native build was good,
>> but it turned out that we really only need a single toolchain, with a single
>> twist: if it should use CC or CPP to link. This is better described by a
>
On Thu, 7 Dec 2023 09:47:16 GMT, Daniel Jeliński wrote:
> This PR fixes a typo in exception message printed when `jdk.readPollers` or
> `jdk.writePollers` is not a power of two.
>
> While at it, I searched the code for other instances of `vale`, and corrected
> them as well.
On Thu, 7 Dec 2023 09:47:16 GMT, Daniel Jeliński wrote:
> This PR fixes a typo in exception message printed when `jdk.readPollers` or
> `jdk.writePollers` is not a power of two.
>
> While at it, I searched the code for other instances of `vale`, and corrected
> them as w
This PR fixes a typo in exception message printed when `jdk.readPollers` or
`jdk.writePollers` is not a power of two.
While at it, I searched the code for other instances of `vale`, and corrected
them as well.
-
Commit messages:
- Fix vale->value
Changes: https://git.openjdk.org/
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my mach
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my mach
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my mach
On Mon, 6 Nov 2023 13:09:08 GMT, Daniel Jeliński wrote:
>> @djelinski Just curious; what would the effect be to both include this
>> change and setting the NO_* defines?
>>
>> If all the references to these defines are made in the excluded files then
>> the only
On Mon, 6 Nov 2023 12:26:58 GMT, Magnus Ihse Bursie wrote:
>> FWIW, I compiled the code without this PR, but with `HARFBUZZ_CFLAGS +=
>> -DHB_NO_SUBSET_LAYOUT -DHB_NO_SUBSET_CFF` instead, and checked `make
>> LOG=profile` output. Results:
>> - without this change, compiling `hb-subset.cc` took
On Wed, 1 Nov 2023 21:31:02 GMT, Daniel Jeliński wrote:
>> These two
>> #define HB_NO_SUBSET_LAYOUT
>> #define HB_NO_SUBSET_CFF
>
> You can find the file here:
> https://github.com/openjdk/jdk/blob/f262f06c97b9ea94cd6119b3a8beb16bf804d083/src/java.desktop/share/native
On Wed, 1 Nov 2023 18:52:15 GMT, Phil Race wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 499:
>>
>>> 497:LIBFONTMANAGER_EXCLUDE_FILES += hb-ft.cc hb-subset-cff-common.cc \
>>> 498:hb-subset-cff1.cc hb-subset-cff2.cc hb-subset-input.cc
>>> hb-subset-plan.cc \
>>> 49
hb-subset and hb-style APIs are not used and not exported by libfontmanger. We
can cut the compilation time by not compiling the unused files.
The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
This is with harfbuzz 8, with harfbuzz 7 the improvement was ~30 seconds.
C
On Thu, 26 Oct 2023 06:56:16 GMT, Daniel Jeliński wrote:
> The removed functions are empty on all platforms.
>
> This patch also removes calls to `Toolkit.loadLibraries();` in classes that
> no longer have any native methods. The call was needed to ensure that the
> native
On Fri, 27 Oct 2023 10:26:26 GMT, Alexey Ivanov wrote:
>> The removed functions are empty on all platforms.
>>
>> This patch also removes calls to `Toolkit.loadLibraries();` in classes that
>> no longer have any native methods. The call was needed to ensure that the
>> native awt library is lo
The removed functions are empty on all platforms.
This patch also removes calls to `Toolkit.loadLibraries();` in classes that no
longer have any native methods. The call was needed to ensure that the native
awt library is loaded.
Client libs tests passed.
-
Commit messages:
- Rem
On Fri, 31 Mar 2023 07:34:50 GMT, Daniel Jeliński wrote:
> Please review this patch that removes a number of unused exports from
> java.desktop native libraries.
>
> In most cases I removed JNIEXPORT from methods and variables that are only
> used within a single shared libr
On Wed, 25 Oct 2023 23:23:19 GMT, Phil Race wrote:
>> Daniel Jeliński has updated the pull request incrementally with seven
>> additional commits since the last revision:
>>
>> - Revert "Remove Color_initIDs"
>>
>>This reverts c
On Fri, 13 Oct 2023 15:19:53 GMT, Daniel Jeliński wrote:
>> Please review this patch that removes a number of unused exports from
>> java.desktop native libraries.
>>
>> In most cases I removed JNIEXPORT from methods and variables that are only
>> used within
On Fri, 13 Oct 2023 15:19:53 GMT, Daniel Jeliński wrote:
>> Please review this patch that removes a number of unused exports from
>> java.desktop native libraries.
>>
>> In most cases I removed JNIEXPORT from methods and variables that are only
>> used within
On Fri, 13 Oct 2023 15:03:30 GMT, Alexey Ivanov wrote:
>> Ok, I'll revert the initIDs removals, and will file a follow-up PR once this
>> one is merged.
>
>> …will file a follow-up PR once this one is merged
>
> You can submit it right away, so that we'll not forget about it.
Filed [JDK-831809
tils`.
>
> Manually verified that the exports are no longer present after these changes.
> Tier1-3 and client libs tests still pass.
Daniel Jeliński has updated the pull request incrementally with seven
additional commits since the last revision:
- Revert "Remove Color_initI
On Fri, 13 Oct 2023 14:50:03 GMT, Alexey Ivanov wrote:
>> Sounds reasonable. Should I move the cleanup of Color as well?
>
>> Should I move the cleanup of Color as well?
>
> Removing `colorValueID` could be left here, I think: it removes an exported
> symbol which is no longer used.
>
> In add
On Fri, 13 Oct 2023 14:27:07 GMT, Alexey Ivanov wrote:
>> Found and removed a few more initIDs methods that were empty on all
>> platforms.
>
>> Found and removed a few more initIDs methods that were empty on all
>> platforms.
>
> It could be a better idea to move this clean up to a separate b
On Fri, 13 Oct 2023 07:02:16 GMT, Daniel Jeliński wrote:
>> src/java.desktop/unix/native/libawt/awt/initIDs.c line 47:
>>
>>> 45: (JNIEnv *env, jclass clazz)
>>> 46: {
>>> 47: }
>>
>> Shall we remove `Color.initIDs`? Its implementation is
On Thu, 5 Oct 2023 16:29:26 GMT, Daniel Jeliński wrote:
>> Please review this patch that removes a number of unused exports from
>> java.desktop native libraries.
>>
>> In most cases I removed JNIEXPORT from methods and variables that are only
>> used within
tils`.
>
> Manually verified that the exports are no longer present after these changes.
> Tier1-3 and client libs tests still pass.
Daniel Jeliński has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
br
On Fri, 13 Oct 2023 07:01:08 GMT, Daniel Jeliński wrote:
>> I totally understand this. However, Windows specific symbols:
>>
>>98 000380A0 GDIWinSD_InitDC
>> 109 000385F0 GDIWindowSurfaceData_GetComp
>> 11A 000386
On Wed, 11 Oct 2023 17:28:07 GMT, Alexey Ivanov wrote:
>> Daniel Jeliński has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Thu, 12 Oct 2023 10:00:15 GMT, Alexey Ivanov wrote:
>> Keep in mind that on Linux libawt is split into libawt, libawt_headless and
>> libawt_xawt, and the export/import dependencies are different.
>
> I totally understand this. However, Windows specific symbols:
>
>98 000380A
On Thu, 5 Oct 2023 16:29:26 GMT, Daniel Jeliński wrote:
>> Please review this patch that removes a number of unused exports from
>> java.desktop native libraries.
>>
>> In most cases I removed JNIEXPORT from methods and variables that are only
>> used within
On Wed, 11 Oct 2023 16:38:16 GMT, Alexey Ivanov wrote:
>> Daniel Jeliński has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Mon, 9 Oct 2023 15:01:41 GMT, Jan Kratochvil wrote:
>> `--with-toolchain-type=clang` fails the compilation for me with
>> `clang-16.0.6-3.fc38.x86_64`
>>
>> While the warnings can be disabled I find better to just fix them. The GTK
>> prototypes in JDK reported by clang are either missing o
On Sat, 7 Oct 2023 16:24:29 GMT, Jan Kratochvil wrote:
> `--with-toolchain-type=clang` fails the compilation for me with
> `clang-16.0.6-3.fc38.x86_64`
>
> While the warnings can be disabled I find better to just fix them. The GTK
> prototypes in JDK reported by clang are either missing or wro
tils`.
>
> Manually verified that the exports are no longer present after these changes.
> Tier1-3 and client libs tests still pass.
Daniel Jeliński has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated chang
On Tue, 8 Aug 2023 18:28:36 GMT, Erik Joelsson wrote:
> it's unfortunate that we need to repeat so much.
Right. The default make convention uses `CPPFLAGS` for flags shared between
preprocessor and both C and C++ compilers. We don't have any shared variable as
far as I could tell.
Thanks for t
On Mon, 3 Jul 2023 17:15:17 GMT, Daniel Jeliński wrote:
> Please review this patch that configures C++ arguments on build jobs that
> involve compiling CPP files. As a result of this change, CPP files are
> compiled with `-std:c++14` command line argument instead of `-std:c11`, wh
On Mon, 3 Jul 2023 17:15:17 GMT, Daniel Jeliński wrote:
> Please review this patch that configures C++ arguments on build jobs that
> involve compiling CPP files. As a result of this change, CPP files are
> compiled with `-std:c++14` command line argument instead of `-std:c11`, wh
On Mon, 3 Jul 2023 20:17:23 GMT, Alexey Ivanov wrote:
>> Please review this patch that configures C++ arguments on build jobs that
>> involve compiling CPP files. As a result of this change, CPP files are
>> compiled with `-std:c++14` command line argument instead of `-std:c11`,
>> which is us
Please review this patch that configures C++ arguments on build jobs that
involve compiling CPP files. As a result of this change, CPP files are compiled
with `-std:c++14` command line argument instead of `-std:c11`, which is used
when C++ arguments are not configured.
While at it, I simplified
On Fri, 23 Jun 2023 08:03:45 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit sin
On Fri, 23 Jun 2023 02:38:13 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Thu, 22 Jun 2023 09:58:19 GMT, Daniel Jeliński wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> make/modules/java.desktop/lib/Awt2dLib
On Thu, 22 Jun 2023 14:40:23 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Thu, 22 Jun 2023 14:23:25 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Thu, 22 Jun 2023 13:48:53 GMT, Julian Waters wrote:
>> src/jdk.accessibility/windows/native/jaccesswalker/jaccesswalker.cpp line
>> 547:
>>
>>> 545: snprintf( s, sizeof(s),
>>> 546: "ERROR calling GetAccessibleContextInfo; vmID = %lX,
>>> context = %p",
>>> 547:
On Thu, 22 Jun 2023 03:00:16 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Thu, 22 Jun 2023 09:13:21 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit sin
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request with a new target base due to a
> merge or a r
On Wed, 21 Jun 2023 05:32:46 GMT, Julian Waters wrote:
>> In windowsaccessbridge(-64).dll the following methods are exported in a def
>> file to C API which in turn call their real implementation, which are
>> instance methods of the class WinAccessBridge:
>>
>> addJavaEventNotification
>> rem
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
According to our docs, [clang is a supported compiler for
Linux](https://github.com/openjdk/jdk
tils`.
>
> Manually verified that the exports are no longer present after these changes.
> Tier1-3 and client libs tests still pass.
Daniel Jeliński has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated change
On Sat, 29 Apr 2023 19:26:00 GMT, Julian Waters wrote:
> In windowsaccessbridge(-64).dll the following methods are exported in a def
> file to C API which in turn call their real implementation, which are
> instance methods of the class WinAccessBridge:
>
> addJavaEventNotification
> removeJav
On Tue, 18 Apr 2023 11:59:44 GMT, Daniel Jeliński wrote:
> Please review this patch that disables a warning that appeared on linux
> builds in slowdebug configuration after
> [JDK-8299592](https://bugs.openjdk.org/browse/JDK-8299592).
>
> I plan to investigate why this failure
On Tue, 18 Apr 2023 11:59:44 GMT, Daniel Jeliński wrote:
> Please review this patch that disables a warning that appeared on linux
> builds in slowdebug configuration after
> [JDK-8299592](https://bugs.openjdk.org/browse/JDK-8299592).
>
> I plan to investigate why this failure
On Tue, 18 Apr 2023 11:59:44 GMT, Daniel Jeliński wrote:
> Please review this patch that disables a warning that appeared on linux
> builds in slowdebug configuration after
> [JDK-8299592](https://bugs.openjdk.org/browse/JDK-8299592).
>
> I plan to investigate why this failure
Please review this patch that disables a warning that appeared on linux builds
in slowdebug configuration after
[JDK-8299592](https://bugs.openjdk.org/browse/JDK-8299592).
I plan to investigate why this failure appears only in slowdebug mode; this
patch is intended to unblock the CI.
Verified
On Thu, 13 Apr 2023 07:13:39 GMT, Daniel Jeliński wrote:
>> Please review this patch that fixes and re-enables a few warnings in libawt
>> compilation.
>>
>> Verified that debug and release builds finish successfully on Win, Mac and
>> Linux. Also verified tha
On Wed, 4 Jan 2023 12:44:39 GMT, Daniel Jeliński wrote:
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs tests st
On Wed, 12 Apr 2023 20:29:19 GMT, Alexey Ivanov wrote:
>> Daniel Jeliński has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 10 commits:
>>
>> - Merge remote-tracking branch 'origin' into awt-
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs tests still pass.
Daniel Jeliński has updated the pull request inc
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs tests still pass.
Daniel Jeliński has updated the pull request wi
Please review this patch that removes a number of unused exports from
java.desktop native libraries.
In most cases I removed JNIEXPORT from methods and variables that are only used
within a single shared library. Other than that:
- removed `getSunFontIDs` that was reportedly used by rasterizer;
On Fri, 20 Jan 2023 12:01:06 GMT, Daniel Jeliński wrote:
>> Please review this patch that fixes and re-enables a few warnings in libawt
>> compilation.
>>
>> Verified that debug and release builds finish successfully on Win, Mac and
>> Linux. Also verified tha
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs tests still pass.
Daniel Jeliński has updated the pull request wi
On Wed, 4 Jan 2023 12:44:39 GMT, Daniel Jeliński wrote:
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs tests
On Tue, 17 Jan 2023 07:43:41 GMT, Daniel Jeliński wrote:
> Please review this patch that fixes memory leaks in native code.
>
> The call to `ReleaseXXArrayElements` with `JNI_COMMIT` parameter does not
> release the native buffer allocated by the previous `GetXXArrayElements`
Please review this patch that fixes memory leaks in native code.
The call to `ReleaseXXArrayElements` with `JNI_COMMIT` parameter does not
release the native buffer allocated by the previous `GetXXArrayElements` call.
The buffer pointers were only stored in local variables and were lost on
func
On Thu, 22 Dec 2022 10:01:02 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from awt.dll.
>
> The exports were introduced in e4c9db984fe1a3a9d06fb60e333e92df3b165454, and
> as far as I could tell, they were never used; the exported functi
On Thu, 22 Dec 2022 10:01:02 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from awt.dll.
>
> The exports were introduced in e4c9db984fe1a3a9d06fb60e333e92df3b165454, and
> as far as I could tell, they were never used; the exported functi
Please review this patch that fixes and re-enables a few warnings in libawt
compilation.
Verified that debug and release builds finish successfully on Win, Mac and
Linux. Also verified that client libs tests still pass.
-
Commit messages:
- Copyright
- snprintf
- cl analyze
- F
On Thu, 22 Dec 2022 10:01:02 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from awt.dll.
>
> The exports were introduced in e4c9db984fe1a3a9d06fb60e333e92df3b165454, and
> as far as I could tell, they were never used; the exported functi
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from libawt and
> libfreetype.
>
> Verified that:
> - mach5 client libs tests pass
> - both release and debug builds finish successfully
This pull re
Please review this patch that removes unnecessary exports from awt.dll.
The exports were introduced in e4c9db984fe1a3a9d06fb60e333e92df3b165454, and as
far as I could tell, they were never used; the exported functions are only used
inside awt.dll.
Verified that:
- debug and release builds finis
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from libawt and
> libfreetype.
>
> Verified that:
> - mach5 client libs tests pass
> - both release and debug builds finish successfully
>
> Did not
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from libawt and
> libfreetype.
>
> Verified that:
> - mach5 client libs tests pass
> - both release and debug builds finish successfully
>
> Did not
Please review this patch that removes unnecessary exports from libawt and
libfreetype.
Verified that:
- mach5 client libs tests pass
- both release and debug builds finish successfully
Did not verify the other issues reported in the linked JBS ticket.
-
Commit messages:
- Export s
On Tue, 30 Aug 2022 12:08:09 GMT, Daniel Jeliński wrote:
> Fix compilation with Zc:preprocessor enabled.
>
> The flag itself will be enabled in
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the
> flag using instructions found in Magnus's c
On Tue, 30 Aug 2022 12:08:09 GMT, Daniel Jeliński wrote:
> Fix compilation with Zc:preprocessor enabled.
>
> The flag itself will be enabled in
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the
> flag using instructions found in Magnus's c
On Tue, 30 Aug 2022 12:08:09 GMT, Daniel Jeliński wrote:
> Fix compilation with Zc:preprocessor enabled.
>
> The flag itself will be enabled in
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the
> flag using instructions found in Magnus's c
On Tue, 30 Aug 2022 12:08:09 GMT, Daniel Jeliński wrote:
> Fix compilation with Zc:preprocessor enabled.
>
> The flag itself will be enabled in
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the
> flag using instructions found in Magnus's c
Fix compilation with Zc:preprocessor enabled.
The flag itself will be enabled in
[JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the flag
using instructions found in Magnus's comment on that issue.
Windows 10 SDK version 2104 (10.0.20348.0) is required for successful
com
On Thu, 11 Aug 2022 09:56:29 GMT, Daniel Jeliński wrote:
> Remove `java.base:include` from `EXTRA_HEADER_DIRS`.
>
> The directory contains base versions of the files present in
> `/support/modules_include/java.base`; the latter is automatically
> [included in every JDK library
Remove `java.base:include` from `EXTRA_HEADER_DIRS`.
The directory contains base versions of the files present in
`/support/modules_include/java.base`; the latter is automatically
[included in every JDK library
build](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L434
96 matches
Mail list logo
