Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-25 Thread Alexey Ivanov
On Mon, 25 Sep 2023 06:53:49 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 55: >> >>> 53: for (UIManager.LookAndFeelInfo laf : >>> UIManager.getInstalledLookAndFeels()) { >>> 54: System.out.println("Testing L&F: " + laf)

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v4]

2023-09-25 Thread Alexey Ivanov
On Mon, 25 Sep 2023 07:00:38 GMT, Prasanta Sadhukhan wrote: >> After the first time a JTableHeader is serialized, it no longer will >> uninstall its UI upon subsequent serializations. >> This happens for classes that use the BasicTableHeaderUI class. Any LAF that >> extends the BasicTableHeade

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-25 Thread Prasanta Sadhukhan
On Fri, 22 Sep 2023 11:53:30 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> try-with-resource use > > test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 55: > >> 53:

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v4]

2023-09-25 Thread Prasanta Sadhukhan
> After the first time a JTableHeader is serialized, it no longer will > uninstall its UI upon subsequent serializations. > This happens for classes that use the BasicTableHeaderUI class. Any LAF that > extends the BasicTableHeaderUI like SynthTableHeaderUI and > WindowsTableHeaderUI will get an

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-22 Thread Alexey Ivanov
On Fri, 22 Sep 2023 07:12:08 GMT, Prasanta Sadhukhan wrote: > I guess in test, resource leak probably wouldn't matter… No, it wouldn't. Yet someone could later copy the code and use file streams where closing the streams matters. Always following the pattern is safer. - PR Review

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-22 Thread Alexey Ivanov
On Fri, 22 Sep 2023 07:18:09 GMT, Prasanta Sadhukhan wrote: >> After the first time a JTableHeader is serialized, it no longer will >> uninstall its UI upon subsequent serializations. >> This happens for classes that use the BasicTableHeaderUI class. Any LAF that >> extends the BasicTableHeade

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-22 Thread Prasanta Sadhukhan
On Mon, 11 Sep 2023 19:05:25 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> try-with-resource use > > test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 46: > >> 44:

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-22 Thread Prasanta Sadhukhan
> After the first time a JTableHeader is serialized, it no longer will > uninstall its UI upon subsequent serializations. > This happens for classes that use the BasicTableHeaderUI class. Any LAF that > extends the BasicTableHeaderUI like SynthTableHeaderUI and > WindowsTableHeaderUI will get an

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v2]

2023-09-21 Thread Prasanta Sadhukhan
> After the first time a JTableHeader is serialized, it no longer will > uninstall its UI upon subsequent serializations. > This happens for classes that use the BasicTableHeaderUI class. Any LAF that > extends the BasicTableHeaderUI like SynthTableHeaderUI and > WindowsTableHeaderUI will get an

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI

2023-09-11 Thread Alexey Ivanov
On Thu, 31 Aug 2023 08:02:35 GMT, Prasanta Sadhukhan wrote: > After the first time a JTableHeader is serialized, it no longer will > uninstall its UI upon subsequent serializations. > This happens for classes that use the BasicTableHeaderUI class. Any LAF that > extends the BasicTableHeaderUI

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI

2023-09-01 Thread Damon Nguyen
On Thu, 31 Aug 2023 08:02:35 GMT, Prasanta Sadhukhan wrote: > After the first time a JTableHeader is serialized, it no longer will > uninstall its UI upon subsequent serializations. > This happens for classes that use the BasicTableHeaderUI class. Any LAF that > extends the BasicTableHeaderUI

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI

2023-08-31 Thread lawrence . andrews
On Thu, 31 Aug 2023 16:07:03 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 47: >> >>> 45: ByteArrayOutputStream baos = new >>> ByteArrayOutputStream(); >>> 46: ObjectOutputStream oos = new ObjectOutputStream(

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI

2023-08-31 Thread Prasanta Sadhukhan
On Thu, 31 Aug 2023 15:54:41 GMT, lawrence.andrews wrote: >> After the first time a JTableHeader is serialized, it no longer will >> uninstall its UI upon subsequent serializations. >> This happens for classes that use the BasicTableHeaderUI class. Any LAF that >> extends the BasicTableHeaderUI

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI

2023-08-31 Thread lawrence . andrews
On Thu, 31 Aug 2023 08:02:35 GMT, Prasanta Sadhukhan wrote: > After the first time a JTableHeader is serialized, it no longer will > uninstall its UI upon subsequent serializations. > This happens for classes that use the BasicTableHeaderUI class. Any LAF that > extends the BasicTableHeaderUI

RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI

2023-08-31 Thread Prasanta Sadhukhan
After the first time a JTableHeader is serialized, it no longer will uninstall its UI upon subsequent serializations. This happens for classes that use the BasicTableHeaderUI class. Any LAF that extends the BasicTableHeaderUI like SynthTableHeaderUI and WindowsTableHeaderUI will get an NotSerial