On Thu, 9 May 2024 19:56:40 GMT, Phil Race wrote:
> You are opening the test, but the bug ID is about the test failing. Why
> specifically did the test fail before and what about this version fixes that ?
The test needed some delays between mouse moves for stability. I accidentally
deleted a d
> Opening closed dnd test
> Test is green on all platforms
Alisen Chung has updated the pull request incrementally with two additional
commits since the last revision:
- extra newline after jtreg tags
- re-added delay
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19128/fil
On Thu, 9 May 2024 04:54:27 GMT, Abhishek Kumar wrote:
>> I'm not aware of this. I've normally seen newlines after the test tags, and
>> I use it in my tests without any comments. Not critical either way I
>> suppose. Maybe others know more precisely? @TejeshR13 @kumarabhi006 maybe?
>
> I use a
On Wed, 8 May 2024 19:15:10 GMT, Alisen Chung wrote:
>> Opening closed dnd test
>> Test is green on all platforms
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> button1_down_mask, dispose on edt, replace system err with ou
On Wed, 8 May 2024 19:15:10 GMT, Alisen Chung wrote:
>> Opening closed dnd test
>> Test is green on all platforms
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> button1_down_mask, dispose on edt, replace system err with ou
On Wed, 8 May 2024 21:21:47 GMT, Damon Nguyen wrote:
>> i thought the standard was to have no newline between the test tags and the
>> class declaration?
>
> I'm not aware of this. I've normally seen newlines after the test tags, and I
> use it in my tests without any comments. Not critical eit
On Wed, 8 May 2024 19:23:43 GMT, Alisen Chung wrote:
>> test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java
>> line 53:
>>
>>> 51: * @run main MouseEventAfterStartDragTest
>>> 52: */
>>> 53: public final class MouseEventAfterStartDragTest implements
>>> AWTEv
On Wed, 8 May 2024 19:17:05 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> button1_down_mask, dispose on edt, replace system err with out, frame
>> srcpoint and dimension access on edt
>
> test/
On Wed, 8 May 2024 19:15:10 GMT, Alisen Chung wrote:
>> Opening closed dnd test
>> Test is green on all platforms
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> button1_down_mask, dispose on edt, replace system err with ou
> Opening closed dnd test
> Test is green on all platforms
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
button1_down_mask, dispose on edt, replace system err with out, frame
srcpoint and dimension access on edt
-
Cha
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote:
> Opening closed dnd test
> Test is green on all platforms
test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java
line 132:
> 130:
> 131: final Point srcPoint = frame.getLocationOnScreen();
> 132:
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote:
> Opening closed dnd test
> Test is green on all platforms
test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java
line 190:
> 188: reset();
> 189: robot.mouseMove(p.x, p.y);
> 190: robot.
On Wed, 8 May 2024 05:29:49 GMT, Tejesh R wrote:
>> Opening closed dnd test
>> Test is green on all platforms
>
> test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java
> line 190:
>
>> 188: reset();
>> 189: robot.mouseMove(p.x, p.y);
>> 190:
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote:
> Opening closed dnd test
> Test is green on all platforms
test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java
line 169:
> 167:
> 168: public void dispose() {
> 169: frame.dispose();
Suggestion:
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote:
> Opening closed dnd test
> Test is green on all platforms
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19128#pullrequestreview-2044249314
15 matches
Mail list logo
