Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v4]

2023-10-25 Thread Alexey Ivanov
> This enhances the `Builder` pattern added in > [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method > `testUI` which allows passing a lambda expression or a method reference to > create *the test UI window*. > > The `PassFailJFrame` will automatically call the method o

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v3]

2023-10-24 Thread Phil Race
On Mon, 23 Oct 2023 20:40:14 GMT, Alexey Ivanov wrote: >> This enhances the `Builder` pattern added in >> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method >> `testUI` which allows passing a lambda expression or a method reference to >> create *the test UI window*. >

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v3]

2023-10-23 Thread Alexey Ivanov
On Mon, 23 Oct 2023 20:59:49 GMT, Alexey Ivanov wrote: >>> > Shouldn't we mention here a window added by `testUI` via builder? >>> >>> I don't think it's necessary: the builder uses `addTestWindow` under the >>> hood. It's the builder that requires documentation. >>> >>> In fact, the entire cl

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v3]

2023-10-23 Thread Alexey Ivanov
On Wed, 20 Sep 2023 18:12:25 GMT, Phil Race wrote: >>> Shouldn't we mention here a window added by `testUI` via builder? >> >> I don't think it's necessary: the builder uses `addTestWindow` under the >> hood. It's the builder that requires documentation. >> >> In fact, the entire class require

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v3]

2023-10-23 Thread Alexey Ivanov
> This enhances the `Builder` pattern added in > [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method > `testUI` which allows passing a lambda expression or a method reference to > create *the test UI window*. > > The `PassFailJFrame` will automatically call the method o

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]

2023-09-27 Thread Alexey Ivanov
On Wed, 13 Sep 2023 14:25:19 GMT, Alexey Ivanov wrote: >> This enhances the `Builder` pattern added in >> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method >> `testUI` which allows passing a lambda expression or a method reference to >> create *the test UI window*. >

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]

2023-09-27 Thread Alexey Ivanov
On Wed, 20 Sep 2023 18:12:25 GMT, Phil Race wrote: >>> Shouldn't we mention here a window added by `testUI` via builder? >> >> I don't think it's necessary: the builder uses `addTestWindow` under the >> hood. It's the builder that requires documentation. >> >> In fact, the entire class require

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]

2023-09-20 Thread Phil Race
On Tue, 12 Sep 2023 13:43:40 GMT, Alexey Ivanov wrote: > > Shouldn't we mention here a window added by `testUI` via builder? > > I don't think it's necessary: the builder uses `addTestWindow` under the > hood. It's the builder that requires documentation. > > In fact, the entire class requires

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]

2023-09-13 Thread Alexey Ivanov
On Tue, 12 Sep 2023 19:51:45 GMT, Alexey Ivanov wrote: >>> However, to test this case I'll need a (simple) scenario where multiple >>> windows are created. >> >> For example >> `test/jdk/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java` >> is not converted to use PassFailJ

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]

2023-09-13 Thread lawrence . andrews
On Wed, 13 Sep 2023 14:25:19 GMT, Alexey Ivanov wrote: >> This enhances the `Builder` pattern added in >> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method >> `testUI` which allows passing a lambda expression or a method reference to >> create *the test UI window*. >

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]

2023-09-13 Thread Alexey Ivanov
On Wed, 13 Sep 2023 14:25:19 GMT, Alexey Ivanov wrote: >> This enhances the `Builder` pattern added in >> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method >> `testUI` which allows passing a lambda expression or a method reference to >> create *the test UI window*. >

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]

2023-09-13 Thread Alexey Ivanov
> This enhances the `Builder` pattern added in > [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method > `testUI` which allows passing a lambda expression or a method reference to > create *the test UI window*. > > The `PassFailJFrame` will automatically call the method o

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI

2023-09-12 Thread Alexander Zvegintsev
On Mon, 11 Sep 2023 15:36:56 GMT, Alexey Ivanov wrote: > This enhances the `Builder` pattern added in > [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method > `testUI` which allows passing a lambda expression or a method reference to > create *the test UI window*. > >

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI

2023-09-12 Thread Alexey Ivanov
On Tue, 12 Sep 2023 18:41:23 GMT, Alexander Zvegintsev wrote: >>> Sometimes we may need to create more than one window(e.g. some DnD test >>> with two windows). Perhaps we should consider that here by adding >>> `List createTestUI()`. >> >> I thought about it. Yet I couldn't find a simple sce

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI

2023-09-12 Thread Alexander Zvegintsev
On Tue, 12 Sep 2023 13:37:09 GMT, Alexey Ivanov wrote: > However, to test this case I'll need a (simple) scenario where multiple > windows are created. For example `test/jdk/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java` is not converted to use PassFailJFrame, but shows

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI

2023-09-12 Thread Alexey Ivanov
On Tue, 12 Sep 2023 13:06:02 GMT, Alexander Zvegintsev wrote: > Shouldn't we mention here a window added by `testUI` via builder? I don't think it's necessary: the builder uses `addTestWindow` under the hood. It's the builder that requires documentation. In fact, the entire class requires a b

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI

2023-09-12 Thread Alexey Ivanov
On Tue, 12 Sep 2023 13:04:09 GMT, Alexander Zvegintsev wrote: > Sometimes we may need to create more than one window(e.g. some DnD test with > two windows). Perhaps we should consider that here by adding `List > createTestUI()`. I thought about it. Yet I couldn't find a simple scenario where

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI

2023-09-12 Thread Alexander Zvegintsev
On Mon, 11 Sep 2023 15:36:56 GMT, Alexey Ivanov wrote: > This enhances the `Builder` pattern added in > [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method > `testUI` which allows passing a lambda expression or a method reference to > create *the test UI window*. > >

RFR: 8294156: Allow PassFailJFrame.Builder to create test UI

2023-09-11 Thread Alexey Ivanov
This enhances the `Builder` pattern added in [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method `testUI` which allows passing a lambda expression or a method reference to create *the test UI window*. The `PassFailJFrame` will automatically call the method on the EDT to