On Thu, 7 Mar 2024 17:40:32 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.java
>> line 1:
>>
>>> 1: /*
>>
>> Does it make sense to remove the tray icon in this test as well when the
>> test exits?
>
> How is this resolved? You haven't update
On Thu, 7 Mar 2024 15:09:02 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> null check for system tray before remove
>
> test/jdk/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.java
On Thu, 7 Mar 2024 16:37:25 GMT, Alexey Ivanov wrote:
>> On windows you need to left click twice, on macos you need to right click
>> once
>
> [I did suggest clearer
> instructions](https://github.com/openjdk/jdk/pull/17838#discussion_r1506056726):
>
> clickInstruction
On Thu, 7 Mar 2024 16:30:32 GMT, Alisen Chung wrote:
>> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java
>> line 63:
>>
>>> 61:" (also called Taskbar Status Area on MS
>>> Windows, Notification\n" +
>>> 62:" Are
On Thu, 7 Mar 2024 14:53:22 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> null check for system tray before remove
>
> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTe
On Wed, 6 Mar 2024 21:36:10 GMT, Alisen Chung wrote:
>> Root cause of the test failure was fixed with
>> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
>> other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one addit
On Wed, 6 Mar 2024 21:36:10 GMT, Alisen Chung wrote:
>> Root cause of the test failure was fixed with
>> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
>> other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one addit
On Wed, 6 Mar 2024 21:36:10 GMT, Alisen Chung wrote:
>> Root cause of the test failure was fixed with
>> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
>> other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one addit
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
null check for syst
