Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v2]

2024-03-21 Thread Alexander Zvegintsev
On Thu, 21 Mar 2024 11:56:46 GMT, Alexey Ivanov wrote: >>> I wonder if it's the default focus owner? >> >> It is(e.g. with `setFocusPainted(true)`): >> ![image](https://github.com/openjdk/jdk/assets/77687766/b47e9011-c47d-437d-b9b0-0e4ac88a5c6f) >> >>> Should we request focus to Pass instead?

Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v2]

2024-03-21 Thread Alexey Ivanov
On Thu, 21 Mar 2024 11:48:28 GMT, Alexander Zvegintsev wrote: >> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 662: >> >>> 660: button = new >>> JButton(TimeoutHandlerPanel.PAUSE_BUTTON_LABEL); >>> 661: >>> 662: button.setFocusPainted(false); >> >> I wonde

Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v3]

2024-03-21 Thread Alexey Ivanov
On Thu, 21 Mar 2024 11:51:43 GMT, Alexander Zvegintsev wrote: >>> we need to add next to Pass/Fail a "Pause Timer" button, that >> (a) stops the count down >> (b) changes the Pause Timer to "Resume Timer" >> ~~(c) disables Pass/Fail until the timer is resumed~~ >> the test will not have to pause

Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v2]

2024-03-21 Thread Alexander Zvegintsev
On Thu, 21 Mar 2024 11:16:29 GMT, Alexey Ivanov wrote: > I wonder if it's the default focus owner? It is(e.g. with `setFocusPainted(true)`): ![image](https://github.com/openjdk/jdk/assets/77687766/b47e9011-c47d-437d-b9b0-0e4ac88a5c6f) > Should we request focus to Pass instead? Probably not, t

Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v3]

2024-03-21 Thread Alexander Zvegintsev
>> we need to add next to Pass/Fail a "Pause Timer" button, that > (a) stops the count down > (b) changes the Pause Timer to "Resume Timer" > ~~(c) disables Pass/Fail until the timer is resumed~~ > the test will not have to pause or be aware - only the PassFailJFrame > machinery. > ~~So the tester

Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v2]

2024-03-21 Thread Alexey Ivanov
On Wed, 20 Mar 2024 20:25:33 GMT, Alexander Zvegintsev wrote: >>> we need to add next to Pass/Fail a "Pause Timer" button, that >> (a) stops the count down >> (b) changes the Pause Timer to "Resume Timer" >> ~~(c) disables Pass/Fail until the timer is resumed~~ >> the test will not have to pause

Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v2]

2024-03-20 Thread Phil Race
On Wed, 20 Mar 2024 20:25:33 GMT, Alexander Zvegintsev wrote: >>> we need to add next to Pass/Fail a "Pause Timer" button, that >> (a) stops the count down >> (b) changes the Pause Timer to "Resume Timer" >> ~~(c) disables Pass/Fail until the timer is resumed~~ >> the test will not have to pause

Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v2]

2024-03-20 Thread Alexander Zvegintsev
On Wed, 20 Mar 2024 17:58:59 GMT, Alexey Ivanov wrote: > I would place the Pause button into the timeout panel at the top. Yet the > button is larger than the label. The font may be reduced, a symbol '⏸' > (U+23F8) and '⏵' (U+23F5) could be used (see [Media control > symbols](https://en.wikipe

Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v2]

2024-03-20 Thread Alexander Zvegintsev
>> we need to add next to Pass/Fail a "Pause Timer" button, that > (a) stops the count down > (b) changes the Pause Timer to "Resume Timer" > ~~(c) disables Pass/Fail until the timer is resumed~~ > the test will not have to pause or be aware - only the PassFailJFrame > machinery. > ~~So the tester

Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame

2024-03-20 Thread Alexey Ivanov
On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev wrote: >> we need to add next to Pass/Fail a "Pause Timer" button, that > (a) stops the count down > (b) changes the Pause Timer to "Resume Timer" > ~~(c) disables Pass/Fail until the timer is resumed~~ > the test will not have to pause or b

Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame

2024-03-18 Thread Alexander Zvegintsev
On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev wrote: >> we need to add next to Pass/Fail a "Pause Timer" button, that > (a) stops the count down > (b) changes the Pause Timer to "Resume Timer" > ~~(c) disables Pass/Fail until the timer is resumed~~ > the test will not have to pause or b

RFR: 8328402: Implement pausing functionality for the PassFailJFrame

2024-03-18 Thread Alexander Zvegintsev
> we need to add next to Pass/Fail a "Pause Timer" button, that (a) stops the count down (b) changes the Pause Timer to "Resume Timer" ~~(c) disables Pass/Fail until the timer is resumed~~ the test will not have to pause or be aware - only the PassFailJFrame machinery. ~~So the tester can do anythi