Re: [Coder-Com] ping timeout bug

2002-02-26 Thread Carlo Wood
On Wed, Feb 27, 2002 at 12:24:48AM +0100, Carlo Wood wrote: > [2002-2-27 0:19:36] DEBUG [DEBUG]: Client Parsing: PRIVMSG #test >:- > [2002-2-27 0:19:36] DEBUG [DEBUG]: poll: delay: 1014765621 (1014765576) 45000 > [2002-2-27 0:20:21] DEBUG [DEBUG]: poll: del

[Coder-Com] ping timeout bug

2002-02-26 Thread Carlo Wood
[2002-2-27 0:19:36] DEBUG [DEBUG]: Client Parsing: PRIVMSG #test :- [2002-2-27 0:19:36] DEBUG [DEBUG]: poll: delay: 1014765621 (1014765576) 45000 [2002-2-27 0:20:21] DEBUG [DEBUG]: poll: delay: 1014765681 (1014765621) 6 [2002-2-27 0:21:21] DEBUG [DEBUG]

Re: [Coder-Com] Bug in mainline.

2002-02-26 Thread Carlo Wood
On Wed, Feb 27, 2002 at 07:37:03AM +1300, Isomer wrote: > In this case it will not squit. It checks to see if the timestamp is > more than 5 minutes in the *future* not the past, so lag will only make > the test *less* likely to succeed. Ah ok. What about that it seems to KILL the client who cr

Re: [Coder-Com] Bug in mainline.

2002-02-26 Thread Isomer
> While implementing apass1-2, my eye fell on m_create. > It seems that what happens there should be changed. > > Firstly, the last exit_client KILLs sptr, a client. It doesn't SQUIT > the server of sptr. But changing this into squitting the server of > sptr would be at least as wrong - conside

[Coder-Com] missing break; ?

2002-02-26 Thread Crusader
When browsing thru the code in m_who.c i realised that there might be missing break; ? case 'i': case 'I': fields |= WHO_FIELD_NIP; break; case 'l': case 'L': fields |= WHO_FIELD_IDL; case 'n': case 'N':

[Coder-Com] Bug in mainline.

2002-02-26 Thread Carlo Wood
While implementing apass1-2, my eye fell on m_create. It seems that what happens there should be changed. The code currently is: int ms_create(struct Client* cptr, struct Client* sptr, int parc, char* parv[]) { ... if (IsServer(sptr)) return protocol_violation(sptr,"%s tried to CREATE a ch