[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-08-02 Thread GitBox
ephraimbuddy commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r681482907 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -242,21 +243,29 @@ def post_dag_run(dag_id, session): except Validatio

[GitHub] [airflow] shadrus commented on pull request #17388: refactor: fixed type annotation for 'sql' in MySqlOperator

2021-08-02 Thread GitBox
shadrus commented on pull request #17388: URL: https://github.com/apache/airflow/pull/17388#issuecomment-891578470 Is it OK to create PR for every SQL Operator or several operators can by be fixed in one PR? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [airflow] shadrus opened a new pull request #17388: refactor: fixed type annotation for 'sql' in MySqlOperator

2021-08-02 Thread GitBox
shadrus opened a new pull request #17388: URL: https://github.com/apache/airflow/pull/17388 Each SQL Operator that uses DbApiHook can receive a str representing a sql statement, a list of str (sql statements), or reference to a template file. But type annotation in MySqlOperator is 'str'

[GitHub] [airflow] github-actions[bot] commented on pull request #17209: ECSOperator returns last logs when ECS task fails

2021-08-02 Thread GitBox
github-actions[bot] commented on pull request #17209: URL: https://github.com/apache/airflow/pull/17209#issuecomment-891570806 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] ephraimbuddy commented on pull request #17385: Fix quarantined/flaky tests in test_local_task_job.py

2021-08-02 Thread GitBox
ephraimbuddy commented on pull request #17385: URL: https://github.com/apache/airflow/pull/17385#issuecomment-891568868 > Maybe we should just remove the `assert not process.is_alive()` lines. `process.join()` was called inside the test, so that line is only testing we wrote the tests righ

[GitHub] [airflow] baolsen commented on pull request #16904: Improve AWS SQS Sensor (#16880)

2021-08-02 Thread GitBox
baolsen commented on pull request #16904: URL: https://github.com/apache/airflow/pull/16904#issuecomment-891545354 Hey @potiuk thanks for the review and merge. I have one quick question regarding CI. See attached screenshot from a different PR. It seems that the "wait for

[GitHub] [airflow] casra-developers commented on pull request #16110: Added windows extensions

2021-08-02 Thread GitBox
casra-developers commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-891525703 @potiuk thank you for the hint. I will try to do that on our test environment as soon as I have a little bit of time at my disposal (this week might be tight). --

[GitHub] [airflow] uranusjr commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-02 Thread GitBox
uranusjr commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-891522262 “Passing” as in they seem to run fine so the config is not broken 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] uranusjr commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-02 Thread GitBox
uranusjr commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-891521385 I only skimmed through the changes and didn’t read all the logic, but structurally this seems fine + the checks are passing. -- This is an automated message from the Apache

[GitHub] [airflow] uranusjr commented on a change in pull request #17325: s3 unify_bucket_name_and_key simplify

2021-08-02 Thread GitBox
uranusjr commented on a change in pull request #17325: URL: https://github.com/apache/airflow/pull/17325#discussion_r681428602 ## File path: airflow/providers/amazon/aws/hooks/s3.py ## @@ -75,15 +75,10 @@ def unify_bucket_name_and_key(func: T) -> T: def wrapper(*args, **kw

[GitHub] [airflow] uranusjr commented on a change in pull request #17068: Influxdb Hook

2021-08-02 Thread GitBox
uranusjr commented on a change in pull request #17068: URL: https://github.com/apache/airflow/pull/17068#discussion_r681427401 ## File path: airflow/providers/influxdb/hooks/influxdb.py ## @@ -0,0 +1,166 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] cctvzd7 edited a comment on issue #17370: Task set to be failed by scheduler directly, while all up streams success

2021-08-02 Thread GitBox
cctvzd7 edited a comment on issue #17370: URL: https://github.com/apache/airflow/issues/17370#issuecomment-891506572 @jedcunningham @uranusjr I enable debug log level in scheduler, and the logs are as follows: ``` [2021-08-03 11:41:46,088] {scheduler_job.py:643} INFO - DAG(s)

[GitHub] [airflow] uranusjr commented on a change in pull request #17387: Invalidate Vault cached prop when not authenticated

2021-08-02 Thread GitBox
uranusjr commented on a change in pull request #17387: URL: https://github.com/apache/airflow/pull/17387#discussion_r681421325 ## File path: airflow/providers/hashicorp/_internal_client/vault_client.py ## @@ -191,8 +191,21 @@ def __init__( self.radius_secret = radius_s

[GitHub] [airflow] cctvzd7 edited a comment on issue #17370: Task set to be failed by scheduler directly, while all up streams success

2021-08-02 Thread GitBox
cctvzd7 edited a comment on issue #17370: URL: https://github.com/apache/airflow/issues/17370#issuecomment-891506572 @jedcunningham @uranusjr I enable debug log level in scheduler, and the logs are as follows: [2021-08-03 11:41:46,088] {scheduler_job.py:643} INFO - DAG(s) dict_ke

[GitHub] [airflow] cctvzd7 commented on issue #17370: Task set to be failed by scheduler directly, while all up streams success

2021-08-02 Thread GitBox
cctvzd7 commented on issue #17370: URL: https://github.com/apache/airflow/issues/17370#issuecomment-891506572 @jedcunningham @uranusjr I enable debug log level in scheduler, and the logs are as follows: [2021-08-03 11:41:46,088] {scheduler_job.py:643} INFO - DAG(s) dict_keys(['bl

[GitHub] [airflow-client-python] er1shivam opened a new issue #27: get_dag_details api is broken

2021-08-02 Thread GitBox
er1shivam opened a new issue #27: URL: https://github.com/apache/airflow-client-python/issues/27 Client version : 2.1.0 Code : ```with client.ApiClient(configuration) as api_client: api_instance = dag_api.DAGApi(api_client) dag_id = "dag_id_example" try:

[GitHub] [airflow] uranusjr commented on pull request #17385: Fix quarantined/flaky tests in test_local_task_job.py

2021-08-02 Thread GitBox
uranusjr commented on pull request #17385: URL: https://github.com/apache/airflow/pull/17385#issuecomment-891498581 Maybe we should just remove the `assert not process.is_alive()` lines. `process.join()` was called inside the test, so that line is only testing we wrote the tests right, not

[GitHub] [airflow] uranusjr commented on pull request #17329: Split sql statements in DbApi run

2021-08-02 Thread GitBox
uranusjr commented on pull request #17329: URL: https://github.com/apache/airflow/pull/17329#issuecomment-891495665 Implementation LGTM! I’m wondering about the interface though. Right now the default `split_statements` is False, but the argument is persuambly meaningless when `sql` contai

[GitHub] [airflow] uranusjr commented on a change in pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-08-02 Thread GitBox
uranusjr commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r681400265 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -242,21 +243,29 @@ def post_dag_run(dag_id, session): except ValidationErr

[GitHub] [airflow] jedcunningham commented on issue #17370: Task set to be failed by scheduler directly, while all up streams success

2021-08-02 Thread GitBox
jedcunningham commented on issue #17370: URL: https://github.com/apache/airflow/issues/17370#issuecomment-891431935 Is there anything in the normal scheduler log (the above is the parsing log)? -- This is an automated message from the Apache Git Service. To respond to the message, please

[airflow] branch main updated: New job update (#17386)

2021-08-02 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ff75cbc New job update (#17386) ff75cbc is

[GitHub] [airflow] jedcunningham merged pull request #17386: Update company after changing jobs

2021-08-02 Thread GitBox
jedcunningham merged pull request #17386: URL: https://github.com/apache/airflow/pull/17386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [airflow] github-actions[bot] commented on pull request #17386: Update company after changing jobs

2021-08-02 Thread GitBox
github-actions[bot] commented on pull request #17386: URL: https://github.com/apache/airflow/pull/17386#issuecomment-891416738 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] github-actions[bot] commented on pull request #16264: Add flag to delete local logs after upload

2021-08-02 Thread GitBox
github-actions[bot] commented on pull request #16264: URL: https://github.com/apache/airflow/pull/16264#issuecomment-891411301 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank y

[GitHub] [airflow] github-actions[bot] commented on pull request #16492: Added metadata support to GCSHook.upload. Closes #16487

2021-08-02 Thread GitBox
github-actions[bot] commented on pull request #16492: URL: https://github.com/apache/airflow/pull/16492#issuecomment-891411292 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank y

[GitHub] [airflow] github-actions[bot] commented on issue #16769: Airflow Helm charts - better integration with Hashicorp Vault

2021-08-02 Thread GitBox
github-actions[bot] commented on issue #16769: URL: https://github.com/apache/airflow/issues/16769#issuecomment-891411276 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] ephraimbuddy commented on pull request #17385: Fix quarantined/flaky tests in test_local_task_job.py

2021-08-02 Thread GitBox
ephraimbuddy commented on pull request #17385: URL: https://github.com/apache/airflow/pull/17385#issuecomment-891380646 Still flaky... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [airflow] flolas commented on pull request #17329: Split sql statements in DbApi run

2021-08-02 Thread GitBox
flolas commented on pull request #17329: URL: https://github.com/apache/airflow/pull/17329#issuecomment-891368646 > Some static checks are failing fix'd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [airflow] mik-laj commented on issue #8301: Support Duration in AwsHook when using assume role

2021-08-02 Thread GitBox
mik-laj commented on issue #8301: URL: https://github.com/apache/airflow/issues/8301#issuecomment-891352427 We support the refreshable credentials on Airflow 2.1. https://github.com/apache/airflow/pull/16771 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [airflow] Falydoor commented on issue #8301: Support Duration in AwsHook when using assume role

2021-08-02 Thread GitBox
Falydoor commented on issue #8301: URL: https://github.com/apache/airflow/issues/8301#issuecomment-891348665 @snazzyfox: were you able to change the role session duration to more than 1h in Airflow 1.10.X? I might have to update to 2.X unless there is a way for 1.10.X -- This is an aut

[GitHub] [airflow] davlum opened a new pull request #17387: Invalidate Vault cached prop when not authenticated

2021-08-02 Thread GitBox
davlum opened a new pull request #17387: URL: https://github.com/apache/airflow/pull/17387 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more info

[GitHub] [airflow] BasPH opened a new pull request #17386: Update company after changing jobs

2021-08-02 Thread GitBox
BasPH opened a new pull request #17386: URL: https://github.com/apache/airflow/pull/17386 Joined Astronomer, updated `INTHEWILD.md` accordingly --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/mai

[GitHub] [airflow] josh-fell commented on pull request #17384: Example DAG-related updates for Apache Drill

2021-08-02 Thread GitBox
josh-fell commented on pull request #17384: URL: https://github.com/apache/airflow/pull/17384#issuecomment-891332634 Thank you @potiuk ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [airflow] vijayakumarpattanashetti commented on issue #17371: File contents of application_file are not loaded due to missing open & read functions

2021-08-02 Thread GitBox
vijayakumarpattanashetti commented on issue #17371: URL: https://github.com/apache/airflow/issues/17371#issuecomment-891328029 Hi @potiuk, yes. I am working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[airflow] branch main updated: Improve AWS SQS Sensor (#16880) (#16904)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d28efbf Improve AWS SQS Sensor (#16880) (#16904) d

[GitHub] [airflow] potiuk merged pull request #16904: Improve AWS SQS Sensor (#16880)

2021-08-02 Thread GitBox
potiuk merged pull request #16904: URL: https://github.com/apache/airflow/pull/16904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk closed issue #16880: Improve AWS SQS Sensor

2021-08-02 Thread GitBox
potiuk closed issue #16880: URL: https://github.com/apache/airflow/issues/16880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] potiuk commented on pull request #16904: Improve AWS SQS Sensor (#16880)

2021-08-02 Thread GitBox
potiuk commented on pull request #16904: URL: https://github.com/apache/airflow/pull/16904#issuecomment-891321570 LGTM. And tests seem to be intermittent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] scrdest commented on pull request #11652: Support for sorting DAGs in the web UI

2021-08-02 Thread GitBox
scrdest commented on pull request #11652: URL: https://github.com/apache/airflow/pull/11652#issuecomment-891320564 @jedcunningham alright, will do; I was going to action this as of @uranusjr 's comment but, well, Life happened. -- This is an automated message from the Apache Git Service.

[airflow] branch main updated (bcf719b -> 2c1880a)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from bcf719b refactor: fixed type annotation for 'sql' param in PostgresOperator (#17331) add 2c1880a Suggest to us

[GitHub] [airflow] potiuk merged pull request #17319: Suggest to use secrets backend for variable when it contains sensitive data

2021-08-02 Thread GitBox
potiuk merged pull request #17319: URL: https://github.com/apache/airflow/pull/17319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk closed issue #14200: Update Best practises doc

2021-08-02 Thread GitBox
potiuk closed issue #14200: URL: https://github.com/apache/airflow/issues/14200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] potiuk commented on issue #17371: File contents of application_file are not loaded due to missing open & read functions

2021-08-02 Thread GitBox
potiuk commented on issue #17371: URL: https://github.com/apache/airflow/issues/17371#issuecomment-891318358 @vijayakumarpattanashetti - would you like to add PR fixing it ? That seems super simple and would be nice contribution to community -- This is an automated message from the Apach

[airflow] branch main updated: refactor: fixed type annotation for 'sql' param in PostgresOperator (#17331)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new bcf719b refactor: fixed type annotation for 'sql'

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17331: refactor: fixed type annotation for 'sql' param in PostgresOperator

2021-08-02 Thread GitBox
boring-cyborg[bot] commented on pull request #17331: URL: https://github.com/apache/airflow/pull/17331#issuecomment-891314089 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] potiuk merged pull request #17331: refactor: fixed type annotation for 'sql' param in PostgresOperator

2021-08-02 Thread GitBox
potiuk merged pull request #17331: URL: https://github.com/apache/airflow/pull/17331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] github-actions[bot] commented on pull request #17379: Add Mongo projections to hook and transfer

2021-08-02 Thread GitBox
github-actions[bot] commented on pull request #17379: URL: https://github.com/apache/airflow/pull/17379#issuecomment-891311340 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] potiuk commented on pull request #17379: Add Mongo projections to hook and transfer

2021-08-02 Thread GitBox
potiuk commented on pull request #17379: URL: https://github.com/apache/airflow/pull/17379#issuecomment-891311299 The mongo tests are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] github-actions[bot] commented on pull request #17319: Suggest to use secrets backend for variable when it contains sensitive data

2021-08-02 Thread GitBox
github-actions[bot] commented on pull request #17319: URL: https://github.com/apache/airflow/pull/17319#issuecomment-891310616 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] github-actions[bot] commented on pull request #17385: Fix quarantined/flaky tests in test_local_task_job.py

2021-08-02 Thread GitBox
github-actions[bot] commented on pull request #17385: URL: https://github.com/apache/airflow/pull/17385#issuecomment-891308022 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17385: Fix quarantined/flaky tests in test_local_task_job.py

2021-08-02 Thread GitBox
ephraimbuddy commented on a change in pull request #17385: URL: https://github.com/apache/airflow/pull/17385#discussion_r681246503 ## File path: tests/jobs/test_local_task_job.py ## @@ -87,6 +87,11 @@ def set_instance_attrs(self, dagbag): with patch('airflow.jobs.base_

[GitHub] [airflow] ephraimbuddy opened a new pull request #17385: Fix quarantined/flaky tests in test_local_task_job.py

2021-08-02 Thread GitBox
ephraimbuddy opened a new pull request #17385: URL: https://github.com/apache/airflow/pull/17385 This PR attempts to fix some flaky/quarantined tests in test_local_task_job.py by terminating multiprocess after process.join() times out. Process.join() waits for process to terminate an

[GitHub] [airflow] github-actions[bot] commented on pull request #17329: Split sql statements in DbApi run

2021-08-02 Thread GitBox
github-actions[bot] commented on pull request #17329: URL: https://github.com/apache/airflow/pull/17329#issuecomment-891306016 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] potiuk commented on pull request #17329: Split sql statements in DbApi run

2021-08-02 Thread GitBox
potiuk commented on pull request #17329: URL: https://github.com/apache/airflow/pull/17329#issuecomment-891305805 Some static checks are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[airflow] branch main updated: Example DAG-related updates for Apache Drill (#17384)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b82bbe8 Example DAG-related updates for Apache Dri

[GitHub] [airflow] potiuk merged pull request #17384: Example DAG-related updates for Apache Drill

2021-08-02 Thread GitBox
potiuk merged pull request #17384: URL: https://github.com/apache/airflow/pull/17384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk commented on pull request #16829: Queue support for DaskExecutor using Dask Worker Resources

2021-08-02 Thread GitBox
potiuk commented on pull request #16829: URL: https://github.com/apache/airflow/pull/16829#issuecomment-891295959 Static checks are failing, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] potiuk commented on pull request #17068: Influxdb Hook

2021-08-02 Thread GitBox
potiuk commented on pull request #17068: URL: https://github.com/apache/airflow/pull/17068#issuecomment-891293072 @uranusjr ?:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[airflow] branch main updated (67cbb0f -> e544ffc)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 67cbb0f Enable specifying dictionary paths in `template_fields_renderers` (#17321) add e544ffc Enhancement to

[GitHub] [airflow] potiuk merged pull request #17098: Enhancement to bash scripts

2021-08-02 Thread GitBox
potiuk merged pull request #17098: URL: https://github.com/apache/airflow/pull/17098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk closed pull request #17239: Improved UI rendering of templated dicts and lists

2021-08-02 Thread GitBox
potiuk closed pull request #17239: URL: https://github.com/apache/airflow/pull/17239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk commented on pull request #17239: Improved UI rendering of templated dicts and lists

2021-08-02 Thread GitBox
potiuk commented on pull request #17239: URL: https://github.com/apache/airflow/pull/17239#issuecomment-891286306 I guess we can close it as #17321 has been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk closed issue #16892: Render template for dictionary keys

2021-08-02 Thread GitBox
potiuk closed issue #16892: URL: https://github.com/apache/airflow/issues/16892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] potiuk commented on issue #16892: Render template for dictionary keys

2021-08-02 Thread GitBox
potiuk commented on issue #16892: URL: https://github.com/apache/airflow/issues/16892#issuecomment-891285835 This feature has now been merged via #17321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] potiuk commented on issue #17307: Trigger Config, Trigger Config Template

2021-08-02 Thread GitBox
potiuk commented on issue #17307: URL: https://github.com/apache/airflow/issues/17307#issuecomment-891283885 duplicate of #17100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [airflow] potiuk closed issue #17307: Trigger Config, Trigger Config Template

2021-08-02 Thread GitBox
potiuk closed issue #17307: URL: https://github.com/apache/airflow/issues/17307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-08-02 Thread GitBox
ephraimbuddy commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r681202782 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -242,21 +243,29 @@ def post_dag_run(dag_id, session): except Validatio

[GitHub] [airflow] josh-fell opened a new pull request #17384: Example DAG-related updates for Apache Drill

2021-08-02 Thread GitBox
josh-fell opened a new pull request #17384: URL: https://github.com/apache/airflow/pull/17384 Making a few updates for the new Apache Drill example DAG: - Adding an `__init__.py` file in the `example_dags` directory - Updating the docstring for the example DAG -- the current docstring

[GitHub] [airflow] josh-fell closed pull request #17383: Updating docstring in Apache Drill example DAG

2021-08-02 Thread GitBox
josh-fell closed pull request #17383: URL: https://github.com/apache/airflow/pull/17383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [airflow] baryluk commented on pull request #17325: s3 unify_bucket_name_and_key simplify

2021-08-02 Thread GitBox
baryluk commented on pull request #17325: URL: https://github.com/apache/airflow/pull/17325#issuecomment-891241943 > I think you are right. However, as you say, `if key_name` always evaluated to True, and I think `if key_name` in this PR also always evaluated to True. So should you remove

[GitHub] [airflow] baryluk commented on a change in pull request #17325: s3 unify_bucket_name_and_key simplify

2021-08-02 Thread GitBox
baryluk commented on a change in pull request #17325: URL: https://github.com/apache/airflow/pull/17325#discussion_r681184216 ## File path: airflow/providers/amazon/aws/hooks/s3.py ## @@ -75,15 +75,10 @@ def unify_bucket_name_and_key(func: T) -> T: def wrapper(*args, **kwa

[GitHub] [airflow] baryluk commented on a change in pull request #17325: s3 unify_bucket_name_and_key simplify

2021-08-02 Thread GitBox
baryluk commented on a change in pull request #17325: URL: https://github.com/apache/airflow/pull/17325#discussion_r681183778 ## File path: airflow/providers/amazon/aws/hooks/s3.py ## @@ -75,15 +75,10 @@ def unify_bucket_name_and_key(func: T) -> T: def wrapper(*args, **kwa

[GitHub] [airflow] SamWheating commented on a change in pull request #17347: Handle and log exceptions raised during task callback

2021-08-02 Thread GitBox
SamWheating commented on a change in pull request #17347: URL: https://github.com/apache/airflow/pull/17347#discussion_r681182088 ## File path: tests/models/test_taskinstance.py ## @@ -1743,6 +1743,32 @@ def on_execute_callable(context): ti.refresh_from_db() a

[GitHub] [airflow] josh-fell opened a new pull request #17383: Updating docstring in Apache Drill example DAG

2021-08-02 Thread GitBox
josh-fell opened a new pull request #17383: URL: https://github.com/apache/airflow/pull/17383 Updating the docstring in the Apache Drill example DAG. The current docstring references Apache Spark operators. --- **^ Add meaningful description above** Read the **[Pull Reques

[GitHub] [airflow] jedcunningham commented on a change in pull request #15385: Added table to view providers in airflow ui under admin tab

2021-08-02 Thread GitBox
jedcunningham commented on a change in pull request #15385: URL: https://github.com/apache/airflow/pull/15385#discussion_r681159977 ## File path: airflow/www/views.py ## @@ -3271,6 +3271,58 @@ def list(self): ) +class ProvidersView(AirflowBaseView): Review comment

[GitHub] [airflow] flolas commented on a change in pull request #17329: Split sql statements in DbApi run

2021-08-02 Thread GitBox
flolas commented on a change in pull request #17329: URL: https://github.com/apache/airflow/pull/17329#discussion_r681163379 ## File path: airflow/hooks/dbapi.py ## @@ -176,18 +178,32 @@ def run(self, sql, autocommit=False, parameters=None, handler=None): :param handl

[GitHub] [airflow] subkanthi commented on issue #17368: Add example DAG for SlackAPIFileOperator

2021-08-02 Thread GitBox
subkanthi commented on issue #17368: URL: https://github.com/apache/airflow/issues/17368#issuecomment-891208726 Yes , please assign it to me. Sorry I should have added that info, was too quick to create the issue. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] jedcunningham commented on pull request #11652: Support for sorting DAGs in the web UI

2021-08-02 Thread GitBox
jedcunningham commented on pull request #11652: URL: https://github.com/apache/airflow/pull/11652#issuecomment-891193935 @scrdest, I'd like to get this in for 2.2.0. Could you take a look at fixing the merge conflicts? Just a heads up, `tests/www/test_views.py` has been split apart so that

[GitHub] [airflow] afonit commented on issue #11309: FileNotFoundError: [Errno 2] No such file or directory: 'airflow': 'airflow'

2021-08-02 Thread GitBox
afonit commented on issue #11309: URL: https://github.com/apache/airflow/issues/11309#issuecomment-891191282 @zacharya19 , I created mine here: ``` /etc/systemd/system/airflow-scheduler.service ``` -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow-site] potiuk commented on pull request #461: Fixes messed-up changelog for some providers

2021-08-02 Thread GitBox
potiuk commented on pull request #461: URL: https://github.com/apache/airflow-site/pull/461#issuecomment-891187348 cc: @mgorski -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [airflow-site] potiuk opened a new pull request #461: Fixes messed-up changelog for some providers

2021-08-02 Thread GitBox
potiuk opened a new pull request #461: URL: https://github.com/apache/airflow-site/pull/461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[airflow-site] 01/01: Fixes messed-up changelog for some providers

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch fix-messed-up-changelogs-for-providers in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 8f006c0226316d862f65a80bc2a8f7e26010e0d4 Author: Jarek Potiuk AuthorDate: Mon Aug

[airflow-site] branch fix-messed-up-changelogs-for-providers created (now 8f006c0)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch fix-messed-up-changelogs-for-providers in repository https://gitbox.apache.org/repos/asf/airflow-site.git. at 8f006c0 Fixes messed-up changelog for some providers This branch includes the

[GitHub] [airflow] uranusjr commented on pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-08-02 Thread GitBox
uranusjr commented on pull request #16352: URL: https://github.com/apache/airflow/pull/16352#issuecomment-891181187 I think this is ready for another round of reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [airflow] cansjt edited a comment on issue #17374: The new weberser does not seem to care about AIRFLOW__CORE__SQL_ALCHEMY_SCHEMA

2021-08-02 Thread GitBox
cansjt edited a comment on issue #17374: URL: https://github.com/apache/airflow/issues/17374#issuecomment-891177075 FYI here is the SQL script I used to move things around: ```sql TRUNCATE TABLE airflow.ab_permission ; TRUNCATE TABLE airflow.ab_view_menu ; TRUNCATE TABLE airflow.

[GitHub] [airflow] cansjt commented on issue #17374: The new weberser does not seem to care about AIRFLOW__CORE__SQL_ALCHEMY_SCHEMA

2021-08-02 Thread GitBox
cansjt commented on issue #17374: URL: https://github.com/apache/airflow/issues/17374#issuecomment-891177075 FYI here is the SQL script I used to move things around: ```sql TRUNCATE TABLE airflow.ab_permission, airflow.ab_view_menu, airflow.ab_user_role, air

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-02 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-891174438 FYI I cherry-picked all the changes (including setup.* changes required for providers to v2-1-test), I also pushed and configured all v2-1-test/* images to ghcr.io. I also rege

[jira] [Commented] (AIRFLOW-5529) Support Apache Drill hook

2021-08-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391695#comment-17391695 ] ASF subversion and git services commented on AIRFLOW-5529: -- Co

[airflow] 04/08: Add type annotations to setup.py (#16658)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit f3b74d802a1bd61060a302b51b894d178b543e03 Author: Ali Muhammad AuthorDate: Fri Jun 25 22:25:52 2021 +0500 Add ty

[airflow] 05/08: bump dnspython (#16698)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit ab46af97bd50ad0f024892eb1c65d7bbb724ae89 Author: kurtqq <47721902+kur...@users.noreply.github.com> AuthorDate: Tue Ju

[airflow] 02/08: Remove SQLAlchemy <1.4 constraint (#16630)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit e8058ebdc6df5d7a168dcccf4d8042ec09faac80 Author: Tzu-ping Chung AuthorDate: Thu Jun 24 21:10:15 2021 +0800 Remo

[airflow] 08/08: Updates to FlaskAppBuilder 3.3.2+ (#17208)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit ac832a2f8446d5a554af2b9833453d8a8bbcb195 Author: Jarek Potiuk AuthorDate: Wed Jul 28 21:37:48 2021 +0200 Update

[airflow] 06/08: AIRFLOW-5529 Add Apache Drill provider. (#16884)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 4aef457774c646940caef7a02e0c2c0d76915160 Author: dzamo <9107319+dz...@users.noreply.github.com> AuthorDate: Mon Jul 1

[airflow] 03/08: Bump Jinja2 upper-bound from 2.12.0 to 4.0.0 (#16595)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit c967d29671b854fdad0d8eba11a807bc3bf3ce3c Author: Ashwin Madavan AuthorDate: Thu Jun 24 15:07:23 2021 -0400 Bump

[airflow] 07/08: Update alias for field_mask in Google Memmcache (#16975)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit f14860d6a7aefe8f98bf6eeba648c487b9cee2cf Author: Jarek Potiuk AuthorDate: Tue Jul 13 20:54:38 2021 +0200 Update

[airflow] 01/08: Switch back http provider after requests removes LGPL dependency (#16974)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 88e6305c92a3e96134589f3bfb29b3ff9803fafd Author: Jarek Potiuk AuthorDate: Tue Jul 13 22:13:30 2021 +0200 Switch

[airflow] branch v2-1-test updated (3d2a5cf -> ac832a2)

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3d2a5cf Switches to "/" convention in ghcr.io images with optimisations new 88e6305 Switch back http prov

[airflow] branch constraints-2-1 updated: Updated constraints after cherry-picking setup changes

2021-08-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch constraints-2-1 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-1 by this push: new 47eb9e5 Updated constraints

[GitHub] [airflow] denimalpaca opened a new pull request #17382: Add new LocalFilesystemToS3Operator under Amazon provider (#17168)

2021-08-02 Thread GitBox
denimalpaca opened a new pull request #17382: URL: https://github.com/apache/airflow/pull/17382 Add new LocalFilesystemToS3Operator under Amazon provider (#17168) Currently, an S3Hook exists that allows transfer of files to S3 via `load_file()`, however there is no operator associate

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17382: Add new LocalFilesystemToS3Operator under Amazon provider (#17168)

2021-08-02 Thread GitBox
boring-cyborg[bot] commented on pull request #17382: URL: https://github.com/apache/airflow/pull/17382#issuecomment-891165202 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

  1   2   3   >