[GitHub] [airflow] blag opened a new pull request #19099: Fixup string concatenations

2021-10-19 Thread GitBox
blag opened a new pull request #19099: URL: https://github.com/apache/airflow/pull/19099 This PR just fixes a few string concatenations here and there. Please pay particular attention to the regexes that I tweaked. I may have been a little overzealous with my changes, namely:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19099: Fixup string concatenations

2021-10-19 Thread GitBox
boring-cyborg[bot] commented on pull request #19099: URL: https://github.com/apache/airflow/pull/19099#issuecomment-947377458 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] pateash opened a new issue #19098: Adding Time remaining for next dag run in Airflow UI

2021-10-19 Thread GitBox
pateash opened a new issue #19098: URL: https://github.com/apache/airflow/issues/19098 ### Description It will be really helpful if we can add a dynamic message/tooltip which shows time remaining for next run for a dag. ### Use case/motivation Although we have next_

[GitHub] [airflow] pateash commented on pull request #16931: #16692 show schedule_interval/timetable description in UI

2021-10-19 Thread GitBox
pateash commented on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-947349360 > > I think it's better to show a message that says "descritpion can not be evaluated for non standard cron" or something of a sort > > That works for me. My main concer

[GitHub] [airflow] pateash edited a comment on pull request #16931: #16692 show schedule_interval/timetable description in UI

2021-10-19 Thread GitBox
pateash edited a comment on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-947348126 > > ![image](https://user-images.githubusercontent.com/16856802/137580282-62c948c1-3dcd-43b3-aceb-9c0b8f3a026b.png) > > The info icons next to the badges are unne

[GitHub] [airflow] pateash commented on pull request #16931: #16692 show schedule_interval/timetable description in UI

2021-10-19 Thread GitBox
pateash commented on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-947348126 > > ![image](https://user-images.githubusercontent.com/16856802/137580282-62c948c1-3dcd-43b3-aceb-9c0b8f3a026b.png) > > The info icons next to the badges are unnecessary

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19097: add detailed information to logging when a dag or a task finishes.

2021-10-19 Thread GitBox
boring-cyborg[bot] commented on pull request #19097: URL: https://github.com/apache/airflow/pull/19097#issuecomment-947345254 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] steveyz-astro opened a new pull request #19097: add detailed information to logging when a dag or a task finishes.

2021-10-19 Thread GitBox
steveyz-astro opened a new pull request #19097: URL: https://github.com/apache/airflow/pull/19097 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for mo

[GitHub] [airflow] uranusjr commented on issue #19058: Manual dagrun logs to last scheduled dagruns log files

2021-10-19 Thread GitBox
uranusjr commented on issue #19058: URL: https://github.com/apache/airflow/issues/19058#issuecomment-947327336 > add a new column `log_filename` on `TaskInstance` that's populated exactly once when the TI is run, to decouple the filenamne derivation logic. But considering how poor th

[GitHub] [airflow] prabhjyotsingh commented on pull request #19025: [Minor] Fix padding on home page

2021-10-19 Thread GitBox
prabhjyotsingh commented on pull request #19025: URL: https://github.com/apache/airflow/pull/19025#issuecomment-947320230 Thank you @bbovenzi for mentoring me on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [airflow] MatrixManAtYrService opened a new issue #19096: Sets in parameters cause "TypeError: Object of type set is not JSON serializable"

2021-10-19 Thread GitBox
MatrixManAtYrService opened a new issue #19096: URL: https://github.com/apache/airflow/issues/19096 ### Apache Airflow version 2.2.0 (latest released) ### Operating System Debian Buster (docker) ### Versions of Apache Airflow Providers n/a ### Deploy

[GitHub] [airflow] ephraimbuddy commented on pull request #19095: Ensure task state doesn't change when marked as failed/success/skipped

2021-10-19 Thread GitBox
ephraimbuddy commented on pull request #19095: URL: https://github.com/apache/airflow/pull/19095#issuecomment-947313085 I'll add tests later... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] ephraimbuddy opened a new pull request #19095: Ensure task state doesn't change when marked as failed/success/skipped

2021-10-19 Thread GitBox
ephraimbuddy opened a new pull request #19095: URL: https://github.com/apache/airflow/pull/19095 Closes: https://github.com/apache/airflow/issues/16078 Currently, when a dagrun is marked as success in the UI, the expected sigterm is sent but the task continues running, changing the

[GitHub] [airflow] ephraimbuddy commented on issue #9975: max_active_runs = 1 can still create multiple active execution runs

2021-10-19 Thread GitBox
ephraimbuddy commented on issue #9975: URL: https://github.com/apache/airflow/issues/9975#issuecomment-947301012 What you see there is queued run. The currently active run is 1 but there's also a queued run which doesn't count as an active run. -- This is an automated message from the Ap

[GitHub] [airflow] uranusjr commented on pull request #19088: Change `ds`, `ts`, etc. back to use logical date

2021-10-19 Thread GitBox
uranusjr commented on pull request #19088: URL: https://github.com/apache/airflow/pull/19088#issuecomment-947288832 Test added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [airflow] lanms edited a comment on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms edited a comment on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947272226 Thanks for your attention, The DAG you give is OK, I can give you some run logs, please analyze the problem, I add some Print in code, and log it here is my DAG

[GitHub] [airflow] lanms edited a comment on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms edited a comment on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947272226 Thanks for your attention, The DAG you give is OK, I can give you some run logs, please analyze the problem, I add some Print in code, and log it here is my DAG

[GitHub] [airflow] lanms commented on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms commented on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947280898 I run this DAG in airfow v2.1.4 It's OK, only raise problem in v2.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [airflow] lanms removed a comment on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms removed a comment on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947280274 > Hi @lanms, I'm not able to reproduce this and I suspect it's something related to `EnterpriseWeiChat`. Can you try to reproduce with this DAG: > > ```python > from

[GitHub] [airflow] lanms closed issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms closed issue #19069: URL: https://github.com/apache/airflow/issues/19069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [airflow] lanms commented on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms commented on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947280274 > Hi @lanms, I'm not able to reproduce this and I suspect it's something related to `EnterpriseWeiChat`. Can you try to reproduce with this DAG: > > ```python > from datetim

[GitHub] [airflow] lanms edited a comment on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms edited a comment on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947272226 Thanks for your attention, The DAG you give is OK, I can give you some run logs, please analyze the problem, I add some Print in code, and log it here is my DAG

[GitHub] [airflow] lanms edited a comment on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms edited a comment on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947272226 Thanks for your attention, The DAG you give is OK, I can give you some run logs, please analyze the problem, I add some Print in code, and log it here is my DAG

[GitHub] [airflow] lanms edited a comment on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms edited a comment on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947272226 Thanks for your attention, The DAG you give is OK, I can give you some run logs, please analyze the problem, I add some Print in code, and log it here is my DAG

[GitHub] [airflow] guotongfei opened a new pull request #19094: Update mysql_to_s3.py

2021-10-19 Thread GitBox
guotongfei opened a new pull request #19094: URL: https://github.com/apache/airflow/pull/19094 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] lanms edited a comment on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms edited a comment on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947272226 Thanks for your attention, The DAG you give is OK, I can give you some run logs, please analyze the problem, I add some Print in code, and log it here is my DAG

[GitHub] [airflow] lanms removed a comment on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms removed a comment on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947275528 [ppe-aiflow-worker-f6f66fd7c-pvxf2-ppe-aiflow-worker.log](https://github.com/apache/airflow/files/7377822/ppe-aiflow-worker-f6f66fd7c-pvxf2-ppe-aiflow-worker.log) -- Th

[GitHub] [airflow] lanms commented on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms commented on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947275528 [ppe-aiflow-worker-f6f66fd7c-pvxf2-ppe-aiflow-worker.log](https://github.com/apache/airflow/files/7377822/ppe-aiflow-worker-f6f66fd7c-pvxf2-ppe-aiflow-worker.log) -- This is an

[GitHub] [airflow] lanms edited a comment on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms edited a comment on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947272226 Thanks for your attention, The DAG you give is OK, I can give you some run logs, please analyze the problem, I add some Print in code, and log it here is my DAG

[GitHub] [airflow] lanms edited a comment on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms edited a comment on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947272226 Thanks for your attention, The DAG you give is OK, I can give you some run logs, please analyze the problem, I add some Print in code, and log it here is my DAG

[GitHub] [airflow] lanms commented on issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-19 Thread GitBox
lanms commented on issue #19069: URL: https://github.com/apache/airflow/issues/19069#issuecomment-947272226 Thanks for your attention, The DAG you give is OK, I can give you some run logs, please analyze the problem, I add some Print in code, and log it here is my DAG Ente

[GitHub] [airflow] edithturn commented on issue #9941: Extra links for Google Cloud operators

2021-10-19 Thread GitBox
edithturn commented on issue #9941: URL: https://github.com/apache/airflow/issues/9941#issuecomment-947270869 @mik-laj I have some experience with Google Cloud, I would really happy to work on this issue. Could you please provide me with the tips and information to start it? I will appreci

[GitHub] [airflow] dave-martinez commented on issue #9975: max_active_runs = 1 can still create multiple active execution runs

2021-10-19 Thread GitBox
dave-martinez commented on issue #9975: URL: https://github.com/apache/airflow/issues/9975#issuecomment-947244571 > Issue does not happen on 2.1.4 ![image](https://user-images.githubusercontent.com/37215642/134760074-23a8bec9-13ae-4b36-8e62-1ce9fc25367c.png) I tested this one with Do

[GitHub] [airflow] github-actions[bot] commented on pull request #19060: Warn about unsupported Python 3.10

2021-10-19 Thread GitBox
github-actions[bot] commented on pull request #19060: URL: https://github.com/apache/airflow/pull/19060#issuecomment-947227424 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] uranusjr commented on pull request #19091: Move away from legacy importlib.resources API

2021-10-19 Thread GitBox
uranusjr commented on pull request #19091: URL: https://github.com/apache/airflow/pull/19091#issuecomment-947225692 BTW the `functools.cache` import in `providers_manager` doesn't seem to be used anywhere, so I removed it as well. -- This is an automated message from the Apache Git Servi

[GitHub] [airflow] uranusjr opened a new pull request #19091: Move away from legacy importlib.resources API

2021-10-19 Thread GitBox
uranusjr opened a new pull request #19091: URL: https://github.com/apache/airflow/pull/19091 `importlib.resources` deprecated the top-level `read_binary()` and similar functions in favor of the new `files()` API. This is only available in Python 3.9 and later, so the `importlib-resources`

[GitHub] [airflow] gitrobert42 commented on pull request #19085: Correct Task definition in docs

2021-10-19 Thread GitBox
gitrobert42 commented on pull request #19085: URL: https://github.com/apache/airflow/pull/19085#issuecomment-947223615 Oh. Nevermind. The document as written is correct. The document live on the Apache site must be out of date. When i came here to make the correction, I didn't notice it ha

[GitHub] [airflow] gitrobert42 closed pull request #19085: Correct Task definition in docs

2021-10-19 Thread GitBox
gitrobert42 closed pull request #19085: URL: https://github.com/apache/airflow/pull/19085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [airflow] dsykes16 commented on issue #15340: helm install airflow in namespace get error: File "", line 32, in TimeoutError: There are still unapplied migrations after 60 se

2021-10-19 Thread GitBox
dsykes16 commented on issue #15340: URL: https://github.com/apache/airflow/issues/15340#issuecomment-947206178 I also ran into this issue. In the interest of saving time for anyone else that stumbles upon this issue, the fix seems to be setting `--wait=false` on the Helm command, per @Libo

[GitHub] [airflow] github-actions[bot] commented on pull request #19064: Remove distutils usages for Python 3.10

2021-10-19 Thread GitBox
github-actions[bot] commented on pull request #19064: URL: https://github.com/apache/airflow/pull/19064#issuecomment-947199957 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] github-actions[bot] commented on pull request #18026: Optimize the providers tests when running subsets of them

2021-10-19 Thread GitBox
github-actions[bot] commented on pull request #18026: URL: https://github.com/apache/airflow/pull/18026#issuecomment-947196848 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank y

[GitHub] [airflow] github-actions[bot] closed pull request #16845: Add state filter to dag_runs endpoint

2021-10-19 Thread GitBox
github-actions[bot] closed pull request #16845: URL: https://github.com/apache/airflow/pull/16845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] closed pull request #17846: Properly reset/adopt taskinstances and fix find_zombies

2021-10-19 Thread GitBox
github-actions[bot] closed pull request #17846: URL: https://github.com/apache/airflow/pull/17846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #18930: Add Guide for Apache Pinot

2021-10-19 Thread GitBox
potiuk commented on pull request #18930: URL: https://github.com/apache/airflow/pull/18930#issuecomment-947195510 Looks like there are many unrelated changes in the PR. I think you should rebase to latest `main` and only leave the "Apache Pinot" related changes. -- This is an automated m

[GitHub] [airflow] mik-laj commented on a change in pull request #19060: Warn about unsupported Python 3.10

2021-10-19 Thread GitBox
mik-laj commented on a change in pull request #19060: URL: https://github.com/apache/airflow/pull/19060#discussion_r732308787 ## File path: airflow/__main__.py ## @@ -19,20 +19,31 @@ # under the License. """Main executable module""" - +import logging import os +import warn

[GitHub] [airflow] uranusjr commented on pull request #18934: Implement API generator and use it on Connection

2021-10-19 Thread GitBox
uranusjr commented on pull request #18934: URL: https://github.com/apache/airflow/pull/18934#issuecomment-947161459 Should be ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] OyinOlamide commented on pull request #19042: Update CONTRIBUTORS_QUICK_START.rst

2021-10-19 Thread GitBox
OyinOlamide commented on pull request #19042: URL: https://github.com/apache/airflow/pull/19042#issuecomment-947157280 I think I have done that now @potiuk and @ephraimbuddy . Please take a look and let me know if there is any way I can make this better. Thank you! :) -- This is an autom

[GitHub] [airflow] SamWheating commented on a change in pull request #18924: Adding dag_id_pattern parameter to the /dags endpoint

2021-10-19 Thread GitBox
SamWheating commented on a change in pull request #18924: URL: https://github.com/apache/airflow/pull/18924#discussion_r732291747 ## File path: airflow/api_connexion/endpoints/dag_endpoint.py ## @@ -60,13 +60,16 @@ def get_dag_details(dag_id): @security.requires_access([(permi

[GitHub] [airflow] SamWheating commented on a change in pull request #18924: Adding dag_id_pattern parameter to the /dags endpoint

2021-10-19 Thread GitBox
SamWheating commented on a change in pull request #18924: URL: https://github.com/apache/airflow/pull/18924#discussion_r732291747 ## File path: airflow/api_connexion/endpoints/dag_endpoint.py ## @@ -60,13 +60,16 @@ def get_dag_details(dag_id): @security.requires_access([(permi

[GitHub] [airflow] uranusjr commented on pull request #18954: Add DAG file processing description to Scheduler Concepts

2021-10-19 Thread GitBox
uranusjr commented on pull request #18954: URL: https://github.com/apache/airflow/pull/18954#issuecomment-947139218 The content looks very good to me. The only concern I have is, this is going into Airflow internals that don't seem to fit with other things under *Concept* (which are mostly

[GitHub] [airflow] uranusjr commented on pull request #18988: SFTP hook to prefer the SSH paramiko key over the key file path

2021-10-19 Thread GitBox
uranusjr commented on pull request #18988: URL: https://github.com/apache/airflow/pull/18988#issuecomment-947131574 Could you address the review comment in the original PR? Namely https://github.com/apache/airflow/pull/16338/files#r649058789 -- This is an automated message from the Apach

[GitHub] [airflow] aladinoss commented on a change in pull request #16338: SFTP hook to prefer the SSH paramiko key over the key file path

2021-10-19 Thread GitBox
aladinoss commented on a change in pull request #16338: URL: https://github.com/apache/airflow/pull/16338#discussion_r688912522 ## File path: airflow/providers/sftp/hooks/sftp.py ## @@ -135,8 +135,13 @@ def get_conn(self) -> pysftp.Connection: } if sel

[GitHub] [airflow] github-actions[bot] commented on pull request #19065: Remove incorrect type comment in Swagger2Specification._set_defaults classmethod

2021-10-19 Thread GitBox
github-actions[bot] commented on pull request #19065: URL: https://github.com/apache/airflow/pull/19065#issuecomment-947126947 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] uranusjr commented on pull request #19065: Remove incorrect type comment in Swagger2Specification._set_defaults classmethod

2021-10-19 Thread GitBox
uranusjr commented on pull request #19065: URL: https://github.com/apache/airflow/pull/19065#issuecomment-947126150 Don't worry about that, it's unrelated and will be fixed separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] github-actions[bot] commented on pull request #18961: Convert www.security test suite to pytest and remove residuals

2021-10-19 Thread GitBox
github-actions[bot] commented on pull request #18961: URL: https://github.com/apache/airflow/pull/18961#issuecomment-947123706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [airflow] uranusjr commented on a change in pull request #18961: Convert www.security test suite to pytest and remove residuals

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #18961: URL: https://github.com/apache/airflow/pull/18961#discussion_r732258687 ## File path: tests/test_utils/api_connexion_utils.py ## @@ -80,15 +81,30 @@ def create_role(app, name, permissions=None): return role +def se

[GitHub] [airflow] uranusjr commented on a change in pull request #19084: [Oracle] Oracle Hook - automatically set current_schema when defined in Connection

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #19084: URL: https://github.com/apache/airflow/pull/19084#discussion_r732255335 ## File path: airflow/providers/oracle/hooks/oracle.py ## @@ -90,8 +91,8 @@ def get_conn(self) -> 'OracleHook': dsn = conn.host

[airflow] branch main updated (eb5cae0 -> 2179964)

2021-10-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from eb5cae0 Rename trigger page label to Logical Date (#19061) add 2179964 Updating TaskGroup unit test to h

[GitHub] [airflow] jedcunningham merged pull request #19089: Updating TaskGroup unit test to handle new tooltip

2021-10-19 Thread GitBox
jedcunningham merged pull request #19089: URL: https://github.com/apache/airflow/pull/19089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [airflow] mehmax commented on a change in pull request #19084: [Oracle] Oracle Hook - automatically set current_schema when defined in Connection

2021-10-19 Thread GitBox
mehmax commented on a change in pull request #19084: URL: https://github.com/apache/airflow/pull/19084#discussion_r732251123 ## File path: airflow/providers/oracle/hooks/oracle.py ## @@ -90,8 +91,8 @@ def get_conn(self) -> 'OracleHook': dsn = conn.host

[GitHub] [airflow] drobert commented on a change in pull request #19053: Referencing Connections in tutorial doc

2021-10-19 Thread GitBox
drobert commented on a change in pull request #19053: URL: https://github.com/apache/airflow/pull/19053#discussion_r732250913 ## File path: docs/apache-airflow/tutorial.rst ## @@ -446,13 +469,14 @@ Here we are passing a ``GET`` request to get the data from the URL and save it

[GitHub] [airflow] drobert commented on a change in pull request #19053: Referencing Connections in tutorial doc

2021-10-19 Thread GitBox
drobert commented on a change in pull request #19053: URL: https://github.com/apache/airflow/pull/19053#discussion_r732250067 ## File path: docs/apache-airflow/tutorial.rst ## @@ -410,23 +431,25 @@ Let's break this down into 2 steps: get data & merge data: @task def get

[GitHub] [airflow] drobert commented on a change in pull request #19053: Referencing Connections in tutorial doc

2021-10-19 Thread GitBox
drobert commented on a change in pull request #19053: URL: https://github.com/apache/airflow/pull/19053#discussion_r732249957 ## File path: docs/apache-airflow/tutorial.rst ## @@ -410,23 +431,25 @@ Let's break this down into 2 steps: get data & merge data: @task def get

[GitHub] [airflow] drobert commented on a change in pull request #19053: Referencing Connections in tutorial doc

2021-10-19 Thread GitBox
drobert commented on a change in pull request #19053: URL: https://github.com/apache/airflow/pull/19053#discussion_r732249440 ## File path: docs/apache-airflow/tutorial.rst ## @@ -374,9 +374,30 @@ Lets look at another example; we need to get some data from a file which is host

[GitHub] [airflow] uranusjr commented on pull request #19088: Change `ds`, `ts`, etc. back to use logical date

2021-10-19 Thread GitBox
uranusjr commented on pull request #19088: URL: https://github.com/apache/airflow/pull/19088#issuecomment-947108055 Because all existing tests have matching `execution_date` and `data_interval_start`. I'll add a test that replicates the failure in #19058 so this won't regress acidentally.

[GitHub] [airflow] uranusjr commented on a change in pull request #18897: Fix catchup by limiting queued dagrun creation using max_active_runs

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #18897: URL: https://github.com/apache/airflow/pull/18897#discussion_r732245384 ## File path: airflow/jobs/scheduler_job.py ## @@ -839,30 +839,19 @@ def _create_dag_runs(self, dag_models: Collection[DagModel], session: Session) -

[GitHub] [airflow] github-actions[bot] commented on pull request #19089: Updating TaskGroup unit test to handle new tooltip

2021-10-19 Thread GitBox
github-actions[bot] commented on pull request #19089: URL: https://github.com/apache/airflow/pull/19089#issuecomment-947106533 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] uranusjr commented on issue #17190: Fetching remote s3 logs fails: An error occurred (AccessDenied) when calling the AssumeRole operation

2021-10-19 Thread GitBox
uranusjr commented on issue #17190: URL: https://github.com/apache/airflow/issues/17190#issuecomment-947103660 I gather this can be closed then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] uranusjr commented on issue #17190: Fetching remote s3 logs fails: An error occurred (AccessDenied) when calling the AssumeRole operation

2021-10-19 Thread GitBox
uranusjr commented on issue #17190: URL: https://github.com/apache/airflow/issues/17190#issuecomment-947103509 It is highly recommended to make sure whatever environment Airflow is running in satisfies the constraint file, so yes. -- This is an automated message from the Apache Git Servi

[airflow] branch main updated (5c79495 -> eb5cae0)

2021-10-19 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 5c79495 Add dataroots to Airflow users (#19074) add eb5cae0 Rename trigger page label to Logical Date (#19061

[GitHub] [airflow] uranusjr merged pull request #19061: Rename trigger page label to Logical Date

2021-10-19 Thread GitBox
uranusjr merged pull request #19061: URL: https://github.com/apache/airflow/pull/19061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[airflow] branch main updated (ee4fb07 -> 5c79495)

2021-10-19 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from ee4fb07 Allow Param to support a default value of ``None`` (#19034) add 5c79495 Add dataroots to Airflow user

[GitHub] [airflow] uranusjr merged pull request #19074: add dataroots to airflow users

2021-10-19 Thread GitBox
uranusjr merged pull request #19074: URL: https://github.com/apache/airflow/pull/19074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19074: add dataroots to airflow users

2021-10-19 Thread GitBox
boring-cyborg[bot] commented on pull request #19074: URL: https://github.com/apache/airflow/pull/19074#issuecomment-947100899 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] uranusjr commented on pull request #16931: #16692 show schedule_interval/timetable description in UI

2021-10-19 Thread GitBox
uranusjr commented on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-947099358 > I think it's better to show a message that says "descritpion can not be evaluated for non standard cron" or something of a sort That works for me. My main concern is

[GitHub] [airflow] uranusjr commented on a change in pull request #18590: Fixing bug when roles list is empty

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #18590: URL: https://github.com/apache/airflow/pull/18590#discussion_r732237155 ## File path: airflow/cli/commands/user_command.py ## @@ -174,12 +189,19 @@ def users_import(args): print("Updated the following users:\n\t{}

[GitHub] [airflow] uranusjr commented on pull request #19053: Referencing Connections in tutorial doc

2021-10-19 Thread GitBox
uranusjr commented on pull request #19053: URL: https://github.com/apache/airflow/pull/19053#issuecomment-947090328 Instead of repeating the example code, we should probably move the example to `airflow/example_dags` and use `exampleinclude` instead (search for this in the documentation fo

[GitHub] [airflow] uranusjr commented on a change in pull request #19053: Referencing Connections in tutorial doc

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #19053: URL: https://github.com/apache/airflow/pull/19053#discussion_r732229012 ## File path: docs/apache-airflow/tutorial.rst ## @@ -446,13 +469,14 @@ Here we are passing a ``GET`` request to get the data from the URL and save it

[GitHub] [airflow] uranusjr commented on a change in pull request #19053: Referencing Connections in tutorial doc

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #19053: URL: https://github.com/apache/airflow/pull/19053#discussion_r732228204 ## File path: docs/apache-airflow/tutorial.rst ## @@ -410,23 +431,25 @@ Let's break this down into 2 steps: get data & merge data: @task def ge

[GitHub] [airflow] uranusjr commented on a change in pull request #19053: Referencing Connections in tutorial doc

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #19053: URL: https://github.com/apache/airflow/pull/19053#discussion_r732227764 ## File path: docs/apache-airflow/tutorial.rst ## @@ -410,23 +431,25 @@ Let's break this down into 2 steps: get data & merge data: @task def ge

[GitHub] [airflow] josh-fell opened a new pull request #19089: Updating TaskGroup unit test to handle new tooltip

2021-10-19 Thread GitBox
josh-fell opened a new pull request #19089: URL: https://github.com/apache/airflow/pull/19089 Fixing current failing tasks on `main` for `tests/utils/test_task_group` to handle the new tooltip enhancement. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] uranusjr commented on a change in pull request #19053: Referencing Connections in tutorial doc

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #19053: URL: https://github.com/apache/airflow/pull/19053#discussion_r732226978 ## File path: docs/apache-airflow/tutorial.rst ## @@ -374,9 +374,30 @@ Lets look at another example; we need to get some data from a file which is hos

[GitHub] [airflow] uranusjr commented on a change in pull request #19084: [Oracle] Oracle Hook - automatically set current_schema when defined in Connection

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #19084: URL: https://github.com/apache/airflow/pull/19084#discussion_r732225328 ## File path: airflow/providers/oracle/hooks/oracle.py ## @@ -90,8 +91,8 @@ def get_conn(self) -> 'OracleHook': dsn = conn.host

[GitHub] [airflow] uranusjr commented on a change in pull request #19084: [Oracle] Oracle Hook - automatically set current_schema when defined in Connection

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #19084: URL: https://github.com/apache/airflow/pull/19084#discussion_r732225002 ## File path: airflow/providers/oracle/hooks/oracle.py ## @@ -136,6 +137,12 @@ def get_conn(self) -> 'OracleHook': if mod is not None:

[GitHub] [airflow] uranusjr commented on a change in pull request #19084: [Oracle] Oracle Hook - automatically set current_schema when defined in Connection

2021-10-19 Thread GitBox
uranusjr commented on a change in pull request #19084: URL: https://github.com/apache/airflow/pull/19084#discussion_r732224449 ## File path: airflow/providers/oracle/hooks/oracle.py ## @@ -136,6 +137,12 @@ def get_conn(self) -> 'OracleHook': if mod is not None:

[airflow] branch main updated (fe28902 -> ee4fb07)

2021-10-19 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from fe28902 Add docker-compose explanation to conn localhost (#19076) add ee4fb07 Allow Param to support a defaul

[GitHub] [airflow] uranusjr closed issue #18909: `None` values no longer accepted in `params`

2021-10-19 Thread GitBox
uranusjr closed issue #18909: URL: https://github.com/apache/airflow/issues/18909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [airflow] uranusjr merged pull request #19034: Allow Param to support a default value of ``None``

2021-10-19 Thread GitBox
uranusjr merged pull request #19034: URL: https://github.com/apache/airflow/pull/19034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[airflow] branch main updated: Add docker-compose explanation to conn localhost (#19076)

2021-10-19 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fe28902 Add docker-compose explanation to conn l

[GitHub] [airflow] uranusjr merged pull request #19076: Add docker-compose explanation to conn localhost

2021-10-19 Thread GitBox
uranusjr merged pull request #19076: URL: https://github.com/apache/airflow/pull/19076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19076: Add docker-compose explanation to conn localhost

2021-10-19 Thread GitBox
boring-cyborg[bot] commented on pull request #19076: URL: https://github.com/apache/airflow/pull/19076#issuecomment-947077603 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[airflow] branch main updated (8745fb9 -> 4548199)

2021-10-19 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 8745fb9 Fix: Add taskgroup tooltip to graph view (#19083) add 4548199 Relax packaging requirement (#19087) N

[GitHub] [airflow] uranusjr merged pull request #19087: Relax packaging requirement

2021-10-19 Thread GitBox
uranusjr merged pull request #19087: URL: https://github.com/apache/airflow/pull/19087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] uranusjr commented on pull request #19087: Relax packaging requirement

2021-10-19 Thread GitBox
uranusjr commented on pull request #19087: URL: https://github.com/apache/airflow/pull/19087#issuecomment-947073953 Failures seem unrelated (also happening in main). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] uranusjr commented on pull request #19085: Correct Task definition in docs

2021-10-19 Thread GitBox
uranusjr commented on pull request #19085: URL: https://github.com/apache/airflow/pull/19085#issuecomment-947073175 It is unclear to me how this is a "correction"; the two reads mostly equivalent to me (and the one from main is even slightly more accurate since "constructor" is not technic

[GitHub] [airflow] github-actions[bot] commented on pull request #19087: Relax packaging requirement

2021-10-19 Thread GitBox
github-actions[bot] commented on pull request #19087: URL: https://github.com/apache/airflow/pull/19087#issuecomment-947040204 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] uranusjr opened a new pull request #19088: Change `ds`, `ts`, etc. back to use logical date

2021-10-19 Thread GitBox
uranusjr opened a new pull request #19088: URL: https://github.com/apache/airflow/pull/19088 One part of the step 1 as outlined in https://github.com/apache/airflow/issues/19058#issuecomment-947023469 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] ferruzzi edited a comment on issue #15434: KubernetesPodOperator name randomization

2021-10-19 Thread GitBox
ferruzzi edited a comment on issue #15434: URL: https://github.com/apache/airflow/issues/15434#issuecomment-947023942 I can take this one on. [[EDIT: Removed question, I was totally overthinking it. I got this.]] -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] ferruzzi edited a comment on issue #15434: KubernetesPodOperator name randomization

2021-10-19 Thread GitBox
ferruzzi edited a comment on issue #15434: URL: https://github.com/apache/airflow/issues/15434#issuecomment-947023942 I can take this one on. [[EDIT: I was totally overthinking it, I got this.]] -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] uranusjr opened a new pull request #19087: Relax packaging requirement

2021-10-19 Thread GitBox
uranusjr opened a new pull request #19087: URL: https://github.com/apache/airflow/pull/19087 We only use packaging for version parsing, which has existed since 14.0, so let's relax the version range. The previous range causes issues with dbt-core, which (IMO) also unreasonably pins packagi

  1   2   3   >