[jira] [Comment Edited] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694195#comment-17694195 ] Stefan Miklosovic edited comment on CASSANDRA-17561 at 2/28/23 7:57 AM: --

[jira] [Comment Edited] (CASSANDRA-18268) Log completed status with cleanup and garbagecollect operations

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694368#comment-17694368 ] Stefan Miklosovic edited comment on CASSANDRA-18268 at 2/28/23 7:49 AM: --

[jira] [Comment Edited] (CASSANDRA-18268) Log completed status with cleanup and garbagecollect operations

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694368#comment-17694368 ] Stefan Miklosovic edited comment on CASSANDRA-18268 at 2/28/23 7:30 AM: --

[jira] [Commented] (CASSANDRA-18268) Log completed status with cleanup and garbagecollect operations

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694368#comment-17694368 ] Stefan Miklosovic commented on CASSANDRA-18268: --- Thanks [~milan_k] for

[jira] [Commented] (CASSANDRA-18283) Enhance nodetool tablestats

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694336#comment-17694336 ] Stefan Miklosovic commented on CASSANDRA-18283: --- Waiting for more feed

[jira] [Commented] (CASSANDRA-18270) ssl-factory demo in examples is broken

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694328#comment-17694328 ] Stefan Miklosovic commented on CASSANDRA-18270: --- Yes, but we need to m

[cassandra-website] branch asf-staging updated (9f76f62cc -> 98fcc69a4)

2023-02-27 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git omit 9f76f62cc generate docs for f808afdf new 98fcc69a4 generate docs for f808afdf This update

[jira] [Commented] (CASSANDRA-18268) Log completed status with cleanup and garbagecollect operations

2023-02-27 Thread Milan Krisko (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694236#comment-17694236 ] Milan Krisko commented on CASSANDRA-18268: -- Okay [~smiklosovic], I have upd

[jira] [Commented] (CASSANDRA-18125) AssertionError on thread MemtableReclaimMemory in MemtablePool$SubPool.released(MemtablePool.java:193)

2023-02-27 Thread Jon Meredith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694220#comment-17694220 ] Jon Meredith commented on CASSANDRA-18125: -- So Benedict has fixed the issue

[jira] [Comment Edited] (CASSANDRA-18270) ssl-factory demo in examples is broken

2023-02-27 Thread Maulin Vasavada (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694218#comment-17694218 ] Maulin Vasavada edited comment on CASSANDRA-18270 at 2/27/23 11:21 PM: ---

[jira] [Commented] (CASSANDRA-18270) ssl-factory demo in examples is broken

2023-02-27 Thread Maulin Vasavada (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694218#comment-17694218 ] Maulin Vasavada commented on CASSANDRA-18270: - Sure [~smiklosovic] I thi

[jira] [Comment Edited] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy

2023-02-27 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694206#comment-17694206 ] Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 2/27/23 10:27 PM: ---

[jira] [Comment Edited] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy

2023-02-27 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694206#comment-17694206 ] Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 2/27/23 10:27 PM: ---

[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy

2023-02-27 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694206#comment-17694206 ] Ekaterina Dimitrova commented on CASSANDRA-18106: - That is weird

[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy

2023-02-27 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694204#comment-17694204 ] Brandon Williams commented on CASSANDRA-18106: -- Interesting, they [fail

[jira] [Commented] (CASSANDRA-18290) Test Failure: SecondaryIndexTest.testUpdatesToMemtableData

2023-02-27 Thread maxwellguo (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694201#comment-17694201 ] maxwellguo commented on CASSANDRA-18290: I think I can take this ticket as I

[jira] [Assigned] (CASSANDRA-18290) Test Failure: SecondaryIndexTest.testUpdatesToMemtableData

2023-02-27 Thread maxwellguo (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maxwellguo reassigned CASSANDRA-18290: -- Assignee: maxwellguo > Test Failure: SecondaryIndexTest.testUpdatesToMemtableData

[jira] [Updated] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17561: -- Status: Ready to Commit (was: Review In Progress) > Diagnostic snapshot s

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694195#comment-17694195 ] Stefan Miklosovic commented on CASSANDRA-17561: --- CI still looks solid

[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy

2023-02-27 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694188#comment-17694188 ] Ekaterina Dimitrova commented on CASSANDRA-18106: - In the last run p

[jira] [Created] (CASSANDRA-18290) Test Failure: SecondaryIndexTest.testUpdatesToMemtableData

2023-02-27 Thread Michael Semb Wever (Jira)
Michael Semb Wever created CASSANDRA-18290: -- Summary: Test Failure: SecondaryIndexTest.testUpdatesToMemtableData Key: CASSANDRA-18290 URL: https://issues.apache.org/jira/browse/CASSANDRA-18290

[jira] [Updated] (CASSANDRA-18290) Test Failure: SecondaryIndexTest.testUpdatesToMemtableData

2023-02-27 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18290: --- Fix Version/s: 4.1.x > Test Failure: SecondaryIndexTest.testUpdatesToMem

[jira] [Updated] (CASSANDRA-18289) Test Failure: sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail

2023-02-27 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18289: --- Fix Version/s: 4.x > Test Failure: > sslnodetonode_test.TestNodeToNodeS

[jira] [Created] (CASSANDRA-18289) Test Failure: sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail

2023-02-27 Thread Michael Semb Wever (Jira)
Michael Semb Wever created CASSANDRA-18289: -- Summary: Test Failure: sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail Key: CASSANDRA-18289 URL: https://issues.apache.org/ji

[jira] [Updated] (CASSANDRA-18287) Test Failure: InsertUpdateIfConditionTest.testMultiExistConditionOnSameRowClustering

2023-02-27 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18287: --- Fix Version/s: 4.x > Test Failure: > InsertUpdateIfConditionTest.testMu

[jira] [Updated] (CASSANDRA-18288) Test Failure: TopPartitionsTest.basicRegularTombstonesTest

2023-02-27 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18288: --- Fix Version/s: 4.x > Test Failure: TopPartitionsTest.basicRegularTombsto

[jira] [Created] (CASSANDRA-18288) Test Failure: TopPartitionsTest.basicRegularTombstonesTest

2023-02-27 Thread Michael Semb Wever (Jira)
Michael Semb Wever created CASSANDRA-18288: -- Summary: Test Failure: TopPartitionsTest.basicRegularTombstonesTest Key: CASSANDRA-18288 URL: https://issues.apache.org/jira/browse/CASSANDRA-18288

[jira] [Created] (CASSANDRA-18287) Test Failure: InsertUpdateIfConditionTest.testMultiExistConditionOnSameRowClustering

2023-02-27 Thread Michael Semb Wever (Jira)
Michael Semb Wever created CASSANDRA-18287: -- Summary: Test Failure: InsertUpdateIfConditionTest.testMultiExistConditionOnSameRowClustering Key: CASSANDRA-18287 URL: https://issues.apache.org/jira/browse/C

[jira] [Updated] (CASSANDRA-18286) Test Failure: TTLTest.testCapWarnExpirationOverflowPolicy negative deletion and expiry value

2023-02-27 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18286: --- Fix Version/s: 3.0.x > Test Failure: TTLTest.testCapWarnExpirationOverfl

[jira] [Created] (CASSANDRA-18286) Test Failure: TTLTest.testCapWarnExpirationOverflowPolicy negative deletion and expiry value

2023-02-27 Thread Michael Semb Wever (Jira)
Michael Semb Wever created CASSANDRA-18286: -- Summary: Test Failure: TTLTest.testCapWarnExpirationOverflowPolicy negative deletion and expiry value Key: CASSANDRA-18286 URL: https://issues.apache.org/jira/

[jira] [Commented] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue

2023-02-27 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694176#comment-17694176 ] David Capwell commented on CASSANDRA-18212: --- +1 > Reduce memory allocatio

[jira] [Comment Edited] (CASSANDRA-18249) Docker image for releases

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694143#comment-17694143 ] Stefan Miklosovic edited comment on CASSANDRA-18249 at 2/27/23 7:25 PM: --

[jira] [Commented] (CASSANDRA-18249) Docker image for releases

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694143#comment-17694143 ] Stefan Miklosovic commented on CASSANDRA-18249: --- That seems right.  I

[jira] [Updated] (CASSANDRA-18283) Enhance nodetool tablestats

2023-02-27 Thread Brad Schoening (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brad Schoening updated CASSANDRA-18283: --- Description: The nodetool tablestats command lacks some available details which

[jira] [Updated] (CASSANDRA-18258) Add test conf for JDK17

2023-02-27 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18258: Source Control Link: https://github.com/apache/cassandra/commit/d1e3c7

[jira] [Updated] (CASSANDRA-18258) Add test conf for JDK17

2023-02-27 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18258: Fix Version/s: 4.2 (was: 4.x) > Add test conf f

[jira] [Commented] (CASSANDRA-18258) Add test conf for JDK17

2023-02-27 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694094#comment-17694094 ] Ekaterina Dimitrova commented on CASSANDRA-18258: - Committed to trun

[cassandra] branch trunk updated: Add JDK17 startup scripts patch by Ekaterina Dimitrova; reviewed by Mick Semb Wever for CASSANDRA-18258

2023-02-27 Thread edimitrova
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new d1e3c781b5 Add JDK17 startup scripts patch

[jira] [Assigned] (CASSANDRA-18262) Switch ant targets running only with JDK8 to be run with JDK11

2023-02-27 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reassigned CASSANDRA-18262: Assignee: Brandon Williams > Switch ant targets running only with JDK

[jira] [Updated] (CASSANDRA-18258) Add test conf for JDK17

2023-02-27 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18258: Status: Ready to Commit (was: Review In Progress) > Add test conf for

[jira] [Commented] (CASSANDRA-18249) Docker image for releases

2023-02-27 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694086#comment-17694086 ] Brandon Williams commented on CASSANDRA-18249: -- That is unfortunate, I

[jira] [Updated] (CASSANDRA-18268) Log completed status with cleanup and garbagecollect operations

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18268: -- Reviewers: Stefan Miklosovic Status: Review In Progress (was: Patch

[jira] [Updated] (CASSANDRA-18268) Log completed status with cleanup and garbagecollect operations

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18268: -- Status: Changes Suggested (was: Review In Progress) > Log completed statu

[jira] [Commented] (CASSANDRA-18268) Log completed status with cleanup and garbagecollect operations

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694067#comment-17694067 ] Stefan Miklosovic commented on CASSANDRA-18268: --- I took a look into th

[jira] [Commented] (CASSANDRA-18249) Docker image for releases

2023-02-27 Thread Berenguer Blasi (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694040#comment-17694040 ] Berenguer Blasi commented on CASSANDRA-18249: - Nah it isn't. Some people

[jira] [Commented] (CASSANDRA-18143) upgradesstables does not always upgrade tables in proper order.

2023-02-27 Thread Jacek Lewandowski (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694013#comment-17694013 ] Jacek Lewandowski commented on CASSANDRA-18143: --- Let's conclude this t

[jira] [Commented] (CASSANDRA-18249) Docker image for releases

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693995#comment-17693995 ] Stefan Miklosovic commented on CASSANDRA-18249: --- It is not in focal (2

[jira] [Commented] (CASSANDRA-18249) Docker image for releases

2023-02-27 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693992#comment-17693992 ] Brandon Williams commented on CASSANDRA-18249: -- bq. It is neither avai

[jira] [Updated] (CASSANDRA-18240) Using SELECT COUNT(*) FROM... LIMIT 1 in the returning section results in ClassCastException

2023-02-27 Thread Jacek Lewandowski (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18240: -- Fix Version/s: NA Since Version: NA Source Control Link

[cassandra] branch cep-15-accord updated: Fix statement validation against partition range queries

2023-02-27 Thread jlewandowski
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a commit to branch cep-15-accord in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cep-15-accord by this push: new 6989e93074 Fix statement

[jira] [Updated] (CASSANDRA-18240) Using SELECT COUNT(*) FROM... LIMIT 1 in the returning section results in ClassCastException

2023-02-27 Thread Jacek Lewandowski (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18240: -- Status: Ready to Commit (was: Review In Progress) > Using SELECT COUNT(*)

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693884#comment-17693884 ] Stefan Miklosovic commented on CASSANDRA-17561: --- Yeah, since this is a

[jira] [Commented] (CASSANDRA-18271) Centralize all snapshot operations to SnapshotManager

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693877#comment-17693877 ] Stefan Miklosovic commented on CASSANDRA-18271: --- sure! At least we don

[cassandra-website] branch asf-site updated (8d9bce3c4 -> 9f76f62cc)

2023-02-27 Thread mck
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 8d9bce3c4 generate docs for 8545a889 add 4bf64ca6a GSoD proposal for 2023 blog add f808afdf1 Fix t