[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337853752 ## build.gradle: ## @@ -108,6 +121,12 @@ rat { // resource files for test excludes.add("**/test**/resources/**") + // resources Review Comment:

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337711756 ## scripts/build-sidecar.sh: ## @@ -0,0 +1,48 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337704175 ## cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/testing/TestVersionSupplier.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the A

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337701632 ## config/checkstyle/checkstyle.xml: ## @@ -203,15 +203,15 @@ - + - - -

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337698527 ## scripts/build-sidecar.sh: ## @@ -0,0 +1,48 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337695886 ## scripts/build-sidecar.sh: ## @@ -0,0 +1,48 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337693032 ## build.gradle: ## @@ -108,6 +121,12 @@ rat { // resource files for test excludes.add("**/test**/resources/**") + // resources Review Comment:

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1327707154 ## scripts/build-dependencies.sh: ## @@ -0,0 +1,23 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1327706372 ## build.gradle: ## @@ -68,9 +77,10 @@ tasks.idea.dependsOn(tasks.copyInspections) tasks.register('buildIgnoreRatList', Exec) { description 'Builds a

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1327668445 ## gradle.properties: ## @@ -29,5 +29,6 @@ jnaVersion=5.9.0 scala=2.12 spark=3 vertxVersion=4.2.1 +sidecarVersion=1.0.0-analytics Review Comment: 👍

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1327667256 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java: ## @@ -129,16 +130,15 @@ public static SidecarClient from(SidecarInsta

[GitHub] [cassandra-analytics] JeetKunDoug commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1327608300 ## build.gradle: ## @@ -68,9 +77,10 @@ tasks.idea.dependsOn(tasks.copyInspections) tasks.register('buildIgnoreRatList', Exec) { description 'Builds a