[GitHub] [cassandra-analytics] frankgh commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

frankgh commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337851038 ## cassandra-analytics-core-example/README.md: ## @@ -108,8 +110,8 @@ cassandra_instances: I have a 3 node setup, so I configure Sidecar for those 3 nodes. CC

[GitHub] [cassandra-analytics] frankgh commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

frankgh commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337850430 ## build.gradle: ## @@ -108,6 +121,12 @@ rat { // resource files for test excludes.add("**/test**/resources/**") + // resources Review Comment: fr

[GitHub] [cassandra-analytics] frankgh commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

frankgh commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1329118359 ## build.gradle: ## @@ -108,6 +121,12 @@ rat { // resource files for test excludes.add("**/test**/resources/**") + // resources Review Comment: we

[GitHub] [cassandra-analytics] frankgh commented on a diff in pull request #14: CASSANDRA-18759: Use in-jvm dtest framework from Sidecar for testing

frankgh commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1326688112 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java: ## @@ -129,16 +130,15 @@ public static SidecarClient from(SidecarInstances