absurdfarce commented on PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#issuecomment-1989597253
With two +1's from committers (mine + one from driftx on the JIRA ticket)
this ticket was considered eligible to merge.
--
This is an automated message from the Apach
absurdfarce merged PR #1907:
URL: https://github.com/apache/cassandra-java-driver/pull/1907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
absurdfarce commented on PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#issuecomment-1931068838
FTR these changes got a clean run on DataStax Jenkins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
absurdfarce commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1478784272
##
core/src/main/java/com/datastax/oss/driver/internal/core/ssl/ReloadingKeyManagerFactory.java:
##
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache
absurdfarce commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1478776793
##
upgrade_guide/README.md:
##
@@ -19,6 +19,17 @@ under the License.
## Upgrade guide
+### NEW VERSION PLACEHOLDER
Review Comment:
Your sugg
aratno commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1476669128
##
upgrade_guide/README.md:
##
@@ -19,6 +19,17 @@ under the License.
## Upgrade guide
+### NEW VERSION PLACEHOLDER
Review Comment:
@absurdfarce L
aratno commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1476658241
##
core/src/main/resources/reference.conf:
##
@@ -790,6 +790,13 @@ datastax-java-driver {
// truststore-password = password123
// keystore-path
absurdfarce commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1470651460
##
core/src/main/resources/reference.conf:
##
@@ -790,6 +790,13 @@ datastax-java-driver {
// truststore-password = password123
// keystore-
tolbertam commented on PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#issuecomment-1908284283
I ran the entire integration suite this PR and seemed to run pretty good;
Since i'm on a M1 mac and need your
[CASSANDRA-19292](https://issues.apache.org/jira/brows
aratno commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1464035185
##
core/src/main/java/com/datastax/oss/driver/api/core/config/DefaultDriverOption.java:
##
@@ -255,6 +255,12 @@ public enum DefaultDriverOption implements
tolbertam commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1464032000
##
core/src/main/java/com/datastax/oss/driver/api/core/config/DefaultDriverOption.java:
##
@@ -255,6 +255,12 @@ public enum DefaultDriverOption impleme
aratno commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1464029541
##
core/src/main/java/com/datastax/oss/driver/internal/core/ssl/ReloadingKeyManagerFactory.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Softw
aratno commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1463983979
##
core/src/main/java/com/datastax/oss/driver/internal/core/ssl/ReloadingKeyManagerFactory.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Softw
aratno commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1463975280
##
core/src/main/java/com/datastax/oss/driver/internal/core/ssl/ReloadingKeyManagerFactory.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Softw
aratno commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1463974845
##
core/src/main/java/com/datastax/oss/driver/internal/core/ssl/ReloadingKeyManagerFactory.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Softw
tolbertam commented on code in PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#discussion_r1463852818
##
core/src/main/java/com/datastax/oss/driver/internal/core/ssl/ReloadingKeyManagerFactory.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache So
aratno opened a new pull request, #1907:
URL: https://github.com/apache/cassandra-java-driver/pull/1907
Jira: https://issues.apache.org/jira/browse/CASSANDRA-19180
This PR includes keystore reloading for `DefautlSslEngineFactory`,
implemented by checking the contents of the keystore f
17 matches
Mail list logo
