[ https://issues.apache.org/jira/browse/CASSANDRA-16288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235664#comment-17235664 ]
David Capwell edited comment on CASSANDRA-16288 at 11/19/20, 6:58 PM: ---------------------------------------------------------------------- {code} <path id="cassandra.classpath.test"> <file file="${build.dir}/${final.name}.jar"/> <!-- we need the jar for tests and benchmarks (multi-version jar) --> <fileset dir="${build.lib}"> <include name="**/*.jar"/> <exclude name="**/*-sources.jar"/> <exclude name="**/ant-*.jar"/> </fileset> <fileset dir="${build.dir.lib}"> <include name="**/*.jar"/> <exclude name="**/*-sources.jar"/> <exclude name="**/ant-*.jar"/> </fileset> </path> {code} vs {code} <target name="dtest-jar" depends="build-test, build" description="Create dtest-compatible jar, including all dependencies"> <jar jarfile="${build.dir}/dtest-${base.version}.jar"> <zipgroupfileset dir="${build.lib}" includes="*.jar" excludes="META-INF/*.SF"/> <fileset dir="${build.classes.main}"/> <fileset dir="${test.classes}"/> <fileset dir="${test.conf}"/> </jar> </target> {code} Looks like we are only adding the src jars not the test jars, can we include the test jars? was (Author: dcapwell): {code} <path id="cassandra.classpath.test"> <file file="${build.dir}/${final.name}.jar"/> <!-- we need the jar for tests and benchmarks (multi-version jar) --> <fileset dir="${build.lib}"> <include name="**/*.jar" /> <exclude name="**/*-sources.jar"/> <exclude name="**/ant-*.jar"/> </fileset> <fileset dir="${build.dir.lib}"> <include name="**/*.jar" /> <exclude name="**/*-sources.jar"/> <exclude name="**/ant-*.jar"/> </fileset> </path> {code} vs {code} <target name="dtest-jar" depends="build-test, build" description="Create dtest-compatible jar, including all dependencies"> <jar jarfile="${build.dir}/dtest-${base.version}.jar"> <zipgroupfileset dir="${build.lib}" includes="*.jar" excludes="META-INF/*.SF"/> <fileset dir="${build.classes.main}"/> <fileset dir="${test.classes}"/> <fileset dir="${test.conf}" /> </jar> </target> {code} Looks like we are only adding the src jars not the test jars, can we include the test jars? > Add reflections and javassist jars to 4.0 (trunk) lib directory > ---------------------------------------------------------------- > > Key: CASSANDRA-16288 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16288 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java > Reporter: Alex Petrov > Assignee: Alex Petrov > Priority: Normal > > Add reflections and javassist jars to 4.0 (trunk) lib directory, since > they're required for dtest uberjar. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org