[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-11 Thread Jordan West (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034571#comment-17034571 ] Jordan West commented on CASSANDRA-15556: - LGTM. Thanks [~dcapwell] > When

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-11 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034563#comment-17034563 ] David Capwell commented on CASSANDRA-15556: --- [~ifesdjeen] [~brandon.willia

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-07 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032650#comment-17032650 ] David Capwell commented on CASSANDRA-15556: --- bq. but I remember segfaulti

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-07 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032646#comment-17032646 ] David Capwell commented on CASSANDRA-15556: --- [~jrwest] pushed the change t

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-07 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032643#comment-17032643 ] David Capwell commented on CASSANDRA-15556: --- bq. Minor nit: any reason I'm

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-07 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032596#comment-17032596 ] David Capwell commented on CASSANDRA-15556: --- latest test results with the

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-07 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032507#comment-17032507 ] David Capwell commented on CASSANDRA-15556: --- Thanks. so my test ran again

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-07 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032456#comment-17032456 ] Brandon Williams commented on CASSANDRA-15556: -- bq. I’ll have to double

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-07 Thread Alex Petrov (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032453#comment-17032453 ] Alex Petrov commented on CASSANDRA-15556: - There's one more issue that is re

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-07 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032447#comment-17032447 ] David Capwell commented on CASSANDRA-15556: --- I’ll have to double check /li

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-07 Thread Jordan West (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032249#comment-17032249 ] Jordan West commented on CASSANDRA-15556: - Thanks [~dcapwell]. Patch overall

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-06 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032125#comment-17032125 ] David Capwell commented on CASSANDRA-15556: --- [~samt] [~brandon.williams] c

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-06 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032118#comment-17032118 ] David Capwell commented on CASSANDRA-15556: --- [Circle CI|https://circleci.

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-06 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032117#comment-17032117 ] David Capwell commented on CASSANDRA-15556: --- With the patch {code} Benchm

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-06 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032116#comment-17032116 ] David Capwell commented on CASSANDRA-15556: --- This patch depends on CASSAND

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-06 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032053#comment-17032053 ] David Capwell commented on CASSANDRA-15556: --- [~cscotta] noticed that this

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-06 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032052#comment-17032052 ] David Capwell commented on CASSANDRA-15556: --- Here is a test case which cau

[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash

2020-02-06 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032051#comment-17032051 ] David Capwell commented on CASSANDRA-15556: --- This is localized to the clie