[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248740#comment-16248740
]
Jay Zhuang commented on CASSANDRA-9988:
---
Thanks [~jasobrown] for the review.
bq.
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244848#comment-16244848
]
Jason Brown commented on CASSANDRA-9988:
Overall, I think the patch is pretty
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120862#comment-16120862
]
Jay Zhuang commented on CASSANDRA-9988:
---
[~Anthony Grasso] would you please fina
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118100#comment-16118100
]
Benedict commented on CASSANDRA-9988:
-
bq. The original implementation is valid. I
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117669#comment-16117669
]
Jay Zhuang commented on CASSANDRA-9988:
---
I created CASSANDRA-13748 for expSearch
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117210#comment-16117210
]
Jay Zhuang commented on CASSANDRA-9988:
---
Hi [~benedict] thanks for the quick res
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116363#comment-16116363
]
Benedict commented on CASSANDRA-9988:
-
I will, separately, note that I suspect we'
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116265#comment-16116265
]
Benedict commented on CASSANDRA-9988:
-
bq. very bad average performance
Could you
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116055#comment-16116055
]
Jay Zhuang commented on CASSANDRA-9988:
---
Here are the test results to search tar
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106073#comment-16106073
]
Benedict commented on CASSANDRA-9988:
-
Assuming your implementation is correct, he
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105981#comment-16105981
]
Jay Zhuang commented on CASSANDRA-9988:
---
Hi [~benedict], would you please point
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103033#comment-16103033
]
Benedict commented on CASSANDRA-9988:
-
Well, it's been a while since I looked at t
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102704#comment-16102704
]
Jay Zhuang commented on CASSANDRA-9988:
---
Hi [~benedict], re-read [your comments
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102593#comment-16102593
]
Jay Zhuang commented on CASSANDRA-9988:
---
{quote}
However, these are iterators, a
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102503#comment-16102503
]
Jay Zhuang commented on CASSANDRA-9988:
---
{quote}
Also, what exactly are these gr
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102361#comment-16102361
]
Benedict commented on CASSANDRA-9988:
-
Also, what exactly are these graphs showing
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102358#comment-16102358
]
Benedict commented on CASSANDRA-9988:
-
So, I took a quick peek at your actual test
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102332#comment-16102332
]
Jay Zhuang commented on CASSANDRA-9988:
---
They're good feedbacks. I did the tests
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101956#comment-16101956
]
Benedict commented on CASSANDRA-9988:
-
Right.
That, and my allusion to a "repres
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101919#comment-16101919
]
Ariel Weisberg commented on CASSANDRA-9988:
---
I think Benedict was looking fo
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099288#comment-16099288
]
Jay Zhuang commented on CASSANDRA-9988:
---
hi [~benedict] I also added tests for d
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097163#comment-16097163
]
Benedict commented on CASSANDRA-9988:
-
So, for the record, I wasn't suggesting a h
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097112#comment-16097112
]
Jay Zhuang commented on CASSANDRA-9988:
---
I added tests for different cell size a
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095840#comment-16095840
]
Jay Zhuang commented on CASSANDRA-9988:
---
[~Anthony Grasso] Thank you for the rev
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094089#comment-16094089
]
Anthony Grasso commented on CASSANDRA-9988:
---
[~jay.zhuang] one other thing I
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094069#comment-16094069
]
Anthony Grasso commented on CASSANDRA-9988:
---
[~benedict], that is a very goo
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092846#comment-16092846
]
Benedict commented on CASSANDRA-9988:
-
Before committing, you may want to consider
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092832#comment-16092832
]
Anthony Grasso commented on CASSANDRA-9988:
---
Have reviewed the code.
Ran th
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058529#comment-16058529
]
Nate McCall commented on CASSANDRA-9988:
We have a few spare cycles coming up.
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966767#comment-15966767
]
Jay Zhuang commented on CASSANDRA-9988:
---
Rebased the
[patch|https://github.com/
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838635#comment-15838635
]
Jay Zhuang commented on CASSANDRA-9988:
---
Thanks Benedict for your quick response
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838313#comment-15838313
]
Benedict commented on CASSANDRA-9988:
-
Sorry Jay, not anytime soon. I no longer w
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838272#comment-15838272
]
Jay Zhuang commented on CASSANDRA-9988:
---
[~benedict] would you please review the
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833718#comment-15833718
]
Jay Zhuang commented on CASSANDRA-9988:
---
[Patch|https://github.com/cooldoger/cas
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828506#comment-15828506
]
Jason Brown commented on CASSANDRA-9988:
[~jay.zhuang] it's all yours :)
> In
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824837#comment-15824837
]
Jay Zhuang commented on CASSANDRA-9988:
---
Can I take this one?
> Introduce leaf-
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118947#comment-15118947
]
Benedict commented on CASSANDRA-9988:
-
FTR, the second half of my point 3 is very
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118944#comment-15118944
]
Piotr Jastrzebski commented on CASSANDRA-9988:
--
That's very interesting.
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118935#comment-15118935
]
Sam Tunnicliffe commented on CASSANDRA-9988:
[~haaawk] see
http://mechani
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117922#comment-15117922
]
Piotr Jastrzebski commented on CASSANDRA-9988:
--
What do you mean by effic
[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117219#comment-15117219
]
Benedict commented on CASSANDRA-9988:
-
Hi Piotr,
Thanks for your patch. A few co
41 matches
Mail list logo