[PR] Do not return OBJECT column data type for Object return type [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang opened a new pull request, #12588: URL: https://github.com/apache/pinot/pull/12588 Another attempt of #11743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] bugfix: fix shared buffer in v4 raw forward index writer [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on code in PR #12587: URL: https://github.com/apache/pinot/pull/12587#discussion_r1515682488 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkForwardIndexWriterV4.java: ## @@ -94,7 +94,7 @@ public class VarByte

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on code in PR #12568: URL: https://github.com/apache/pinot/pull/12568#discussion_r1515673763 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -291,6 +297,88 @@ private RoaringBitmap get

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on code in PR #12568: URL: https://github.com/apache/pinot/pull/12568#discussion_r1515672339 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -291,6 +297,88 @@ private RoaringBitmap get

(pinot) 01/01: Leverage ONLINE-OFFLINE state model for realtime tables

2024-03-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch full-auto-same-state-model in repository https://gitbox.apache.org/repos/asf/pinot.git commit 4ea45ce08f423a9d9428ac1c752ae45ede921e05 Author: jlli_LinkedIn AuthorDate: Wed Mar 6 12:57:45 2024 -080

(pinot) branch full-auto-same-state-model updated (6c7302caf9 -> 4ea45ce08f)

2024-03-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch full-auto-same-state-model in repository https://gitbox.apache.org/repos/asf/pinot.git discard 6c7302caf9 Leverage ONLINE-OFFLINE state model for realtime tables new 4ea45ce08f Leverage ONLIN

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
itschrispeck commented on PR #12568: URL: https://github.com/apache/pinot/pull/12568#issuecomment-1982602428 > IMO, iterating over all the keys of the mutable json index's map is wasteful, and we can do better by filtering the keys to iterate over by using a TreeMap. +1 we thought ab

Re: [PR] bugfix: fix shared buffer in v4 raw forward index writer [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12587: URL: https://github.com/apache/pinot/pull/12587#issuecomment-1982559122 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12587?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
saurabhd336 commented on code in PR #12568: URL: https://github.com/apache/pinot/pull/12568#discussion_r1515602818 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -291,6 +297,88 @@ private RoaringBitmap getM

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
saurabhd336 commented on code in PR #12568: URL: https://github.com/apache/pinot/pull/12568#discussion_r1515601560 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -291,6 +297,88 @@ private RoaringBitmap getM

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
saurabhd336 commented on code in PR #12568: URL: https://github.com/apache/pinot/pull/12568#discussion_r1515600999 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/RangePredicate.java: ## @@ -67,15 +69,17 @@ public RangePredicate(ExpressionContext

Re: [I] Seems text_match() function doesn't support search with '#' character [pinot]

2024-03-06 Thread via GitHub
Betternan commented on issue #12262: URL: https://github.com/apache/pinot/issues/12262#issuecomment-1982462905 @kkrugler , so you mean Pinot might need to customize the StandardAnalyzer to suit "#" search character, right? -- This is an automated message from the Apache Git Service. To re

Re: [PR] bugfix: fix shared chunk buffer in v4 raw forward index writer [pinot]

2024-03-06 Thread via GitHub
itschrispeck commented on code in PR #12587: URL: https://github.com/apache/pinot/pull/12587#discussion_r1515580137 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/creator/VarByteChunkV4Test.java: ## @@ -46,73 +47,122 @@ public class VarByteC

[PR] bugfix: fix shared chunk buffer in v4 raw forward index writer [pinot]

2024-03-06 Thread via GitHub
itschrispeck opened a new pull request, #12587: URL: https://github.com/apache/pinot/pull/12587 Scanning column data for columns using `rawIndexWriterVersion=4` caused intermittent buffer position exceptions and decompression exceptions. When investigating this I noticed chunks from one par

Re: [PR] [experiment] Deterministic Hash Function for Upsert Type-4 UUID Primary Keys [pinot]

2024-03-06 Thread via GitHub
ankitsultana commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1515548930 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -36,6 +40,35 @@ public static byte[] hashMD5(byte[] bytes) { r

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
saurabhd336 commented on code in PR #12568: URL: https://github.com/apache/pinot/pull/12568#discussion_r1515534775 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -291,6 +297,88 @@ private RoaringBitmap getM

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
saurabhd336 commented on code in PR #12568: URL: https://github.com/apache/pinot/pull/12568#discussion_r1515523094 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -291,6 +297,88 @@ private RoaringBitmap getM

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
saurabhd336 commented on code in PR #12568: URL: https://github.com/apache/pinot/pull/12568#discussion_r1515519971 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -291,6 +297,88 @@ private RoaringBitmap getM

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
saurabhd336 commented on code in PR #12568: URL: https://github.com/apache/pinot/pull/12568#discussion_r1515519781 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -291,6 +297,88 @@ private RoaringBitmap getM

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
satishd commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515463808 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
satishd commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515463808 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Update 'instances' API with ability to filter by tag [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12585: URL: https://github.com/apache/pinot/pull/12585#issuecomment-1982238818 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12585?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] [CVE-2022-39135] Bump up the calcite version to 1.30.2 [pinot]

2024-03-06 Thread via GitHub
snleee opened a new pull request, #12586: URL: https://github.com/apache/pinot/pull/12586 - Bumping up the calcite version from 1.30.0 to 1.30.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Update 'instances' API with ability to filter by tag [pinot]

2024-03-06 Thread via GitHub
cbalci opened a new pull request, #12585: URL: https://github.com/apache/pinot/pull/12585 This can be used to filter instances for various purposes. Example: `fetch all controller instances', 'fetch all instances located in ' etc. `feature` -- This is an automated message from the

Re: [I] Seems text_match() function doesn't support search with '#' character [pinot]

2024-03-06 Thread via GitHub
kkrugler commented on issue #12262: URL: https://github.com/apache/pinot/issues/12262#issuecomment-1982202148 Pinot uses Lucene's StandardAnalyzer to convert text into "tokens", which are then used for matching against queries. The StandardAnalyzer removes most punctuation, so the behavior

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on code in PR #12568: URL: https://github.com/apache/pinot/pull/12568#discussion_r1515366550 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -291,6 +297,88 @@ private RoaringBitmap get

Re: [PR] 11743: remove placeholder OBJECT column data type. [pinot]

2024-03-06 Thread via GitHub
abhioncbr closed pull request #11816: 11743: remove placeholder OBJECT column data type. URL: https://github.com/apache/pinot/pull/11816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Custom configuration property reader for segment metadata files [pinot]

2024-03-06 Thread via GitHub
abhioncbr commented on code in PR #12440: URL: https://github.com/apache/pinot/pull/12440#discussion_r1515359972 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/SegmentMetadataPropertyReader.java: ## @@ -0,0 +1,82 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Move hadoop-mapreduce-client-core dependency to test scope in pinot-parquet [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12583: URL: https://github.com/apache/pinot/pull/12583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (528294279d -> e578dd2b19)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 528294279d verify PrimaryKey equals (#12574) add e578dd2b19 Remove hadoop-mapreduce-client-core dependency from

Re: [PR] Upgrade maven release plugin version [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12584: URL: https://github.com/apache/pinot/pull/12584#issuecomment-1982097590 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12584?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Remove hadoop-mapreduce-client-core dependency from pinot-parquet [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12583: URL: https://github.com/apache/pinot/pull/12583#issuecomment-1982090421 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12583?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Upgrade maven release plugin version [pinot]

2024-03-06 Thread via GitHub
xiangfu0 opened a new pull request, #12584: URL: https://github.com/apache/pinot/pull/12584 Upgrade `maven-release-plugin` to 3.0.1 Upgrade `maven-scm-provider-gitexe` to 2.0.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

(pinot) branch master updated (227281aa1d -> 528294279d)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 227281aa1d Supporting human-readable format when configuring broker response size (#12510) add 528294279d verify

Re: [PR] verify PrimaryKey equals method [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang merged PR #12574: URL: https://github.com/apache/pinot/pull/12574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Remove hadoop-mapreduce-client-core dependency from pinot-parquet [pinot]

2024-03-06 Thread via GitHub
xiangfu0 opened a new pull request, #12583: URL: https://github.com/apache/pinot/pull/12583 Remove hadoop-mapreduce-client-core dependency from pinot-parquet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] Rebalancing table with no segments and "reassign instances" returns IN_PROGRESS but doesn't track the job_id or NullPointerException [pinot]

2024-03-06 Thread via GitHub
jadami10 commented on issue #12316: URL: https://github.com/apache/pinot/issues/12316#issuecomment-1982035460 ya, i know you had some fixes here recently. I will let you know once we pick up 1.1 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] verify PrimaryKey equals method [pinot]

2024-03-06 Thread via GitHub
sullis commented on PR #12574: URL: https://github.com/apache/pinot/pull/12574#issuecomment-1982020381 ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

(pinot) branch master updated: Supporting human-readable format when configuring broker response size (#12510)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 227281aa1d Supporting human-readable format when

Re: [PR] Supporting human-readable format when configuring broker response size [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang merged PR #12510: URL: https://github.com/apache/pinot/pull/12510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) 01/01: Leverage ONLINE-OFFLINE state model for realtime tables

2024-03-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch full-auto-same-state-model in repository https://gitbox.apache.org/repos/asf/pinot.git commit 6c7302caf904837f414e76f4ad77a78fdbd3e71c Author: jlli_LinkedIn AuthorDate: Wed Mar 6 12:57:45 2024 -080

(pinot) branch full-auto-same-state-model updated (7408de4fd0 -> 6c7302caf9)

2024-03-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch full-auto-same-state-model in repository https://gitbox.apache.org/repos/asf/pinot.git discard 7408de4fd0 Leverage ONLINE-OFFLINE state model for realtime tables new 6c7302caf9 Leverage ONLIN

(pinot) branch master updated: Revert "Bump org.apache.maven.scm:maven-scm-provider-gitexe from 1.9.4 to 2.0.1 (#12472)" (#12582)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0153e9ee73 Revert "Bump org.apache.maven.scm:mav

Re: [PR] Revert "Bump org.apache.maven.scm:maven-scm-provider-gitexe from 1.94 to 2.0.1 (#12472)" [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12582: URL: https://github.com/apache/pinot/pull/12582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[PR] Revert "Bump org.apache.maven.scm:maven-scm-provider-gitexe from 1.94 to 2.0.1 (#12472)" [pinot]

2024-03-06 Thread via GitHub
xiangfu0 opened a new pull request, #12582: URL: https://github.com/apache/pinot/pull/12582 Revert "Bump org.apache.maven.scm:maven-scm-provider-gitexe from 1.94 to 2.0.1 (#12472)" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] bugfix: do not move src ByteBuffer position for LZ4 length prefixed decompress [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on PR #12539: URL: https://github.com/apache/pinot/pull/12539#issuecomment-1981984404 +1 on adding a unit test to prevent future regression -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] bugfix: do not move src ByteBuffer position for LZ4 length prefixed decompress [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on PR #12539: URL: https://github.com/apache/pinot/pull/12539#issuecomment-1981983862 @itschrispeck Thanks for digging into it! I feel using safe decompressor is the safe go here, and we can get consistent behavior for v2 and v4. -- This is an automated message from

Re: [PR] Detect expired messages in Kafka. Log and set a guage. [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on PR #12157: URL: https://github.com/apache/pinot/pull/12157#issuecomment-1981974328 Ideally we want a unit test to directly read the value from the gauge, instead of relying on a rest API which is kind of an integration test. Currently I saw CI test failures, but no

(pinot) branch master updated (a36b564391 -> af43f591b7)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from a36b564391 Upgrade hadoop-common dependency from hadoop-shaded-protobuf_3_7 to hadoop-shaded-protobuf_3_21 (#12578)

Re: [PR] Upgrade com.microsoft.azure:msal4j from 1.3.5 to 1.3.10 for CVE fixing [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12580: URL: https://github.com/apache/pinot/pull/12580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (acbbd01317 -> a36b564391)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from acbbd01317 reduce Java enum .values() usage in TimerContext (#12579) add a36b564391 Upgrade hadoop-common depende

Re: [PR] Upgrade hadoop-common dependency from hadoop-shaded-protobuf_3_7 to hadoop-shaded-protobuf_3_21 [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12578: URL: https://github.com/apache/pinot/pull/12578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Add Prefix, Suffix and Ngram UDFs [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on code in PR #12392: URL: https://github.com/apache/pinot/pull/12392#discussion_r1515232533 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -570,6 +572,107 @@ public static String[] split(String input, Str

Re: [PR] Add metric to track number of segments missed in upsert-snapshot [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12581: URL: https://github.com/apache/pinot/pull/12581#issuecomment-1981958898 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12581?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Upgrade com.microsoft.azure:msal4j from 1.3.5 to 1.3.10 for CVE fixing [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12580: URL: https://github.com/apache/pinot/pull/12580#issuecomment-1981896059 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12580?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

(pinot) branch master updated: reduce Java enum .values() usage in TimerContext (#12579)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new acbbd01317 reduce Java enum .values() usage in Ti

Re: [PR] reduce enum array allocation in TimerContext [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang merged PR #12579: URL: https://github.com/apache/pinot/pull/12579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Add metric to track number of segments missed in upsert-snapshot [pinot]

2024-03-06 Thread via GitHub
tibrewalpratik17 opened a new pull request, #12581: URL: https://github.com/apache/pinot/pull/12581 label: - `observability` Adding a metric to track number of segments missed in upsert-snapshot. cc @ankitsultana -- This is an automated message from the Apache Git Service

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515187581 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515186487 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] enable Netty native transports by default [pinot]

2024-03-06 Thread via GitHub
jasperjiaguo commented on PR #12577: URL: https://github.com/apache/pinot/pull/12577#issuecomment-1981822434 >Correct me if I am wrong. There is unlikely to be any negative impact for this. In fact this will only lead to may be P99 improvements at high throughput ? Yes we've only see

(pinot) branch master updated (797e39cae1 -> c6cfc602b0)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 797e39cae1 Bump antlr.version from 4.6 to 4.13.1 (#12572) add c6cfc602b0 Update hadoop transitive dependencies an

Re: [PR] Update hadoop transitive dependencies and remove redundant exclusions [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12576: URL: https://github.com/apache/pinot/pull/12576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Detect expired messages in Kafka. Log and set a guage. [pinot]

2024-03-06 Thread via GitHub
vrajat commented on PR #12157: URL: https://github.com/apache/pinot/pull/12157#issuecomment-1981792537 Debug APIs and tests are there to test that the data loss is detected. Is it OK if one of the PRs has no test to check the changes? -- This is an automated message from the Apache Git S

Re: [PR] enable Netty native transports by default [pinot]

2024-03-06 Thread via GitHub
siddharthteotia commented on PR #12577: URL: https://github.com/apache/pinot/pull/12577#issuecomment-1981788213 Correct me if I am wrong. There is unlikely to be any negative impact for this. In fact this will only lead to may be P99 improvements at high throughput ? cc @jasperjiaguo

Re: [PR] Upgrade hadoop-common dependency from hadoop-shaded-protobuf_3_7 to hadoop-shaded-protobuf_3_21 [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12578: URL: https://github.com/apache/pinot/pull/12578#issuecomment-1981784665 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] reduce enum array allocation in TimerContext [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12579: URL: https://github.com/apache/pinot/pull/12579#issuecomment-1981777616 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12579?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

(pinot) branch full-auto-same-state-model created (now 7408de4fd0)

2024-03-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch full-auto-same-state-model in repository https://gitbox.apache.org/repos/asf/pinot.git at 7408de4fd0 Leverage ONLINE-OFFLINE state model for realtime tables This branch includes the followin

(pinot) 01/01: Leverage ONLINE-OFFLINE state model for realtime tables

2024-03-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch full-auto-same-state-model in repository https://gitbox.apache.org/repos/asf/pinot.git commit 7408de4fd0069bf5caea938b4936d9f3a1f6a556 Author: jlli_LinkedIn AuthorDate: Wed Mar 6 12:57:45 2024 -080

[PR] Upgrade com.microsoft.azure:msal4j from 1.3.5 to 1.3.10 for CVE fixing [pinot]

2024-03-06 Thread via GitHub
xiangfu0 opened a new pull request, #12580: URL: https://github.com/apache/pinot/pull/12580 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

svn commit: r67761 - /dev/pinot/apache-pinot-1.1.0-rc1/

2024-03-06 Thread vvivekiyer
Author: vvivekiyer Date: Wed Mar 6 20:51:31 2024 New Revision: 67761 Log: Update apache-pinot-1.1.0-rc1 Added: dev/pinot/apache-pinot-1.1.0-rc1/ dev/pinot/apache-pinot-1.1.0-rc1/apache-pinot-1.1.0-bin.tar.gz (with props) dev/pinot/apache-pinot-1.1.0-rc1/apache-pinot-1.1.0-bin.tar.

Re: [PR] Update hadoop transitive dependencies and remove redundant exclusions [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12576: URL: https://github.com/apache/pinot/pull/12576#issuecomment-1981706555 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12576?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] enable Netty native transports by default [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12577: URL: https://github.com/apache/pinot/pull/12577#issuecomment-1981697202 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12577?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] reduce Java enum .values() usage in TimerContext [pinot]

2024-03-06 Thread via GitHub
sullis opened a new pull request, #12579: URL: https://github.com/apache/pinot/pull/12579 Motivation: reduce enum array allocation in TimerContext Modifications: cache ServerQueryPhase.values().length in a static variable Result: Java enum .values() method i

[PR] Upgrade hadoop-common dependency from hadoop-shaded-protobuf_3_7 to hadoop-shaded-protobuf_3_21 [pinot]

2024-03-06 Thread via GitHub
xiangfu0 opened a new pull request, #12578: URL: https://github.com/apache/pinot/pull/12578 Upgrade hadoop-common dependency from hadoop-shaded-protobuf_3_7 to hadoop-shaded-protobuf_3_21 for CVE fixing. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515059370 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, St

Re: [PR] enable Netty native transports in ClusterTest [pinot]

2024-03-06 Thread via GitHub
sullis commented on PR #12527: URL: https://github.com/apache/pinot/pull/12527#issuecomment-1981613259 for discussion: enable native transports by default in NettyConfig.java https://github.com/apache/pinot/pull/12577 -- This is an automated message from the Apache Git Serv

[PR] enable Netty native transports by default [pinot]

2024-03-06 Thread via GitHub
sullis opened a new pull request, #12577: URL: https://github.com/apache/pinot/pull/12577 enable native transports (epoll, kqueue) by default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add Prefix, Suffix and Ngram UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on PR #12392: URL: https://github.com/apache/pinot/pull/12392#issuecomment-1981564946 > Are there equivalent/similar functions in other commonly used DBs (e.g. PostgreSQL)? We should try to match the behavior i think postgresql provide a 3-gram module called `pg_trg

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on PR #12437: URL: https://github.com/apache/pinot/pull/12437#issuecomment-1981544903 > Are there equivalent/similar functions in other commonly used DBs (e.g. PostgreSQL)? We should try to match the behavior Hi @Jackie-Jiang thanks for looking into it. the followin

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1514972783 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

(pinot) branch release-1.1.0-rc updated: [maven-release-plugin] prepare for next development iteration

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a commit to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.1.0-rc by this push: new f95c4aaaf9 [maven-release

(pinot) annotated tag release-1.1.0-rc1 updated (c2606742bb -> 0c323caa05)

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to annotated tag release-1.1.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.1.0-rc1 was modified! *** from c2606742bb (commit) to 0c323caa05 (ta

(pinot) branch release-1.1.0-rc updated: [maven-release-plugin] prepare release release-1.1.0-rc1

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a commit to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.1.0-rc by this push: new c2606742bb [maven-release

Re: [PR] add AwsSdkUtil to pinot-kinesis [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12573: URL: https://github.com/apache/pinot/pull/12573#issuecomment-1981504060 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12573?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Enter segment preloading at partition level [pinot]

2024-03-06 Thread via GitHub
klsince commented on code in PR #12451: URL: https://github.com/apache/pinot/pull/12451#discussion_r1514938270 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ## @@ -55,20 +39,11 @@ public abstract class BaseTableUp

Re: [PR] verify PrimaryKey equals method [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12574: URL: https://github.com/apache/pinot/pull/12574#issuecomment-1981480303 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12574?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [I] Seems text_match() function doesn't support search with '#' character [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on issue #12262: URL: https://github.com/apache/pinot/issues/12262#issuecomment-1981467319 I find something [here](https://solr-user.lucene.apache.narkive.com/X6ReA2cA/search-for-the-single-hash-character-never-returns-results) that might help: `text_match(tags, '[# T

(pinot) 01/01: exclude .mvn directory from source assembly (#12558)

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a commit to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git commit f2a59866bb67b2049df2d13606482717f632e8dc Author: Xiang Fu AuthorDate: Tue Mar 5 10:56:57 2024 -0800 ex

(pinot) branch release-1.1.0-rc updated (d3d3089e37 -> f2a59866bb)

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git discard d3d3089e37 [maven-release-plugin] prepare for next development iteration discard b10b4dd249 [maven-rele

(pinot) branch master updated: Bump antlr.version from 4.6 to 4.13.1 (#12572)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 797e39cae1 Bump antlr.version from 4.6 to 4.13.1

(pinot) branch dependabot/maven/antlr.version-4.13.1 deleted (was ef74c4a1e6)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/antlr.version-4.13.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was ef74c4a1e6 Bump antlr.version from 4.6 to 4.13.1 The revisions that were on this branch

Re: [PR] Bump antlr.version from 4.6 to 4.13.1 [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang merged PR #12572: URL: https://github.com/apache/pinot/pull/12572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) annotated tag release-1.1.0-rc0 deleted (was 5c1f08d2cc)

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to annotated tag release-1.1.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.1.0-rc0 was deleted! *** tag was 5c1f08d2cc The revisions that were on th

(pinot) branch master updated: verify Plugin equals method (#12575)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 038ef06e5f verify Plugin equals method (#12575) 0

Re: [PR] verify Plugin equals method [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang merged PR #12575: URL: https://github.com/apache/pinot/pull/12575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Update hadoop transitive dependencies and remove redundant exclusions [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang opened a new pull request, #12576: URL: https://github.com/apache/pinot/pull/12576 - `jline`: `3.22.0` -> `3.25.1` - `wildfly-common`: `1.5.4.Final` -> `1.7.0.Final` - `jettison`: `1.4.0` -> `1.5.4` -- This is an automated message from the Apache Git Service. To respond

(pinot) branch dependabot/maven/org.codehaus.jettison-jettison-1.5.4 deleted (was 00447b8c89)

2024-03-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.codehaus.jettison-jettison-1.5.4 in repository https://gitbox.apache.org/repos/asf/pinot.git was 00447b8c89 Bump org.codehaus.jettison:jettison from 1.4.0 to 1.5.4

Re: [PR] Bump org.codehaus.jettison:jettison from 1.4.0 to 1.5.4 [pinot]

2024-03-06 Thread via GitHub
dependabot[bot] commented on PR #12569: URL: https://github.com/apache/pinot/pull/12569#issuecomment-1981442518 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump org.codehaus.jettison:jettison from 1.4.0 to 1.5.4 [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang closed pull request #12569: Bump org.codehaus.jettison:jettison from 1.4.0 to 1.5.4 URL: https://github.com/apache/pinot/pull/12569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

  1   2   >