[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11628: assign segments for upsert table with respect to ideal state

2023-09-22 Thread via GitHub
Jackie-Jiang commented on code in PR #11628: URL: https://github.com/apache/pinot/pull/11628#discussion_r1334888076 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignment.java: ## @@ -0,0 +1,129 @@ +/** + * Lic

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11628: assign segments for upsert table with respect to ideal state

2023-09-21 Thread via GitHub
Jackie-Jiang commented on code in PR #11628: URL: https://github.com/apache/pinot/pull/11628#discussion_r1333475161 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/SegmentAssignment.java: ## @@ -52,6 +52,22 @@ public interface SegmentA

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11628: assign segments for upsert table with respect to ideal state

2023-09-19 Thread via GitHub
Jackie-Jiang commented on code in PR #11628: URL: https://github.com/apache/pinot/pull/11628#discussion_r1330837146 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignment.java: ## @@ -0,0 +1,108 @@ +/** + * Lic