[GitHub] [pinot] deemoliu commented on a diff in pull request #11346: Add hyperLogLogPlus aggregation function for distinct count

2023-09-20 Thread via GitHub
deemoliu commented on code in PR #11346: URL: https://github.com/apache/pinot/pull/11346#discussion_r1332156424 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountHLLPlusAggregationFunction.java: ## @@ -0,0 +1,469 @@ +/** + * Licensed to th

[GitHub] [pinot] deemoliu commented on a diff in pull request #11346: Add hyperLogLogPlus aggregation function for distinct count

2023-09-19 Thread via GitHub
deemoliu commented on code in PR #11346: URL: https://github.com/apache/pinot/pull/11346#discussion_r1330687546 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountHLLPlusAggregationFunction.java: ## @@ -0,0 +1,473 @@ +/** + * Licensed to th

[GitHub] [pinot] deemoliu commented on a diff in pull request #11346: Add hyperLogLogPlus aggregation function for distinct count

2023-09-19 Thread via GitHub
deemoliu commented on code in PR #11346: URL: https://github.com/apache/pinot/pull/11346#discussion_r1330357789 ## pinot-core/src/main/java/org/apache/pinot/core/operator/query/NonScanBasedAggregationOperator.java: ## @@ -233,6 +256,25 @@ private static HyperLogLog getDistinctC

[GitHub] [pinot] deemoliu commented on a diff in pull request #11346: Add hyperLogLogPlus aggregation function for distinct count

2023-09-14 Thread via GitHub
deemoliu commented on code in PR #11346: URL: https://github.com/apache/pinot/pull/11346#discussion_r1326558271 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/DistinctCountHLLPlusValueAggregator.java: ## @@ -0,0 +1,126 @@ +/** + * Licensed to the

[GitHub] [pinot] deemoliu commented on a diff in pull request #11346: Add hyperLogLogPlus aggregation function for distinct count

2023-09-14 Thread via GitHub
deemoliu commented on code in PR #11346: URL: https://github.com/apache/pinot/pull/11346#discussion_r1326477324 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountHLLPlusAggregationFunction.java: ## @@ -0,0 +1,473 @@ +/** + * Licensed to th