[GitHub] [pinot] klsince commented on a diff in pull request #11628: assign segments for upsert table with respect to ideal state

2023-09-21 Thread via GitHub
klsince commented on code in PR #11628: URL: https://github.com/apache/pinot/pull/11628#discussion_r1333575669 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java: ## @@ -335,7 +335,7 @@ private void processNewSegment(String tableNameWithType

[GitHub] [pinot] klsince commented on a diff in pull request #11628: assign segments for upsert table with respect to ideal state

2023-09-21 Thread via GitHub
klsince commented on code in PR #11628: URL: https://github.com/apache/pinot/pull/11628#discussion_r1333513401 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/SegmentAssignment.java: ## @@ -52,6 +52,22 @@ public interface SegmentAssign

[GitHub] [pinot] klsince commented on a diff in pull request #11628: assign segments for upsert table with respect to ideal state

2023-09-19 Thread via GitHub
klsince commented on code in PR #11628: URL: https://github.com/apache/pinot/pull/11628#discussion_r1330857514 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignment.java: ## @@ -0,0 +1,108 @@ +/** + * Licensed

[GitHub] [pinot] klsince commented on a diff in pull request #11628: assign segments for upsert table with respect to ideal state

2023-09-19 Thread via GitHub
klsince commented on code in PR #11628: URL: https://github.com/apache/pinot/pull/11628#discussion_r1330857397 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignment.java: ## @@ -0,0 +1,108 @@ +/** + * Licensed

[GitHub] [pinot] klsince commented on a diff in pull request #11628: assign segments for upsert table with respect to ideal state

2023-09-19 Thread via GitHub
klsince commented on code in PR #11628: URL: https://github.com/apache/pinot/pull/11628#discussion_r1330852853 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignment.java: ## @@ -0,0 +1,108 @@ +/** + * Licensed

[GitHub] [pinot] klsince commented on a diff in pull request #11628: assign segments for upsert table with respect to ideal state

2023-09-19 Thread via GitHub
klsince commented on code in PR #11628: URL: https://github.com/apache/pinot/pull/11628#discussion_r1330852721 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignment.java: ## @@ -0,0 +1,108 @@ +/** + * Licensed