walterddr commented on code in PR #11620:
URL: https://github.com/apache/pinot/pull/11620#discussion_r1330335754
##########
pinot-core/src/main/java/org/apache/pinot/core/auth/BasicAuthUtils.java:
##########
@@ -64,21 +61,22 @@ private BasicAuthUtils() {
* @return list of BasicAuthPrincipals
*/
public static List<BasicAuthPrincipal>
extractBasicAuthPrincipals(PinotConfiguration configuration, String prefix) {
- String principalNames = configuration.getProperty(prefix);
- Preconditions.checkArgument(StringUtils.isNotBlank(principalNames),
"must provide principals");
+ String principalNames = configuration.getProperty(prefix);
Review Comment:
does it make sense to also refactor the rest of the utils into common?
putting them in core seems weird to me: is there any situation when the rest of
the function util is not utilized together with the common one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
