Re: [PR] Add some additional metrics for Minion tasks [pinot]

2024-03-31 Thread via GitHub
vvivekiyer merged PR #12710: URL: https://github.com/apache/pinot/pull/12710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

Re: [PR] Add some additional metrics for Minion tasks [pinot]

2024-03-26 Thread via GitHub
vvivekiyer commented on code in PR #12710: URL: https://github.com/apache/pinot/pull/12710#discussion_r1540548233 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/MinionMeter.java: ## @@ -31,7 +31,13 @@ public enum MinionMeter implements AbstractMetrics.Meter { N

Re: [PR] Add some additional metrics for Minion tasks [pinot]

2024-03-26 Thread via GitHub
sajjad-moradi commented on code in PR #12710: URL: https://github.com/apache/pinot/pull/12710#discussion_r1539860670 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseTaskExecutor.java: ## @@ -68,4 +71,10 @@ pro

Re: [PR] Add some additional metrics for Minion tasks [pinot]

2024-03-25 Thread via GitHub
Jackie-Jiang commented on code in PR #12710: URL: https://github.com/apache/pinot/pull/12710#discussion_r1538368740 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/MinionMeter.java: ## @@ -31,7 +31,13 @@ public enum MinionMeter implements AbstractMetrics.Meter {

Re: [PR] Add some additional metrics for Minion tasks [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12710: URL: https://github.com/apache/pinot/pull/12710#issuecomment-2016217271 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add some additional metrics for Minion tasks [pinot]

2024-03-22 Thread via GitHub
vvivekiyer opened a new pull request, #12710: URL: https://github.com/apache/pinot/pull/12710 PR adds some additional metrics for Minion tasks. Adds the following metrics: - SEGMENTS_DOWNLOADED - SEGMENTS_UPLOADED - SEGMENT_SIZE_DOWNLOADED - SEGMENT_SIZE_UPLOADED - RECO