Re: [PR] Improved null check for varargs [pinot]

2024-04-01 Thread via GitHub
gortiz merged PR #12673: URL: https://github.com/apache/pinot/pull/12673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Improved null check for varargs [pinot]

2024-03-25 Thread via GitHub
soumitra-st commented on code in PR #12673: URL: https://github.com/apache/pinot/pull/12673#discussion_r1538339891 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCache.java: ## @@ -190,7 +190,7 @@ protected void updateBrokerData() public Stri

Re: [PR] Improved null check for varargs [pinot]

2024-03-22 Thread via GitHub
gortiz commented on code in PR #12673: URL: https://github.com/apache/pinot/pull/12673#discussion_r1535213030 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCache.java: ## @@ -190,7 +190,7 @@ protected void updateBrokerData() public String ge

Re: [PR] Improved null check for varargs [pinot]

2024-03-21 Thread via GitHub
soumitra-st commented on code in PR #12673: URL: https://github.com/apache/pinot/pull/12673#discussion_r1534297887 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java: ## @@ -230,7 +230,7 @@ public static String arrayElementAtString(String[]

Re: [PR] Improved null check for varargs [pinot]

2024-03-21 Thread via GitHub
gortiz commented on code in PR #12673: URL: https://github.com/apache/pinot/pull/12673#discussion_r1533540774 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java: ## @@ -230,7 +230,7 @@ public static String arrayElementAtString(String[] arr,

Re: [PR] Improved null check for varargs [pinot]

2024-03-20 Thread via GitHub
soumitra-st commented on code in PR #12673: URL: https://github.com/apache/pinot/pull/12673#discussion_r1532339342 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java: ## @@ -230,7 +230,7 @@ public static String arrayElementAtString(String[]

Re: [PR] Improved null check for varargs [pinot]

2024-03-20 Thread via GitHub
gortiz commented on code in PR #12673: URL: https://github.com/apache/pinot/pull/12673#discussion_r1531621823 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java: ## @@ -230,7 +230,7 @@ public static String arrayElementAtString(String[] arr,

Re: [PR] Improved null check for varargs [pinot]

2024-03-19 Thread via GitHub
soumitra-st commented on code in PR #12673: URL: https://github.com/apache/pinot/pull/12673#discussion_r1530610070 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java: ## @@ -230,7 +230,7 @@ public static String arrayElementAtString(String[]

Re: [PR] Improved null check for varargs [pinot]

2024-03-19 Thread via GitHub
gortiz commented on code in PR #12673: URL: https://github.com/apache/pinot/pull/12673#discussion_r1529883369 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java: ## @@ -230,7 +230,7 @@ public static String arrayElementAtString(String[] arr,

Re: [PR] Improved null check for varargs [pinot]

2024-03-18 Thread via GitHub
codecov-commenter commented on PR #12673: URL: https://github.com/apache/pinot/pull/12673#issuecomment-2005922208 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12673?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Improved null check for varargs [pinot]

2024-03-18 Thread via GitHub
soumitra-st opened a new pull request, #12673: URL: https://github.com/apache/pinot/pull/12673 Adding null checks for cases: 1. If literal null is passes 2. No value passed 3. A variable is passed with null value during runtime `cleanup` -- This is an automated mess