Re: [PR] Set per record log to debug level [pinot]

2024-04-12 Thread via GitHub
itschrispeck commented on PR #12909: URL: https://github.com/apache/pinot/pull/12909#issuecomment-2052249401 Is `info` the right default level for this log? My thinking was `debug` might be more apt as default given the potentially high volume, and users could override the level if needed.

Re: [PR] Set per record log to debug level [pinot]

2024-04-12 Thread via GitHub
gortiz commented on PR #12909: URL: https://github.com/apache/pinot/pull/12909#issuecomment-2051444563 You don't need to modify the source code to change a log. Instead I would recommend to modify the log4j2.xml file you are using to disable the logging on this class (or change it to warn).

Re: [PR] Set per record log to debug level [pinot]

2024-04-11 Thread via GitHub
codecov-commenter commented on PR #12909: URL: https://github.com/apache/pinot/pull/12909#issuecomment-2050807216 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Set per record log to debug level [pinot]

2024-04-11 Thread via GitHub
itschrispeck opened a new pull request, #12909: URL: https://github.com/apache/pinot/pull/12909 Per record level logging is pretty expensive, this log line emits >95% of our logs. I believe changing it to debug level is reasonable. tags: `refactor` -- This is an automated message