robertzych commented on PR #12754:
URL: https://github.com/apache/pinot/pull/12754#issuecomment-2071110780
I just filed the Calcite issue:
https://issues.apache.org/jira/browse/CALCITE-6381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Jackie-Jiang commented on PR #12754:
URL: https://github.com/apache/pinot/pull/12754#issuecomment-2040327692
@robertzych Sure, we can file an issue and confirm what I did is necessary.
The long term plan could be we maintain our own parser just for Pinot.
Currently Calcite parser trie
robertzych commented on PR #12754:
URL: https://github.com/apache/pinot/pull/12754#issuecomment-2039920664
> Not sure if it is a Calcite bug because IMO the builtinFunctionCallMethods
should be injected before parsing it with the default implementations
Should we open a Calcite issue
Jackie-Jiang commented on PR #12754:
URL: https://github.com/apache/pinot/pull/12754#issuecomment-2038268789
> Are we sure we needed to copy the whole jj file? I'm not an expert here,
but AFAIU Calcite parser is designed to be extensible.
I tried multiple approaches and didn't find a
gortiz commented on PR #12754:
URL: https://github.com/apache/pinot/pull/12754#issuecomment-2034058210
Are we sure we needed to copy the whole jj file? AFAIU Calcite parser is
designed to be extensible.
--
This is an automated message from the Apache Git Service.
To respond to the message
Jackie-Jiang merged PR #12754:
URL: https://github.com/apache/pinot/pull/12754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
xiangfu0 commented on PR #12754:
URL: https://github.com/apache/pinot/pull/12754#issuecomment-2030422110
wow！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
codecov-commenter commented on PR #12754:
URL: https://github.com/apache/pinot/pull/12754#issuecomment-2027780795
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12754?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang opened a new pull request, #12754:
URL: https://github.com/apache/pinot/pull/12754
Upgrade Calcite from `1.30.0` -> `1.36.0`.
There are some behavior changes, thus changing the code to adapt:
- `CoreRules.AGGREGATE_CASE_TO_FILTER` is changed to be applied on `SUM0`
instead
