klsince merged PR #12694:
URL: https://github.com/apache/pinot/pull/12694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
Jackie-Jiang commented on code in PR #12694:
URL: https://github.com/apache/pinot/pull/12694#discussion_r1556437699
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -433,6 +435,14 @@ public Map getSegmentErrors() {
}
}
+
klsince commented on code in PR #12694:
URL: https://github.com/apache/pinot/pull/12694#discussion_r1554386583
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManager.java:
##
@@ -50,4 +53,6 @@ public interface TableUpsertMetadataMan
Jackie-Jiang commented on code in PR #12694:
URL: https://github.com/apache/pinot/pull/12694#discussion_r1554332240
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/SegmentContext.java:
##
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
klsince commented on code in PR #12694:
URL: https://github.com/apache/pinot/pull/12694#discussion_r1536258715
##
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##
@@ -256,8 +257,9 @@ private InstanceResponseBlock
executeInternal(S
tibrewalpratik17 commented on code in PR #12694:
URL: https://github.com/apache/pinot/pull/12694#discussion_r1536170709
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapTableUpsertMetadataManager.java:
##
@@ -55,6 +58,14 @@ public Map getPa
codecov-commenter commented on PR #12694:
URL: https://github.com/apache/pinot/pull/12694#issuecomment-2014067551
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12694?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
klsince opened a new pull request, #12694:
URL: https://github.com/apache/pinot/pull/12694
This PR adds SegmentContext used to collect segment related context before
query execution. E.g. this makes it easier to collect validDocIds for many
segments together, so that we can add the support
