Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-05-10 Thread via GitHub
Jackie-Jiang merged PR #12659: URL: https://github.com/apache/pinot/pull/12659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-05-09 Thread via GitHub
Jackie-Jiang commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1596061999 ## pom.xml: ## @@ -237,6 +237,7 @@ 1.9.24 +1.19.0 Review Comment: This variable is already defined above ## pom.xml: ## @@

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-05-09 Thread via GitHub
sullis commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1595945421 ## pinot-connectors/pinot-flink-connector/pom.xml: ## @@ -51,7 +51,18 @@ org.apache.flink - flink-streaming-java_${scala.compat.version} + f

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-04-19 Thread via GitHub
sullis commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1572742497 ## pinot-connectors/pinot-flink-connector/pom.xml: ## @@ -51,7 +51,18 @@ org.apache.flink - flink-streaming-java_${scala.compat.version} + f

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-04-19 Thread via GitHub
Jackie-Jiang commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1572726491 ## pinot-connectors/pinot-flink-connector/pom.xml: ## @@ -51,7 +51,18 @@ org.apache.flink - flink-streaming-java_${scala.compat.version} +

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-04-02 Thread via GitHub
yupeng9 commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1548368730 ## pinot-connectors/pinot-flink-connector/pom.xml: ## @@ -51,7 +51,18 @@ org.apache.flink - flink-streaming-java_${scala.compat.version} Review

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-04-02 Thread via GitHub
snleee commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1548316107 ## pinot-connectors/pinot-flink-connector/pom.xml: ## @@ -51,7 +51,18 @@ org.apache.flink - flink-streaming-java_${scala.compat.version} + f

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-04-02 Thread via GitHub
snleee commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1548315118 ## pinot-connectors/pinot-flink-connector/pom.xml: ## @@ -51,7 +51,18 @@ org.apache.flink - flink-streaming-java_${scala.compat.version} Review

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-03-25 Thread via GitHub
Jackie-Jiang commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1538601907 ## pinot-connectors/pinot-flink-connector/pom.xml: ## @@ -51,7 +51,18 @@ org.apache.flink - flink-streaming-java_${scala.compat.version} +

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-03-25 Thread via GitHub
yupeng9 commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1538047965 ## pinot-connectors/pinot-flink-connector/pom.xml: ## @@ -51,7 +51,18 @@ org.apache.flink - flink-streaming-java_${scala.compat.version} Review

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-03-25 Thread via GitHub
sullis commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1537994325 ## pinot-connectors/pinot-flink-connector/pom.xml: ## @@ -51,7 +51,18 @@ org.apache.flink - flink-streaming-java_${scala.compat.version} Review

Re: [PR] upgrade flink to 1.19.0 [pinot]

2024-03-25 Thread via GitHub
yupeng9 commented on code in PR #12659: URL: https://github.com/apache/pinot/pull/12659#discussion_r1537984558 ## pinot-connectors/pinot-flink-connector/pom.xml: ## @@ -51,7 +51,18 @@ org.apache.flink - flink-streaming-java_${scala.compat.version} Review