Jackie-Jiang merged PR #12659:
URL: https://github.com/apache/pinot/pull/12659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1596061999
##
pom.xml:
##
@@ -237,6 +237,7 @@
1.9.24
+1.19.0
Review Comment:
This variable is already defined above
##
pom.xml:
##
@@
sullis commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1595945421
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
+ f
sullis commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1572742497
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
+ f
Jackie-Jiang commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1572726491
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
+
yupeng9 commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1548368730
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
Review
snleee commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1548316107
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
+ f
snleee commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1548315118
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
Review
Jackie-Jiang commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1538601907
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
+
yupeng9 commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1538047965
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
Review
sullis commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1537994325
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
Review
yupeng9 commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1537984558
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
Review
12 matches
Mail list logo