Re: [I] Investigate `Timetable` usage for client-server separation [airflow]
kaxil commented on issue #51549: URL: https://github.com/apache/airflow/issues/51549#issuecomment-2999361543 So that has to be on Server side? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Investigate `Timetable` usage for client-server separation [airflow]
uranusjr commented on issue #51549: URL: https://github.com/apache/airflow/issues/51549#issuecomment-2998754788 Yes it does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Investigate `Timetable` usage for client-server separation [airflow]
kaxil commented on issue #51549: URL: https://github.com/apache/airflow/issues/51549#issuecomment-2996272488 If I use a Custom Timetable, does that code currently run in the Scheduler? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Investigate `Timetable` usage for client-server separation [airflow]
uranusjr commented on issue #51549: URL: https://github.com/apache/airflow/issues/51549#issuecomment-2979233282 Oh yes, it does, for the first ever run. I forgot about that. This can be changed if we need to though. The scheduler is responsible for calculating all later runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Investigate `Timetable` usage for client-server separation [airflow]
kaxil commented on issue #51549: URL: https://github.com/apache/airflow/issues/51549#issuecomment-2969784296 > Timetable is kind of the reverse of e.g. dag and asset. It allows customisation, but all the logis is only needed in the scheduler, not the worker nor the dag processor. The main implementation should therefore likely belong in core. However, non-core timetables (e.g. `EventsTimetable`) may belong in the standard provider instead. Doesn't the dag processor use timetable to get the next run time though? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Investigate `Timetable` usage for client-server separation [airflow]
uranusjr commented on issue #51549: URL: https://github.com/apache/airflow/issues/51549#issuecomment-2969281200 Timetable is kind of the reverse of e.g. dag and asset. It allows customisation, but all the logis is only needed in the scheduler, not the worker nor the dag processor. The main implementation should therefore likely belong in core. However, non-core timetables (e.g. `EventsTimetable`) may belong in the standard provider instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Investigate `Timetable` usage for client-server separation [airflow]
kaxil opened a new issue, #51549: URL: https://github.com/apache/airflow/issues/51549 Analyze current timetable usage in scheduler vs DAG processor. Decide if timetables belong in core, task-sdk, or separate package (`airflow-commons`/`airflow-protocols`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org