Re: [I] Replace `external_trigger` check with DagRunType [airflow]

[via GitHub]

Lee-W closed issue #45932: Replace `external_trigger` check with DagRunType
URL: https://github.com/apache/airflow/issues/45932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] Replace `external_trigger` check with DagRunType [airflow]

[via GitHub]

kaxil commented on issue #45932:
URL: https://github.com/apache/airflow/issues/45932#issuecomment-2607373912

   Awesome, assigned it to you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] Replace `external_trigger` check with DagRunType [airflow]

[via GitHub]

jason810496 commented on issue #45932:
URL: https://github.com/apache/airflow/issues/45932#issuecomment-2607352181

   Hi @kaxil, I can work on this issue, could you assign to me ? Thanks !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] Replace `external_trigger` check with DagRunType [airflow]

[via GitHub]

kaxil opened a new issue, #45932:
URL: https://github.com/apache/airflow/issues/45932

   Now that we have explicit Dag Run types, we should not need 
`DagRun.external_trigger` too.
   
   
   Example, the following code can be changed
   
   
https://github.com/apache/airflow/blob/49581b38499d0e00742b289ae177913493499fe6/providers/src/airflow/providers/standard/operators/latest_only.py#L52-L58
   
   to
   
   ```py
   def choose_branch(self, context: Context) -> str | Iterable[str]:
   # If the DAG Run is manually triggered, then return without
   # skipping downstream tasks
   dag_run: DagRun = context["dag_run"]  # type: ignore[assignment]
   if dag_run.run_type == DagRunType.MANUAL:
   self.log.info("Externally triggered DAG_Run: allowing execution 
to proceed.")
   return 
list(context["task"].get_direct_relative_ids(upstream=False))
   
   ```
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org