Re: [PR] [snowflake] Add ocsp_fail_open setting for SnowflakeHook [airflow]
potiuk merged PR #46476: URL: https://github.com/apache/airflow/pull/46476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [snowflake] Add ocsp_fail_open setting for SnowflakeHook [airflow]
boring-cyborg[bot] commented on PR #46476: URL: https://github.com/apache/airflow/pull/46476#issuecomment-2638127038 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [snowflake] Add ocsp_fail_open setting for SnowflakeHook [airflow]
jcrobak commented on PR #46476: URL: https://github.com/apache/airflow/pull/46476#issuecomment-2638004731 Thanks for the review @potiuk !! The build failed with: ``` The image /mnt/ci-image-save-linux_amd64-3.9.tar does not exist. ``` during the "Prepare breeze & CI Image: 3.9" step of [Lowest direct dependency providers tests / All-core:LowestDeps-Postgres:13:3.9](https://github.com/apache/airflow/actions/runs/13162285492/job/36745165887#logs). I don't think this is related to this change, so I have rebased to see if it can pick up any fixes for main. Do you mind kicking off the CI again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [snowflake] Add ocsp_fail_open setting for SnowflakeHook [airflow]
boring-cyborg[bot] commented on PR #46476: URL: https://github.com/apache/airflow/pull/46476#issuecomment-2637461919 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] [snowflake] Add ocsp_fail_open setting for SnowflakeHook [airflow]
jcrobak opened a new pull request, #46476:
URL: https://github.com/apache/airflow/pull/46476
Adds support for passing through the `ocsp_fail_open` parameter. Ref:
https://docs.snowflake.com/en/developer-guide/python-connector/python-connector-connect#choosing-fail-open-or-fail-close-mode
The `ocsp_fail_open` parameter defaults to `True` inside of the driver when
the snowflake-connector version is 1.8.0 or later. So the usual case for
overriding the setting will be providing a `False` value. That is different
than other flags (where we only pass through `True`), so you may notice some
difference in the flag handling.
Also, for building the sqlalchemy engine, this parameter needs to be passed
in as part of `connect_args`.
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
